sr-dev December 2019

sr-dev@lists.kamailio.org

19 participants
279 discussions

git:master:a1acd621: dialog: export dlg_reset_property() to kemi
by Daniel-Constantin Mierla 09 Dec '19

09 Dec '19

Module: kamailio Branch: master Commit: a1acd62128c7c1e1d7e3c6ce55a9b78a3e32c0b2 URL: https://github.com/kamailio/kamailio/commit/a1acd62128c7c1e1d7e3c6ce55a9b78… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-12-09T12:47:22+01:00 dialog: export dlg_reset_property() to kemi --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/a1acd62128c7c1e1d7e3c6ce55a9b78… Patch: https://github.com/kamailio/kamailio/commit/a1acd62128c7c1e1d7e3c6ce55a9b78… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index 381017032e..48bf0b1f44 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -246,7 +246,7 @@ static cmd_export_t cmds[]={ {"dlg_set_property", (cmd_function)w_dlg_set_property,1,fixup_spve_null, 0, ANY_ROUTE }, {"dlg_reset_property", (cmd_function)w_dlg_reset_property,1,fixup_spve_null, - 0, ANY_ROUTE }, + 0, ANY_ROUTE }, {"dlg_remote_profile", (cmd_function)w_dlg_remote_profile, 5, fixup_dlg_remote_profile, 0, ANY_ROUTE }, {"dlg_set_ruri", (cmd_function)w_dlg_set_ruri, 0, NULL, @@ -2071,6 +2071,11 @@ static sr_kemi_t sr_kemi_dialog_exports[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("dialog"), str_init("dlg_reset_property"), + SR_KEMIP_INT, ki_dlg_reset_property, + { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("dialog"), str_init("dlg_get"), SR_KEMIP_INT, ki_dlg_get, { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR,

1 0

git:master:5fc66547: modules: readme files regenerated - dialog ... [skip ci]
by Kamailio Dev 09 Dec '19

09 Dec '19

Module: kamailio Branch: master Commit: 5fc6654781a930bcb9791e8214d6b53ce8482492 URL: https://github.com/kamailio/kamailio/commit/5fc6654781a930bcb9791e8214d6b53… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-12-09T12:46:27+01:00 modules: readme files regenerated - dialog ... [skip ci] --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/5fc6654781a930bcb9791e8214d6b53… Patch: https://github.com/kamailio/kamailio/commit/5fc6654781a930bcb9791e8214d6b53… --- diff --git a/src/modules/dialog/README b/src/modules/dialog/README index 31eda51225..d6a4e4bba2 100644 --- a/src/modules/dialog/README +++ b/src/modules/dialog/README @@ -135,6 +135,7 @@ Julien Klingenmeyer 7.18. dlg_set_ruri() 7.19. dlg_db_load_callid(cival) 7.20. dlg_db_load_extra() + 7.21. dlg_reset_property(attr) 8. Statistics @@ -271,6 +272,7 @@ Julien Klingenmeyer 1.80. dlg_set_ruri() usage 1.81. dlg_db_load_callid() usage 1.82. dlg_db_load_extra() usage + 1.83. dlg_reset_property usage Chapter 1. Admin Guide @@ -372,6 +374,7 @@ Chapter 1. Admin Guide 7.18. dlg_set_ruri() 7.19. dlg_db_load_callid(cival) 7.20. dlg_db_load_extra() + 7.21. dlg_reset_property(attr) 8. Statistics @@ -1452,6 +1455,7 @@ modparam("dialog", "keep_proxy_rr", 1) 7.18. dlg_set_ruri() 7.19. dlg_db_load_callid(cival) 7.20. dlg_db_load_extra() + 7.21. dlg_reset_property(attr) 7.1. set_dlg_profile(profile,[value]) @@ -1875,6 +1879,27 @@ if(has_totag()) { } ... +7.21. dlg_reset_property(attr) + + Reset a dialog property - an attribute that enable/disable various + behaviours (e.g., sending keep alive requests). + + Meaning of the parameters is as follows: + * attr - name of property. It can be: + + 'ka-src' - send keep alive OPTION requests to caller + + 'ka-dst' - send keep alive OPTION requests to callee + + 'timeout-noreset' - don't reset timeout on in-dialog messages + reception + + This function can be used from ANY_ROUTE. + + Example 1.83. dlg_reset_property usage +... +dlg_reset_property("ka-src"); +dlg_reset_property("ka-dst"); +dlg_reset_property("timeout-noreset"); +... + 8. Statistics 8.1. active_dialogs

1 0

git:master:0303415c: Merge pull request #2172 from korayvt/korayvt/dlg_reset_property
by GitHub 09 Dec '19

09 Dec '19

Module: kamailio Branch: master Commit: 0303415cce2acafe01cbbff0601259cd9162586a URL: https://github.com/kamailio/kamailio/commit/0303415cce2acafe01cbbff0601259c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-12-09T12:44:54+01:00 Merge pull request #2172 from korayvt/korayvt/dlg_reset_property dialog: add new dlg_reset_property function --- Modified: src/modules/dialog/dialog.c Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/0303415cce2acafe01cbbff0601259c… Patch: https://github.com/kamailio/kamailio/commit/0303415cce2acafe01cbbff0601259c…

1 0

git:master:3af08bbd: dialod: indentation fixed
by KORAY VATANSEVER 09 Dec '19

09 Dec '19

Module: kamailio Branch: master Commit: 3af08bbd0bffacc6b31029e436ce729b1952d4a9 URL: https://github.com/kamailio/kamailio/commit/3af08bbd0bffacc6b31029e436ce729… Author: KORAY VATANSEVER <koray.vatansever(a)turkcell.com.tr> Committer: KORAY VATANSEVER <koray.vatansever(a)turkcell.com.tr> Date: 2019-12-09T09:09:40+03:00 dialod: indentation fixed --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/3af08bbd0bffacc6b31029e436ce729… Patch: https://github.com/kamailio/kamailio/commit/3af08bbd0bffacc6b31029e436ce729… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index e10b74e12c..381017032e 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -245,7 +245,7 @@ static cmd_export_t cmds[]={ 0, ANY_ROUTE }, {"dlg_set_property", (cmd_function)w_dlg_set_property,1,fixup_spve_null, 0, ANY_ROUTE }, - {"dlg_reset_property", (cmd_function)w_dlg_reset_property,1,fixup_spve_null, + {"dlg_reset_property", (cmd_function)w_dlg_reset_property,1,fixup_spve_null, 0, ANY_ROUTE }, {"dlg_remote_profile", (cmd_function)w_dlg_remote_profile, 5, fixup_dlg_remote_profile, 0, ANY_ROUTE }, @@ -1342,36 +1342,36 @@ static int ki_dlg_reset_property(sip_msg_t *msg, str *pval) dlg_cell_t *d; if(pval->len<=0) { - LM_ERR("empty property value\n"); - return -1; + LM_ERR("empty property value\n"); + return -1; } if ( (dctx=dlg_get_dlg_ctx())==NULL ) - return -1; + return -1; if(pval->len==6 && strncmp(pval->s, "ka-src", 6)==0) { - dctx->iflags &= ~(DLG_IFLAG_KA_SRC); - d = dlg_get_by_iuid(&dctx->iuid); - if(d!=NULL) { - d->iflags &= ~(DLG_IFLAG_KA_SRC); - dlg_release(d); - } + dctx->iflags &= ~(DLG_IFLAG_KA_SRC); + d = dlg_get_by_iuid(&dctx->iuid); + if(d!=NULL) { + d->iflags &= ~(DLG_IFLAG_KA_SRC); + dlg_release(d); + } } else if(pval->len==6 && strncmp(pval->s, "ka-dst", 6)==0) { - dctx->iflags &= ~(DLG_IFLAG_KA_DST); - d = dlg_get_by_iuid(&dctx->iuid); - if(d!=NULL) { - d->iflags &= ~(DLG_IFLAG_KA_DST); - dlg_release(d); - } + dctx->iflags &= ~(DLG_IFLAG_KA_DST); + d = dlg_get_by_iuid(&dctx->iuid); + if(d!=NULL) { + d->iflags &= ~(DLG_IFLAG_KA_DST); + dlg_release(d); + } } else if(pval->len==15 && strncmp(pval->s, "timeout-noreset", 15)==0) { - dctx->iflags &= ~(DLG_IFLAG_TIMER_NORESET); - d = dlg_get_by_iuid(&dctx->iuid); - if(d!=NULL) { - d->iflags &= ~(DLG_IFLAG_TIMER_NORESET); - dlg_release(d); - } + dctx->iflags &= ~(DLG_IFLAG_TIMER_NORESET); + d = dlg_get_by_iuid(&dctx->iuid); + if(d!=NULL) { + d->iflags &= ~(DLG_IFLAG_TIMER_NORESET); + dlg_release(d); + } } else { - LM_ERR("unknown property value [%.*s]\n", pval->len, pval->s); - return -1; + LM_ERR("unknown property value [%.*s]\n", pval->len, pval->s); + return -1; } return 1; @@ -1386,8 +1386,8 @@ static int w_dlg_reset_property(struct sip_msg *msg, char *prop, char *s2) if(fixup_get_svalue(msg, (gparam_t*)prop, &val)!=0) { - LM_ERR("no property value\n"); - return -1; + LM_ERR("no property value\n"); + return -1; } return ki_dlg_reset_property(msg, &val);

1 0

git:master:4883b692: dialog: add new dlg_reset_property function
by KORAY VATANSEVER 09 Dec '19

09 Dec '19

Module: kamailio Branch: master Commit: 4883b69298deda1fede5bcd02af9849e4142a629 URL: https://github.com/kamailio/kamailio/commit/4883b69298deda1fede5bcd02af9849… Author: KORAY VATANSEVER <koray.vatansever(a)turkcell.com.tr> Committer: KORAY VATANSEVER <koray.vatansever(a)turkcell.com.tr> Date: 2019-12-09T08:41:56+03:00 dialog: add new dlg_reset_property function - new dlg_reset_property() function is added to disable the previously enabled dialog module behaviour. e.g. stop sending keep-alive OPTIONS messages. --- Modified: src/modules/dialog/dialog.c Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/4883b69298deda1fede5bcd02af9849… Patch: https://github.com/kamailio/kamailio/commit/4883b69298deda1fede5bcd02af9849…

1 0

[kamailio/kamailio] dialog: add new dlg_reset_property function (#2172)
by korayvt 09 Dec '19

09 Dec '19

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  - new dlg_reset_property() function is added to disable the previously enabled dialog module behaviour. e.g. stop sending keep-alive OPTIONS messages. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2172 -- Commit Summary -- * dialog: add new dlg_reset_property function * dialod: indentation fixed -- File Changes -- M src/modules/dialog/dialog.c (63) M src/modules/dialog/doc/dialog_admin.xml (42) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2172.patch https://github.com/kamailio/kamailio/pull/2172.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2172

2 2

5061 port Cannot assign requested address
by Jignesh Datta 09 Dec '19

09 Dec '19

Hi All, I have Kamailio v4.4.1 installed in ubuntu 14.04 server with TLS enabled. After I have done the patching of the server and then restarted the server. After that, it is not working. When I try to start the Kamailio service it says "already running". But when I check the status of the service it says "Kamailio is not running". I thought this Kamailio process might be using port 5061 but when checked using netstat it shows 5061 is not used by anywhere. SO I am wondering why it is not working? Can anyone face similar issue? Please help me. Thank you. -- Best Regards, __________________________________ Jignesh Datta Lead Developer Boston Byte LLC Contact :+91 7385860123 Email : jignesh.datta(a)bostonbyte.com Website : *www.bostonbyte.com <http://www.bostonbyte.com/>* Blog: <http://bostonbyte.blogspot.com>bostonbyte.blogspot.com

2 7

Kamailio management group updates
by Daniel-Constantin Mierla 09 Dec '19

09 Dec '19

Hello, Jesus Rodrigues and Inaki Baz Castillo changed their work roles a while ago, so they no longer deal with Kamailio and they do not expect to do it in the near future. To keep the Management group with members connected as much as possible with the project, Fred Posner and Victor Seva were proposed to replace them. For the new members in the public lists: the management group of Kamailio is not involved in the daily development or administration of the project -- all those are done on public mailing lists or kadmin group (internal infrastructure administration) -- management team is supposed to take the decisions on sensitive situations for the evolution of the project. Should anyone have opinions about these changes, let's discuss on sr-users mailing list. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference - April 27-29, 2020, in Berlin -- www.kamailioworld.com

1 0

git:master:e1a3e0d6: cfgt: use snprintf instead of sprintf
by Victor Seva 09 Dec '19

09 Dec '19

Module: kamailio Branch: master Commit: e1a3e0d6f21507bc6f6ccb2e50a03c19872ff04b URL: https://github.com/kamailio/kamailio/commit/e1a3e0d6f21507bc6f6ccb2e50a03c1… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-12-09T09:19:17+01:00 cfgt: use snprintf instead of sprintf --- Modified: src/modules/cfgt/cfgt_int.c --- Diff: https://github.com/kamailio/kamailio/commit/e1a3e0d6f21507bc6f6ccb2e50a03c1… Patch: https://github.com/kamailio/kamailio/commit/e1a3e0d6f21507bc6f6ccb2e50a03c1… --- diff --git a/src/modules/cfgt/cfgt_int.c b/src/modules/cfgt/cfgt_int.c index 7582bec61f..5f73a05bc8 100644 --- a/src/modules/cfgt/cfgt_int.c +++ b/src/modules/cfgt/cfgt_int.c @@ -112,7 +112,8 @@ void _cfgt_remove_report(const str *scen) continue; } } - sprintf(filepath.s, "%s/%s", dest.s, next_file->d_name); + snprintf(filepath.s, dest.len + 1, "%s/%s", dest.s, + next_file->d_name); if(remove(filepath.s) < 0) { LM_ERR("failed removing file: %s\n", strerror(errno)); } else {

1 0

git:master:913ba6f1: pv_headers: use snprintf instead of sprintf
by Victor Seva 09 Dec '19

09 Dec '19

Module: kamailio Branch: master Commit: 913ba6f196d19005a0e93ad0dbbdc48f532a9897 URL: https://github.com/kamailio/kamailio/commit/913ba6f196d19005a0e93ad0dbbdc48… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-12-09T09:12:05+01:00 pv_headers: use snprintf instead of sprintf --- Modified: src/modules/pv_headers/pvh_xavp.c --- Diff: https://github.com/kamailio/kamailio/commit/913ba6f196d19005a0e93ad0dbbdc48… Patch: https://github.com/kamailio/kamailio/commit/913ba6f196d19005a0e93ad0dbbdc48… --- diff --git a/src/modules/pv_headers/pvh_xavp.c b/src/modules/pv_headers/pvh_xavp.c index de296b4bca..fa7fe1b9e1 100644 --- a/src/modules/pv_headers/pvh_xavp.c +++ b/src/modules/pv_headers/pvh_xavp.c @@ -384,7 +384,7 @@ int pvh_get_branch_xname(struct sip_msg *msg, str *xname, str *dst) pvh_get_branch_index(msg, &br_idx); if(br_idx > 0) { - sprintf(br_idx_s, "%d", br_idx - 1); + snprintf(br_idx_s, 32, "%d", br_idx - 1); br_idx_len = strlen(br_idx_s); memcpy(dst->s + os, ".", 1); os += 1;

1 0

← Newer
1
...
20
21
22
23
24
25
26
27
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2019