sr-dev December 2019

sr-dev@lists.kamailio.org

19 participants
279 discussions

git:master:d7f4493d: permissions: fix crash if load_backends parameter is 1

by Victor Seva

Module: kamailio Branch: master Commit: d7f4493da751802dc47a694d251d34a85a7b3bf1 URL: https://github.com/kamailio/kamailio/commit/d7f4493da751802dc47a694d251d34a… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-12-03T12:12:54+01:00 permissions: fix crash if load_backends parameter is 1 fixes #2151 --- Modified: src/modules/permissions/permissions.c --- Diff: https://github.com/kamailio/kamailio/commit/d7f4493da751802dc47a694d251d34a… Patch: https://github.com/kamailio/kamailio/commit/d7f4493da751802dc47a694d251d34a… --- diff --git a/src/modules/permissions/permissions.c b/src/modules/permissions/permissions.c index 7505bb3dd1..30637380d4 100644 --- a/src/modules/permissions/permissions.c +++ b/src/modules/permissions/permissions.c @@ -648,8 +648,10 @@ static int mod_init(void) static int child_init(int rank) { - if (init_child_trusted(rank) == -1) - return -1; + if(_perm_load_backends&PERM_LOAD_TRUSTEDDB) { + if(init_child_trusted(rank) == -1) + return -1; + } return 0; }

4 years, 4 months

Kamailio Developer Guide

by Markus Bönke

Hello all, I’ve a question about the kamailio developer guide. I’ve found 2 locations: 1. The source code on https://github.com/asipto/kamailio-devel-guide <https://github.com/asipto/kamailio-devel-guide> and 2. an HTML version on https://www.asipto.com/pub/kamailio-devel-guide/ <https://www.asipto.com/pub/kamailio-devel-guide/> . The HTML version seems to be different from the source, e.g. the doxygen link points to http://rpm.kamailio.org/doxygen/sip-router/branch/master/index.html <http://rpm.kamailio.org/doxygen/sip-router/branch/master/index.html> in the github version but to http://devel.kamailio.net/doxygen/ <http://devel.kamailio.net/doxygen/> on the html version (actually both links are dead). Also some paragraphs differ slightly. As I start with Kamailio development, I can review the document and update links, remove outdated stuff like MI - Management Interface, etc to be compatible with the lastest version. I also can add a new chapter how to setup an IDE like vscode for debugging kamailio. Let me know where I can find the latest source version of the guide. Best Regards Markus

4 years, 4 months

git:master:e896f2c9: rtproxy: docs - fixed section id value

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: e896f2c9286809b5ef81c4952577780002ee5df8 URL: https://github.com/kamailio/kamailio/commit/e896f2c9286809b5ef81c4952577780… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-12-02T19:07:40+01:00 rtproxy: docs - fixed section id value --- Modified: src/modules/rtpproxy/doc/rtpproxy_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/e896f2c9286809b5ef81c4952577780… Patch: https://github.com/kamailio/kamailio/commit/e896f2c9286809b5ef81c4952577780… --- diff --git a/src/modules/rtpproxy/doc/rtpproxy_admin.xml b/src/modules/rtpproxy/doc/rtpproxy_admin.xml index d7f9b6de15..203f280f90 100644 --- a/src/modules/rtpproxy/doc/rtpproxy_admin.xml +++ b/src/modules/rtpproxy/doc/rtpproxy_admin.xml @@ -380,7 +380,7 @@ rtpproxy_offer(); </programlisting> </example> </section> - <section id="rtpproxy.f.rtpproxy_ofrer"> + <section id="rtpproxy.f.rtpproxy_offer"> <title> <function moreinfo="none">rtpproxy_offer([flags [, ip_address]])</function> </title>

4 years, 4 months

git:master:9e89a66b: kex: docs - fixed rpc command name for shm memory details

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 9e89a66b36d7aa691cf69d5b33b7ee31330693e9 URL: https://github.com/kamailio/kamailio/commit/9e89a66b36d7aa691cf69d5b33b7ee3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-12-02T16:47:40+01:00 kex: docs - fixed rpc command name for shm memory details --- Modified: src/modules/kex/doc/kex_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/9e89a66b36d7aa691cf69d5b33b7ee3… Patch: https://github.com/kamailio/kamailio/commit/9e89a66b36d7aa691cf69d5b33b7ee3… --- diff --git a/src/modules/kex/doc/kex_admin.xml b/src/modules/kex/doc/kex_admin.xml index 53380b7676..4893b4a280 100644 --- a/src/modules/kex/doc/kex_admin.xml +++ b/src/modules/kex/doc/kex_admin.xml @@ -561,9 +561,9 @@ resetdebug(); ... </programlisting> </section> - <section id="kex.r.core.shmem"> + <section id="kex.r.core.shmmem"> <title> - <function moreinfo="none">core.shmem</function> + <function moreinfo="none">core.shmmem</function> </title> <para> Returns shared memory info. It has an optional parameter that specifies

4 years, 4 months

git:master:b2267fd5: jsonrpcc: use snprintf() instead of sprintf()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b2267fd5d2825214ae9be5217514547e60e6c0f3 URL: https://github.com/kamailio/kamailio/commit/b2267fd5d2825214ae9be5217514547… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-12-02T16:25:44+01:00 jsonrpcc: use snprintf() instead of sprintf() --- Modified: src/modules/jsonrpcc/netstring.c --- Diff: https://github.com/kamailio/kamailio/commit/b2267fd5d2825214ae9be5217514547… Patch: https://github.com/kamailio/kamailio/commit/b2267fd5d2825214ae9be5217514547… --- diff --git a/src/modules/jsonrpcc/netstring.c b/src/modules/jsonrpcc/netstring.c index 4dbc651630..43a7486987 100644 --- a/src/modules/jsonrpcc/netstring.c +++ b/src/modules/jsonrpcc/netstring.c @@ -185,7 +185,7 @@ size_t netstring_encode_new(char **netstring, char *data, size_t len) { LM_ERR("Out of memory!"); return 0; } - sprintf(ns, "%lu:", (unsigned long)len); + snprintf(ns, num_len + len + 2, "%lu:", (unsigned long)len); memcpy(ns + num_len + 1, data, len); ns[num_len + len + 1] = ','; }

4 years, 4 months

git:master:c10ab724: nsq: use snprintf() instead of sprintf()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: c10ab724803cc084a00bab964dc1e2d582a0627b URL: https://github.com/kamailio/kamailio/commit/c10ab724803cc084a00bab964dc1e2d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-12-02T16:21:25+01:00 nsq: use snprintf() instead of sprintf() --- Modified: src/modules/nsq/nsq_reader.c --- Diff: https://github.com/kamailio/kamailio/commit/c10ab724803cc084a00bab964dc1e2d… Patch: https://github.com/kamailio/kamailio/commit/c10ab724803cc084a00bab964dc1e2d… --- diff --git a/src/modules/nsq/nsq_reader.c b/src/modules/nsq/nsq_reader.c index 9a472ca8df..a8f403bda9 100644 --- a/src/modules/nsq/nsq_reader.c +++ b/src/modules/nsq/nsq_reader.c @@ -92,23 +92,23 @@ int nsq_consumer_event(char *payload, char *channel, char *topic) json_api.extract_field(json_obj, k, &ev_name); pkg_free(k); - sprintf(buffer, "nsq:consumer-event-%.*s-%.*s",ev_category.len, ev_category.s, ev_name.len, ev_name.s); + snprintf(buffer, 512, "nsq:consumer-event-%.*s-%.*s",ev_category.len, ev_category.s, ev_name.len, ev_name.s); for (p=buffer ; *p; ++p) *p = tolower(*p); for (p=buffer ; *p; ++p) if(*p == '_') *p = '-'; if (nsq_consumer_fire_event(buffer) != 0) { - sprintf(buffer, "nsq:consumer-event-%.*s", ev_category.len, ev_category.s); + snprintf(buffer, 512, "nsq:consumer-event-%.*s", ev_category.len, ev_category.s); for (p=buffer ; *p; ++p) *p = tolower(*p); for (p=buffer ; *p; ++p) if(*p == '_') *p = '-'; if (nsq_consumer_fire_event(buffer) != 0) { - sprintf(buffer, "nsq:consumer-event-%.*s-%.*s", nsq_event_key.len, nsq_event_key.s, nsq_event_sub_key.len, nsq_event_sub_key.s); + snprintf(buffer, 512, "nsq:consumer-event-%.*s-%.*s", nsq_event_key.len, nsq_event_key.s, nsq_event_sub_key.len, nsq_event_sub_key.s); for (p=buffer ; *p; ++p) *p = tolower(*p); for (p=buffer ; *p; ++p) if(*p == '_') *p = '-'; if (nsq_consumer_fire_event(buffer) != 0) { - sprintf(buffer, "nsq:consumer-event-%.*s", nsq_event_key.len, nsq_event_key.s); + snprintf(buffer, 512, "nsq:consumer-event-%.*s", nsq_event_key.len, nsq_event_key.s); for (p=buffer ; *p; ++p) *p = tolower(*p); for (p=buffer ; *p; ++p) if(*p == '_') *p = '-'; if (nsq_consumer_fire_event(buffer) != 0) { - sprintf(buffer, "nsq:consumer-event"); + snprintf(buffer, 512, "nsq:consumer-event"); if (nsq_consumer_fire_event(buffer) != 0) { LM_ERR("nsq:consumer-event not found"); }

4 years, 4 months

[kamailio/kamailio] deb.kamailio.org certificate is expired (#2161)

by Thomas Weber

### Description  ### Troubleshooting #### Reproduction  Point your browser to https://deb.kamailio.org #### Debugging Data  The lets encrypt certificate expired on 2019-11-30 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2161

4 years, 4 months

Kamailio World 2020 - Call For Presentations

by Daniel-Constantin Mierla

Hello, I would like to announce that Call for Presentations at Kamailio World 2020 is now open. You can submit your proposal or see more details at: - https://www.kamailioworld.com/k08/call-for-speakers/ The 8th edition of the event takes place again in Berlin, Germany, during April 27-29, 2020. Expect over 150 participants, developers and community members as well as representatives of other popular open source VoIP projects such as Asterisk or FreeSwitch. Looking forward to meeting many of you there! Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference - April 27-29, 2020, in Berlin -- www.kamailioworld.com

4 years, 4 months

Strategy for visibility defines?

by Greg Troxel

(I'm new and this issue is nonobvious, so I'm posting to the list instead of opening an issue, hoping sr-dev is the right call.) I am packaging kamailio for pkgsrc, a multi-OS multi-CPU portable packaging system, with NetBSD and SmartOS being perhaps the biggest targets. Mostly this is going well, and I'm probably doing a few things wrong (but am not asking for help on those yet). During the build (NetBSD 8 amd64), I got a failure in src/lib/srdb1/db_ut.c: CC (gcc) [L libsrdb1.so.1.0] db_ut.o In file included from db_ut.c:63:0: /usr/include/stdlib.h:273:28: error: unknown type name 'u_char' void arc4random_addrandom(u_char *, int); ^ /usr/include/stdlib.h:306:1: error: unknown type name 'devmajor_t' devmajor_t getdevmajor(const char *, mode_t); ^ gmake[3]: *** [../../Makefile.rules:100: db_ut.o] Error 1 This may be a NetBSD bug and I am investigating that in parallel. In db_ut.c, several visibility defines are set. These have the effect of ensuring that definitions mandated by a certain standard are visible, but they also restrict visibility of definitions not mandated by that standard. The code is: /** * make strptime available * use 600 for 'Single UNIX Specification, Version 3' * _XOPEN_SOURCE creates conflict in swab definition in Solaris */ #ifndef __OS_solaris #define _XOPEN_SOURCE 600 /* glibc2 on linux, bsd */ #define _BSD_SOURCE 1 /* needed on linux to "fix" the effect * of the above define on * features.h/unistd.h syscall() */ #define _DEFAULT_SOURCE 1 /* _BSD_SOURCE is deprecated */ #else #define _XOPEN_SOURCE_EXTENDED 1 /* solaris */ #endif #include <time.h> #ifndef __OS_solaris #undef _XOPEN_SOURCE #undef _XOPEN_SOURCE_EXTENDED #else /* solaris */ #undef _XOPEN_SOURCE_EXTENDED #endif strptime seems to have originally been XPG4, and now seems to be in base POSIX: https://pubs.opengroup.org/onlinepubs/9699919799/functions/strptime.html _XOPEN_SOURCE being 600 seems to be "X/Open 6, incorporating POSIX 2004": https://pubs.opengroup.org/onlinepubs/009695399/ I am not following the comment "_BSD_SOURCE is deprecated"; that is perhaps referring to the situation on Linux. But that define is not used on recent NetBSD. Overall, feature tests macros are complicated, and while I'm sure there were good reasons they was added over time, I suspect that today they are not needed at all, or in a far more limited manner. (I'm unclear on how far back on various systems kamailio intends to support.) On NetBSD 8, removing all the visibility defines that I quoted results in a clean build, and I have a patch in pkgsrc that does that. I would advance the hypothesis that it would be preferable to remove the visibility defines, and if there are systems on which they are needed, to #ifdef system and perhaps #ifdef version <= OK_VERSION and then define things. This would avoid setting visibility defines on systemss where they haven't been tested and probably aren't needed. I am therefore curious what happens on various systems if the above-quoted text from db_ut is removed. There are also POSIX and other XOPEN defines in other files, and I'm not sure if they are ok or if I'm just not building those modules. Alternatively I could prepare a PR to not set any defines on NetBSD, or to define _NETBSD_SOURCE, which should be more or less equivalent. Thanks, Greg

4 years, 4 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2019