sr-dev May 2018

sr-dev@lists.kamailio.org

22 participants
214 discussions

[kamailio/kamailio] cfgutils route_if_exists causing leak (#1503)

by Julien Chavanton

### Description cfgutils route_if_exists can leak when 1: using a $var or $avp 2: some functions are called within the called route ### Troubleshooting #### Reproduction Note the route is executed from `rtimer` in case this is part of the problem somehow. ``` modparam("rtimer", "timer", "name=tmetrics;interval=9;mode=1;") modparam("rtimer", "exec", "timer=tmetrics;route=test") ``` example : ``` route[dummy] { xinfo("[dummy]"); statsd_gauge("dummy_1xx", $stat(1xx_replies)); } route[test] { $var(route_name) = "dummy"; route_if_exists($var(route_name)); ] ``` working alternative ``` route[dummy] { xinfo("[dummy]"); statsd_gauge("dummy_1xx", $stat(1xx_replies)); } route[test] { $var(route_name) = "dummy"; if (check_route_exists($var(route_name))) { route($var(route_name)); } } ``` #### Debugging Data ``` kamcmd pkg.stats you can see the `real_used` of the timer process with leak every time the route is called ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1503

5 years, 11 months

[kamailio/kamailio] Bugfix issue 1168 - Unregistered Terminating Services (PSI) Configured at HSS (#1538)

by Christoph VALENTIN

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally against Version 5.1.0 - [x] Related to issue #1168 (replace XXXX with an open issue number) #### Description  The ims_isc module cannot cope with the fact that asynchronous Response from HSS (Diameter SAA message) is received as "FAILURE_ROUTE". ims_isc module erroneously assumes, it is an answer from the AS. Change: added a "firstflag", which makes a difference between first call (SAA from HSS) and subsequent call (FAILURE ROUTE from AS). You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1538 -- Commit Summary -- * ims_isc: initial fix of issue #1168 * ims_isc: implement regexec for isc_checker_find() for wildcarded PSIs * ims_isc: fix: use null terminated strings for regex functions * ims_isc: delete regexec for wildcarded PSIs from isc_checker_find() * ims_isc: remove KCCVICT tagging * Merge branch 'devel_rewi_psi' into bugfix_issue_1168 -- File Changes -- M src/modules/ims_isc/ims_isc_mod.c (9) M src/modules/ims_isc/isc.c (4) M src/modules/ims_isc/isc.h (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1538.patch https://github.com/kamailio/kamailio/pull/1538.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1538

5 years, 11 months

sip_msg structure and memory free

by Konstantin Polyakov

Hello All, There is a structure sip_msg which is passed into a module and represents a received sip message. It contains number of pointers to hdr_field members. In its turn hdr_field contains member void* parsed In the sanity module we assign to parsed member a pointer to newly allocated memory and we don't free that memory at the end. Do we need to free explicitly or this memory will be deallocated later together with sip_msg ? In other words is it memory leak or not? Best regards, Konstantin

5 years, 11 months

[kamailio/kamailio] sipt: Add functions to work with forwarding info (#1498)

by sergey-vb

#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description This commits adding some new functions to Get and Change forwarding info in ISUP part of SIP-I/SIP-T messages. sipt_forwarding(origin, nai) - updates the IAM in the body if it exists, setting (or adding) the forwarding number to origin with the nature address specified in nai $sipt_redirection_info - Returns "Redirecting reason" or -1 if no redirection info found. $sipt_redirection_number - Returns number to which redirection will trigered sipt_redirection_number_nai - Returns NAI for redirection number from ISUP You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1498 -- Commit Summary -- * sipt: Add functions to work with forwarding info (#18) -- File Changes -- M src/modules/sipt/doc/sipt_admin.xml (72) M src/modules/sipt/sipt.c (149) M src/modules/sipt/ss7.h (6) M src/modules/sipt/ss7_parser.c (138) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1498.patch https://github.com/kamailio/kamailio/pull/1498.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1498

5 years, 11 months

git:master:1f2dbe7d: modules: readme files regenerated - app_ruby ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 1f2dbe7d0f21dbe405787d32e48e8a59583ab679 URL: https://github.com/kamailio/kamailio/commit/1f2dbe7d0f21dbe405787d32e48e8a5… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-05-31T12:46:39+02:00 modules: readme files regenerated - app_ruby ... [skip ci] --- Modified: src/modules/app_ruby/README --- Diff: https://github.com/kamailio/kamailio/commit/1f2dbe7d0f21dbe405787d32e48e8a5… Patch: https://github.com/kamailio/kamailio/commit/1f2dbe7d0f21dbe405787d32e48e8a5… --- diff --git a/src/modules/app_ruby/README b/src/modules/app_ruby/README index 40490ad75b..56b7731e4a 100644 --- a/src/modules/app_ruby/README +++ b/src/modules/app_ruby/README @@ -76,9 +76,10 @@ Chapter 1. Admin Guide available within the Ruby module 'KSR'. IMPORTANT: because of Ruby language policy (which require that a public - submodule name has to start with an uppercase leter), the KSR submodule - names are with all leters uppercase. For example, what is documented as - KSR.sl in KEMI docs, must be used as KSR::SL in Ruby scripts. + submodule name has to start with an uppercase letter), the KSR + submodule names are with all letters uppercase. For example, what is + documented as KSR.sl in KEMI docs, must be used as KSR::SL in Ruby + scripts. 2. Dependencies

5 years, 11 months

git:master:ba26117d: app_ruby: small spelling fix in docs

by Henning Westerholt

Module: kamailio Branch: master Commit: ba26117dc22d29913dcf48a15c097829b3892a6f URL: https://github.com/kamailio/kamailio/commit/ba26117dc22d29913dcf48a15c09782… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2018-05-31T12:35:07+02:00 app_ruby: small spelling fix in docs --- Modified: src/modules/app_ruby/doc/app_ruby_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/ba26117dc22d29913dcf48a15c09782… Patch: https://github.com/kamailio/kamailio/commit/ba26117dc22d29913dcf48a15c09782… --- diff --git a/src/modules/app_ruby/doc/app_ruby_admin.xml b/src/modules/app_ruby/doc/app_ruby_admin.xml index bbebe1d6e3..8a2c311bc2 100644 --- a/src/modules/app_ruby/doc/app_ruby_admin.xml +++ b/src/modules/app_ruby/doc/app_ruby_admin.xml @@ -25,8 +25,8 @@ </para> <para> IMPORTANT: because of Ruby language policy (which require that a public - submodule name has to start with an uppercase leter), the KSR submodule - names are with all leters uppercase. For example, what is documented as + submodule name has to start with an uppercase letter), the KSR submodule + names are with all letters uppercase. For example, what is documented as KSR.sl in KEMI docs, must be used as KSR::SL in Ruby scripts. </para> </section>

5 years, 11 months

git: new commits in branch 5.1

by Daniel-Constantin Mierla

- URL: https://github.com/kamailio/kamailio/commit/f42886f1ab9bb61610fca462ee6dc56… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:45:16+02:00 app_lua: kemi - exported KSR.pv.getw("$...") - get the value of the pseudo-variable if it is not $null and the string "<<null>>" if it is $null - useful to use in building log messages without testing if the variable is set, otherwise lua throws error while trying to concatenate null value (cherry picked from commit c3e36a1eb2ff70f94b83a42de3e901f4ba142813) - URL: https://github.com/kamailio/kamailio/commit/0c04b6f8b7f532147e03c1c4bb706e4… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2018-05-31T09:45:31+02:00 db_perlvdb: fix compilation warning > db_perlvdb.c: In function 'db_perlvdb_bind_api': > db_perlvdb.c:98:24: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types] > dbb->replace = perlvdb_db_replace; > ^ (cherry picked from commit dbae2561720c97200d8e58e1e6c408a943e3c07b) - URL: https://github.com/kamailio/kamailio/commit/91649cd46bf88d80f4fbcaccecb03e3… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2018-05-31T09:46:04+02:00 db2_ldap: fix compilation warning > ld_fld.c:831:19: warning: unused function 'db_double2ldap_str' [-Wunused-function] > static inline int db_double2ldap_str(struct sbuf* buf, db_fld_t* fld) > ^ > 1 warning generated. (cherry picked from commit 5b1355aa3d9404a5165b0afbfdac384fe9cf785a) - URL: https://github.com/kamailio/kamailio/commit/8f3d8495297d459e5802a5dc86dab4f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:46:14+02:00 app_python: added KSR.pv.getw(...) (cherry picked from commit 115fa38f427b1bc3730add9078c44219b25960cb) - URL: https://github.com/kamailio/kamailio/commit/e62762cb657912f22c7a0e97f9a43b6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:46:23+02:00 app_python: added KSR.pv.getw() to kemi expors - wrapper function for returning the value (cherry picked from commit e8b434f13f56b2f34d5b30bf728c4685c488e63c) - URL: https://github.com/kamailio/kamailio/commit/b8602fc0f3ea9f3e7bba593c2d8486e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:46:34+02:00 app_sqlang: added KSR.pv.getw(...) (cherry picked from commit cb97be77664625a4fb454bdd6d5c84c8a2c7adb3) - URL: https://github.com/kamailio/kamailio/commit/44a31db68237ca3a43382a20a75e95e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:46:43+02:00 app_jsdt: implemented kemi KSR.pv.getw(...) (cherry picked from commit 3647cc1a9b2e85e71657ba3dd3bba21c6bdc5ff5) - URL: https://github.com/kamailio/kamailio/commit/4cf03cdac8f4f31dbc5fa716ac9b541… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:46:56+02:00 core: cfg.lex - removed redundant token defining max_branches (cherry picked from commit 420fa5e581af5668cdecd0c97b555f4d673105f7) - URL: https://github.com/kamailio/kamailio/commit/ad9817f9d6df0aabe4888b8b2d489a5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:47:08+02:00 topoh: more verbose debug messages when decoding r-uri (cherry picked from commit 5a0086fb5d54cf0411180a8426ea49ad440f147a) - URL: https://github.com/kamailio/kamailio/commit/0cd09d42878ed0125bfad480e9706a8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:47:27+02:00 core: qm malloc - wrapper to print execution file and line for qm_debug_frag() (cherry picked from commit f3109d4dcdc4ef810ccf4a8d17f28f7fce42271c) - URL: https://github.com/kamailio/kamailio/commit/cc1ff15335a81971aa891231cbea7c8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:47:41+02:00 tm: set msg for log_prefix before running failure_route - reported by GH #1531 (cherry picked from commit eb2f25ca0810f966d089da3aa1e32e3e98a4ab16) - URL: https://github.com/kamailio/kamailio/commit/5fc19fd9159c649a6a21ad20193f69e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:47:53+02:00 topos_redis: proper length value when comparing to insert INVITE branch (cherry picked from commit 2a3ca5942291d29de05b14338a36cecbec11f129) - URL: https://github.com/kamailio/kamailio/commit/a1a397bbf6cd6a01ccd505b7b85d448… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:48:07+02:00 sanity: updated docs to reflect default value for default_checks param - reported by GH #1542 (cherry picked from commit 6ff985605b3fbb6aa350af4c21fc73afb8cf122f) - URL: https://github.com/kamailio/kamailio/commit/dace75ab9a294c34bec07d07b328be9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:48:27+02:00 core: kemi - more combinations for function prototypes (cherry picked from commit 6528c9cbc5a89128d4892f1a526c76747b42448c) - URL: https://github.com/kamailio/kamailio/commit/f1fbf3d6d6e4461e6f0440b042121fe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:48:38+02:00 app_lua: fix for running kemi functions with 4 or more parameters - added new combinations for 4 params case - reported by GH #1544 (cherry picked from commit 52f246fbcc9097f77b6a64d15a4ff74e03577ba8) - URL: https://github.com/kamailio/kamailio/commit/b25d7002fe58fff7e876fa3e9818ec0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:48:49+02:00 app_jsdt: fix for executing kemi functions with 4 or more params - more combinations for 4 params (cherry picked from commit 81d517f0a3dcd769dc84ff019c58e248ef7eb466) - URL: https://github.com/kamailio/kamailio/commit/7999ddc6b9b7289cd1f1fe620719e14… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:48:59+02:00 app_python: fix for executing kemi functions with 4 or more params - more combinations for 4 params (cherry picked from commit 551e4d372892d1d5c7803c3812d0bd4613efaf36) - URL: https://github.com/kamailio/kamailio/commit/71f328f8ab2f41ed83749c77eb4b9c3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:49:12+02:00 app_sqlang: fix for executing kemi functions with 4 or more params - more combinations for 4 params (cherry picked from commit d86b67bbde300e4aa1be7ea7c5bdb21469ece03c) - URL: https://github.com/kamailio/kamailio/commit/96eec5f5aaa99288ef59097cc39c632… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:49:26+02:00 rls: allocate size for normalized uri for cloning buffer - it can be longer than pres uri, when proto prefix needs to be added (cherry picked from commit 93932a4ff18760d8fc8c59bd08984fd00cfd7759) - URL: https://github.com/kamailio/kamailio/commit/7e763c727076af3a3a35db4fc840e85… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:49:41+02:00 lib/srdb1: increased the safety check for max db url to 1023 - was 255, too small for large connection strings needed for no-sql - reported by GH #1545 (cherry picked from commit 0a9ebbbdfe0cd4c137338adbacf5c5890222708a) - URL: https://github.com/kamailio/kamailio/commit/7d6dddfbf2ccadaf749496a4288f176… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:49:51+02:00 stun: catch udp ping 0000 when trying to parse stun headers - avoid useless debug message - info message made debug if the size of received packet is too small for a stun header (cherry picked from commit 7e08fc8d2b74657d6e6171effbab2770482d693e) - URL: https://github.com/kamailio/kamailio/commit/fd163baf20ab28354bb7cbf92ffd7e7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:50:02+02:00 app_jsdt: exported KSR.pv.getw(...) (cherry picked from commit 616b68904e0741ebcdb70e3c7f66b3b6d1254a8d) - URL: https://github.com/kamailio/kamailio/commit/4cf3f3e84bcd45eb32545de9fa71d80… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:50:15+02:00 core: kemi - more log-level message shortcut functions (cherry picked from commit f854f2c27bee1b1e4f43565ff1865b88c27387c9) - URL: https://github.com/kamailio/kamailio/commit/0c17c1c8ba43967025f13a87507e687… Author: Olle E. Johansson <oej(a)edvina.net> Date: 2018-05-31T09:50:26+02:00 db_cluster remove old svn ID tags (cherry picked from commit be82892a68342287d37de90ddb74c1f66a37e28f) - URL: https://github.com/kamailio/kamailio/commit/e3a78848857ee4a12211f10e091209e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:50:47+02:00 topos: skip handling local DMQ messages (cherry picked from commit 7ff8d4284f20763e8e47f9b24e4604867a242e4a) - URL: https://github.com/kamailio/kamailio/commit/9aee0374e1db8733a220d37fbc53517… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:51:01+02:00 carrierroute: rename boolean type conflicting with clang sdtbool In file included from carrierroute.c:51: ./cr_db.h:92:2: error: expected identifier false = 0, ^ /usr/lib/clang/9.1.0/include/stdbool.h:33:15: note: expanded from macro 'false' #define false 0 (cherry picked from commit 0a14914fc1f98c18b9b75f66fe2e71f15147c9bf)

5 years, 11 months

git:master:a557e628: modules: readme files regenerated - app_ruby ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: a557e628ac9d06488c0818da4e94d09ecd93170b URL: https://github.com/kamailio/kamailio/commit/a557e628ac9d06488c0818da4e94d09… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-05-31T09:46:42+02:00 modules: readme files regenerated - app_ruby ... [skip ci] --- Modified: src/modules/app_ruby/README --- Diff: https://github.com/kamailio/kamailio/commit/a557e628ac9d06488c0818da4e94d09… Patch: https://github.com/kamailio/kamailio/commit/a557e628ac9d06488c0818da4e94d09… --- diff --git a/src/modules/app_ruby/README b/src/modules/app_ruby/README index 5b706bb915..40490ad75b 100644 --- a/src/modules/app_ruby/README +++ b/src/modules/app_ruby/README @@ -175,7 +175,7 @@ kamcmd app_ruby.api_list '/usr/local/etc/kamailio/ruby/myscript.rb'. ... def ksr_sl_reply() - KSR.dbg("==== from ruby\n") + KSR.dbg("==== from ruby - src ip: " + KSR::PV.get("$si") + "\n") KSR::SL.sl_send_reply(200, "OK-Ruby") end ...

5 years, 11 months

git:master:f9c7c127: app_ruby: docs - added to example how to get value for pv

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f9c7c127acf7320356e978eb13821b5e0a89f30d URL: https://github.com/kamailio/kamailio/commit/f9c7c127acf7320356e978eb13821b5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T09:40:11+02:00 app_ruby: docs - added to example how to get value for pv --- Modified: src/modules/app_ruby/doc/app_ruby_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/f9c7c127acf7320356e978eb13821b5… Patch: https://github.com/kamailio/kamailio/commit/f9c7c127acf7320356e978eb13821b5… --- diff --git a/src/modules/app_ruby/doc/app_ruby_admin.xml b/src/modules/app_ruby/doc/app_ruby_admin.xml index b6773785d1..bbebe1d6e3 100644 --- a/src/modules/app_ruby/doc/app_ruby_admin.xml +++ b/src/modules/app_ruby/doc/app_ruby_admin.xml @@ -172,7 +172,7 @@ ruby_run("rb_funcx", "$rU", "2"); <programlisting format="linespecific"> ... def ksr_sl_reply() - KSR.dbg("==== from ruby\n") + KSR.dbg("==== from ruby - src ip: " + KSR::PV.get("$si") + "\n") KSR::SL.sl_send_reply(200, "OK-Ruby") end ...

5 years, 11 months

git:master:c173ab86: app_ruby: implemented KSR::PV kemi exports

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: c173ab860670cbc03cb8cd3027e033ff67b02a45 URL: https://github.com/kamailio/kamailio/commit/c173ab860670cbc03cb8cd3027e033f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-31T08:24:44+02:00 app_ruby: implemented KSR::PV kemi exports --- Modified: src/modules/app_ruby/app_ruby_api.c --- Diff: https://github.com/kamailio/kamailio/commit/c173ab860670cbc03cb8cd3027e033f… Patch: https://github.com/kamailio/kamailio/commit/c173ab860670cbc03cb8cd3027e033f…

5 years, 11 months

← Newer
1
...
6
7
8
9
10
11
12
...
22
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2018