sr-dev May 2018

sr-dev@lists.kamailio.org

22 participants
214 discussions

git:master:52f246fb: app_lua: fix for running kemi functions with 4 or more parameters

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 52f246fbcc9097f77b6a64d15a4ff74e03577ba8 URL: https://github.com/kamailio/kamailio/commit/52f246fbcc9097f77b6a64d15a4ff74… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-25T11:42:45+02:00 app_lua: fix for running kemi functions with 4 or more parameters - added new combinations for 4 params case - reported by GH #1544 --- Modified: src/modules/app_lua/app_lua_sr.c --- Diff: https://github.com/kamailio/kamailio/commit/52f246fbcc9097f77b6a64d15a4ff74… Patch: https://github.com/kamailio/kamailio/commit/52f246fbcc9097f77b6a64d15a4ff74… --- diff --git a/src/modules/app_lua/app_lua_sr.c b/src/modules/app_lua/app_lua_sr.c index 6edba5d7a7..c98830da5c 100644 --- a/src/modules/app_lua/app_lua_sr.c +++ b/src/modules/app_lua/app_lua_sr.c @@ -1682,19 +1682,33 @@ int sr_kemi_lua_exec_func_ex(lua_State* L, sr_kemi_t *ket, int pdelta) break; case 4: if(ket->ptypes[0]==SR_KEMIP_STR - || ket->ptypes[1]==SR_KEMIP_STR - || ket->ptypes[2]==SR_KEMIP_STR - || ket->ptypes[3]==SR_KEMIP_STR) { + && ket->ptypes[1]==SR_KEMIP_STR + && ket->ptypes[2]==SR_KEMIP_STR + && ket->ptypes[3]==SR_KEMIP_STR) { ret = ((sr_kemi_fmssss_f)(ket->func))(env_L->msg, &vps[0].s, &vps[1].s, &vps[2].s, &vps[3].s); return sr_kemi_lua_return_int(L, ket, ret); } else if(ket->ptypes[0]==SR_KEMIP_STR - || ket->ptypes[1]==SR_KEMIP_STR - || ket->ptypes[2]==SR_KEMIP_INT - || ket->ptypes[3]==SR_KEMIP_INT) { + && ket->ptypes[1]==SR_KEMIP_STR + && ket->ptypes[2]==SR_KEMIP_STR + && ket->ptypes[3]==SR_KEMIP_INT) { + ret = ((sr_kemi_fmsssn_f)(ket->func))(env_L->msg, + &vps[0].s, &vps[1].s, &vps[2].s, vps[3].n); + return sr_kemi_lua_return_int(L, ket, ret); + } else if(ket->ptypes[0]==SR_KEMIP_STR + && ket->ptypes[1]==SR_KEMIP_STR + && ket->ptypes[2]==SR_KEMIP_INT + && ket->ptypes[3]==SR_KEMIP_INT) { ret = ((sr_kemi_fmssnn_f)(ket->func))(env_L->msg, &vps[0].s, &vps[1].s, vps[2].n, vps[3].n); return sr_kemi_lua_return_int(L, ket, ret); + } else if(ket->ptypes[0]==SR_KEMIP_INT + && ket->ptypes[1]==SR_KEMIP_STR + && ket->ptypes[2]==SR_KEMIP_STR + && ket->ptypes[3]==SR_KEMIP_STR) { + ret = ((sr_kemi_fmnsss_f)(ket->func))(env_L->msg, + vps[0].n, &vps[1].s, &vps[2].s, &vps[3].s); + return sr_kemi_lua_return_int(L, ket, ret); } else { LM_ERR("invalid parameters for: %.*s\n", fname->len, fname->s); @@ -1703,10 +1717,10 @@ int sr_kemi_lua_exec_func_ex(lua_State* L, sr_kemi_t *ket, int pdelta) break; case 5: if(ket->ptypes[0]==SR_KEMIP_STR - || ket->ptypes[1]==SR_KEMIP_STR - || ket->ptypes[2]==SR_KEMIP_STR - || ket->ptypes[3]==SR_KEMIP_STR - || ket->ptypes[4]==SR_KEMIP_STR) { + && ket->ptypes[1]==SR_KEMIP_STR + && ket->ptypes[2]==SR_KEMIP_STR + && ket->ptypes[3]==SR_KEMIP_STR + && ket->ptypes[4]==SR_KEMIP_STR) { ret = ((sr_kemi_fmsssss_f)(ket->func))(env_L->msg, &vps[0].s, &vps[1].s, &vps[2].s, &vps[3].s, &vps[4].s); @@ -1719,11 +1733,11 @@ int sr_kemi_lua_exec_func_ex(lua_State* L, sr_kemi_t *ket, int pdelta) break; case 6: if(ket->ptypes[0]==SR_KEMIP_STR - || ket->ptypes[1]==SR_KEMIP_STR - || ket->ptypes[2]==SR_KEMIP_STR - || ket->ptypes[3]==SR_KEMIP_STR - || ket->ptypes[4]==SR_KEMIP_STR - || ket->ptypes[5]==SR_KEMIP_STR) { + && ket->ptypes[1]==SR_KEMIP_STR + && ket->ptypes[2]==SR_KEMIP_STR + && ket->ptypes[3]==SR_KEMIP_STR + && ket->ptypes[4]==SR_KEMIP_STR + && ket->ptypes[5]==SR_KEMIP_STR) { ret = ((sr_kemi_fmssssss_f)(ket->func))(env_L->msg, &vps[0].s, &vps[1].s, &vps[2].s, &vps[3].s, &vps[4].s, &vps[5].s);

6 years, 7 months

git:master:6528c9cb: core: kemi - more combinations for function prototypes

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 6528c9cbc5a89128d4892f1a526c76747b42448c URL: https://github.com/kamailio/kamailio/commit/6528c9cbc5a89128d4892f1a526c767… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-25T11:42:45+02:00 core: kemi - more combinations for function prototypes --- Modified: src/core/kemi.h --- Diff: https://github.com/kamailio/kamailio/commit/6528c9cbc5a89128d4892f1a526c767… Patch: https://github.com/kamailio/kamailio/commit/6528c9cbc5a89128d4892f1a526c767… --- diff --git a/src/core/kemi.h b/src/core/kemi.h index d19e094c63..0822c752f4 100644 --- a/src/core/kemi.h +++ b/src/core/kemi.h @@ -89,8 +89,22 @@ typedef int (*sr_kemi_fmssn_f)(sip_msg_t*, str*, str*, int); typedef int (*sr_kemi_fmsss_f)(sip_msg_t*, str*, str*, str*); /* sip_msg_t and four int|str params */ -typedef int (*sr_kemi_fmssss_f)(sip_msg_t*, str*, str*, str*, str*); +typedef int (*sr_kemi_fmnnnn_f)(sip_msg_t*, int, int, int, int); +typedef int (*sr_kemi_fmnnns_f)(sip_msg_t*, int, int, int, str*); +typedef int (*sr_kemi_fmnnsn_f)(sip_msg_t*, int, int, str*, int); +typedef int (*sr_kemi_fmnnss_f)(sip_msg_t*, int, int, str*, str*); +typedef int (*sr_kemi_fmnsnn_f)(sip_msg_t*, int, str*, int, int); +typedef int (*sr_kemi_fmnsns_f)(sip_msg_t*, int, str*, int, str*); +typedef int (*sr_kemi_fmnssn_f)(sip_msg_t*, int, str*, str*, int); +typedef int (*sr_kemi_fmnsss_f)(sip_msg_t*, int, str*, str*, str*); +typedef int (*sr_kemi_fmsnnn_f)(sip_msg_t*, str*, int, int, int); +typedef int (*sr_kemi_fmsnns_f)(sip_msg_t*, str*, int, int, str*); +typedef int (*sr_kemi_fmsnsn_f)(sip_msg_t*, str*, int, str*, int); +typedef int (*sr_kemi_fmsnss_f)(sip_msg_t*, str*, int, str*, str*); typedef int (*sr_kemi_fmssnn_f)(sip_msg_t*, str*, str*, int, int); +typedef int (*sr_kemi_fmssns_f)(sip_msg_t*, str*, str*, int, str*); +typedef int (*sr_kemi_fmsssn_f)(sip_msg_t*, str*, str*, str*, int); +typedef int (*sr_kemi_fmssss_f)(sip_msg_t*, str*, str*, str*, str*); /* sip_msg_t and five int|str params */ typedef int (*sr_kemi_fmsssss_f)(sip_msg_t*, str*, str*, str*, str*, str*);

6 years, 7 months

[kamailio/kamailio] Bugfix trash expires (#1539)

by Christoph VALENTIN

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally against Version 5.1.0 - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  When old (maybe forgotten) Contacts expire in S-CSCF, then current - wanted - calls will be deleted, which is not wanted. Reason is the usage of "=" Operator instead "==" Operator in ims_usrloc_scscf module. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1539 -- Commit Summary -- * ims_usrloc_scscf: bugfix Contct is removed when old Contct expires * removed KCCVICT tagging * Merge branch 'bugfix_prm18_0000756_trash_expires' into bugfix_trash_expires -- File Changes -- M src/modules/ims_usrloc_scscf/impurecord.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1539.patch https://github.com/kamailio/kamailio/pull/1539.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1539

6 years, 7 months

git:master:c2fd44b6: Merge pull request #1539 from christoph-v/bugfix_trash_expires

by GitHub

Module: kamailio Branch: master Commit: c2fd44b6101116dd6bfb4c14ef81ea87e5af6f6e URL: https://github.com/kamailio/kamailio/commit/c2fd44b6101116dd6bfb4c14ef81ea8… Author: ng-voice GmbH <info(a)ng-voice.com> Committer: GitHub <noreply(a)github.com> Date: 2018-05-24T10:30:22+02:00 Merge pull request #1539 from christoph-v/bugfix_trash_expires Bugfix trash expires --- Modified: src/modules/ims_usrloc_scscf/impurecord.c --- Diff: https://github.com/kamailio/kamailio/commit/c2fd44b6101116dd6bfb4c14ef81ea8… Patch: https://github.com/kamailio/kamailio/commit/c2fd44b6101116dd6bfb4c14ef81ea8… --- diff --git a/src/modules/ims_usrloc_scscf/impurecord.c b/src/modules/ims_usrloc_scscf/impurecord.c index 9cee5bc765..6510d85aa1 100644 --- a/src/modules/ims_usrloc_scscf/impurecord.c +++ b/src/modules/ims_usrloc_scscf/impurecord.c @@ -1239,7 +1239,7 @@ int unlink_contact_from_impu(impurecord_t* impu, ucontact_t* contact, int write_ impucontact = impu->linked_contacts.head; while (impucontact) { - if ((contact = impucontact->contact)) { + if ((contact == impucontact->contact)) { remove_impucontact_from_list(impu, impucontact); if (write_to_db && db_mode == WRITE_THROUGH && (db_unlink_contact_from_impu(impu, contact) != 0)) { LM_ERR("Failed to un-link DB contact [%.*s] from IMPU [%.*s]...continuing but db will be out of sync!\n", contact->c.len, contact->c.s, impu->public_identity.len, impu->public_identity.s);

6 years, 7 months

git:master:2b1e895e: ims_usrloc_scscf: bugfix Contct is removed when old Contct expires

by Christoph Valentin

Module: kamailio Branch: master Commit: 2b1e895e1a319b932a449c703a974c6ab8aafc6e URL: https://github.com/kamailio/kamailio/commit/2b1e895e1a319b932a449c703a974c6… Author: Christoph Valentin <christoph.valentin(a)kapsch.net> Committer: Christoph Valentin <christoph.valentin(a)kapsch.net> Date: 2018-05-22T17:12:10+02:00 ims_usrloc_scscf: bugfix Contct is removed when old Contct expires in function unlink_contact_from_impu() (in file impurecord.c) an assignment "=" is used instead of a comparision operator "==". This leads to mess, when old contact expires. --- Modified: src/modules/ims_usrloc_scscf/impurecord.c --- Diff: https://github.com/kamailio/kamailio/commit/2b1e895e1a319b932a449c703a974c6… Patch: https://github.com/kamailio/kamailio/commit/2b1e895e1a319b932a449c703a974c6… --- diff --git a/src/modules/ims_usrloc_scscf/impurecord.c b/src/modules/ims_usrloc_scscf/impurecord.c index 9cee5bc765..6510d85aa1 100644 --- a/src/modules/ims_usrloc_scscf/impurecord.c +++ b/src/modules/ims_usrloc_scscf/impurecord.c @@ -1239,7 +1239,7 @@ int unlink_contact_from_impu(impurecord_t* impu, ucontact_t* contact, int write_ impucontact = impu->linked_contacts.head; while (impucontact) { - if ((contact = impucontact->contact)) { + if ((contact == impucontact->contact)) { remove_impucontact_from_list(impu, impucontact); if (write_to_db && db_mode == WRITE_THROUGH && (db_unlink_contact_from_impu(impu, contact) != 0)) { LM_ERR("Failed to un-link DB contact [%.*s] from IMPU [%.*s]...continuing but db will be out of sync!\n", contact->c.len, contact->c.s, impu->public_identity.len, impu->public_identity.s);

6 years, 7 months

git:master:61f19592: modules: readme files regenerated - sanity ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 61f19592b7a252357c444ec36d24650ad51dbe5c URL: https://github.com/kamailio/kamailio/commit/61f19592b7a252357c444ec36d24650… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-05-24T10:16:45+02:00 modules: readme files regenerated - sanity ... [skip ci] --- Modified: src/modules/sanity/README --- Diff: https://github.com/kamailio/kamailio/commit/61f19592b7a252357c444ec36d24650… Patch: https://github.com/kamailio/kamailio/commit/61f19592b7a252357c444ec36d24650… --- diff --git a/src/modules/sanity/README b/src/modules/sanity/README index f11c61e01e..14aa8462cc 100644 --- a/src/modules/sanity/README +++ b/src/modules/sanity/README @@ -120,10 +120,10 @@ Chapter 1. Admin Guide of the sanity_check function. The integer value is the sum of the check numbers which should be executed by default. - Default value is “999”. This resolves to the following list of checks: + Default value is “3047”. This resolves to the following list of checks: ruri_sip_version (1), ruri_scheme (2), required_headers (4), - cseq_method (32), cseq_value (64), cotent_length (128), expires_value - (256), proxy_require (512). + cseq_method (32), cseq_value (64), content_length (128), expires_value + (256), proxy_require (512), digest credentials (2048). Example 1.1. Set default_checks parameter ...

6 years, 7 months

[kamailio/kamailio] sanity: Mistakes in the documentation article. (#1542)

by Konstantin

### Description  Wrong information in the documentation. 1. Default value of the parameter default_checks is 2791. In the documentation it is said that default is 999. 2. One check is not described - SANITY_CHECK_DUPTAGS. It was found in the version 4.4.7. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1542

6 years, 7 months

git:master:6ff98560: sanity: updated docs to reflect default value for default_checks param

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 6ff985605b3fbb6aa350af4c21fc73afb8cf122f URL: https://github.com/kamailio/kamailio/commit/6ff985605b3fbb6aa350af4c21fc73a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-05-24T10:09:20+02:00 sanity: updated docs to reflect default value for default_checks param - reported by GH #1542 --- Modified: src/modules/sanity/doc/sanity_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/6ff985605b3fbb6aa350af4c21fc73a… Patch: https://github.com/kamailio/kamailio/commit/6ff985605b3fbb6aa350af4c21fc73a… --- diff --git a/src/modules/sanity/doc/sanity_admin.xml b/src/modules/sanity/doc/sanity_admin.xml index cc8fe0f121..f951ca0031 100644 --- a/src/modules/sanity/doc/sanity_admin.xml +++ b/src/modules/sanity/doc/sanity_admin.xml @@ -152,10 +152,10 @@ is the sum of the check numbers which should be executed by default. </para> <para> - Default value is <quote>999</quote>. This resolves to the following list of + Default value is <quote>3047</quote>. This resolves to the following list of checks: ruri_sip_version (1), ruri_scheme (2), required_headers (4), - cseq_method (32), cseq_value (64), cotent_length (128), - expires_value (256), proxy_require (512). + cseq_method (32), cseq_value (64), content_length (128), + expires_value (256), proxy_require (512), digest credentials (2048). </para> <example> <title>Set <varname>default_checks</varname> parameter</title>

6 years, 7 months

[kamailio/kamailio] P-CSCF crash during client login (#1526)

by uts09

### Description Kamailio P-CSCF is crashing during IMS client login. I am using Boghe IMS client,  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (gdb) list 352 } else { //contact already exists - update 353 LM_DBG("Contact already exists - not doing anything for now\n"); 354 } 355 356 // Update security parameters 357 if(ul.update_temp_security(_d, sec_params->type, sec_params, pcontact) != 0) 358 { 359 LM_ERR("Error updating temp security\n"); 360 } 361 ``` #### Log Messages  ``` [root@8bd3221bd31e pcscf]# kamailio -f /usr/local/src/kamailio-5.1/kamailio/misc/examples/ims/pcscf/kamailio.cfg -E -E -dd 0(32522) INFO: <core> [main.c:1939]: main(): private (per process) memory: 8388608 bytes 0(32522) INFO: <core> [core/ppcfg.c:82]: pp_subst_add(): ### added subst expression: /NETWORKNAME/mnc001.mcc001.3gppnetwork.org/ 0(32522) INFO: <core> [core/ppcfg.c:82]: pp_subst_add(): ### added subst expression: /HOSTNAME/pcscf.mnc001.mcc001.3gppnetwork.org/ loading modules under config path: /usr/local/lib64/kamailio/modules/ 0(32522) INFO: pv [pv_shv.c:60]: shvar_init_locks(): locks array size 16 0(32522) INFO: <core> [core/sctp_core.c:75]: sctp_core_check_support(): SCTP API not enabled - if you want to use it, load sctp module Listening on udp: 172.17.0.3 [172.17.0.3]:5060 advertise net1.test:5060 Aliases: *: pcscf.net1.test:* WARNING: no fork mode 0(32522) INFO: rr [../outbound/api.h:52]: ob_load_api(): unable to import bind_ob - maybe module is not loaded 0(32522) INFO: rr [rr_mod.c:177]: mod_init(): outbound module not available 0(32522) INFO: auth [auth_mod.c:347]: mod_init(): qop set, but nonce-count (nc_enabled) support disabled 0(32522) INFO: path [../outbound/api.h:52]: ob_load_api(): unable to import bind_ob - maybe module is not loaded 0(32522) INFO: path [path_mod.c:153]: mod_init(): outbound module not available 0(32522) INFO: ims_usrloc_pcscf [hslot.c:62]: ul_init_locks(): locks array size 512 0(32522) ERROR: rtpengine [rtpengine.c:2649]: select_rtpp_set(): no rtpp_set_list->rset_first 0(32522) NOTICE: rtpengine [rtpengine.c:1588]: mod_init(): Default rtpp set 0 NOT found 0(32522) WARNING: tm [tm.c:513]: fixup_routes(): t_on_failure("NATMANAGE"): empty/non existing route 0(32522) INFO: <core> [core/udp_server.c:153]: probe_max_receive_buffer(): SO_RCVBUF is initially 65535 0(32522) INFO: <core> [core/udp_server.c:205]: probe_max_receive_buffer(): SO_RCVBUF is finally 524280 0(32522) ERROR: <script>: event_route[htable:mod-init] { 4(32529) INFO: ctl [io_listener.c:210]: io_listen_loop(): io_listen_loop: using epoll_lt as the io watch method (auto detected) 5(32534) WARNING: ims_usrloc_pcscf [usrloc_db.c:61]: connect_db(): DB connection already open... continuing 0(32522) WARNING: ims_usrloc_pcscf [usrloc_db.c:61]: connect_db(): DB connection already open... continuing 7(32536) INFO: jsonrpcs [jsonrpcs_sock.c:443]: jsonrpc_dgram_process(): a new child 0/32536 0(32522) ERROR: <script>: REGISTER (sip:bob@net1.test (10.0.9.101:61728) to sip:bob@net1.test, d171ff89-efcb-de9f-9eb6-8dfdbf8b7221) 0(32522) INFO: rr [rr_mod.c:445]: pv_get_route_uri_f(): No route header present. 0(32522) INFO: ims_registrar_pcscf [sec_agree.c:255]: cscf_get_security(): No security parameters found 0(32522) ERROR: ims_registrar_pcscf [save.c:339]: save_pending(): Will save pending contact without security parameters Segmentation fault ``` #### SIP Traffic  ``` ................ 08:53:01.511644 IP 10.0.9.101.64932 > 172.17.0.3.5060: SIP: REGISTER sip:net1.test SIP/2.0 E...#...~.V. . e...........pREGISTER sip:net1.test SIP/2.0 Via: SIP/2.0/UDP 10.0.9.101:64932;branch=z9hG4bK537357731;rport From: <sip:bob@net1.test>;tag=537331589 To: <sip:bob@net1.test> Contact: <sip:bob@10.0.9.101:64932;transport=udp>;expires=600000;+g.oma.sip-im;language="en,fr";+g.3gpp.smsip;+g.oma.sip-im.large-message;audio;+g.3gpp.icsi-ref="urn%3Aurn-7%3A3gpp-application.ims.iari.gsma-vs";+g.3gpp.cs-voice Call-ID: 4175e599-11d6-fd99-cdaf-225973666aa6 CSeq: 16432 REGISTER Content-Length: 0 Max-Forwards: 70 Allow: INVITE, ACK, CANCEL, BYE, MESSAGE, OPTIONS, NOTIFY, PRACK, UPDATE, REFER Privacy: none P-Access-Network-Info: ADSL;utran-cell-id-3gpp=00000000 User-Agent: IM-client/OMA1.0 Boghe-Win32/v2.0.153.836 P-Preferred-Identity: <sip:bob@net1.test> Supported: path ................ 08:53:01.512031 IP 172.17.0.3.5060 > 10.0.9.101.64932: SIP: SIP/2.0 100 Trying E..F.M..@....... . e.....2..SIP/2.0 100 Trying Via: SIP/2.0/UDP 10.0.9.101:64932;branch=z9hG4bK537357731;rport=64932;received=10.0.9.101 From: <sip:bob@net1.test>;tag=537331589 To: <sip:bob@net1.test> Call-ID: 4175e599-11d6-fd99-cdaf-225973666aa6 CSeq: 16432 REGISTER Server: TelcoSuite Proxy-CSCF Content-Length: 0 ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` [root@8bd3221bd31e pcscf]# kamailio -v version: kamailio 5.2.0-dev5 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 05:45:36 May 8 2018 with gcc 4.8.5 ``` * **Operating System**:  ``` Linux 8bd3221bd31e 3.10.0-229.el7.x86_64 #1 SMP Fri Mar 6 11:36:42 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1526

6 years, 7 months

git:master:62a669f9: Merge pull request #1527 from tdimitrov/pcscf_crash

by GitHub

Module: kamailio Branch: master Commit: 62a669f9f4125f88e60b2a1f621442a8ca923c82 URL: https://github.com/kamailio/kamailio/commit/62a669f9f4125f88e60b2a1f621442a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2018-05-24T08:36:28+02:00 Merge pull request #1527 from tdimitrov/pcscf_crash ims_registrar_pcscf: Update tmp security only if there are sec-agree â¦ --- Modified: src/modules/ims_registrar_pcscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/62a669f9f4125f88e60b2a1f621442a… Patch: https://github.com/kamailio/kamailio/commit/62a669f9f4125f88e60b2a1f621442a… --- diff --git a/src/modules/ims_registrar_pcscf/save.c b/src/modules/ims_registrar_pcscf/save.c index 0edf7bd808..39dfe4d589 100644 --- a/src/modules/ims_registrar_pcscf/save.c +++ b/src/modules/ims_registrar_pcscf/save.c @@ -354,9 +354,11 @@ int save_pending(struct sip_msg* _m, udomain_t* _d) { } // Update security parameters - if(ul.update_temp_security(_d, sec_params->type, sec_params, pcontact) != 0) - { - LM_ERR("Error updating temp security\n"); + if(sec_params) { + if(ul.update_temp_security(_d, sec_params->type, sec_params, pcontact) != 0) + { + LM_ERR("Error updating temp security\n"); + } } ul.unlock_udomain(_d, &ci.via_host, ci.via_port, ci.via_prot);

6 years, 7 months

← Newer
1
...
10
11
12
13
14
15
16
...
22
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2018