sr-dev July 2017

sr-dev@lists.kamailio.org

23 participants
410 discussions

git:master:56d1d317: mtree: access values before safety checks of variables

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 56d1d317e4bac7130586541fed75be670ea0f9ce URL: https://github.com/kamailio/kamailio/commit/56d1d317e4bac7130586541fed75be6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-04T12:00:47+02:00 mtree: access values before safety checks of variables --- Modified: src/modules/mtree/mtree.c Modified: src/modules/mtree/mtree_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/56d1d317e4bac7130586541fed75be6… Patch: https://github.com/kamailio/kamailio/commit/56d1d317e4bac7130586541fed75be6… --- diff --git a/src/modules/mtree/mtree.c b/src/modules/mtree/mtree.c index 433c6b4c50..c4de10c763 100644 --- a/src/modules/mtree/mtree.c +++ b/src/modules/mtree/mtree.c @@ -985,12 +985,13 @@ int mt_rpc_add_tvalues(rpc_t* rpc, void* ctx, m_tree_t *pt, str *tomatch) mt_node_t *itn; mt_is_t *tvalues; void *vstruct = NULL; - str prefix = *tomatch; + str prefix = STR_NULL; if (pt == NULL || tomatch == NULL || tomatch->s == NULL) { LM_ERR("bad parameters\n"); return -1; } + prefix = *tomatch; l = 0; itn = pt->head; @@ -1051,7 +1052,7 @@ int mt_rpc_match_prefix(rpc_t* rpc, void* ctx, m_tree_t *it, is_t *tvalue; mt_dw_t *dw; int tprefix_len = 0; - str prefix = *tomatch; + str prefix = STR_NULL; void *vstruct = NULL; #define MT_MAX_DST_LIST 64 @@ -1063,6 +1064,7 @@ int mt_rpc_match_prefix(rpc_t* rpc, void* ctx, m_tree_t *it, LM_ERR("bad parameters\n"); return -1; } + prefix = *tomatch; if (rpc->add(ctx, "S", &it->tname) < 0) { rpc->fault(ctx, 500, "Internal error adding tname"); diff --git a/src/modules/mtree/mtree_mod.c b/src/modules/mtree/mtree_mod.c index 9808018840..4ce2786afb 100644 --- a/src/modules/mtree/mtree_mod.c +++ b/src/modules/mtree/mtree_mod.c @@ -764,16 +764,20 @@ static int mt_load_db_trees() { /* check for NULL values ?!?! */ tname.s = (char*)(RES_ROWS(db_res)[i].values[0].val.string_val); - tname.len = strlen(tname.s); - tprefix.s = (char*)(RES_ROWS(db_res)[i].values[1].val.string_val); - tprefix.len = strlen(tprefix.s); - tvalue.s = (char*)(RES_ROWS(db_res)[i].values[2].val.string_val); + + if(tprefix.s==NULL || tvalue.s==NULL || tname.s==NULL) + { + LM_ERR("Error - null fields in db\n"); + continue; + } + + tname.len = strlen(tname.s); + tprefix.len = strlen(tprefix.s); tvalue.len = strlen(tvalue.s); - if(tprefix.s==NULL || tvalue.s==NULL || tname.s==NULL || - tprefix.len<=0 || tvalue.len<=0 || tname.len<=0) + if(tname.len<=0 || tprefix.len<=0 || tvalue.len<=0) { LM_ERR("Error - bad values in db\n"); continue;

7 years, 5 months

git:master:e9cfb2bf: dispatcher: log messages for hashing auth username

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: e9cfb2bf5012cdbde36559f615b58e3a556bfc2d URL: https://github.com/kamailio/kamailio/commit/e9cfb2bf5012cdbde36559f615b58e3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-04T11:52:53+02:00 dispatcher: log messages for hashing auth username --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/e9cfb2bf5012cdbde36559f615b58e3… Patch: https://github.com/kamailio/kamailio/commit/e9cfb2bf5012cdbde36559f615b58e3… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 38a6213de1..155be57ca5 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -1214,12 +1214,16 @@ int ds_hash_authusername(struct sip_msg *msg, unsigned int *hash) LM_ERR("bad parameters\n"); return -1; } + *hash = 0; if(parse_headers(msg, HDR_PROXYAUTH_F, 0) == -1) { LM_ERR("error parsing headers!\n"); return -1; } - if(msg->proxy_auth && !msg->proxy_auth->parsed) - parse_credentials(msg->proxy_auth); + if(msg->proxy_auth && !msg->proxy_auth->parsed) { + if(parse_credentials(msg->proxy_auth)!=0) { + LM_DBG("no parsing for proxy-auth header\n"); + } + } if(msg->proxy_auth && msg->proxy_auth->parsed) { h = msg->proxy_auth; } @@ -1228,8 +1232,11 @@ int ds_hash_authusername(struct sip_msg *msg, unsigned int *hash) LM_ERR("error parsing headers!\n"); return -1; } - if(msg->authorization && !msg->authorization->parsed) - parse_credentials(msg->authorization); + if(msg->authorization && !msg->authorization->parsed) { + if(parse_credentials(msg->authorization)!=0) { + LM_DBG("no parsing for auth header\n"); + } + } if(msg->authorization && msg->authorization->parsed) { h = msg->authorization; }

7 years, 5 months

[kamailio/kamailio] Cfg reset (#1178)

by hdikme

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  kamcmd cfg.reset "group_name", cfg.reset has been created in order to reset all the variables of the referred group to be set to their initial values (default). You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1178 -- Commit Summary -- * cfg_rpc: rpc_reset() function has been created * Merge branch 'master' of https://github.com/kamailio/kamailio into cfg_reset * README file has been re-created. * Merge branch 'master' of https://github.com/kamailio/kamailio into cfg_reset -- File Changes -- M src/core/cfg/cfg_ctx.c (68) M src/core/cfg/cfg_ctx.h (3) M src/modules/cfg_rpc/README (118) M src/modules/cfg_rpc/cfg_rpc.c (55) M src/modules/cfg_rpc/doc/rpc.xml (16) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1178.patch https://github.com/kamailio/kamailio/pull/1178.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1178

7 years, 5 months

git:master:b8ab9fcc: dialog: lookup kemi engine for event route execution

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b8ab9fcccd442e9e9ac887a7dc16b690213a6e28 URL: https://github.com/kamailio/kamailio/commit/b8ab9fcccd442e9e9ac887a7dc16b69… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-04T11:11:41+02:00 dialog: lookup kemi engine for event route execution --- Modified: src/modules/dialog/dlg_handlers.c Modified: src/modules/dialog/dlg_profile.c --- Diff: https://github.com/kamailio/kamailio/commit/b8ab9fcccd442e9e9ac887a7dc16b69… Patch: https://github.com/kamailio/kamailio/commit/b8ab9fcccd442e9e9ac887a7dc16b69… --- diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index eb5d41ceac..c4218be50a 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -1550,6 +1550,7 @@ void dlg_ontimeout(struct dlg_tl *tl) if(dlg->toroute>0) { run_top_route(main_rt.rlist[dlg->toroute], fmsg, 0); } else { + keng = sr_kemi_eng_get(); if(keng!=NULL) { evname.s = "dialog:timeout"; evname.len = sizeof("dialog:timeout") - 1; @@ -1703,22 +1704,28 @@ int dlg_run_event_route(dlg_cell_t *dlg, sip_msg_t *msg, int ostate, int nstate) if(dlg_event_callback.s==NULL || dlg_event_callback.len<=0) { if(nstate==DLG_STATE_CONFIRMED_NA) { rt = dlg_event_rt[DLG_EVENTRT_START]; + } else if(nstate==DLG_STATE_DELETED) { + if(ostate==DLG_STATE_CONFIRMED || ostate==DLG_STATE_CONFIRMED_NA) { + rt = dlg_event_rt[DLG_EVENTRT_END]; + } else if(ostate==DLG_STATE_UNCONFIRMED || ostate==DLG_STATE_EARLY) { + rt = dlg_event_rt[DLG_EVENTRT_FAILED]; + } + } + if(rt==-1 || event_rt.rlist[rt]==NULL) + return 0; + } else { + if(nstate==DLG_STATE_CONFIRMED_NA) { evname.s = "dialog:start"; evname.len = sizeof("dialog:start") - 1; } else if(nstate==DLG_STATE_DELETED) { if(ostate==DLG_STATE_CONFIRMED || ostate==DLG_STATE_CONFIRMED_NA) { - rt = dlg_event_rt[DLG_EVENTRT_END]; evname.s = "dialog:end"; evname.len = sizeof("dialog:end") - 1; } else if(ostate==DLG_STATE_UNCONFIRMED || ostate==DLG_STATE_EARLY) { evname.s = "dialog:failed"; evname.len = sizeof("dialog:failed") - 1; - rt = dlg_event_rt[DLG_EVENTRT_FAILED]; } } - if(rt==-1 || event_rt.rlist[rt]==NULL) - return 0; - } else { keng = sr_kemi_eng_get(); if(keng==NULL) { LM_DBG("event callback (%s) set, but no cfg engine\n", diff --git a/src/modules/dialog/dlg_profile.c b/src/modules/dialog/dlg_profile.c index e58dbad83d..3576f68036 100644 --- a/src/modules/dialog/dlg_profile.c +++ b/src/modules/dialog/dlg_profile.c @@ -594,8 +594,14 @@ int set_dlg_profile(struct sip_msg *msg, str *value, struct dlg_profile_table *p linker->hash_linker.value.len = value->len; } sruid_next_safe(&_dlg_profile_sruid); - strcpy(linker->hash_linker.puid, _dlg_profile_sruid.uid.s); - linker->hash_linker.puid_len = _dlg_profile_sruid.uid.len; + if(_dlg_profile_sruid.uid.len<SRUID_SIZE) { + strcpy(linker->hash_linker.puid, _dlg_profile_sruid.uid.s); + linker->hash_linker.puid_len = _dlg_profile_sruid.uid.len; + } else { + LM_ERR("sruid size is too large\n"); + shm_free(linker); + goto error; + } if (dlg!=NULL) { /* add linker directly to the dialog and profile */

7 years, 5 months

git:master:609297d6: dialog: safety checks and free of profiles in case of errors

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 609297d62a08d1d75550c2f5e7f7fd19b98fd104 URL: https://github.com/kamailio/kamailio/commit/609297d62a08d1d75550c2f5e7f7fd1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-04T09:59:10+02:00 dialog: safety checks and free of profiles in case of errors - free partial list of profiles in dlg_set_timeout_by_profile() when no more memory --- Modified: src/modules/dialog/dlg_cseq.c Modified: src/modules/dialog/dlg_profile.c Modified: src/modules/dialog/dlg_var.c --- Diff: https://github.com/kamailio/kamailio/commit/609297d62a08d1d75550c2f5e7f7fd1… Patch: https://github.com/kamailio/kamailio/commit/609297d62a08d1d75550c2f5e7f7fd1…

7 years, 5 months

git:master:2ab0adee: tmx: missing break in t_cancel_branches(others)

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 2ab0adee57aa82487adf7d3776835eca071afa27 URL: https://github.com/kamailio/kamailio/commit/2ab0adee57aa82487adf7d3776835ec… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-04T09:08:04+02:00 tmx: missing break in t_cancel_branches(others) --- Modified: src/modules/tmx/tmx_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/2ab0adee57aa82487adf7d3776835ec… Patch: https://github.com/kamailio/kamailio/commit/2ab0adee57aa82487adf7d3776835ec… --- diff --git a/src/modules/tmx/tmx_mod.c b/src/modules/tmx/tmx_mod.c index 19a8962813..9c5f8b1042 100644 --- a/src/modules/tmx/tmx_mod.c +++ b/src/modules/tmx/tmx_mod.c @@ -322,15 +322,18 @@ static int t_cancel_branches(struct sip_msg* msg, char *k, char *s2) init_cancel_info(&cancel_data); switch(n) { case 1: - /* prepare cancel for every branch except idx */ + /* prepare cancel for every branch except idx (others) */ _tmx_tmb.prepare_to_cancel(t, &cancel_data.cancel_bitmap, 1<<idx); + break; case 2: + /* prepare cancel for current branch (idx) */ if(msg->first_line.u.reply.statuscode>=200) break; cancel_data.cancel_bitmap = 1<<idx; break; default: + /* prepare cancel for all branches */ if (msg->first_line.u.reply.statuscode>=200) /* prepare cancel for every branch except idx */ _tmx_tmb.prepare_to_cancel(t,

7 years, 5 months

git:master:6118d832: core: msg translator - reworked error handling to free allocated buffers

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 6118d832d3ba0efb96820915520af3c8a9bf29de URL: https://github.com/kamailio/kamailio/commit/6118d832d3ba0efb96820915520af3c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-04T09:00:45+02:00 core: msg translator - reworked error handling to free allocated buffers --- Modified: src/core/msg_translator.c --- Diff: https://github.com/kamailio/kamailio/commit/6118d832d3ba0efb96820915520af3c… Patch: https://github.com/kamailio/kamailio/commit/6118d832d3ba0efb96820915520af3c… --- diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c index 618a6ba2e7..1a20d0d005 100644 --- a/src/core/msg_translator.c +++ b/src/core/msg_translator.c @@ -2033,7 +2033,10 @@ char * build_req_buf_from_sip_req( struct sip_msg* msg, } if (via_insert_param==0) goto error02; /* free received_buf */ if (insert_new_lump_after(via_insert_param, received_buf, received_len, - HDR_VIA_T) ==0 ) goto error02; /* free received_buf */ + HDR_VIA_T) ==0 ) { + goto error02; /* free received_buf */ + } + received_buf = NULL; } /* if rport needs to be updated, delete it if present and add it's value */ if (rport_len){ @@ -2048,9 +2051,10 @@ char * build_req_buf_from_sip_req( struct sip_msg* msg, } if (via_insert_param==0) goto error03; /* free rport_buf */ if (insert_new_lump_after(via_insert_param, rport_buf, rport_len, - HDR_VIA_T) ==0 ) + HDR_VIA_T) ==0 ) { goto error03; /* free rport_buf */ - + } + rport_buf = NULL; } after_update_via1: @@ -2073,25 +2077,26 @@ char * build_req_buf_from_sip_req( struct sip_msg* msg, (if present & parsed), after the local via or after in front of the first via if we don't add a local via*/ if (msg->route){ - path_anchor=anchor_lump(msg, msg->route->name.s-buf, 0, + path_anchor=anchor_lump(msg, msg->route->name.s-buf, 0, HDR_ROUTE_T); }else if (likely(via_anchor)){ path_anchor=via_anchor; }else if (likely(msg->via1)){ - path_anchor=anchor_lump(msg, msg->via1->hdr.s-buf, 0, + path_anchor=anchor_lump(msg, msg->via1->hdr.s-buf, 0, HDR_ROUTE_T); }else{ /* if no via1 (theoretically possible for non-sip messages, e.g. http xmlrpc) */ - path_anchor=anchor_lump(msg, msg->headers->name.s-buf, 0, + path_anchor=anchor_lump(msg, msg->headers->name.s-buf, 0, HDR_ROUTE_T); } if (unlikely(path_anchor==0)) goto error05; if (unlikely((path_lump=insert_new_lump_after(path_anchor, path_buf.s, - path_buf.len, - HDR_ROUTE_T))==0)) + path_buf.len, HDR_ROUTE_T))==0)) { goto error05; + } + path_buf.s = NULL; } /* compute new msg len and fix overlapping zones*/ new_len=len+body_delta+lumps_len(msg, msg->add_rm, send_info)+via_len; @@ -2100,7 +2105,7 @@ char * build_req_buf_from_sip_req( struct sip_msg* msg, #endif udp_mtu=cfg_get(core, core_cfg, udp_mtu); di.proto=PROTO_NONE; - if (unlikely((send_info->proto==PROTO_UDP) && udp_mtu && + if (unlikely((send_info->proto==PROTO_UDP) && udp_mtu && (flags & FL_MTU_FB_MASK) && (new_len>udp_mtu) && (!(mode&BUILD_NO_LOCAL_VIA)))){ @@ -2127,7 +2132,7 @@ char * build_req_buf_from_sip_req( struct sip_msg* msg, di.proto=PROTO_SCTP; } #endif /* USE_SCTP */ - + if (di.proto!=PROTO_NONE){ new_len-=via_len; if(likely(line_buf)) pkg_free(line_buf); @@ -2144,8 +2149,10 @@ char * build_req_buf_from_sip_req( struct sip_msg* msg, /* add first via, as an anchor for second via*/ if(likely(line_buf)) { if ((via_lump=insert_new_lump_before(via_anchor, line_buf, via_len, - HDR_VIA_T))==0) + HDR_VIA_T))==0) { goto error04; + } + line_buf = 0; } if (msg->new_uri.s){ uri_len=msg->new_uri.len; @@ -2182,7 +2189,7 @@ char * build_req_buf_from_sip_req( struct sip_msg* msg, new_buf[new_len]=0; /* update the send_info if udp_mtu affected */ - if (di.proto!=PROTO_NONE) { + if (di.proto!=PROTO_NONE) { send_info->proto=di.proto; send_info->send_sock=di.send_sock; } @@ -2199,13 +2206,14 @@ char * build_req_buf_from_sip_req( struct sip_msg* msg, error01: error02: - if (received_buf) pkg_free(received_buf); error03: - if (rport_buf) pkg_free(rport_buf); error04: - if (line_buf) pkg_free(line_buf); error05: + if (received_buf) pkg_free(received_buf); + if (rport_buf) pkg_free(rport_buf); if (path_buf.s) pkg_free(path_buf.s); + if (line_buf) pkg_free(line_buf); + error00: *returned_len=0; return 0;

7 years, 5 months

git:master:98a6ef19: core: free locl link structures not linked to listen sockets

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 98a6ef19bcfe14b7150183a9bec98854f5c0063b URL: https://github.com/kamailio/kamailio/commit/98a6ef19bcfe14b7150183a9bec9885… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-04T09:00:45+02:00 core: free locl link structures not linked to listen sockets --- Modified: src/core/socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/98a6ef19bcfe14b7150183a9bec9885… Patch: https://github.com/kamailio/kamailio/commit/98a6ef19bcfe14b7150183a9bec9885… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index 8344c950f2..1544ec4cbd 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -886,8 +886,8 @@ static int nl_bound_sock(void) struct sockaddr_nl la; sock = socket(AF_NETLINK, SOCK_RAW, NETLINK_ROUTE); - if(sock <= 0){ - LM_ERR("could not create NETLINK sock to get interface list"); + if(sock < 0){ + LM_ERR("could not create NETLINK sock to get interface list\n"); goto error; } @@ -1077,7 +1077,7 @@ static int build_iface_list(void) entry->next = 0; entry->family = families[i]; entry->ifa_flags = ifi->ifa_flags; - is_link_local = 0; + is_link_local = 0; for(;RTA_OK(rtap, rtl);rtap=RTA_NEXT(rtap,rtl)){ switch(rtap->rta_type){ @@ -1110,7 +1110,10 @@ static int build_iface_list(void) break; } } - if(is_link_local) continue; /* link local addresses are not bindable */ + if(is_link_local) { + pkg_free(entry); + continue; /* link local addresses are not bindable */ + } if(strlen(ifaces[index].name)==0) strncpy(ifaces[index].name, name, MAX_IF_LEN);

7 years, 5 months

git:master:0aa7571a: core: proxy - free in case of errors making proxy only from ip

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0aa7571afe5c25bfffaf865595181470ac78f4d2 URL: https://github.com/kamailio/kamailio/commit/0aa7571afe5c25bfffaf86559518147… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-04T09:00:45+02:00 core: proxy - free in case of errors making proxy only from ip --- Modified: src/core/proxy.c --- Diff: https://github.com/kamailio/kamailio/commit/0aa7571afe5c25bfffaf86559518147… Patch: https://github.com/kamailio/kamailio/commit/0aa7571afe5c25bfffaf86559518147… --- diff --git a/src/core/proxy.c b/src/core/proxy.c index 78e74da3a6..06e400b0b1 100644 --- a/src/core/proxy.c +++ b/src/core/proxy.c @@ -290,11 +290,15 @@ struct proxy_l* mk_proxy_from_ip(struct ip_addr* ip, unsigned short port, p->host.h_addrtype=ip->af; p->host.h_length=ip->len; p->host.h_addr_list=pkg_malloc(2*sizeof(char*)); - if (p->host.h_addr_list==0) goto error; + if (p->host.h_addr_list==0) { + pkg_free(p); + goto error; + } p->host.h_addr_list[1]=0; p->host.h_addr_list[0]=pkg_malloc(ip->len+1); if (p->host.h_addr_list[0]==0){ pkg_free(p->host.h_addr_list); + pkg_free(p); goto error; }

7 years, 5 months

git:master:1a5662b2: core: parser uri - add missing break to avoid useless assignments

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 1a5662b212ddcbea40ca33e34bfda0459802b756 URL: https://github.com/kamailio/kamailio/commit/1a5662b212ddcbea40ca33e34bfda04… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-04T09:00:45+02:00 core: parser uri - add missing break to avoid useless assignments --- Modified: src/core/parser/parse_uri.c --- Diff: https://github.com/kamailio/kamailio/commit/1a5662b212ddcbea40ca33e34bfda04… Patch: https://github.com/kamailio/kamailio/commit/1a5662b212ddcbea40ca33e34bfda04… --- diff --git a/src/core/parser/parse_uri.c b/src/core/parser/parse_uri.c index 0661ce4bfa..31d67f41f0 100644 --- a/src/core/parser/parse_uri.c +++ b/src/core/parser/parse_uri.c @@ -996,9 +996,11 @@ int parse_uri(char* buf, int len, struct sip_uri* uri) if (scheme==URN_SCH){ uri->host.s=s; uri->host.len=p-s; - DBG("parsed urn scheme...\n"); + DBG("parsed urn scheme with host: %.*s\n", + uri->host.len, uri->host.s); /* this is the port, it can't be the passwd */ }else goto error_bad_port; + break; case URI_HOST_P: case URI_HOST6_END: uri->host.s=s;

7 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2017