sr-dev July 2017

sr-dev@lists.kamailio.org

23 participants
410 discussions

by Cléviton Mendes de Araújo

Hi Folks Let me do one design question about to writing code module when write it. What’s conditions to allow an module exported function may be running from Kamailio route blocks? Why can I running an module function from REQUST_ROUTE and isn’t from REPLY_ROUTE block? What restricts me to run from one block and not another? Best regards CMA

6 years, 11 months

[kamailio/kamailio] Cfg reset function (#1179)

by hdikme

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  kamcmd cfg.reset "group_name", cfg.reset has been created in order to reset all the variables of the referred group to be set to their initial values (default). You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1179 -- Commit Summary -- * cfg_rpc: rpc_reset() function has been created * Merge branch 'master' of https://github.com/kamailio/kamailio into cfg_reset * README file has been re-created. * Merge branch 'master' of https://github.com/kamailio/kamailio into cfg_reset * Compilation problem has been solved * Merge branch 'master' of https://github.com/kamailio/kamailio into cfg_reset -- File Changes -- M src/core/cfg/cfg_ctx.c (68) M src/core/cfg/cfg_ctx.h (3) M src/modules/cfg_rpc/README (118) M src/modules/cfg_rpc/cfg_rpc.c (56) M src/modules/cfg_rpc/doc/rpc.xml (16) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1179.patch https://github.com/kamailio/kamailio/pull/1179.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1179

6 years, 11 months

CDR information is not getting logged, when dialog:end takes too long

by Paul Claudiu Boriga

Hello, We are experiencing an issue when having some blocking code in the dialog:end event route. If the code takes too long to execute then CDR information is not logged. In our case we have a blocking socket trying to establish a connection and waiting 500ms before failing. When it timeouts, the accounting module will never log any CDR logs for that call. It appears that the callbacks for DLGCB_TERMINATED_CONFIRMED event are never called. That is because the function dlg_terminated_confirmed is never called (this function is registered as a callback to the TMCB_RESPONSE_OUT event from tm module). After further investigation, the problem seems to be related to a race condition between two processes when dealing with ending a dialog: From what we saw the dialog:end event route is treated when a BYE request is received. But if that takes too long, and that BYE request will be retransmitted (we are using SIPp to test this, and SIPp will automatically retransmit the message), it will then be treated by a different process. When this happens, the first process has already modified the dialog state, so the second process will not execute code specific to dialog ending from the dialog module dlg_onroute function. It will not execute the event route, nor the DLGCB_TERMINATED event callbacks, and it will neither register the dlg_terminated_confirmed function to the TMCB_RESPONSE_OUT event. This means that the second process will actually finish processing the BYE faster then the first process. By the time the first process finishes with processing the dialog:end event route, the transaction corresponding to the BYE request is already created, and even though dlg_terminated_confirmed function is eventually registered for the TMCB_RESPONSE_OUT event, it is too late because this event was already treated, and all callbacks registered for it were called. This means that DLGCB_TERMINATED_CONFIRMED event will never be treated, and the registered callbacks for this event (including the accounting module functions) will not get called. We managed to work around this behavior by decreasing the timeout of the socket so that the BYE can be processed before a retransmit occurs, but maybe there is a different solution to fix this issue. Do you have any suggestions on how to solve this problem? Thank you, Claudiu Boriga.

6 years, 11 months

git:master:f8fa313f: Merge pull request #1180 from smititelu/master

by GitHub

Module: kamailio Branch: master Commit: f8fa313fd372ffc94fad0c11dba76774c1e3002a URL: https://github.com/kamailio/kamailio/commit/f8fa313fd372ffc94fad0c11dba7677… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2017-07-04T12:33:11+02:00 Merge pull request #1180 from smititelu/master dispatcher: Increase line buffer size --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/f8fa313fd372ffc94fad0c11dba7677… Patch: https://github.com/kamailio/kamailio/commit/f8fa313fd372ffc94fad0c11dba7677… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 155be57ca5..bea737f4bc 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -623,7 +623,7 @@ int reindex_dests(ds_set_t *node) /*! \brief load groups of destinations from file */ int ds_load_list(char *lfile) { - char line[256], *p; + char line[1024], *p; FILE *f = NULL; int id, setn, flags, priority; str uri; @@ -650,7 +650,7 @@ int ds_load_list(char *lfile) *next_idx = (*crt_idx + 1) % 2; ds_avl_destroy(&ds_lists[*next_idx]); - p = fgets(line, 256, f); + p = fgets(line, 1024, f); while(p) { /* eat all white spaces */ while(*p && (*p == ' ' || *p == '\t' || *p == '\r' || *p == '\n')) @@ -728,7 +728,7 @@ int ds_load_list(char *lfile) LM_WARN("unable to add destination %.*s to set %d -- skipping\n", uri.len, uri.s, id); next_line: - p = fgets(line, 256, f); + p = fgets(line, 1024, f); } if(reindex_dests(ds_lists[*next_idx]) != 0) {

6 years, 11 months

git:master:1391db0f: dispatcher: Increase line buffer size

by Stefan Mititelu

Module: kamailio Branch: master Commit: 1391db0f349956795b8cf6936657fb974ec9b65f URL: https://github.com/kamailio/kamailio/commit/1391db0f349956795b8cf6936657fb9… Author: Stefan Mititelu <stefan.mititelu(a)onem.com> Committer: Stefan Mititelu <stefan.mititelu(a)onem.com> Date: 2017-07-04T13:06:26+03:00 dispatcher: Increase line buffer size --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/1391db0f349956795b8cf6936657fb9… Patch: https://github.com/kamailio/kamailio/commit/1391db0f349956795b8cf6936657fb9… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 38a6213de1..b970c94b44 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -623,7 +623,7 @@ int reindex_dests(ds_set_t *node) /*! \brief load groups of destinations from file */ int ds_load_list(char *lfile) { - char line[256], *p; + char line[1024], *p; FILE *f = NULL; int id, setn, flags, priority; str uri; @@ -650,7 +650,7 @@ int ds_load_list(char *lfile) *next_idx = (*crt_idx + 1) % 2; ds_avl_destroy(&ds_lists[*next_idx]); - p = fgets(line, 256, f); + p = fgets(line, 1024, f); while(p) { /* eat all white spaces */ while(*p && (*p == ' ' || *p == '\t' || *p == '\r' || *p == '\n')) @@ -728,7 +728,7 @@ int ds_load_list(char *lfile) LM_WARN("unable to add destination %.*s to set %d -- skipping\n", uri.len, uri.s, id); next_line: - p = fgets(line, 256, f); + p = fgets(line, 1024, f); } if(reindex_dests(ds_lists[*next_idx]) != 0) {

6 years, 11 months

[kamailio/kamailio] dispatcher: Increase line buffer size (#1180)

by Stefan Mititelu

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Depending on how many custom attributes one has set in the dispatcher file, some of them might be ignored due to the 256 read line buffer size. Increase the line buffer size. Probably adding a modparam for that would be a better approach ?! but I want to avoid any dynamic alloc/free(for now). You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1180 -- Commit Summary -- * dispatcher: Increase line buffer size -- File Changes -- M src/modules/dispatcher/dispatch.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1180.patch https://github.com/kamailio/kamailio/pull/1180.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1180

6 years, 11 months

git:master:ceaafc67: rls: reset vars to avoid double free in case of error

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ceaafc67dae4f7e7424c8706ccea90c30eed45b6 URL: https://github.com/kamailio/kamailio/commit/ceaafc67dae4f7e7424c8706ccea90c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-04T12:29:08+02:00 rls: reset vars to avoid double free in case of error --- Modified: src/modules/rls/rls_db.c --- Diff: https://github.com/kamailio/kamailio/commit/ceaafc67dae4f7e7424c8706ccea90c… Patch: https://github.com/kamailio/kamailio/commit/ceaafc67dae4f7e7424c8706ccea90c… --- diff --git a/src/modules/rls/rls_db.c b/src/modules/rls/rls_db.c index f7c03efcb8..35618675c2 100644 --- a/src/modules/rls/rls_db.c +++ b/src/modules/rls/rls_db.c @@ -228,9 +228,11 @@ int delete_expired_subs_rlsdb( void ) } pkg_free(rlsubs_did.s); + rlsubs_did.s = NULL; } rls_dbf.free_result(rls_db, result); + result = NULL; if (rls_dbf.end_transaction) {

6 years, 11 months

git:master:97ac3b91: presence: reset vars to avoid double free in case of error

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 97ac3b910dc955058fa4c08ad22ac01a4f31fe74 URL: https://github.com/kamailio/kamailio/commit/97ac3b910dc955058fa4c08ad22ac01… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-04T12:26:41+02:00 presence: reset vars to avoid double free in case of error --- Modified: src/modules/presence/presentity.c --- Diff: https://github.com/kamailio/kamailio/commit/97ac3b910dc955058fa4c08ad22ac01… Patch: https://github.com/kamailio/kamailio/commit/97ac3b910dc955058fa4c08ad22ac01… --- diff --git a/src/modules/presence/presentity.c b/src/modules/presence/presentity.c index 9755c4f0e9..e3246e2133 100644 --- a/src/modules/presence/presentity.c +++ b/src/modules/presence/presentity.c @@ -1148,9 +1148,12 @@ int update_presentity(struct sip_msg* msg, presentity_t* presentity, str* body, if(rules_doc->s) pkg_free(rules_doc->s); pkg_free(rules_doc); + rules_doc = NULL; } - if(pres_uri.s) + if(pres_uri.s) { pkg_free(pres_uri.s); + pres_uri.s = NULL; + } if (pa_dbf.end_transaction) { @@ -1189,7 +1192,6 @@ int update_presentity(struct sip_msg* msg, presentity_t* presentity, str* body, } if(pres_uri.s) { pkg_free(pres_uri.s); - pres_uri.s = NULL; } if (pa_dbf.abort_transaction) {

6 years, 11 months

git:master:9a6182fa: avp: return in case of error in avp select

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 9a6182fa8b535bc19c43e905d6b6a110b0e830d2 URL: https://github.com/kamailio/kamailio/commit/9a6182fa8b535bc19c43e905d6b6a11… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-04T12:17:54+02:00 avp: return in case of error in avp select --- Modified: src/modules/avp/avp.c --- Diff: https://github.com/kamailio/kamailio/commit/9a6182fa8b535bc19c43e905d6b6a11… Patch: https://github.com/kamailio/kamailio/commit/9a6182fa8b535bc19c43e905d6b6a11… --- diff --git a/src/modules/avp/avp.c b/src/modules/avp/avp.c index 40640dfc40..47c775facb 100644 --- a/src/modules/avp/avp.c +++ b/src/modules/avp/avp.c @@ -1596,7 +1596,7 @@ static int select_attr_fixup(str* res, select_t* s, struct sip_msg* msg) if (! msg) { /* fixup call */ str attr_name; - + if (s->params[SEL_PARAM_IDX].type != SEL_PARAM_STR) { ERR("attribute name expected.\n"); return -1; @@ -1619,6 +1619,7 @@ static int select_attr_fixup(str* res, select_t* s, struct sip_msg* msg) if (parse_avp_ident(&attr_name, avp_ident) < 0) { ERR("failed to parse attribute name: `%.*s'.\n", STR_FMT(&attr_name)); pkg_free(avp_ident); + return -1; } s->params[SEL_PARAM_IDX].v.p = avp_ident; s->params[SEL_PARAM_IDX].type = SEL_PARAM_PTR;

6 years, 11 months

git:master:22aa9043: xcap_server: reset server_name variable after free

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 22aa9043f179f4de8e90fc5946a7afb28060b6f6 URL: https://github.com/kamailio/kamailio/commit/22aa9043f179f4de8e90fc5946a7afb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-07-04T12:17:36+02:00 xcap_server: reset server_name variable after free - avoid re-use in the loop --- Modified: src/modules/xcap_server/xcap_server.c --- Diff: https://github.com/kamailio/kamailio/commit/22aa9043f179f4de8e90fc5946a7afb… Patch: https://github.com/kamailio/kamailio/commit/22aa9043f179f4de8e90fc5946a7afb… --- diff --git a/src/modules/xcap_server/xcap_server.c b/src/modules/xcap_server/xcap_server.c index 02b713a745..86f7816dd7 100644 --- a/src/modules/xcap_server/xcap_server.c +++ b/src/modules/xcap_server/xcap_server.c @@ -893,7 +893,7 @@ static int xcaps_get_directory(struct sip_msg *msg, str *user, str *domain, str qvals[n_qcols].nul = 0; qvals[n_qcols].val.str_val = *user; n_qcols++; - + qcols[n_qcols] = &str_domain_col; qvals[n_qcols].type = DB1_STR; qvals[n_qcols].nul = 0; @@ -904,7 +904,7 @@ static int xcaps_get_directory(struct sip_msg *msg, str *user, str *domain, str rcols[doc_uri_col = n_rcols++] = &str_doc_uri_col; rcols[etag_col = n_rcols++] = &str_etag_col; - if (xcaps_dbf.use_table(xcaps_db, &xcaps_db_table) < 0) + if (xcaps_dbf.use_table(xcaps_db, &xcaps_db_table) < 0) { LM_ERR("in use_table-[table]= %.*s\n", xcaps_db_table.len, xcaps_db_table.s); @@ -1015,7 +1015,7 @@ static int xcaps_get_directory(struct sip_msg *msg, str *user, str *domain, str { directory->len += snprintf(directory->s + directory->len, xcaps_buf.len - directory->len, - "%.*s", server_name.len, server_name.s); + "%.*s", server_name.len, server_name.s); } else { @@ -1023,8 +1023,10 @@ static int xcaps_get_directory(struct sip_msg *msg, str *user, str *domain, str server_name.len = ip_addr2sbuf(&msg->rcv.dst_ip, server_name.s, IP6_MAX_STR_SIZE); directory->len += snprintf(directory->s + directory->len, xcaps_buf.len - directory->len, - "%.*s:%d", server_name.len, server_name.s, msg->rcv.dst_port); + "%.*s:%d", server_name.len, server_name.s, msg->rcv.dst_port); pkg_free(server_name.s); + server_name.s = 0; + server_name.len = 0; } }

6 years, 11 months

← Newer
1
...
34
35
36
37
38
39
40
41
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2017