sr-dev November 2017

sr-dev@lists.kamailio.org

26 participants
481 discussions

[kamailio/kamailio] schema: allow null in active_watchers reason (#1345)

by lazedo

some code paths in presence module set the `reason` field to null causing problems updating the database. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1345 -- Commit Summary -- * schema: allow null in active_watchers reason -- File Changes -- M src/lib/srdb1/schema/pr_active_watchers.xml (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1345.patch https://github.com/kamailio/kamailio/pull/1345.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1345

6 years, 5 months

git:master:419275a5: evrexec: new module to execute an event route at startup in a dedicated process

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 419275a588d0f655d98ac80591cbd8756803b8ee URL: https://github.com/kamailio/kamailio/commit/419275a588d0f655d98ac80591cbd87… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-04-12T10:03:33+02:00 evrexec: new module to execute an event route at startup in a dedicated process --- Added: src/modules/evrexec/Makefile Added: src/modules/evrexec/README Added: src/modules/evrexec/doc/Makefile Added: src/modules/evrexec/doc/evrexec.xml Added: src/modules/evrexec/doc/evrexec_admin.xml Added: src/modules/evrexec/evrexec_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/419275a588d0f655d98ac80591cbd87… Patch: https://github.com/kamailio/kamailio/commit/419275a588d0f655d98ac80591cbd87…

6 years, 5 months

[kamailio/kamailio] topos: BYE befor 200 OK creates new connection (#1339)

by sergey-vb

### Description If call has ended with BYE after 180/183 before 200 OK, kamailio tries to create new connection to destination, not to use existing. With firewall enabled and TLS transport this is issue. ### Troubleshooting #### Reproduction Load topos module, register client (asterisk, it shows port 5061 in contact but real query comes from random tcp port) using TLS, make call to it, terminate call with BYE, before answering. #### Log Messages [kamailio-topos.gz](https://github.com/kamailio/kamailio/files/1505189/kamai… #### SIP Traffic [topos-by-befor-ack.tar.gz](https://github.com/kamailio/kamailio/files/15051… ### Additional Information version: kamailio 5.2.0-dev1 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 09:24:06 Nov 27 2017 with gcc 4.8.5 * **Operating System**: Red Hat Enterprise Linux Server 7.3 3.10.0-514.el7.x86_64 #1 SMP Wed Oct 19 11:24:13 EDT 2016 x86_64 x86_64 x86_64 GNU/Linux -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1339

6 years, 5 months

[kamailio/kamailio] tm: make t_run_local_req reentrant (#1348)

by Federico Cabiddu

- avoid crash when local-request event route is triggered inside another one Nested calls to tm:local-routes generate a crash. I've been recently experiencing this with the following scenario: - event_route[tm:local-request] defined - dialog module's send_bye param set to 1 - htable module's enable_dmq param set to 1 When a dialog reaches the timeout, the BYE generated by dialog module triggers the tm:local-request event route. One of the operations done in my scenario is an htable decrement on a table for which dmq replication is enabled. This trigger again the tm event route (because dmq is using tm uac). When the execution of the 2nd route ends the first one is continued, but the sip_msg structure is at this point corrupted because is declared static in t_run_local_req. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1348 -- Commit Summary -- * tm: make t_run_local_req reentrant -- File Changes -- M src/modules/tm/uac.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1348.patch https://github.com/kamailio/kamailio/pull/1348.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1348

6 years, 5 months

Kamailio 5.1 nightly (rc2) crashing - udp_rcv_loop(): print buffer building failed

by George Diamantopoulos

Hello, I've just installed kamailio 5.1 nightly from the debian repo for stretch. I didn't change anything in the configuration compared to 5.0.4 (which I was testing previously), apart from the database structure as found in the wiki for upgrading from 5.0.x. Now kamailio crashes after a while, with the following output in the logs: Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 3(2502) ERROR: <core> [core/udp_server.c:481]: udp_rcv_loop(): print buffer building failed Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 121(2620) CRITICAL: <core> [core/pass_fd.c:277]: receive_fd(): EOF on 26 Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 121(2620) DEBUG: <core> [core/tcp_main.c:3512]: handle_ser_child(): dead child 3, pid 2502 (shutting down?) Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 121(2620) DEBUG: <core> [core/io_wait.h:602]: io_watch_del(): DBG: io_watch_del (0x55ae7132ffc0, 26, -1, 0x0) fd_no=126 called Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 0(2499) ALERT: <core> [main.c:741]: handle_sigs(): child process 2502 exited normally, status=255 Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 0(2499) INFO: <core> [main.c:771]: handle_sigs(): terminating due to SIGCHLD Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 0(2499) DEBUG: <core> [main.c:773]: handle_sigs(): terminating due to SIGCHLD Nov 29 15:47:05 modcom-sbc-dev1 kamailio[2497]: 118(2617) INFO: <core> [main.c:826]: sig_usr(): signal 15 received Let me know if I can somehow help dissect this issue, I don't really know where to start. Thanks. BR, George

6 years, 5 months

[kamailio/kamailio] loose route cannot be completed when kamailio inserts two Record-Route headers (#1215)

by sergey-safarov

### Description When kamailio need to pass call from carrier to customer VoIP PBX in docker container on swarm cluster then it not possible. Network interconnection. In docker environment eth1 NIC of kamailio and VoIP PBX connected to internet via iptables masquerading. eth1 NIC of kamailio and VoIP PBX have random IP address and generally no way to pass message between kamailio and VoIP PBX via eth1 NIC. Also both containers have eth0 NIC in same network with static IP. But network on eth0 NIC not connected to Internet. SIP signaling is passed like eth1-Kamailio-eth0 <-> eth0-VoIP PBX In this network kamailio add/removes two Record-Route. For ACK message with two `Route` headers this rule does not work. Each `Route` headers for same kamailio instance and must be translated by one loose_route call ``` The proxy will inspect the URI in the topmost Route header field value. If it indicates this proxy, the proxy removes it from the Route header field (this route node has been reached). ``` Really `Route` headers translated separately and second `loose_route` cannot be completed. Details in `details.txt` [details.txt](https://github.com/kamailio/kamailio/files/1220872/details.txt) Wireshark pcap file and kamailio log with enabled debug attached of similar calls is attached. [full-call.zip](https://github.com/kamailio/kamailio/files/1220875/full-call… #### Reproduction Create config when kamailio add two `Record-Route` headers and send ACK with two `Route` headers -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1215

6 years, 5 months

[kamailio/kamailio] mtree: fix handling of character values >= 0x80 (#1343)

by Timo Teräs

#### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [X ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description This fixes mtree to be able to contain strings with character values larger than 0x80. Previously this would not work because the str.s[i] is 'char' and when cast to 'unsigned int' it would be first sign extended for maximum range (on systems where 'char' defaults to signed). E.g. on x86_64 system: (unsigned int)(char)0x80 = 4294967168 The >=MT_CHAR_TABLE_SIZE test would filter any string containing these characters out as invalid. Code is fixed to cast _mt_char_table index to 'unsigned char' always so index is within range always. The new redundant checks against MT_CHAR_TABLE_SIZE are removed, and the result is stored to local variable (and used from it) to improve code readability. The error message in mt_add_to_tree() is harmonized with the other messages to show the full string with a problem. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1343 -- Commit Summary -- * mtree: fix handling of character values >= 0x80 -- File Changes -- M src/modules/mtree/mtree.c (132) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1343.patch https://github.com/kamailio/kamailio/pull/1343.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1343

6 years, 5 months

git:master:ae18e409: mtree: use cast to unsigned char for accessing _mt_char_table array

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ae18e409d71d2d4eccb4604bb6f29a121309b54e URL: https://github.com/kamailio/kamailio/commit/ae18e409d71d2d4eccb4604bb6f29a1… Author: Timo Teras <timo.teras(a)iki.fi> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-11-29T19:58:45+01:00 mtree: use cast to unsigned char for accessing _mt_char_table array - switched the index from unsigned int to unsigned char - simplifies the code by avoiding the tests for exceeding the size of the array - error message extended to print the full string - slightly modified version of PR #1343 --- Modified: src/modules/mtree/mtree.c --- Diff: https://github.com/kamailio/kamailio/commit/ae18e409d71d2d4eccb4604bb6f29a1… Patch: https://github.com/kamailio/kamailio/commit/ae18e409d71d2d4eccb4604bb6f29a1…

6 years, 5 months

git:5.0:5f26a4e8: evapi: enable tcp keepalive on client connections

by Victor Seva

Module: kamailio Branch: 5.0 Commit: 5f26a4e8c55cdf5a5a7eaf6864c4f5213d321293 URL: https://github.com/kamailio/kamailio/commit/5f26a4e8c55cdf5a5a7eaf6864c4f52… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-11-29T13:53:10+01:00 evapi: enable tcp keepalive on client connections (cherry picked from commit d340582267174ccb0a5d816049c582fe75d2177b) --- Modified: src/modules/evapi/evapi_dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/5f26a4e8c55cdf5a5a7eaf6864c4f52… Patch: https://github.com/kamailio/kamailio/commit/5f26a4e8c55cdf5a5a7eaf6864c4f52… --- diff --git a/src/modules/evapi/evapi_dispatch.c b/src/modules/evapi/evapi_dispatch.c index 3aa5288c7f..9fcde59f39 100644 --- a/src/modules/evapi/evapi_dispatch.c +++ b/src/modules/evapi/evapi_dispatch.c @@ -450,6 +450,8 @@ void evapi_accept_client(struct ev_loop *loop, struct ev_io *watcher, int revent struct ev_io *evapi_client; int i; evapi_env_t evenv; + int optval; + socklen_t optlen; evapi_client = (struct ev_io*) malloc (sizeof(struct ev_io)); if(evapi_client==NULL) { @@ -496,6 +498,12 @@ void evapi_accept_client(struct ev_loop *loop, struct ev_io *watcher, int revent return; } } + optval = 1; + optlen = sizeof(optval); + if(setsockopt(csock, SOL_SOCKET, SO_KEEPALIVE, + &optval, optlen) < 0) { + LM_WARN("failed to enable keepalive on socket %d\n", csock); + } _evapi_clients[i].connected = 1; _evapi_clients[i].sock = csock; _evapi_clients[i].af = caddr.sa_family;

6 years, 5 months

git:5.0:c7dc3f9d: evapi: do close() on client socket if libev detects it is gone

by Victor Seva

Module: kamailio Branch: 5.0 Commit: c7dc3f9dbd691323bb65c549c6578adfb03392c6 URL: https://github.com/kamailio/kamailio/commit/c7dc3f9dbd691323bb65c549c6578ad… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-11-29T13:53:10+01:00 evapi: do close() on client socket if libev detects it is gone - handle socket values for valid range >=0 (cherry picked from commit bb91d6c4fa88324c31d3b7a91687057e0ae8bfa0) --- Modified: src/modules/evapi/evapi_dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/c7dc3f9dbd691323bb65c549c6578ad… Patch: https://github.com/kamailio/kamailio/commit/c7dc3f9dbd691323bb65c549c6578ad… --- diff --git a/src/modules/evapi/evapi_dispatch.c b/src/modules/evapi/evapi_dispatch.c index 47fc6a0052..3aa5288c7f 100644 --- a/src/modules/evapi/evapi_dispatch.c +++ b/src/modules/evapi/evapi_dispatch.c @@ -154,10 +154,10 @@ int evapi_close_connection(int cidx) if(cidx<0 || cidx>=EVAPI_MAX_CLIENTS) return -1; if(_evapi_clients[cidx].connected==1 - && _evapi_clients[cidx].sock > 0) { + && _evapi_clients[cidx].sock >= 0) { close(_evapi_clients[cidx].sock); _evapi_clients[cidx].connected = 0; - _evapi_clients[cidx].sock = 0; + _evapi_clients[cidx].sock = -1; return 0; } return -2; @@ -196,7 +196,7 @@ int evapi_set_tag(sip_msg_t* msg, str* stag) return -1; if(!(_evapi_clients[evenv->conidx].connected==1 - && _evapi_clients[evenv->conidx].sock > 0)) { + && _evapi_clients[evenv->conidx].sock >= 0)) { LM_ERR("connection not established\n"); return -1; } @@ -221,7 +221,8 @@ int evapi_init_notify_sockets(void) LM_ERR("opening notify stream socket pair\n"); return -1; } - LM_DBG("inter-process event notification sockets initialized\n"); + LM_DBG("inter-process event notification sockets initialized: %d ~ %d\n", + _evapi_notify_sockets[0], _evapi_notify_sockets[1]); return 0; } @@ -256,7 +257,7 @@ int evapi_dispatch_notify(evapi_msg_t *emsg) n = 0; for(i=0; i<EVAPI_MAX_CLIENTS; i++) { - if(_evapi_clients[i].connected==1 && _evapi_clients[i].sock>0) { + if(_evapi_clients[i].connected==1 && _evapi_clients[i].sock>=0) { if(emsg->tag.s==NULL || (emsg->tag.len = _evapi_clients[i].stag.len && strncmp(_evapi_clients[i].stag.s, emsg->tag.s, emsg->tag.len)==0)) { @@ -329,7 +330,10 @@ void evapi_recv_client(struct ev_loop *loop, struct ev_io *watcher, int revents) evenv.conidx = i; evapi_run_cfg_route(&evenv, _evapi_rts.con_closed); _evapi_clients[i].connected = 0; - _evapi_clients[i].sock = 0; + if(_evapi_clients[i].sock>=0) { + close(_evapi_clients[i].sock); + } + _evapi_clients[i].sock = -1; _evapi_clients[i].rpos = 0; ev_io_stop(loop, watcher); free(watcher); @@ -565,11 +569,14 @@ int evapi_run_dispatcher(char *laddr, int lport) struct ev_io io_notify; int yes_true = 1; int fflags = 0; + int i; LM_DBG("starting dispatcher processing\n"); memset(_evapi_clients, 0, sizeof(evapi_client_t) * EVAPI_MAX_CLIENTS); - + for(i=0; i<EVAPI_MAX_CLIENTS; i++) { + _evapi_clients[i].sock = -1; + } loop = ev_default_loop(0); if(loop==NULL) { @@ -843,7 +850,7 @@ int pv_get_evapi(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) return pv_get_null(msg, param, res); if(_evapi_clients[evenv->conidx].connected==0 - && _evapi_clients[evenv->conidx].sock <= 0) + && _evapi_clients[evenv->conidx].sock < 0) return pv_get_null(msg, param, res); switch(param->pvn.u.isname.name.n)

6 years, 5 months

← Newer
1
...
6
7
8
9
10
11
12
...
49
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2017