sr-dev July 2016

sr-dev@lists.kamailio.org

29 participants
297 discussions

git:master:a52ee4f0: ims_charging: Fix sequence of Ro Request-Number AVP
by Marco Sinibaldi 25 Jul '16

25 Jul '16

Module: kamailio Branch: master Commit: a52ee4f0ff8eefbe9d89f168db98f18361e48958 URL: https://github.com/kamailio/kamailio/commit/a52ee4f0ff8eefbe9d89f168db98f18… Author: Marco Sinibaldi <marco.sinibaldi(a)athonet.com> Committer: Marco Sinibaldi <marco.sinibaldi(a)athonet.com> Date: 2016-07-21T17:03:26+02:00 ims_charging: Fix sequence of Ro Request-Number AVP --- Modified: modules/ims_charging/ro_session_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/a52ee4f0ff8eefbe9d89f168db98f18… Patch: https://github.com/kamailio/kamailio/commit/a52ee4f0ff8eefbe9d89f168db98f18… --- diff --git a/modules/ims_charging/ro_session_hash.c b/modules/ims_charging/ro_session_hash.c index d63697d..3967b0c 100644 --- a/modules/ims_charging/ro_session_hash.c +++ b/modules/ims_charging/ro_session_hash.c @@ -220,7 +220,7 @@ struct ro_session* build_new_ro_session(int direction, int auth_appid, int auth_ new_ro_session->reserved_secs = requested_secs; new_ro_session->valid_for = validity_timeout; - new_ro_session->hop_by_hop = 1; + new_ro_session->hop_by_hop = 0; new_ro_session->next = 0; new_ro_session->dlg_h_entry = dlg_h_entry; new_ro_session->dlg_h_id = dlg_h_id;

1 0

git:master:1dc12d8f: ims_charging: Fix double free upon Ro AAA send failure
by Marco Sinibaldi 25 Jul '16

25 Jul '16

Module: kamailio Branch: master Commit: 1dc12d8f83c9f5f9851dfdbe57fe64a38fc9911e URL: https://github.com/kamailio/kamailio/commit/1dc12d8f83c9f5f9851dfdbe57fe64a… Author: Marco Sinibaldi <marco.sinibaldi(a)athonet.com> Committer: Marco Sinibaldi <marco.sinibaldi(a)athonet.com> Date: 2016-07-21T14:55:52+02:00 ims_charging: Fix double free upon Ro AAA send failure --- Modified: modules/ims_charging/ims_ro.c --- Diff: https://github.com/kamailio/kamailio/commit/1dc12d8f83c9f5f9851dfdbe57fe64a… Patch: https://github.com/kamailio/kamailio/commit/1dc12d8f83c9f5f9851dfdbe57fe64a… --- diff --git a/modules/ims_charging/ims_ro.c b/modules/ims_charging/ims_ro.c index df56bad..c0c586f 100644 --- a/modules/ims_charging/ims_ro.c +++ b/modules/ims_charging/ims_ro.c @@ -638,6 +638,7 @@ void send_ccr_interim(struct ro_session* ro_session, unsigned int used, unsigned } if (ret != 1) { + ccr = 0; // If an error is returned from cdp AAASendMessage, the message has been freed there goto error; } // cdpb.AAASessionsUnlock(auth->hash);

1 0

git:master:54cb0e7e: ims_charging: Do not close dialog upon Ro credit control timeout before answer
by Marco Sinibaldi 25 Jul '16

25 Jul '16

Module: kamailio Branch: master Commit: 54cb0e7e7821e4158b105419e79e030eec6453f7 URL: https://github.com/kamailio/kamailio/commit/54cb0e7e7821e4158b105419e79e030… Author: Marco Sinibaldi <marco.sinibaldi(a)athonet.com> Committer: Marco Sinibaldi <marco.sinibaldi(a)athonet.com> Date: 2016-07-21T14:49:26+02:00 ims_charging: Do not close dialog upon Ro credit control timeout before answer --- Modified: modules/ims_charging/ro_timer.c --- Diff: https://github.com/kamailio/kamailio/commit/54cb0e7e7821e4158b105419e79e030… Patch: https://github.com/kamailio/kamailio/commit/54cb0e7e7821e4158b105419e79e030… --- diff --git a/modules/ims_charging/ro_timer.c b/modules/ims_charging/ro_timer.c index 3f6c8dd..57bf55c 100644 --- a/modules/ims_charging/ro_timer.c +++ b/modules/ims_charging/ro_timer.c @@ -473,6 +473,9 @@ void ro_session_ontimeout(struct ro_tl *tl) { case delayed_delete: destroy_ro_session(ro_session); return; + case pending: + /* call is not answered yet. No point asking more credit. Just wait for dialog to progress somehow */ + return; default: LM_ERR("Diameter call session - event [%d]\n", ro_session->event_type);

1 0

git:master:f087a82f: ims_charging: Ignore Ro Validity-Time AVP if 0 or missing.
by Marco Sinibaldi 25 Jul '16

25 Jul '16

Module: kamailio Branch: master Commit: f087a82fd54f337c8ba746fb8919561c9a757651 URL: https://github.com/kamailio/kamailio/commit/f087a82fd54f337c8ba746fb8919561… Author: Marco Sinibaldi <marco.sinibaldi(a)athonet.com> Committer: Marco Sinibaldi <marco.sinibaldi(a)athonet.com> Date: 2016-07-21T14:43:22+02:00 ims_charging: Ignore Ro Validity-Time AVP if 0 or missing. --- Modified: modules/ims_charging/ro_timer.c --- Diff: https://github.com/kamailio/kamailio/commit/f087a82fd54f337c8ba746fb8919561… Patch: https://github.com/kamailio/kamailio/commit/f087a82fd54f337c8ba746fb8919561… --- diff --git a/modules/ims_charging/ro_timer.c b/modules/ims_charging/ro_timer.c index ded2a4b..3f6c8dd 100644 --- a/modules/ims_charging/ro_timer.c +++ b/modules/ims_charging/ro_timer.c @@ -280,7 +280,7 @@ void resume_ro_session_ontimeout(struct interim_ccr *i_req, int timeout_or_error used_secs = rint((now - ((timeout_or_error==1 && i_req->ro_session->last_event_timestamp_backup>0)?i_req->ro_session->last_event_timestamp_backup : i_req->ro_session->last_event_timestamp)) / (float) 1000000); /* check to make sure diameter server is giving us sane values */ - if (i_req->new_credit > i_req->credit_valid_for) { + if (i_req->credit_valid_for !=0 && i_req->new_credit > i_req->credit_valid_for) { LM_WARN("That's weird, Diameter server gave us credit with a lower validity period :D. Setting reserved time to validity period instead \n"); i_req->new_credit = i_req->credit_valid_for; }

1 0

git:master:d3c1ea0b: ims_charging: move Expires AVP inside Event-Type AVP, according to TS 32.299
by Marco Sinibaldi 25 Jul '16

25 Jul '16

Module: kamailio Branch: master Commit: d3c1ea0bd2aea71d2e7f124816a93aea2f818cd9 URL: https://github.com/kamailio/kamailio/commit/d3c1ea0bd2aea71d2e7f124816a93ae… Author: Marco Sinibaldi <marco.sinibaldi(a)athonet.com> Committer: Marco Sinibaldi <marco.sinibaldi(a)athonet.com> Date: 2016-07-21T14:38:39+02:00 ims_charging: move Expires AVP inside Event-Type AVP, according to TS 32.299 --- Modified: modules/ims_charging/ccr.c --- Diff: https://github.com/kamailio/kamailio/commit/d3c1ea0bd2aea71d2e7f124816a93ae… Patch: https://github.com/kamailio/kamailio/commit/d3c1ea0bd2aea71d2e7f124816a93ae… --- diff --git a/modules/ims_charging/ccr.c b/modules/ims_charging/ccr.c index a2fa489..82e5ae8 100644 --- a/modules/ims_charging/ccr.c +++ b/modules/ims_charging/ccr.c @@ -21,7 +21,7 @@ int Ro_write_event_type_avps(AAA_AVP_LIST * avp_list, event_type_t * x) { goto error; if (x->expires) - if (!cdp_avp->epcapp.add_Expires(avp_list, *(x->expires))) + if (!cdp_avp->epcapp.add_Expires(&aList, *(x->expires))) goto error; if (!cdp_avp->epcapp.add_Event_Type(avp_list, &aList, AVP_FREE_DATA)) //TODO: used to be DONT FREE

1 0

[kamailio/kamailio] ims_charging: fix Ro issues (#722)
by Marco Sinibaldi 25 Jul '16

25 Jul '16

Fixing a set of issues related to IMS Ro interface. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/722 -- Commit Summary -- * ims_charging: move Expires AVP inside Event-Type AVP, according to TS 32.299 * ims_charging: Ignore Ro Validity-Time AVP if 0 or missing. * ims_charging: Do not close dialog upon Ro credit control timeout before answer * ims_charging: Fix double free upon Ro AAA send failure * ims_charging: Fix sequence of Ro Request-Number AVP -- File Changes -- M modules/ims_charging/ccr.c (2) M modules/ims_charging/ims_ro.c (1) M modules/ims_charging/ro_session_hash.c (2) M modules/ims_charging/ro_timer.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/722.patch https://github.com/kamailio/kamailio/pull/722.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/722

2 1

git:master:1562c31c: core: print content when failing to parse rr body
by Daniel-Constantin Mierla 24 Jul '16

24 Jul '16

Module: kamailio Branch: master Commit: 1562c31c799cbaeeb7453e73183950f6818534b6 URL: https://github.com/kamailio/kamailio/commit/1562c31c799cbaeeb7453e73183950f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-07-24T15:19:27+02:00 core: print content when failing to parse rr body --- Modified: parser/parse_rr.c --- Diff: https://github.com/kamailio/kamailio/commit/1562c31c799cbaeeb7453e73183950f… Patch: https://github.com/kamailio/kamailio/commit/1562c31c799cbaeeb7453e73183950f… --- diff --git a/parser/parse_rr.c b/parser/parse_rr.c index e478ebe..4fb32b0 100644 --- a/parser/parse_rr.c +++ b/parser/parse_rr.c @@ -129,6 +129,7 @@ static inline int do_parse_rr_body(char *buf, int len, rr_t **head) error: if (r) free_rr(&r); free_rr(head); /* Free any contacts created so far */ + LM_ERR("Failed parsing rr header body [%.*s]\n", len, ZSW(buf)); return -1; ok:

1 0

git:master:697c285b: core: parse rr - removed function name from logs
by Daniel-Constantin Mierla 24 Jul '16

24 Jul '16

Module: kamailio Branch: master Commit: 697c285be7f52c6586b70fa4188e5f5b94f4e785 URL: https://github.com/kamailio/kamailio/commit/697c285be7f52c6586b70fa4188e5f5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-07-24T08:27:00+02:00 core: parse rr - removed function name from logs - it is added automatically - coherent indentation --- Modified: parser/parse_rr.c --- Diff: https://github.com/kamailio/kamailio/commit/697c285be7f52c6586b70fa4188e5f5… Patch: https://github.com/kamailio/kamailio/commit/697c285be7f52c6586b70fa4188e5f5…

1 0

git:master:89d88412: modules: readme files regenerated - ims_registrar_scscf ...
by Kamailio Dev 22 Jul '16

22 Jul '16

Module: kamailio Branch: master Commit: 89d8841259387cb5a63ece1f1c5e864f93018210 URL: https://github.com/kamailio/kamailio/commit/89d8841259387cb5a63ece1f1c5e864… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2016-07-22T09:01:24+02:00 modules: readme files regenerated - ims_registrar_scscf ... --- Modified: modules/ims_registrar_scscf/README --- Diff: https://github.com/kamailio/kamailio/commit/89d8841259387cb5a63ece1f1c5e864… Patch: https://github.com/kamailio/kamailio/commit/89d8841259387cb5a63ece1f1c5e864… --- diff --git a/modules/ims_registrar_scscf/README b/modules/ims_registrar_scscf/README index 05f0d38..7f3eb9d 100644 --- a/modules/ims_registrar_scscf/README +++ b/modules/ims_registrar_scscf/README @@ -64,7 +64,7 @@ Richard Good 5. RPC Commands - 5.1. ulpcscf.status + 5.1. regscscf.dereg_impu 6. Statistics @@ -156,7 +156,7 @@ Chapter 1. Admin Guide 5. RPC Commands - 5.1. ulpcscf.status + 5.1. regscscf.dereg_impu 6. Statistics @@ -752,13 +752,13 @@ if (can_publish_reg("location")){ 5. RPC Commands - 5.1. ulpcscf.status + 5.1. regscscf.dereg_impu exported RPC commands. -5.1. ulpcscf.status +5.1. regscscf.dereg_impu - Status of pcscf_usrloc, AORs, max slots, etc. + Initiate network de-register of IMPU 6. Statistics

1 0

git:master:70a8652f: modules/ims_registrar_scscf: new RPC command regscscf.dereg_impu to initiate network de-register
by Richard Good 22 Jul '16

22 Jul '16

Module: kamailio Branch: master Commit: 70a8652f3a6b11718ee1a21a0dad1503d3af1902 URL: https://github.com/kamailio/kamailio/commit/70a8652f3a6b11718ee1a21a0dad150… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: 2016-07-22T08:49:13+02:00 modules/ims_registrar_scscf: new RPC command regscscf.dereg_impu to initiate network de-register --- Added: modules/ims_registrar_scscf/reg_rpc.c Added: modules/ims_registrar_scscf/reg_rpc.h Modified: modules/ims_registrar_scscf/doc/ims_registrar_scscf_admin.xml Modified: modules/ims_registrar_scscf/reg_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/70a8652f3a6b11718ee1a21a0dad150… Patch: https://github.com/kamailio/kamailio/commit/70a8652f3a6b11718ee1a21a0dad150…

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2016