sr-dev July 2016

sr-dev@lists.kamailio.org

29 participants
298 discussions

unused var
by Juha Heinanen 18 Jul '16

18 Jul '16

latest master gives this: CC (gcc) [M dialplan.so] dialplan.o dialplan.c: In function 'dp_reload_f': dialplan.c:460:18: warning: unused variable 'rpl_tree' [-Wunused-variable] struct mi_root* rpl_tree= NULL; ^ -- juha

1 0

[kamailio/kamailio] SIP to SIP call not working (#712)
by Gaurav Bmotra 15 Jul '16

15 Jul '16

i have just install fresh kamailio 4.3.4 , after create two extention 100 and 200 , both the extention Registered successfully but unable to make call .. when i dial from 100 to 200 it seem like call going to 200 but the other side no notification ... plz help.. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/712

2 3

git:master:be527b19: modules/ims_registrar_scscf: fix memory leak related to S-CSCF notification engine
by jaybeepee 14 Jul '16

14 Jul '16

Module: kamailio Branch: master Commit: be527b19062389d2621a1e01b1b17e4aa8e80f1a URL: https://github.com/kamailio/kamailio/commit/be527b19062389d2621a1e01b1b17e4… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-07-14T15:58:11+02:00 modules/ims_registrar_scscf: fix memory leak related to S-CSCF notification engine --- Modified: modules/ims_registrar_scscf/registrar_notify.c --- Diff: https://github.com/kamailio/kamailio/commit/be527b19062389d2621a1e01b1b17e4… Patch: https://github.com/kamailio/kamailio/commit/be527b19062389d2621a1e01b1b17e4… --- diff --git a/modules/ims_registrar_scscf/registrar_notify.c b/modules/ims_registrar_scscf/registrar_notify.c index 9e41593..ff2db72 100644 --- a/modules/ims_registrar_scscf/registrar_notify.c +++ b/modules/ims_registrar_scscf/registrar_notify.c @@ -440,7 +440,7 @@ int can_subscribe_to_reg(struct sip_msg *msg, char *_t, char *str2) { int event_reg(udomain_t* _d, impurecord_t* r_passed, int event_type, str *presentity_uri, str *watcher_contact, str *explit_dereg_contact, int num_explit_dereg_contact) { impurecord_t* r; int num_impus; - str* impu_list; + str* impu_list = 0; int res = 0; udomain_t* udomain; @@ -483,7 +483,10 @@ int event_reg(udomain_t* _d, impurecord_t* r_passed, int event_type, str *presen LM_DBG("About to ceate notification"); create_notifications(_d, r_passed, presentity_uri, watcher_contact, impu_list, num_impus, event_type, explit_dereg_contact, num_explit_dereg_contact); - return 0; + if (impu_list) { + pkg_free(impu_list); + } + return 0; break; //richard: we only use reg unreg expired and refresh @@ -510,12 +513,18 @@ int event_reg(udomain_t* _d, impurecord_t* r_passed, int event_type, str *presen //TODO this should be a configurable module param if (ul.register_udomain(domain, &udomain) < 0) { LM_ERR("Unable to register usrloc domain....aborting\n"); - return 0; + if (impu_list) { + pkg_free(impu_list); + } + return 0; } LM_DBG("About to ceate notification"); create_notifications(_d, r_passed, presentity_uri, watcher_contact, impu_list, num_impus, event_type, explit_dereg_contact, num_explit_dereg_contact); - return 1; + if (impu_list) { + pkg_free(impu_list); + } + return 1; default: LM_ERR("ERR:event_reg: Unknown event %d\n", event_type);

1 0

git:master:b2fb56fe: modules/ims_usrloc_scscf: correctly read and reference subscription when reading from DB
by jaybeepee 14 Jul '16

14 Jul '16

Module: kamailio Branch: master Commit: b2fb56fe0e1c8cd8fb3fc6315df90daaa69b7087 URL: https://github.com/kamailio/kamailio/commit/b2fb56fe0e1c8cd8fb3fc6315df90da… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-07-14T15:56:31+02:00 modules/ims_usrloc_scscf: correctly read and reference subscription when reading from DB --- Modified: modules/ims_usrloc_scscf/bin_utils.c Modified: modules/ims_usrloc_scscf/impurecord.h Modified: modules/ims_usrloc_scscf/usrloc_db.c --- Diff: https://github.com/kamailio/kamailio/commit/b2fb56fe0e1c8cd8fb3fc6315df90da… Patch: https://github.com/kamailio/kamailio/commit/b2fb56fe0e1c8cd8fb3fc6315df90da…

1 0

git:master:b4d2be7a: modules/ims_usrloc_scscf: remove old incorrect comment
by jaybeepee 14 Jul '16

14 Jul '16

Module: kamailio Branch: master Commit: b4d2be7a817507a1e44b6d18bd5c5cdc27ba8b2f URL: https://github.com/kamailio/kamailio/commit/b4d2be7a817507a1e44b6d18bd5c5cd… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-07-14T15:56:31+02:00 modules/ims_usrloc_scscf: remove old incorrect comment --- Modified: modules/ims_usrloc_scscf/impurecord.c --- Diff: https://github.com/kamailio/kamailio/commit/b4d2be7a817507a1e44b6d18bd5c5cd… Patch: https://github.com/kamailio/kamailio/commit/b4d2be7a817507a1e44b6d18bd5c5cd… --- diff --git a/modules/ims_usrloc_scscf/impurecord.c b/modules/ims_usrloc_scscf/impurecord.c index ceee7e5..cf41149 100644 --- a/modules/ims_usrloc_scscf/impurecord.c +++ b/modules/ims_usrloc_scscf/impurecord.c @@ -851,7 +851,6 @@ void free_ims_subscription_data(ims_subscription *s) { } -/* Still needs to be implemented */ int compare_subscription(ims_subscription* new, ims_subscription* orig) { int i, j, k, l; LM_DBG("Comparing subscription for IMPI [%.*s]\n", orig->private_identity.len, orig->private_identity.s);

1 0

git:master:4396c5fb: cdp: fix occasional segfault on process exit
by Dragos Oancea 14 Jul '16

14 Jul '16

Module: kamailio Branch: master Commit: 4396c5fbc85848c69b3318397a7ed8b67d76a05f URL: https://github.com/kamailio/kamailio/commit/4396c5fbc85848c69b3318397a7ed8b… Author: Dragos Oancea <dragos.oancea(a)athonet.com> Committer: Dragos Oancea <dragos.oancea(a)athonet.com> Date: 2016-07-14T14:20:26+02:00 cdp: fix occasional segfault on process exit --- Modified: modules/cdp/diameter_peer.c --- Diff: https://github.com/kamailio/kamailio/commit/4396c5fbc85848c69b3318397a7ed8b… Patch: https://github.com/kamailio/kamailio/commit/4396c5fbc85848c69b3318397a7ed8b… --- diff --git a/modules/cdp/diameter_peer.c b/modules/cdp/diameter_peer.c index dd571b2..cd0b85e 100644 --- a/modules/cdp/diameter_peer.c +++ b/modules/cdp/diameter_peer.c @@ -411,6 +411,9 @@ void diameter_peer_destroy() int pid,status; handler *h; + if (!shutdownx_lock) { + return; + } lock_get(shutdownx_lock); if (*shutdownx) { /* already other process is cleaning stuff */

1 0

git:master:380e84d9: Merge pull request #710 from athonet-open/fix_cdp_cleanup
by GitHub 14 Jul '16

14 Jul '16

Module: kamailio Branch: master Commit: 380e84d93986496f0c3ac78b11df9c889a099c94 URL: https://github.com/kamailio/kamailio/commit/380e84d93986496f0c3ac78b11df9c8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2016-07-14T14:47:57+02:00 Merge pull request #710 from athonet-open/fix_cdp_cleanup cdp: fix occasional segfault on process exit --- Modified: modules/cdp/diameter_peer.c --- Diff: https://github.com/kamailio/kamailio/commit/380e84d93986496f0c3ac78b11df9c8… Patch: https://github.com/kamailio/kamailio/commit/380e84d93986496f0c3ac78b11df9c8… --- diff --git a/modules/cdp/diameter_peer.c b/modules/cdp/diameter_peer.c index dd571b2..cd0b85e 100644 --- a/modules/cdp/diameter_peer.c +++ b/modules/cdp/diameter_peer.c @@ -411,6 +411,9 @@ void diameter_peer_destroy() int pid,status; handler *h; + if (!shutdownx_lock) { + return; + } lock_get(shutdownx_lock); if (*shutdownx) { /* already other process is cleaning stuff */

1 0

[kamailio/kamailio] cdp: fix occasional segfault on process exit (#710)
by Dragos Oancea 14 Jul '16

14 Jul '16

this may happen at kamailio shutdown : Program terminated with signal 11, Segmentation fault. #0 0x00007fb66a73e591 in atomic_cmpxchg_int (var=0x0, old=0, new_v=1) at ../../mem/../atomic/atomic_x86.h:233 233 ATOMIC_FUNC_CMPXCHG(cmpxchg, "cmpxchgl %2, %1", int , int) (gdb) bt #0 0x00007fb66a73e591 in atomic_cmpxchg_int (var=0x0, old=0, new_v=1) at ../../mem/../atomic/atomic_x86.h:233 #1 0x00007fb66a73e5e0 in futex_get (lock=0x0) at ../../mem/../futexlock.h:99 #2 0x00007fb66a743183 in diameter_peer_destroy () at diameter_peer.c:416 #3 0x00007fb66a745272 in cdp_exit () at mod.c:244 #4 0x000000000059bf98 in destroy_modules () at sr_module.c:817 #5 0x00000000004a113a in cleanup (show_status=0) at main.c:513 #6 0x00000000004a272e in shutdown_children (sig=15, show_status=0) at main.c:655 #7 0x00000000004b255d in main (argc=12, argv=0x7ffcdbd4bac8) at main.c:2568 (gdb) bt full #0 0x00007fb66a73e591 in atomic_cmpxchg_int (var=0x0, old=0, new_v=1) at ../../mem/../atomic/atomic_x86.h:233 ret = 48 #1 0x00007fb66a73e5e0 in futex_get (lock=0x0) at ../../mem/../futexlock.h:99 v = 0 i = 1024 #2 0x00007fb66a743183 in diameter_peer_destroy () at diameter_peer.c:416 pid = 1786325736 status = 32694 h = 0x7fb660289560 __FUNCTION__ = "diameter_peer_destroy" #3 0x00007fb66a745272 in cdp_exit () at mod.c:244 __llevel = 2 __FUNCTION__ = "cdp_exit" #4 0x000000000059bf98 in destroy_modules () at sr_module.c:817 t = 0x7fb66f3a6010 foo = 0x7fb66f3a5d40 __FUNCTION__ = "destroy_modules" #5 0x00000000004a113a in cleanup (show_status=0) at main.c:513 memlog = 32764 __FUNCTION__ = "cleanup" #6 0x00000000004a272e in shutdown_children (sig=15, show_status=0) at main.c:655 __FUNCTION__ = "shutdown_children" #7 0x00000000004b255d in main (argc=12, argv=0x7ffcdbd4bac8) at main.c:2568 cfg_stream = 0x1706010 c = -1 r = 0 tmp = 0x7ffcdbd4bf2f "" tmp_len = 0 port = 0 proto = 0 options = 0x71c738 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:" ret = -1 seed = 1767645291 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x76 p = 0x7ffcdbd4b9ce "" st = {st_dev = 0, st_ino = 0, st_nlink = 0, st_mode = 0, st_uid = 0, st_gid = 0, __pad0 = 0, st_rdev = 0, st_size = 0, st_blksize = 0, st_blocks = 0, st_atim = { tv_sec = 0, tv_nsec = 0}, st_mtim = {tv_sec = 0, tv_nsec = 0}, st_ctim = {tv_sec = 0, tv_nsec = 0}, __unused = {0, 0, 0}} ---Type <return> to continue, or q <return> to quit--- __FUNCTION__ = "main" (gdb) Patch provides a quick fix so that it will not dump core. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/710 -- Commit Summary -- * cdp: fix occasional segfault on process exit -- File Changes -- M modules/cdp/diameter_peer.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/710.patch https://github.com/kamailio/kamailio/pull/710.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/710

2 2

git:master:68ef4774: modules: readme files regenerated - tls ...
by Kamailio Dev 14 Jul '16

14 Jul '16

Module: kamailio Branch: master Commit: 68ef4774e22cccc8801c0c3ea51b201cf01db322 URL: https://github.com/kamailio/kamailio/commit/68ef4774e22cccc8801c0c3ea51b201… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2016-07-14T12:46:23+02:00 modules: readme files regenerated - tls ... --- Modified: modules/tls/README --- Diff: https://github.com/kamailio/kamailio/commit/68ef4774e22cccc8801c0c3ea51b201… Patch: https://github.com/kamailio/kamailio/commit/68ef4774e22cccc8801c0c3ea51b201… --- diff --git a/modules/tls/README b/modules/tls/README index 1e4d2de..dd4cb8c 100644 --- a/modules/tls/README +++ b/modules/tls/README @@ -191,7 +191,11 @@ Chapter 1. Admin Guide This module implements the TLS transport for Kamailio using the OpenSSL library (http://www.openssl.org). To enable the Kamailio TLS support this module must be loaded and enable_tls=yes core setting must be - added to the Kamailio config file + added to the Kamailio config file. + + IMPORTANT: tls module must be loaded before any other Kamailio module + that uses libssl (OpenSSL library). A safe option is to have tls module + loaded first (be in the first "loadmodule" inside Kamailio.cfg). 2. Quick Start

1 0

git:master:7d04380f: tls: added note in docs about loading tls module first
by Daniel-Constantin Mierla 14 Jul '16

14 Jul '16

Module: kamailio Branch: master Commit: 7d04380ff628d6c99f89b220c904b727a1c0f47f URL: https://github.com/kamailio/kamailio/commit/7d04380ff628d6c99f89b220c904b72… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-07-14T12:34:58+02:00 tls: added note in docs about loading tls module first --- Modified: modules/tls/doc/tls.xml --- Diff: https://github.com/kamailio/kamailio/commit/7d04380ff628d6c99f89b220c904b72… Patch: https://github.com/kamailio/kamailio/commit/7d04380ff628d6c99f89b220c904b72… --- diff --git a/modules/tls/doc/tls.xml b/modules/tls/doc/tls.xml index 22046d8..af4ff22 100644 --- a/modules/tls/doc/tls.xml +++ b/modules/tls/doc/tls.xml @@ -2,7 +2,7 @@ <!DOCTYPE section PUBLIC "-//OASIS//DTD DocBook XML V4.2//EN" "http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd" [ <!ENTITY % local.common.attrib - "xmlns:xi CDATA #FIXED 'http://www.w3.org/2001/XInclude'"> + "xmlns:xi CDATA #FIXED 'http://www.w3.org/2001/XInclude'"> <!ENTITY % docentities SYSTEM "../../../docbook/entities.xml"> %docentities; @@ -48,8 +48,13 @@ This module implements the TLS transport for &kamailio; using the <ulink url="http://www.openssl.org">OpenSSL library</ulink> (http://www.openssl.org). To enable the &kamailio; TLS support this - module must be loaded and <emphasis>enable_tls=yes</emphasis> core setting - must be added to the Kamailio config file + module must be loaded and <emphasis>enable_tls=yes</emphasis> core setting + must be added to the Kamailio config file. + </para> + <para> + IMPORTANT: tls module must be loaded before any other &kamailio; module + that uses libssl (OpenSSL library). A safe option is to have tls module + loaded first (be in the first "loadmodule" inside &kamailio;.cfg). </para> </section> <section id="tls.quick_start">

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2016