sr-dev May 2016

sr-dev@lists.kamailio.org

28 participants
348 discussions

[kamailio/kamailio] "flags" and "reg_delay" uacreg columns not read if database lacks DB_CAP_FETCH capability (#640)

by AndyJRobinson

In both 4.4.1 and master, the recently added "flags" and "reg_delay" columns are not read if the database lacks DB_CAP_FETCH capability. uac.reg_dump shows them as some large random values. The issue is in uac_reg.c:uac_reg_load_db(). ` if (DB_CAPABILITY(reg_dbf, DB_CAP_FETCH)) { if(reg_dbf.query(reg_db_con, 0, 0, 0, db_cols, 0, 12, 0, 0) < 0)` ... so if the database has DB_CAP_FETCH capability, 12 columns are read; however, if not... ` } else { if((ret=reg_dbf.query(reg_db_con, NULL, NULL, NULL, db_cols, 0, 10, 0, &db_res))!=0 || RES_ROW_N(db_res)<=0 ) {` only 10 columns are read, missing the last two (flags and reg_delay) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/640

8 years

[kamailio/kamailio] Read all 12 columns from uacreg if the database does not have DB_CAP_… (#642)

by AndyJRobinson

When the database does not have DB_CAP_FETCH capability, only 10 columns are being read from uacreg instead of 12, so the flags and reg_delay columns are being omitted. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/642 -- Commit Summary -- * Read all 12 columns from uacreg if the database does not have DB_CAP_FETCH capability -- File Changes -- M modules/uac/uac_reg.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/642.patch https://github.com/kamailio/kamailio/pull/642.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/642

8 years

git:master:d3abee96: uac: read all 12 columns from uacreg database table

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d3abee96d9ddfa6b0600d9e7f6864bd5786fdebe URL: https://github.com/kamailio/kamailio/commit/d3abee96d9ddfa6b0600d9e7f6864bd… Author: Andrew J Robinson <AndyJRobinson(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-26T16:30:35+02:00 uac: read all 12 columns from uacreg database table - fix when the database connector does not have DB_CAP_FETCH capability - GH #642 --- Modified: modules/uac/uac_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/d3abee96d9ddfa6b0600d9e7f6864bd… Patch: https://github.com/kamailio/kamailio/commit/d3abee96d9ddfa6b0600d9e7f6864bd… --- diff --git a/modules/uac/uac_reg.c b/modules/uac/uac_reg.c index 86b17e9..f8c30ca 100644 --- a/modules/uac/uac_reg.c +++ b/modules/uac/uac_reg.c @@ -1172,7 +1172,7 @@ int uac_reg_load_db(void) } } else { if((ret=reg_dbf.query(reg_db_con, NULL, NULL, NULL, db_cols, - 0, 10, 0, &db_res))!=0 + 0, 12, 0, &db_res))!=0 || RES_ROW_N(db_res)<=0 ) { reg_dbf.free_result(reg_db_con, db_res);

8 years

Errored: kamailio/kamailio#2475 (master - e50e3ba)

by Travis CI

Build Update for kamailio/kamailio ------------------------------------- Build: #2475 Status: Errored Duration: 26 minutes and 15 seconds Commit: e50e3ba (master) Author: Daniel-Constantin Mierla Message: Merge pull request #638 from mslehto/NULL Fix variable initialization and NULL pointer dereference issues View the changeset: https://github.com/kamailio/kamailio/compare/b0047530b004...e50e3badc797 View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/132937215 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

8 years

git:master:c8ac7f99: Merge pull request #639 from AndreasHuber-CH/authinfo_hdr

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: c8ac7f99a31e77e10abcdbccf14c8731fb068bc3 URL: https://github.com/kamailio/kamailio/commit/c8ac7f99a31e77e10abcdbccf14c873… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-25T21:42:14+02:00 Merge pull request #639 from AndreasHuber-CH/authinfo_hdr Add support for Authentication-Info header in auth module --- Modified: modules/auth/api.c Modified: modules/auth/api.h Modified: modules/auth/auth_mod.c Modified: modules/auth/auth_mod.h Modified: modules/auth/challenge.c Modified: modules/auth/challenge.h Modified: modules/auth/doc/auth_params.xml Modified: modules/auth/nonce.c Modified: modules/auth/rfc2617.c Modified: modules/auth/rfc2617_sha256.c Modified: modules/auth_db/authorize.c Modified: modules/auth_ephemeral/authorize.c Modified: modules/auth_radius/authorize.c Modified: modules/uid_auth_db/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/c8ac7f99a31e77e10abcdbccf14c873… Patch: https://github.com/kamailio/kamailio/commit/c8ac7f99a31e77e10abcdbccf14c873…

8 years

git:master:5ad94e15: auth_radius: add NULL for ha1 parameter in auth_api.post_auth

by AndreasHuber-CH

Module: kamailio Branch: master Commit: 5ad94e15c2de70c2e0054ed55e8b8b25e27ad76e URL: https://github.com/kamailio/kamailio/commit/5ad94e15c2de70c2e0054ed55e8b8b2… Author: AndreasHuber-CH <andreas.huber(a)nagra.com> Committer: AndreasHuber-CH <andreas.huber(a)nagra.com> Date: 2016-05-25T15:44:01+02:00 auth_radius: add NULL for ha1 parameter in auth_api.post_auth auth api was updated to support Authentication-Info header and requires now the ha1 value in post_auth. NULL is used (because I didn't find the ha1 value) which makes that the new feature cannot be used with this module. --- Modified: modules/auth_radius/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/5ad94e15c2de70c2e0054ed55e8b8b2… Patch: https://github.com/kamailio/kamailio/commit/5ad94e15c2de70c2e0054ed55e8b8b2… --- diff --git a/modules/auth_radius/authorize.c b/modules/auth_radius/authorize.c index cb26693..18dff11 100644 --- a/modules/auth_radius/authorize.c +++ b/modules/auth_radius/authorize.c @@ -172,7 +172,7 @@ static inline int authorize(struct sip_msg* _msg, pv_elem_t* _realm, } if (res == 1) { - switch(auth_api.post_auth(_msg, h)) { + switch(auth_api.post_auth(_msg, h, NULL)) { default: BUG("unexpected reply '%d'.\n", auth_api.pre_auth(_msg, &domain, _hftype, &h, NULL));

8 years

git:master:2a91141e: uid_auth_db: add ha1 parameter in auth_api.post_auth

by AndreasHuber-CH

Module: kamailio Branch: master Commit: 2a91141eba2f7870767c9a16e635171f011dc717 URL: https://github.com/kamailio/kamailio/commit/2a91141eba2f7870767c9a16e635171… Author: AndreasHuber-CH <andreas.huber(a)nagra.com> Committer: AndreasHuber-CH <andreas.huber(a)nagra.com> Date: 2016-05-25T15:42:29+02:00 uid_auth_db: add ha1 parameter in auth_api.post_auth auth api was updated to support Authentication-Info header and requires now the ha1 value in post_auth. --- Modified: modules/uid_auth_db/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/2a91141eba2f7870767c9a16e635171… Patch: https://github.com/kamailio/kamailio/commit/2a91141eba2f7870767c9a16e635171… --- diff --git a/modules/uid_auth_db/authorize.c b/modules/uid_auth_db/authorize.c index 4b69e7a..4599947 100644 --- a/modules/uid_auth_db/authorize.c +++ b/modules/uid_auth_db/authorize.c @@ -288,7 +288,7 @@ static inline int check_all_ha1(struct sip_msg* msg, struct hdr_field* hdr, } if (!check_response(dig, method, ha1)) { - if (auth_api.post_auth(msg, hdr) == AUTHENTICATED) { + if (auth_api.post_auth(msg, hdr, ha1) == AUTHENTICATED) { generate_avps(*res, row); return 0; } @@ -416,7 +416,7 @@ static inline int authenticate(struct sip_msg* msg, str* realm, authdb_table_inf /* Recalculate response, it must be same to authorize successfully */ if (!check_response(&(cred->digest), &msg->first_line.u.request.method, ha1)) { - switch(auth_api.post_auth(msg, h)) { + switch(auth_api.post_auth(msg, h, ha1)) { case ERROR: case BAD_CREDENTIALS: ret = -2;

8 years

git:master:32ef6dfc: auth_ephemeral: add ha1 parameter in auth_api.post_auth

by AndreasHuber-CH

Module: kamailio Branch: master Commit: 32ef6dfc9b8f02a7c57b653c033592b2e02056a5 URL: https://github.com/kamailio/kamailio/commit/32ef6dfc9b8f02a7c57b653c033592b… Author: AndreasHuber-CH <andreas.huber(a)nagra.com> Committer: AndreasHuber-CH <andreas.huber(a)nagra.com> Date: 2016-05-25T15:37:41+02:00 auth_ephemeral: add ha1 parameter in auth_api.post_auth auth api was updated to support Authentication-Info header and requires now the ha1 value in post_auth. --- Modified: modules/auth_ephemeral/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/32ef6dfc9b8f02a7c57b653c033592b… Patch: https://github.com/kamailio/kamailio/commit/32ef6dfc9b8f02a7c57b653c033592b… --- diff --git a/modules/auth_ephemeral/authorize.c b/modules/auth_ephemeral/authorize.c index fcd8de0..5725d7f 100644 --- a/modules/auth_ephemeral/authorize.c +++ b/modules/auth_ephemeral/authorize.c @@ -101,7 +101,7 @@ static inline int do_auth(struct sip_msg *_m, struct hdr_field *_h, str *_realm, ret = eph_auth_api.check_response(&cred->digest, _method, ha1); if (ret == AUTHENTICATED) { - if (eph_auth_api.post_auth(_m, _h) != AUTHENTICATED) + if (eph_auth_api.post_auth(_m, _h, ha1) != AUTHENTICATED) { return AUTH_ERROR; }

8 years

git:master:d415dd70: auth_db: add ha1 parameter in auth_api.post_auth

by AndreasHuber-CH

Module: kamailio Branch: master Commit: d415dd70c56ed88489856a7888cb4acae76615db URL: https://github.com/kamailio/kamailio/commit/d415dd70c56ed88489856a7888cb4ac… Author: AndreasHuber-CH <andreas.huber(a)nagra.com> Committer: AndreasHuber-CH <andreas.huber(a)nagra.com> Date: 2016-05-25T15:37:30+02:00 auth_db: add ha1 parameter in auth_api.post_auth auth api was updated to support Authentication-Info header and requires now the ha1 value in post_auth. --- Modified: modules/auth_db/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/d415dd70c56ed88489856a7888cb4ac… Patch: https://github.com/kamailio/kamailio/commit/d415dd70c56ed88489856a7888cb4ac… --- diff --git a/modules/auth_db/authorize.c b/modules/auth_db/authorize.c index e65a300..0291d01 100644 --- a/modules/auth_db/authorize.c +++ b/modules/auth_db/authorize.c @@ -299,7 +299,7 @@ static int digest_authenticate_hdr(sip_msg_t* msg, str *realm, ret = auth_api.check_response(&(cred->digest), method, ha1); if(ret==AUTHENTICATED) { ret = AUTH_OK; - switch(auth_api.post_auth(msg, h)) { + switch(auth_api.post_auth(msg, h, ha1)) { case AUTHENTICATED: generate_avps(msg, result); break;

8 years

git:master:e2ee8b57: auth: add support for Authentication-Info header

by AndreasHuber-CH

Module: kamailio Branch: master Commit: e2ee8b5741ce2d9dc2613c698e5b7002c2f19e4f URL: https://github.com/kamailio/kamailio/commit/e2ee8b5741ce2d9dc2613c698e5b700… Author: AndreasHuber-CH <andreas.huber(a)nagra.com> Committer: AndreasHuber-CH <andreas.huber(a)nagra.com> Date: 2016-05-25T15:30:03+02:00 auth: add support for Authentication-Info header Add an option to include an Authentication-Info header in the response to a successful authentication. The header can be enabled with the parameter 'add_authinfo_hdr' module parameter. The implementation follows RFC2617. The Authentication-Info header is added inside the function post_auth of the auth api. The parameter HA1 had to be added to the post_auth api function which requires an update in all auth_* modules that use the module auth api. --- Modified: modules/auth/api.c Modified: modules/auth/api.h Modified: modules/auth/auth_mod.c Modified: modules/auth/auth_mod.h Modified: modules/auth/challenge.c Modified: modules/auth/challenge.h Modified: modules/auth/doc/auth_params.xml Modified: modules/auth/nonce.c Modified: modules/auth/rfc2617.c Modified: modules/auth/rfc2617_sha256.c --- Diff: https://github.com/kamailio/kamailio/commit/e2ee8b5741ce2d9dc2613c698e5b700… Patch: https://github.com/kamailio/kamailio/commit/e2ee8b5741ce2d9dc2613c698e5b700…

8 years

← Newer
1
...
6
7
8
9
10
11
12
...
35
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2016