sr-dev May 2016

sr-dev@lists.kamailio.org

28 participants
348 discussions

[kamailio/kamailio] Add support for Authentication-Info header in auth module (#639)

by AndreasHuber-CH

The Authentication-Info header is already supported by the ims_auth module. This pull requsts proposes an implementation for auth module. The Authentication-Info header is added in the function "post_auth" (if "add_authinfo_hdr" is configured.) Modules depending on "auth" are adapted slightly to offer the ha1 value to the function "post_auth". You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/639 -- Commit Summary -- * auth: add support for Authentication-Info header * auth_db: add ha1 parameter in auth_api.post_auth * auth_ephemeral: add ha1 parameter in auth_api.post_auth * uid_auth_db: add ha1 parameter in auth_api.post_auth * auth_radius: add NULL for ha1 parameter in auth_api.post_auth -- File Changes -- M modules/auth/api.c (90) M modules/auth/api.h (4) M modules/auth/auth_mod.c (4) M modules/auth/auth_mod.h (1) M modules/auth/challenge.c (107) M modules/auth/challenge.h (2) M modules/auth/doc/auth_params.xml (66) M modules/auth/nonce.c (2) M modules/auth/rfc2617.c (4) M modules/auth/rfc2617_sha256.c (4) M modules/auth_db/authorize.c (2) M modules/auth_ephemeral/authorize.c (2) M modules/auth_radius/authorize.c (2) M modules/uid_auth_db/authorize.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/639.patch https://github.com/kamailio/kamailio/pull/639.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/639

7 years, 11 months

git:master:e50e3bad: Merge pull request #638 from mslehto/NULL

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: e50e3badc79776a6fa5ab225978df7bff14d26e7 URL: https://github.com/kamailio/kamailio/commit/e50e3badc79776a6fa5ab225978df7b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-25T21:33:28+02:00 Merge pull request #638 from mslehto/NULL Fix variable initialization and NULL pointer dereference issues --- Modified: modules/call_control/call_control.c Modified: modules/http_client/http_client.c Modified: modules/mediaproxy/mediaproxy.c Modified: modules/rr/record.c Modified: modules/sipcapture/sipcapture.c Modified: modules/uid_domain/uid_domain_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/e50e3badc79776a6fa5ab225978df7b… Patch: https://github.com/kamailio/kamailio/commit/e50e3badc79776a6fa5ab225978df7b… --- diff --git a/modules/call_control/call_control.c b/modules/call_control/call_control.c index 62af924..5450e00 100644 --- a/modules/call_control/call_control.c +++ b/modules/call_control/call_control.c @@ -985,7 +985,7 @@ __dialog_ended(struct dlg_cell *dlg, int type, struct dlg_cb_params *_params) if( !msg || msg == FAKED_REPLY) msg = _params->req; call_control_stop(msg, dlg->callid); - *_params->param = (void*)CCInactive; + *_params->param = NULL; } } diff --git a/modules/http_client/http_client.c b/modules/http_client/http_client.c index 9a6c269..3efb0ee 100644 --- a/modules/http_client/http_client.c +++ b/modules/http_client/http_client.c @@ -508,6 +508,7 @@ static int w_curl_connect(struct sip_msg* _m, char* _con, char * _url, char* _re if (_con == NULL || _url == NULL || _result == NULL) { LM_ERR("Invalid parameter\n"); + return -1; } con.s = _con; con.len = strlen(con.s); @@ -546,6 +547,7 @@ static int w_curl_connect_post(struct sip_msg* _m, char* _con, char * _url, char if (_con == NULL || _url == NULL || _data == NULL || _result == NULL) { LM_ERR("Invalid parameter\n"); + return -1; } con.s = _con; con.len = strlen(con.s); @@ -782,6 +784,7 @@ static int w_curl_get_redirect(struct sip_msg* _m, char* _con, char* _result) { if (_con == NULL || _result == NULL) { LM_ERR("Invalid parameter\n"); + return -1; } con.s = _con; con.len = strlen(con.s); diff --git a/modules/mediaproxy/mediaproxy.c b/modules/mediaproxy/mediaproxy.c index f96a635..5b37add 100644 --- a/modules/mediaproxy/mediaproxy.c +++ b/modules/mediaproxy/mediaproxy.c @@ -1926,7 +1926,7 @@ __dialog_ended(struct dlg_cell *dlg, int type, struct dlg_cb_params *_params) { if ((int)(long)*_params->param == MPActive) { end_media_session(dlg->callid, dlg->tag[DLG_CALLER_LEG], dlg->tag[DLG_CALLEE_LEG]); - *_params->param = MPInactive; + *_params->param = NULL; } } diff --git a/modules/rr/record.c b/modules/rr/record.c index b8f526e..6c7cc05 100644 --- a/modules/rr/record.c +++ b/modules/rr/record.c @@ -492,7 +492,7 @@ int record_route(struct sip_msg* _m, str *params) int record_route_preset(struct sip_msg* _m, str* _data) { str user = {NULL, 0}; - struct to_body* from; + struct to_body* from = NULL; struct lump* l; char* hdr, *p; int hdr_len; @@ -511,10 +511,6 @@ int record_route_preset(struct sip_msg* _m, str* _data) rr_prefix_len = RR_PREFIX_SIPS_LEN; } - from = 0; - user.len = 0; - user.s = 0; - if (add_username) { if (get_username(_m, &user) < 0) { LM_ERR("failed to extract username\n"); diff --git a/modules/sipcapture/sipcapture.c b/modules/sipcapture/sipcapture.c index 8a3fb7b..83eae4d 100644 --- a/modules/sipcapture/sipcapture.c +++ b/modules/sipcapture/sipcapture.c @@ -626,13 +626,13 @@ void * capture_mode_init(str *name, str * params) { return n; error: - if (n->name.s){ - pkg_free(n->name.s); - } - if (n->table_names){ - pkg_free(n->table_names); - } if (n){ + if (n->name.s){ + pkg_free(n->name.s); + } + if (n->table_names){ + pkg_free(n->table_names); + } pkg_free(n); } return 0; diff --git a/modules/uid_domain/uid_domain_mod.c b/modules/uid_domain/uid_domain_mod.c index fda7bb9..abe43d5 100644 --- a/modules/uid_domain/uid_domain_mod.c +++ b/modules/uid_domain/uid_domain_mod.c @@ -433,7 +433,7 @@ static int db_load_domain(domain_t** d, unsigned long flags, str* domain) static int lookup_domain(struct sip_msg* msg, char* flags, char* fp) { str domain, tmp; - domain_t* d; + domain_t* d = NULL; int ret = -1; if (get_str_fparam(&domain, msg, (fparam_t*)fp) != 0) { @@ -527,13 +527,12 @@ int reload_domain_list(void) static int lookup_domain_fixup(void** param, int param_no) { - unsigned long flags; + unsigned long flags=0; char* s; if (param_no == 1) { /* Determine the track and class of attributes to be loaded */ s = (char*)*param; - flags = 0; if (*s != '$' || (strlen(s) != 3)) { ERR("Invalid parameter value, $xy expected\n"); return -1;

7 years, 11 months

git:master:700b334b: modules/[call_control|mediaproxy]: proper assigment to NULL pointer

by Mikko Lehto

Module: kamailio Branch: master Commit: 700b334b51b39056c4c0004451ca41304510f164 URL: https://github.com/kamailio/kamailio/commit/700b334b51b39056c4c0004451ca413… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2016-05-24T13:23:45+03:00 modules/[call_control|mediaproxy]: proper assigment to NULL pointer CC (clang) [M mediaproxy.so] mediaproxy.o mediaproxy.c:1929:27: warning: expression which evaluates to zero treated as a null pointer constant of type 'void *' [-Wnon-literal-null-conversion] *_params->param = MPInactive; ^~~~~~~~~~ --- Modified: modules/call_control/call_control.c Modified: modules/mediaproxy/mediaproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/700b334b51b39056c4c0004451ca413… Patch: https://github.com/kamailio/kamailio/commit/700b334b51b39056c4c0004451ca413… --- diff --git a/modules/call_control/call_control.c b/modules/call_control/call_control.c index 62af924..5450e00 100644 --- a/modules/call_control/call_control.c +++ b/modules/call_control/call_control.c @@ -985,7 +985,7 @@ __dialog_ended(struct dlg_cell *dlg, int type, struct dlg_cb_params *_params) if( !msg || msg == FAKED_REPLY) msg = _params->req; call_control_stop(msg, dlg->callid); - *_params->param = (void*)CCInactive; + *_params->param = NULL; } } diff --git a/modules/mediaproxy/mediaproxy.c b/modules/mediaproxy/mediaproxy.c index f96a635..5b37add 100644 --- a/modules/mediaproxy/mediaproxy.c +++ b/modules/mediaproxy/mediaproxy.c @@ -1926,7 +1926,7 @@ __dialog_ended(struct dlg_cell *dlg, int type, struct dlg_cb_params *_params) { if ((int)(long)*_params->param == MPActive) { end_media_session(dlg->callid, dlg->tag[DLG_CALLER_LEG], dlg->tag[DLG_CALLEE_LEG]); - *_params->param = MPInactive; + *_params->param = NULL; } }

7 years, 11 months

git:master:a9cce177: modules/sipcapture: fix possible NULL pointer dereference

by Mikko Lehto

Module: kamailio Branch: master Commit: a9cce1772d25e1f03cec3ee291ae5fb4a945f82f URL: https://github.com/kamailio/kamailio/commit/a9cce1772d25e1f03cec3ee291ae5fb… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2016-05-24T13:23:10+03:00 modules/sipcapture: fix possible NULL pointer dereference --- Modified: modules/sipcapture/sipcapture.c --- Diff: https://github.com/kamailio/kamailio/commit/a9cce1772d25e1f03cec3ee291ae5fb… Patch: https://github.com/kamailio/kamailio/commit/a9cce1772d25e1f03cec3ee291ae5fb… --- diff --git a/modules/sipcapture/sipcapture.c b/modules/sipcapture/sipcapture.c index 8a3fb7b..83eae4d 100644 --- a/modules/sipcapture/sipcapture.c +++ b/modules/sipcapture/sipcapture.c @@ -626,13 +626,13 @@ void * capture_mode_init(str *name, str * params) { return n; error: - if (n->name.s){ - pkg_free(n->name.s); - } - if (n->table_names){ - pkg_free(n->table_names); - } if (n){ + if (n->name.s){ + pkg_free(n->name.s); + } + if (n->table_names){ + pkg_free(n->table_names); + } pkg_free(n); } return 0;

7 years, 11 months

git:master:c00867e5: modules/rr: initialize to NULL

by Mikko Lehto

Module: kamailio Branch: master Commit: c00867e50de1c7855fed8a05745086092fef38a5 URL: https://github.com/kamailio/kamailio/commit/c00867e50de1c7855fed8a057450860… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2016-05-24T13:21:25+03:00 modules/rr: initialize to NULL --- Modified: modules/rr/record.c --- Diff: https://github.com/kamailio/kamailio/commit/c00867e50de1c7855fed8a057450860… Patch: https://github.com/kamailio/kamailio/commit/c00867e50de1c7855fed8a057450860… --- diff --git a/modules/rr/record.c b/modules/rr/record.c index b8f526e..6c7cc05 100644 --- a/modules/rr/record.c +++ b/modules/rr/record.c @@ -492,7 +492,7 @@ int record_route(struct sip_msg* _m, str *params) int record_route_preset(struct sip_msg* _m, str* _data) { str user = {NULL, 0}; - struct to_body* from; + struct to_body* from = NULL; struct lump* l; char* hdr, *p; int hdr_len; @@ -511,10 +511,6 @@ int record_route_preset(struct sip_msg* _m, str* _data) rr_prefix_len = RR_PREFIX_SIPS_LEN; } - from = 0; - user.len = 0; - user.s = 0; - if (add_username) { if (get_username(_m, &user) < 0) { LM_ERR("failed to extract username\n");

7 years, 11 months

git:master:e6a3f660: modules/uid_domain: initialize variables

by Mikko Lehto

Module: kamailio Branch: master Commit: e6a3f6605f50d16f673724a2dc6cf22fc47bc717 URL: https://github.com/kamailio/kamailio/commit/e6a3f6605f50d16f673724a2dc6cf22… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2016-05-24T13:22:28+03:00 modules/uid_domain: initialize variables --- Modified: modules/uid_domain/uid_domain_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/e6a3f6605f50d16f673724a2dc6cf22… Patch: https://github.com/kamailio/kamailio/commit/e6a3f6605f50d16f673724a2dc6cf22… --- diff --git a/modules/uid_domain/uid_domain_mod.c b/modules/uid_domain/uid_domain_mod.c index fda7bb9..abe43d5 100644 --- a/modules/uid_domain/uid_domain_mod.c +++ b/modules/uid_domain/uid_domain_mod.c @@ -433,7 +433,7 @@ static int db_load_domain(domain_t** d, unsigned long flags, str* domain) static int lookup_domain(struct sip_msg* msg, char* flags, char* fp) { str domain, tmp; - domain_t* d; + domain_t* d = NULL; int ret = -1; if (get_str_fparam(&domain, msg, (fparam_t*)fp) != 0) { @@ -527,13 +527,12 @@ int reload_domain_list(void) static int lookup_domain_fixup(void** param, int param_no) { - unsigned long flags; + unsigned long flags=0; char* s; if (param_no == 1) { /* Determine the track and class of attributes to be loaded */ s = (char*)*param; - flags = 0; if (*s != '$' || (strlen(s) != 3)) { ERR("Invalid parameter value, $xy expected\n"); return -1;

7 years, 11 months

git:master:19dcb95c: modules/http_client: fix NULL pointer dereference

by Mikko Lehto

Module: kamailio Branch: master Commit: 19dcb95c3b18be7cf538d38673c17a06583fd0e9 URL: https://github.com/kamailio/kamailio/commit/19dcb95c3b18be7cf538d38673c17a0… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2016-05-24T13:20:04+03:00 modules/http_client: fix NULL pointer dereference --- Modified: modules/http_client/http_client.c --- Diff: https://github.com/kamailio/kamailio/commit/19dcb95c3b18be7cf538d38673c17a0… Patch: https://github.com/kamailio/kamailio/commit/19dcb95c3b18be7cf538d38673c17a0… --- diff --git a/modules/http_client/http_client.c b/modules/http_client/http_client.c index 9a6c269..3efb0ee 100644 --- a/modules/http_client/http_client.c +++ b/modules/http_client/http_client.c @@ -508,6 +508,7 @@ static int w_curl_connect(struct sip_msg* _m, char* _con, char * _url, char* _re if (_con == NULL || _url == NULL || _result == NULL) { LM_ERR("Invalid parameter\n"); + return -1; } con.s = _con; con.len = strlen(con.s); @@ -546,6 +547,7 @@ static int w_curl_connect_post(struct sip_msg* _m, char* _con, char * _url, char if (_con == NULL || _url == NULL || _data == NULL || _result == NULL) { LM_ERR("Invalid parameter\n"); + return -1; } con.s = _con; con.len = strlen(con.s); @@ -782,6 +784,7 @@ static int w_curl_get_redirect(struct sip_msg* _m, char* _con, char* _result) { if (_con == NULL || _result == NULL) { LM_ERR("Invalid parameter\n"); + return -1; } con.s = _con; con.len = strlen(con.s);

7 years, 11 months

[kamailio/kamailio] Fix variable initialization and NULL pointer dereference issues (#638)

by Mikko Lehto

Most found with Clang 3.8 static analyzer. Full results here: http://mslehto.iki.fi/clang-static-analyzer/kamailio/01/modules/ You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/638 -- Commit Summary -- * modules/http_client: fix NULL pointer dereference * modules/rr: initialize to NULL * modules/uid_domain: initialize variables * modules/sipcapture: fix possible NULL pointer dereference * modules/[call_control|mediaproxy]: proper assigment to NULL pointer -- File Changes -- M modules/call_control/call_control.c (2) M modules/http_client/http_client.c (3) M modules/mediaproxy/mediaproxy.c (2) M modules/rr/record.c (6) M modules/sipcapture/sipcapture.c (12) M modules/uid_domain/uid_domain_mod.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/638.patch https://github.com/kamailio/kamailio/pull/638.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/638

7 years, 11 months

[kamailio/kamailio] Enable compilation with gcc-6.1.1 (#633)

by Anthony Messina

In preparing RPMs for Fedora 24, I'm unable to compile...```Makefile.defs:980: You are using an old and unsupported gcc version (6.1.1), compile at your own risk!``` --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/633

7 years, 11 months

git:4.4:6a01019b: Makefile.defs: detect gcc 6.x

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.4 Commit: 6a01019bf63cf897d2430d6ada085cd23465fa79 URL: https://github.com/kamailio/kamailio/commit/6a01019bf63cf897d2430d6ada085cd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-25T20:42:14+02:00 Makefile.defs: detect gcc 6.x - reported by Anthony Messina, GH #633 (cherry picked from commit 1975ebdf37b9ffd325a38960bc0bf417466b432f) --- Modified: Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/6a01019bf63cf897d2430d6ada085cd… Patch: https://github.com/kamailio/kamailio/commit/6a01019bf63cf897d2430d6ada085cd…

7 years, 11 months

← Newer
1
...
7
8
9
10
11
12
13
...
35
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2016