In commit c1863d7dc5d7504a8096e9a31dfc200f5e14dd03 added homer5 functionality and table name is built based on timestamp, but corrupted. The added functionality isn't documented too.
Q: why it is mandatory to build table name based on time stamp?
Kind regards,
Seudin
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/566
Module: kamailio
Branch: master
Commit: 6e9f1c045ae827ea4f6bec8ab62187ec41788255
URL: https://github.com/kamailio/kamailio/commit/6e9f1c045ae827ea4f6bec8ab62187e…
Author: Alexandr Dubovikov <alexandr.dubovikov(a)gmail.com>
Committer: Alexandr Dubovikov <alexandr.dubovikov(a)gmail.com>
Date: 2016-05-09T09:31:02+02:00
modules/sipcapture updated modparam description
---
Modified: modules/sipcapture/README
Modified: modules/sipcapture/doc/sipcapture_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/6e9f1c045ae827ea4f6bec8ab62187e…
Patch: https://github.com/kamailio/kamailio/commit/6e9f1c045ae827ea4f6bec8ab62187e…
---
diff --git a/modules/sipcapture/README b/modules/sipcapture/README
index dfdd66d..5b50d46 100644
--- a/modules/sipcapture/README
+++ b/modules/sipcapture/README
@@ -211,7 +211,8 @@ modparam("sipcapture", "db_url", "mysql://user:passwd@host/dbname")
Name of the table's name used to store the SIP messages. Can contain
multiple tables, separated by "|".
- Default value is "sip_capture".
+ Default value is "sip_capture". Only for Homer 3. For Homer 5, please
+ use an argument for the sip_capture function.
Example 1.2. Set sip_capture parameter
...
diff --git a/modules/sipcapture/doc/sipcapture_admin.xml b/modules/sipcapture/doc/sipcapture_admin.xml
index a7c677f..b47a102 100644
--- a/modules/sipcapture/doc/sipcapture_admin.xml
+++ b/modules/sipcapture/doc/sipcapture_admin.xml
@@ -108,7 +108,7 @@ modparam("sipcapture", "db_url", "mysql://user:passwd@host/dbname")
</para>
<para>
<emphasis>
- Default value is "sip_capture".
+ Default value is "sip_capture". Only for Homer 3. For Homer 5, please use an argument for the sip_capture function.
</emphasis>
</para>
<example>
We are using the `presence` module and have noticed many errors in the log as follows:
```WARNING: db_postgres [km_dbase.c:240]: db_postgres_submit_query(): postgres result check failed with code 7 (PGRES_FATAL_ERROR)
WARNING: db_postgres [km_dbase.c:244]: db_postgres_submit_query(): postgres query command failed, connection status 0, error [ERROR: duplicate key value violates unique constraint "presentity_presentity_idx"#012DETAIL: Key (username, domain, event, etag)=(user+test2, phonedev.test2.io, dialog, *#-OFFLINE-#*) already exists.#012]```
I looked over the `presentity.c` code and it appears that the module is marking the records for deletion once they expire by setting the `etag` to `*#-OFFLINE-#*`
This is triggering the postgres constraint and throwing the error. I am confused why the module is using the `etag` column to mark for deletion since it is part of a constraint. Why not add a new column such as `delete_record` and set it to true?
If there is no good reason for this, I would like to propose a patch to add said column.
Please let me know if I am misunderstanding anything here, thanks.
Emmanuel
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/600