[kamailio/kamailio] sipcapture: table name corrupted (#566)

List overview All Threads
Download

newer

older

git:master:d4a2ba2e: smsops:...

git:master:6e9f1c04:...

Seudin Kasumovic

14 Apr 2016 14 Apr '16

2:20 p.m.

In commit c1863d7dc5d7504a8096e9a31dfc200f5e14dd03 added homer5 functionality and table name is built based on timestamp, but corrupted. The added functionality isn't documented too. Q: why it is mandatory to build table name based on time stamp? Kind regards, Seudin --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/566

Attachments:

attachment.html (text/html — 1.1 KB)

Show replies by date

Seudin Kasumovic

14 Apr 14 Apr

2:32 p.m.

New subject: [kamailio/kamailio] sipcapture: table name corrupted (#566)

correct commit where it's added is 37afdd156d5d49b29f44d26339e7d839f1bb381d Kind regards, Seudin --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/566#issuecomment-209972090

Alexandr Dubovikov

5:16 p.m.

New subject: [kamailio/kamailio] sipcapture: table name corrupted (#566)

sorry, but I don't really understand why its corrupted. The timestamp as part of table name is a new design that works well, without any issues. Did you install kamailio 4.4 and check the last config ? https://github.com/sipcapture/homer-api/blob/master/examples/sipcapture/sip… --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/566#issuecomment-210056751

Seudin Kasumovic

15 Apr 15 Apr

7:52 a.m.

New subject: [kamailio/kamailio] sipcapture: table name corrupted (#566)

Hi, I'm testing on 4.4. The 'new design' isn't documented, so I can't figure out how the name will be generated. When use simple config: ``` modparam("sipcapture", "db_url", DBURL) modparam("sipcapture", "capture_on", 1) modparam("sipcapture", "hep_capture_on", 1) modparam("sipcapture", "raw_ipip_capture_on", 0) modparam("sipcapture", "table_name", "sip_capture") ``` sipcapture uses given table name as format string, but the final result was `'sip_capture.....A'`. So no any timestamp in the name. The reason for this could be next two lines: ``` ntab.len = strftime(strftime_buf, sizeof(strftime_buf), table->s, &capt_ts); ntab.s = strftime_buf; ``` The table->s not necessary ends with '\0', because it's part of Kamailio internal str structure. Avoid non zero terminated string will work in this case. Parsing loop in parse_table_names function doesn't add '\0' at the end of table name. Suggested patch is here. ``` diff --git a/modules/sipcapture/sipcapture.c b/modules/sipcapture/sipcapture.c index 41d153e..2bdb4b4 100644 --- a/modules/sipcapture/sipcapture.c +++ b/modules/sipcapture/sipcapture.c @@ -436,8 +436,9 @@ int parse_table_names (str table_name, str ** table_names){ { LM_INFO ("INFO: table name:%s\n",p); names[i].len = strlen (p); - names[i].s = (char *)pkg_malloc(sizeof(char) *names[i].len); + names[i].s = (char *)pkg_malloc(sizeof(char) *(names[i].len + 1)); memcpy(names[i].s, p, names[i].len); + names[i].s[names[i].len] = '\0'; i++; p = strtok (NULL, "| \t"); } ``` BTW, can you explain what 'table->s' will contain (format string required by strftime) using provided example config ? Thanks, Seudin --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/566#issuecomment-210343805

Alexandr Dubovikov

8:04 a.m.

New subject: [kamailio/kamailio] sipcapture: table name corrupted (#566)

the docs are here: https://github.com/sipcapture/homer/wiki since H5 we generate table name depends on message type and datestamp: I have pointed you already to the new kamailio's config: https://github.com/sipcapture/homer-api/blob/master/examples/sipcapture/sip… https://github.com/sipcapture/homer-api/blob/master/examples/sipcapture/sip… https://github.com/sipcapture/homer-api/blob/master/examples/sipcapture/sip… at the end (L855) you push the generated table name to sip_capture function and a message will be inserted to the table. modparam "table_name" is only for H3 Wbr, Alexandr On 15 April 2016 at 09:52, Seudin Kasumovic <notifications(a)github.com> wrote:

...

Hi, I'm testing on 4.4. The 'new design' isn't documented, so I can't figure out how the name will be generated. When use simple config: modparam("sipcapture", "db_url", DBURL) modparam("sipcapture", "capture_on", 1) modparam("sipcapture", "hep_capture_on", 1) modparam("sipcapture", "raw_ipip_capture_on", 0) modparam("sipcapture", "table_name", "sip_capture") sipcapture uses given table name as format string, but the final result was 'sip_capture.....A'. So no any timestamp in the name. The reason for this could be next two lines: ntab.len = strftime(strftime_buf, sizeof(strftime_buf), table->s, &capt_ts); ntab.s = strftime_buf; The table->s not necessary ends with '\0', because it's part of Kamailio internal str structure. Avoid non zero terminated string will work in this case. Parsing loop in parse_table_names function doesn't add '\0' at the end of table name. Suggested patch is here. diff --git a/modules/sipcapture/sipcapture.c b/modules/sipcapture/sipcapture.c index 41d153e..2bdb4b4 100644 --- a/modules/sipcapture/sipcapture.c +++ b/modules/sipcapture/sipcapture.c @@ -436,8 +436,9 @@ int parse_table_names (str table_name, str ** table_names){ { LM_INFO ("INFO: table name:%s\n",p); names[i].len = strlen (p); - names[i].s = (char *)pkg_malloc(sizeof(char) *names[i].len); + names[i].s = (char *)pkg_malloc(sizeof(char) *(names[i].len + 1)); memcpy(names[i].s, p, names[i].len); + names[i].s[names[i].len] = '\0'; i++; p = strtok (NULL, "| \t"); } BTW, can you explain what 'table->s' will contain (format string required by strftime) using provided example config ? Thanks, Seudin — You are receiving this because you commented. Reply to this email directly or view it on GitHub <https://github.com/kamailio/kamailio/issues/566#issuecomment-210343805>

--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/566#issuecomment-210346518

Daniel-Constantin Mierla

9:25 a.m.

New subject: [kamailio/kamailio] sipcapture: table name corrupted (#566)

Is the modparam table_name still needed? Like, is it making possible to run kamailio 4.4 with homer 3? Or, if it is not longer needed, then it should be removed -- it can be confusing and messing up things. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/566#issuecomment-210380901

Seudin Kasumovic

9:31 a.m.

New subject: [kamailio/kamailio] sipcapture: table name corrupted (#566)

I thought on Kamailio docs. Thanks for links. So, workaround in my setup is to always call sip_capture("$var(table_format)") with table format as argument, even don't need to shard data, to get correct table name. Kind regards and thanks, Seudin On Fri, Apr 15, 2016 at 10:03 AM, Alexandr Dubovikov < notifications(a)github.com> wrote:

...

Hi, I'm testing on 4.4. The 'new design' isn't documented, so I can't figure out how the name

will

be generated. When use simple config: modparam("sipcapture", "db_url", DBURL) modparam("sipcapture", "capture_on", 1) modparam("sipcapture", "hep_capture_on", 1) modparam("sipcapture", "raw_ipip_capture_on", 0) modparam("sipcapture", "table_name", "sip_capture") sipcapture uses given table name as format string, but the final result

was

'sip_capture.....A'. So no any timestamp in the name. The reason for this could be next two lines: ntab.len = strftime(strftime_buf, sizeof(strftime_buf), table->s,

&capt_ts);

ntab.s = strftime_buf; The table->s not necessary ends with '\0', because it's part of Kamailio internal str structure. Avoid non zero terminated string will work in this case. Parsing loop in parse_table_names function doesn't add '\0' at the end of table name. Suggested patch is here. diff --git a/modules/sipcapture/sipcapture.c

b/modules/sipcapture/sipcapture.c

index 41d153e..2bdb4b4 100644 --- a/modules/sipcapture/sipcapture.c +++ b/modules/sipcapture/sipcapture.c @@ -436,8 +436,9 @@ int parse_table_names (str table_name, str **

table_names){

{ LM_INFO ("INFO: table name:%s\n",p); names[i].len = strlen (p); - names[i].s = (char *)pkg_malloc(sizeof(char) *names[i].len); + names[i].s = (char *)pkg_malloc(sizeof(char) *(names[i].len + 1)); memcpy(names[i].s, p, names[i].len); + names[i].s[names[i].len] = '\0'; i++; p = strtok (NULL, "| \t"); } BTW, can you explain what 'table->s' will contain (format string required by strftime) using provided example config ? Thanks, Seudin — You are receiving this because you commented. Reply to this email directly or view it on GitHub <https://github.com/kamailio/kamailio/issues/566#issuecomment-210343805>

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub <https://github.com/kamailio/kamailio/issues/566#issuecomment-210346518>

-- MSC Seudin Kasumovic Tuzla, Bosnia --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/566#issuecomment-210382956

Alexandr Dubovikov

9:36 a.m.

New subject: [kamailio/kamailio] sipcapture: table name corrupted (#566)

@miconda this is only for back compatibility to H3. We have a lot users who still use it in production. So better keep it until kamailio 5.0 release Wbr, Alexandr --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/566#issuecomment-210384685

Alexandr Dubovikov

9:38 a.m.

New subject: [kamailio/kamailio] sipcapture: table name corrupted (#566)

@seudin yes, please always call the table name param. Since H5 it will be mandatory. thank you Wbr, Alexandr --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/566#issuecomment-210385658

Daniel-Constantin Mierla

20 Apr 20 Apr

10:12 a.m.

New subject: [kamailio/kamailio] sipcapture: table name corrupted (#566)

Is this sorted out? Does it need a further action (e.g., adding some notes to the docs) or can be closed? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/566#issuecomment-212365160

Alexandr Dubovikov

10:15 a.m.

New subject: [kamailio/kamailio] sipcapture: table name corrupted (#566)

@miconda I will update the docs during this week. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/566#issuecomment-212366286

Daniel-Constantin Mierla

6 May 6 May

12:15 p.m.

New subject: [kamailio/kamailio] sipcapture: table name corrupted (#566)

Hoping @adubovikov will get back to this soon to close this issue. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/566#issuecomment-217424776

Alexandr Dubovikov

12:23 p.m.

New subject: [kamailio/kamailio] sipcapture: table name corrupted (#566)

sorry guys, a lot stuff... yes, I will close it on this WE... --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/566#issuecomment-217425991

Alexandr Dubovikov

9 May 9 May

7:41 a.m.

New subject: [kamailio/kamailio] sipcapture: table name corrupted (#566)

ok, the docs are in. I close the ticket, please re-open if anything. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/566#issuecomment-217796418

Alexandr Dubovikov

7:41 a.m.

New subject: [kamailio/kamailio] sipcapture: table name corrupted (#566)

Closed #566. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/566#event-654045475

2927

days inactive

2952

days old

sr-dev@lists.kamailio.org

Manage subscription

14 comments

3 participants

tags (0)

participants (3)

Alexandr Dubovikov
Daniel-Constantin Mierla
Seudin Kasumovic