sr-dev March 2016

sr-dev@lists.kamailio.org

27 participants
387 discussions

[kamailio] kamailio crash when use http_query (#468)

by situnan

1file:modules/utils/functionsc 2Problem Description：Array Overflow and View Code Label：wsong@grandstreamcn size_t write_function( void *ptr, size_t size, size_t nmemb, void *stream_ptr) { http_res_stream_t *stream = (http_res_stream_t *) stream_ptr; stream->buf = (char *) pkg_realloc(stream->buf, stream->curr_size + (size * nmemb) + 1); if (stream->buf == NULL) { LM_ERR("cannot allocate memory for stream\n"); return CURLE_WRITE_ERROR; } memcpy(&stream->buf[stream->pos], (char *) ptr, (size * nmemb)); stream->curr_size += ((size * nmemb) + 1); stream->pos += (size * nmemb); //begin modify wsong@grandstreamcn // reason:stream->buf size begin with 0 // stream->buf[stream->pos + 1] = '\0'; stream->buf[stream->pos ] = '\0'; //end modify wsong@grandstreamcn return size * nmemb; } --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/468

8 years, 7 months

[kamailio] kazoo: missing documentation (#530)

by Niklas Larsson

modparam("kazoo", "pua_mode", 0) - missing in docs how to use an vhost in the connection url is missing: amqp://kamailio_ngpbx:password@rabbit01.example.com:5672/virthost01 --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/530

8 years, 7 months

[kamailio] dialog: Enabling track_cseq_updates causes message parsing to fail (#526)

by Erik Davidson

With the config that we use for Kamailio, when we enable the track_cseq_updates option on the dialog module (for use with uac_auth()) it causes Kamailio to start failing on parse_first_line() with the following error: 2(6160) INFO: <core> [parser/parse_fline.c:144]: parse_first_line(): ERROR:parse_first_line: method not followed by SP 2(6160) ERROR: <core> [parser/parse_fline.c:257]: parse_first_line(): parse_first_line: bad message (offset: 0) 2(6160) ERROR: <core> [parser/msg_parser.c:690]: parse_msg(): ERROR: parse_msg: message=<ÄÜ s2¬> If you look at the 3rd line of the error it looks like the pointer to the message or the message itself somehow gets corrupted. If I simply switch off the track_cseq_updates option it starts to function normally again. I'm sorry I don't have a config file I can give as an example because the minimalist config I tried creating with that option on worked fine, so there must be something in our config that's leading to this issue but I'm unable to include our config. =/ I'm working on tracking down the issue myself but I wanted to create this issue in case anyone has run into this before or has any pointers on where I should look to reduce the amount of code I need to look through. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/526

8 years, 8 months

[kamailio/kamailio] dialog module : new rpc function for terminate (#555)

by Yasin CANER

- added new rpc command for terminate a dialog with callid, fromtag and totag. - added new rpc command to doc and serctl is removed - added rpc return code to dlg_terminate_dlg function - added rpc return code to rpc domain reload function You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/555 -- Commit Summary -- * dialog module : new rpc function for terminate * dialog module : rpc terminate dialog doc added * domain module : added rpc return code * dialog module: fixed response * domain module : fixed response * dialog module: fixes travis error * domain module : fixed typo -- File Changes -- M modules/dialog/dialog.c (46) M modules/dialog/doc/dialog_admin.xml (46) M modules/domain/domain_mod.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/555.patch https://github.com/kamailio/kamailio/pull/555.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/555

8 years, 8 months

[kamailio] module http_client - support for keeping connections open (#542)

by filiplx

The current implementation uses curl_easy_init() to create a CURL easy handle and curl_easy_cleanup() to destroy the handle, including all open connections within it. If curl_easy_cleanup() isn't called, it's possible to reuse an open connection for the next http call. To reset the CURL options, curl_easy_reset() can be used instead. [http_client_keep_connections_open.diff](https://github.com/kamailio/kamailio/files/168832/http_client_keep_connections_open.txt) --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/542

8 years, 8 months

[kamailio] app_perl module - "use UNIVERSAL" is a fatal error starting with Pert 5.22 (#516)

by Peter Lemenkov

At least two places in OpenSIPS where "use UNIVERSAL" is used: At least two places in Kamailio where "use UNIVERSAL" is used: modules/app_perl/lib/perl/Kamailio/LDAPUtils/LDAPConnection.pm 55:use UNIVERSAL qw( isa ); if( isa($conf ,"Kamailio::LDAPUtils::LDAPConnection") ) { modules/app_perl/lib/perl/Kamailio/VDB.pm 48:use UNIVERSAL qw ( can ); 90: if (can($pkg, $3)) { 92: } elsif (can($v, "init")) { 95: } elsif (can($v, "new")) { This should be fixed as according to this document it will throw a fatal error starting with Perl 5.22: http://search.cpan.org/~shay/perl-5.21.11/pod/perl5213delta.pod#use%C2%A0UN… --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/516

8 years, 8 months

[kamailio] escape transformation chokes on UTF characters (#549)

by apogrebennyk

Version 4.3.4 fails to escape the string that contains Unicode characters: $var(test) = "Foobar s.à.r.l."; $var(test_escaped) = $(var(test){s.escape.user}); Mar 23 16:00:28 sp1 (local7.err) proxy[27853]: ERROR: <core> [strcommon.c:241]: escape_user(): invalid escaped character <4294967235> Mar 23 16:00:28 sp1 (local7.err) proxy[27853]: ERROR: <core> [lvalue.c:345]: lval_pvar_assign(): non existing right pvar Mar 23 16:00:28 sp1 (local7.err) proxy[27853]: ERROR: <core> [lvalue.c:405]: lval_assign(): assignment failed at pos: (701,35-701,97) is there a way to ignore those characters or is it something we have to live with? Some background: we are storing some user-defined data as custom attributes in acc src_leg/dst_leg. As you know the fields in src/dst_leg are pipe-separated. In order to prevent the user from hijacking the attributes we have devided to escape the user-provided fields. This is when we realized that this is limited to latin1 encoding. In theory we can escape it using lua just wanted to avoid the overhead of calling the interpreter too often. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/549

8 years, 8 months

git:master:d72ac166: srdb1/schema: removed unique constraint from connection_idx

by Juha Heinanen

Module: kamailio Branch: master Commit: d72ac166b152ca6906248d67e2605d5b283fa01e URL: https://github.com/kamailio/kamailio/commit/d72ac166b152ca6906248d67e2605d5… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: 2016-03-23T16:32:06+02:00 srdb1/schema: removed unique constraint from connection_idx --- Modified: lib/srdb1/schema/location.xml --- Diff: https://github.com/kamailio/kamailio/commit/d72ac166b152ca6906248d67e2605d5… Patch: https://github.com/kamailio/kamailio/commit/d72ac166b152ca6906248d67e2605d5… --- diff --git a/lib/srdb1/schema/location.xml b/lib/srdb1/schema/location.xml index 07c8d58..c22fcaf 100644 --- a/lib/srdb1/schema/location.xml +++ b/lib/srdb1/schema/location.xml @@ -232,7 +232,6 @@ <name>connection_idx</name> <colref linkend="server_id"/> <colref linkend="connection_id"/> - <unique/> </index>

8 years, 8 months

[kamailio] TLS [client:default] no way to verify_certificate but not require_certificate (#551)

by Anthony Messina

I have the following settings in tls.cfg and I'd like to verify the server certificate IF one is provided on outbound (client) connections, but this doesn't seem possible and set_verification spits out **Server MUST present valid certificate**. The default tls.cfg https://github.com/kamailio/kamailio/blob/master/modules/tls/tls.cfg#L41 seems to indicate that this is possible. ``` [client:default] method = TLSv1+ verify_certificate = yes require_certificate = no private_key = /etc/kamailio/our.key.pem certificate = /etc/kamailio/our.crt.pem verify_depth = 2 ca_list = /etc/pki/tls/cert.pem ``` When starting Kamailio... ``` INFO: tls [tls_domain.c:278]: fill_missing(): TLSc<default>: tls_method=20 INFO: tls [tls_domain.c:290]: fill_missing(): TLSc<default>: certificate='/etc/kamailio/our.crt.pem' INFO: tls [tls_domain.c:297]: fill_missing(): TLSc<default>: ca_list='/etc/pki/tls/cert.pem' INFO: tls [tls_domain.c:304]: fill_missing(): TLSc<default>: crl='(null)' INFO: tls [tls_domain.c:308]: fill_missing(): TLSc<default>: require_certificate=0 INFO: tls [tls_domain.c:322]: fill_missing(): TLSc<default>: private_key='/etc/kamailio/our.key.pem' INFO: tls [tls_domain.c:326]: fill_missing(): TLSc<default>: verify_certificate=1 INFO: tls [tls_domain.c:329]: fill_missing(): TLSc<default>: verify_depth=2 INFO: tls [tls_domain.c:667]: set_verification(): TLSc<default>: Server MUST present valid certificate ``` --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/551

8 years, 8 months

[kamailio/kamailio] Timeout param added in ndb_redis module (#557)

by misaksen

The connection timeout was hardcoded to 1 sec. This can now be set from cfg file. If the redis server became unresponsive kamailio would wait for the standard Linux TCP timeout for an answer (very long time). This patch has added an timeout value for redis commands. The default timeout is 1 sec. [30-redis-timeout.txt](https://github.com/kamailio/kamailio/files/198503/30-… --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/557

8 years, 8 months

← Newer
1
2
3
4
5
6
7
...
39
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2016