sr-dev March 2016

sr-dev@lists.kamailio.org

27 participants
387 discussions

git:master:4a0856be: Merge pull request #520 from kamailio/tsearle-futex-try
by Daniel-Constantin Mierla 01 Mar '16

01 Mar '16

Module: kamailio Branch: master Commit: 4a0856be3acd1c1a1eaaa058a39723a881fd6ed8 URL: https://github.com/kamailio/kamailio/commit/4a0856be3acd1c1a1eaaa058a39723a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-03-01T08:46:37+01:00 Merge pull request #520 from kamailio/tsearle-futex-try core/futex: fix bug in futex_try --- Modified: futexlock.h --- Diff: https://github.com/kamailio/kamailio/commit/4a0856be3acd1c1a1eaaa058a39723a… Patch: https://github.com/kamailio/kamailio/commit/4a0856be3acd1c1a1eaaa058a39723a… --- diff --git a/futexlock.h b/futexlock.h index 7aa7c73..db2fca4 100644 --- a/futexlock.h +++ b/futexlock.h @@ -142,7 +142,7 @@ static inline int futex_try(futex_lock_t* lock) { int c; c=atomic_cmpxchg(lock, 0, 1); - if (likely(c)) + if (likely(c==0)) membar_enter_lock(); return c; }

1 0

git:master:47aa94c6: core/futex: fix bug in futex_try
by tsearle 01 Mar '16

01 Mar '16

Module: kamailio Branch: master Commit: 47aa94c694e5471fa85bb15c372f9120876e4927 URL: https://github.com/kamailio/kamailio/commit/47aa94c694e5471fa85bb15c372f912… Author: tsearle <tsearle(a)gmail.com> Committer: tsearle <tsearle(a)gmail.com> Date: 2016-02-25T09:56:09+01:00 core/futex: fix bug in futex_try atomic_cmpxchg returns the previous value. If the previous value was 0 then it was previously unlocked and we now have acquired the lock. Thus, it should be c==0 that is considered as the case we enter the lock, not c!=0 As far as I can tell, lock_try (and lock_set_try) are currently no used anywhere in the code, so this fix shoudn't have any impact --- Modified: futexlock.h --- Diff: https://github.com/kamailio/kamailio/commit/47aa94c694e5471fa85bb15c372f912… Patch: https://github.com/kamailio/kamailio/commit/47aa94c694e5471fa85bb15c372f912… --- diff --git a/futexlock.h b/futexlock.h index 7aa7c73..db2fca4 100644 --- a/futexlock.h +++ b/futexlock.h @@ -142,7 +142,7 @@ static inline int futex_try(futex_lock_t* lock) { int c; c=atomic_cmpxchg(lock, 0, 1); - if (likely(c)) + if (likely(c==0)) membar_enter_lock(); return c; }

1 0

[kamailio] core/futex: fix bug in futex_try (#520)
by tsearle 01 Mar '16

01 Mar '16

atomic_cmpxchg returns the previous value. If the previous value was 0 then it was previously unlocked and we now have acquired the lock. Thus, it should be c==0 that is considered as the case we enter the lock, not c!=0 As far as I can tell, lock_try (and lock_set_try) are currently no used anywhere in the code, so this fix shoudn't have any impact You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/520 -- Commit Summary -- * core/futex: fix bug in futex_try -- File Changes -- M futexlock.h (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/520.patch https://github.com/kamailio/kamailio/pull/520.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/520

2 2

git:master:63987e26: Merge pull request #522 from mslehto/sdpops
by Daniel-Constantin Mierla 01 Mar '16

01 Mar '16

Module: kamailio Branch: master Commit: 63987e266c0ee07d8ff184b9056ce30bac7db405 URL: https://github.com/kamailio/kamailio/commit/63987e266c0ee07d8ff184b9056ce30… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-03-01T08:45:16+01:00 Merge pull request #522 from mslehto/sdpops sdpops improvements and tests --- Added: test/unit/60-message-sdp0.sip Added: test/unit/60-message-sdp1.sip Added: test/unit/60-message-sdp2.sip Added: test/unit/60-message-sdp3.sip Added: test/unit/60-message-sdp4.sip Added: test/unit/60-message-sdp5.sip Added: test/unit/60-message-sdp6.sip Added: test/unit/60-message-sdp7.sip Added: test/unit/60.cfg Added: test/unit/60.sh Added: test/unit/include/require.sh Modified: modules/sdpops/sdpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/63987e266c0ee07d8ff184b9056ce30… Patch: https://github.com/kamailio/kamailio/commit/63987e266c0ee07d8ff184b9056ce30…

1 0

git:master:83d44c64: test/unit: add unit test for sdpops script function sdp_remove_line_by_prefix()
by Mikko Lehto 01 Mar '16

01 Mar '16

Module: kamailio Branch: master Commit: 83d44c6472567932e6eede1c0b820d0eb4c99fb6 URL: https://github.com/kamailio/kamailio/commit/83d44c6472567932e6eede1c0b820d0… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2016-02-29T16:23:58+02:00 test/unit: add unit test for sdpops script function sdp_remove_line_by_prefix() --- Added: test/unit/60-message-sdp0.sip Added: test/unit/60-message-sdp1.sip Added: test/unit/60-message-sdp2.sip Added: test/unit/60-message-sdp3.sip Added: test/unit/60-message-sdp4.sip Added: test/unit/60-message-sdp5.sip Added: test/unit/60-message-sdp6.sip Added: test/unit/60-message-sdp7.sip Added: test/unit/60.cfg Added: test/unit/60.sh Added: test/unit/include/require.sh --- Diff: https://github.com/kamailio/kamailio/commit/83d44c6472567932e6eede1c0b820d0… Patch: https://github.com/kamailio/kamailio/commit/83d44c6472567932e6eede1c0b820d0…

1 0

git:master:5db4cec2: modules/sdpops: reimplement sdp_remove_line_by_prefix() to fix shortcomings
by Mikko Lehto 01 Mar '16

01 Mar '16

Module: kamailio Branch: master Commit: 5db4cec2c9e8ab62c711738eae181afa69c1724d URL: https://github.com/kamailio/kamailio/commit/5db4cec2c9e8ab62c711738eae181af… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2016-02-29T15:35:41+02:00 modules/sdpops: reimplement sdp_remove_line_by_prefix() to fix shortcomings - single line match was not removed - multiline match with non-related lines between was not removed --- Modified: modules/sdpops/sdpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/5db4cec2c9e8ab62c711738eae181af… Patch: https://github.com/kamailio/kamailio/commit/5db4cec2c9e8ab62c711738eae181af…

1 0

[kamailio] sdpops improvements and tests (#522)
by Mikko Lehto 01 Mar '16

01 Mar '16

Complete re-implementation of sdp_remove_line_by_prefix(), maybe reviewing by diff does not make sense. Also feedback is on unit test is welcome as I have not created such for Kamailio earlier. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/522 -- Commit Summary -- * modules/sdpops: reimplement sdp_remove_line_by_prefix() to fix shortcomings * test/unit: add unit test for sdpops script function sdp_remove_line_by_prefix() -- File Changes -- M modules/sdpops/sdpops_mod.c (118) A test/unit/60-message-sdp0.sip (18) A test/unit/60-message-sdp1.sip (18) A test/unit/60-message-sdp2.sip (19) A test/unit/60-message-sdp3.sip (19) A test/unit/60-message-sdp4.sip (20) A test/unit/60-message-sdp5.sip (20) A test/unit/60-message-sdp6.sip (20) A test/unit/60-message-sdp7.sip (19) A test/unit/60.cfg (41) A test/unit/60.sh (75) A test/unit/include/require.sh (65) -- Patch Links -- https://github.com/kamailio/kamailio/pull/522.patch https://github.com/kamailio/kamailio/pull/522.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/522

2 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2016