sr-dev March 2016

sr-dev@lists.kamailio.org

27 participants
387 discussions

git:master:8bc9d1b4: Merge pull request #523 from sippy/master_rtpp_ip6_fix

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 8bc9d1b4f9e285dcacf748688ace164efa763600 URL: https://github.com/kamailio/kamailio/commit/8bc9d1b4f9e285dcacf748688ace164… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-03-01T08:49:31+01:00 Merge pull request #523 from sippy/master_rtpp_ip6_fix Fix an issue with IPv6 in the rtpproxy module --- Modified: modules/rtpproxy/rtpproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/8bc9d1b4f9e285dcacf748688ace164… Patch: https://github.com/kamailio/kamailio/commit/8bc9d1b4f9e285dcacf748688ace164…

8 years, 2 months

git:master:6af319ea: Fix IPv6 handling with the default setup. With the current code,

by Maksym Sobolyev

Module: kamailio Branch: master Commit: 6af319ea9307feb840c9f318954c49c3eac8bbe1 URL: https://github.com/kamailio/kamailio/commit/6af319ea9307feb840c9f318954c49c… Author: Maksym Sobolyev <sobomax(a)sippysoft.com> Committer: Maksym Sobolyev <sobomax(a)sippysoft.com> Date: 2016-02-29T13:28:53-08:00 Fix IPv6 handling with the default setup. With the current code, it's possible for it to pit IPv6 address, but set adress family to the IP4. --- Modified: modules/rtpproxy/rtpproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/6af319ea9307feb840c9f318954c49c… Patch: https://github.com/kamailio/kamailio/commit/6af319ea9307feb840c9f318954c49c…

8 years, 2 months

[kamailio] Fix an issue with IPv6 in the rtpproxy module (#523)

by sobomax

There is an old issue in the OpenSIPS which may result in SDP containing mismatching protocols, when processing rtpproxy_offer() on a IPv6 message with default flags. This has been revealed by the new version of the [voiptests](https://travis-ci.org/sippy/voiptests/) <MSG IN> 00:00:03.089/GLOBAL/alice_ua: SENDING message to [::1]:5060: INVITE sip:bob_6@[::1]:5060 SIP/2.0 v: SIP/2.0/UDP [::1]:5061;branch=z9hG4bKfffb7b9e25497c853146ea72a3399f5c;rport Max-Forwards: 70 f: "Alice Smith" <sip:alice_6_ipv6@[::1]>;tag=628b36c02f1d1d5a7b4305c050a3feb6 t: <sip:bob_6@[::1]> i: 759e9723cfa1bc5c9c294b2a6c816e77(a)184.71.172.86 CSeq: 200 INVITE m: Anonymous <sip:alice_6_ipv6@[::1]:5061> Expires: 300 User-Agent: Sippy cisco-GUID: 3824430197-1272056386-4229849152-47475815 h323-conf-id: 3824430197-1272056386-4229849152-47475815 c: application/sdp l: 409 v=0 o=- 986474003697 986474003697 IN IP6 ::1 s=- c=IN IP6 2001:0:0:0:7c1:0:52b8:0 t=0 0 m=audio 40534 RTP/AVP 18 0 2 4 8 96 97 98 101 a=rtpmap:18 G729a/8000 a=rtpmap:0 PCMU/8000 a=rtpmap:2 G726-32/8000 a=rtpmap:4 G723/8000 a=rtpmap:8 PCMA/8000 a=rtpmap:96 G726-40/8000 a=rtpmap:97 G726-24/8000 a=rtpmap:98 G726-16/8000 a=rtpmap:101 telephone-event/8000 a=fmtp:101 0-15 a=ptime:30 a=sendrecv </MSG IN> <MSG OUT> 00:00:03.090/GLOBAL/bob_ua: RECEIVED message from [::1]:5060: INVITE sip:bob_6@[::1]:5062 SIP/2.0 Record-Route: <sip:[0:0:0:0:0:0:0:1];lr;ftag=628b36c02f1d1d5a7b4305c050a3feb6> Via: SIP/2.0/UDP [0:0:0:0:0:0:0:1]:5060;branch=z9hG4bKddc6.7a0c3345.0 v: SIP/2.0/UDP [::1]:5061;received=0:0:0:0:0:0:0:1;branch=z9hG4bKfffb7b9e25497c853146ea72a3399f5c;rport=5061 Max-Forwards: 69 f: "Alice Smith" <sip:alice_6_ipv6@[::1]>;tag=628b36c02f1d1d5a7b4305c050a3feb6 t: <sip:bob_6@[::1]> i: 759e9723cfa1bc5c9c294b2a6c816e77(a)184.71.172.86 CSeq: 200 INVITE m: Anonymous <sip:alice_6_ipv6@[::1]:5061> Expires: 300 User-Agent: Sippy cisco-GUID: 3824430197-1272056386-4229849152-47475815 h323-conf-id: 3824430197-1272056386-4229849152-47475815 c: application/sdp Content-Length: 419 v=0 o=- 986474003697 986474003697 IN IP6 ::1 s=- c=IN IP4 0:0:0:0:0:0:0:1 t=0 0 m=audio 12260 RTP/AVP 18 0 2 4 8 96 97 98 101 a=rtpmap:18 G729a/8000 a=rtpmap:0 PCMU/8000 a=rtpmap:2 G726-32/8000 a=rtpmap:4 G723/8000 a=rtpmap:8 PCMA/8000 a=rtpmap:96 G726-40/8000 a=rtpmap:97 G726-24/8000 a=rtpmap:98 G726-16/8000 a=rtpmap:101 telephone-event/8000 a=fmtp:101 0-15 a=ptime:30 a=sendrecv a=nortpproxy:yes </MSG OUT> You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/523 -- Commit Summary -- * Fix IPv6 handling with the default setup. With the current code, -- File Changes -- M modules/rtpproxy/rtpproxy.c (74) -- Patch Links -- https://github.com/kamailio/kamailio/pull/523.patch https://github.com/kamailio/kamailio/pull/523.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/523

8 years, 2 months

git:4.3:b8a5651d: Merge pull request #518 from phil-lavin/backport-loading-dialogs-from-database

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.3 Commit: b8a5651dd6ad3d61b46d74c78e651abd2c677442 URL: https://github.com/kamailio/kamailio/commit/b8a5651dd6ad3d61b46d74c78e651ab… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-03-01T08:48:29+01:00 Merge pull request #518 from phil-lavin/backport-loading-dialogs-from-database [4.3 BACKPORT] pua_dialoginfo: don't free dlginfo structure in dlg loaded callback --- Modified: modules/pua_dialoginfo/pua_dialoginfo.c --- Diff: https://github.com/kamailio/kamailio/commit/b8a5651dd6ad3d61b46d74c78e651ab… Patch: https://github.com/kamailio/kamailio/commit/b8a5651dd6ad3d61b46d74c78e651ab… --- diff --git a/modules/pua_dialoginfo/pua_dialoginfo.c b/modules/pua_dialoginfo/pua_dialoginfo.c index de53e0f..446d980 100644 --- a/modules/pua_dialoginfo/pua_dialoginfo.c +++ b/modules/pua_dialoginfo/pua_dialoginfo.c @@ -609,7 +609,11 @@ __dialog_loaded(struct dlg_cell *dlg, int type, struct dlg_cb_params *_params) LM_DBG("INVITE dialog loaded: from=%.*s\n", dlg->from_uri.len, dlg->from_uri.s); dlginfo=get_dialog_data(dlg, type); - if(dlginfo!=NULL) free_dlginfo_cell(dlginfo); + if(dlginfo!=NULL) { + LM_DBG("dialog info initialized (from=%.*s)\n", + dlg->from_uri.len, dlg->from_uri.s); + /* free_dlginfo_cell(dlginfo); */ + } }

8 years, 2 months

git:4.3:11715a36: pua_dialoginfo: don't free dlginfo structure in dlg loaded callback

by Phil Lavin

Module: kamailio Branch: 4.3 Commit: 11715a3601629d8f1b79cac4f84f7e0ebebd318e URL: https://github.com/kamailio/kamailio/commit/11715a3601629d8f1b79cac4f84f7e0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Phil Lavin <phil.lavin(a)synety.com> Date: 2016-02-24T08:40:43Z pua_dialoginfo: don't free dlginfo structure in dlg loaded callback - the structure will be destroyed in a later dlg callback, enabled by dlg_api.register_dlgcb(), via free_dlginfo_cell() - based and includes partial patch from GH #492, by Phil Lavin --- Modified: modules/pua_dialoginfo/pua_dialoginfo.c --- Diff: https://github.com/kamailio/kamailio/commit/11715a3601629d8f1b79cac4f84f7e0… Patch: https://github.com/kamailio/kamailio/commit/11715a3601629d8f1b79cac4f84f7e0… --- diff --git a/modules/pua_dialoginfo/pua_dialoginfo.c b/modules/pua_dialoginfo/pua_dialoginfo.c index de53e0f..446d980 100644 --- a/modules/pua_dialoginfo/pua_dialoginfo.c +++ b/modules/pua_dialoginfo/pua_dialoginfo.c @@ -609,7 +609,11 @@ __dialog_loaded(struct dlg_cell *dlg, int type, struct dlg_cb_params *_params) LM_DBG("INVITE dialog loaded: from=%.*s\n", dlg->from_uri.len, dlg->from_uri.s); dlginfo=get_dialog_data(dlg, type); - if(dlginfo!=NULL) free_dlginfo_cell(dlginfo); + if(dlginfo!=NULL) { + LM_DBG("dialog info initialized (from=%.*s)\n", + dlg->from_uri.len, dlg->from_uri.s); + /* free_dlginfo_cell(dlginfo); */ + } }

8 years, 2 months

[kamailio] [4.3 BACKPORT] pua_dialoginfo: don't free dlginfo structure in dlg loaded callback (#518)

by Phil Lavin

I figured it was worth backporting this crash fix, before the v4.3.5 release Daniel mentioned on the mailing list - the structure will be destroyed in a later dlg callback, enabled by dlg_api.register_dlgcb(), via free_dlginfo_cell() - based and includes partial patch from GH #492, by Phil Lavin You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/518 -- Commit Summary -- * pua_dialoginfo: don't free dlginfo structure in dlg loaded callback -- File Changes -- M modules/pua_dialoginfo/pua_dialoginfo.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/518.patch https://github.com/kamailio/kamailio/pull/518.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/518

8 years, 2 months

git:master:d6fb5dd1: Merge pull request #519 from phil-lavin/tls-threshold-logging

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d6fb5dd11642b70b29d356a59620ee065e1538c3 URL: https://github.com/kamailio/kamailio/commit/d6fb5dd11642b70b29d356a59620ee0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-03-01T08:47:23+01:00 Merge pull request #519 from phil-lavin/tls-threshold-logging tls: enhance the logging of ssl bug #1491 workaround --- Modified: modules/tls/tls_server.c --- Diff: https://github.com/kamailio/kamailio/commit/d6fb5dd11642b70b29d356a59620ee0… Patch: https://github.com/kamailio/kamailio/commit/d6fb5dd11642b70b29d356a59620ee0… --- diff --git a/modules/tls/tls_server.c b/modules/tls/tls_server.c index e5f838d..880fae2 100644 --- a/modules/tls/tls_server.c +++ b/modules/tls/tls_server.c @@ -186,7 +186,8 @@ static int tls_complete_init(struct tcp_connection* c) if (LOW_MEM_NEW_CONNECTION_TEST()){ ERR("tls: ssl bug #1491 workaround: not enough memory for safe" - " operation: %lu\n", shm_available()); + " operation: shm=%lu threshold1=%d\n", shm_available_safe(), + cfg_get(tls, tls_cfg, low_mem_threshold1)); goto error2; } /* Get current TLS configuration and increase reference @@ -294,7 +295,8 @@ static int tls_fix_connection_unsafe(struct tcp_connection* c) } }else if (unlikely(LOW_MEM_CONNECTED_TEST())){ ERR("tls: ssl bug #1491 workaround: not enough memory for safe" - " operation: %lu\n", shm_available()); + " operation: shm=%lu threshold2=%d\n", shm_available_safe(), + cfg_get(tls, tls_cfg, low_mem_threshold2)); return -1; } return 0; @@ -324,7 +326,8 @@ static int tls_fix_connection(struct tcp_connection* c) } if (unlikely(LOW_MEM_CONNECTED_TEST())){ ERR("tls: ssl bug #1491 workaround: not enough memory for safe" - " operation: %lu\n", shm_available()); + " operation: shm=%lu threshold2=%d\n", shm_available_safe(), + cfg_get(tls, tls_cfg, low_mem_threshold2)); return -1; } return 0; @@ -527,7 +530,8 @@ static int tls_shutdown(struct tcp_connection *c) return 0; if (unlikely(LOW_MEM_CONNECTED_TEST())){ ERR("tls: ssl bug #1491 workaround: not enough memory for safe" - " operation: %lu\n", shm_available()); + " operation: shm=%lu threshold2=%d\n", shm_available_safe(), + cfg_get(tls, tls_cfg, low_mem_threshold2)); goto err; }

8 years, 2 months

git:master:8736b2dc: tls: fix line breaks

by Phil Lavin

Module: kamailio Branch: master Commit: 8736b2dc8dcd5fd8ee253134b19cb8ce0aa1c0b4 URL: https://github.com/kamailio/kamailio/commit/8736b2dc8dcd5fd8ee253134b19cb8c… Author: Phil Lavin <phil.lavin(a)synety.com> Committer: Phil Lavin <phil.lavin(a)synety.com> Date: 2016-02-24T12:21:42Z tls: fix line breaks - fix line breaks in previous logging commit --- Modified: modules/tls/tls_server.c --- Diff: https://github.com/kamailio/kamailio/commit/8736b2dc8dcd5fd8ee253134b19cb8c… Patch: https://github.com/kamailio/kamailio/commit/8736b2dc8dcd5fd8ee253134b19cb8c… --- diff --git a/modules/tls/tls_server.c b/modules/tls/tls_server.c index 3627f07..880fae2 100644 --- a/modules/tls/tls_server.c +++ b/modules/tls/tls_server.c @@ -186,7 +186,8 @@ static int tls_complete_init(struct tcp_connection* c) if (LOW_MEM_NEW_CONNECTION_TEST()){ ERR("tls: ssl bug #1491 workaround: not enough memory for safe" - " operation: shm=%lu threshold1=%d\n", shm_available_safe(), cfg_get(tls, tls_cfg, low_mem_threshold1)); + " operation: shm=%lu threshold1=%d\n", shm_available_safe(), + cfg_get(tls, tls_cfg, low_mem_threshold1)); goto error2; } /* Get current TLS configuration and increase reference @@ -294,7 +295,8 @@ static int tls_fix_connection_unsafe(struct tcp_connection* c) } }else if (unlikely(LOW_MEM_CONNECTED_TEST())){ ERR("tls: ssl bug #1491 workaround: not enough memory for safe" - " operation: shm=%lu threshold2=%d\n", shm_available_safe(), cfg_get(tls, tls_cfg, low_mem_threshold2)); + " operation: shm=%lu threshold2=%d\n", shm_available_safe(), + cfg_get(tls, tls_cfg, low_mem_threshold2)); return -1; } return 0; @@ -324,7 +326,8 @@ static int tls_fix_connection(struct tcp_connection* c) } if (unlikely(LOW_MEM_CONNECTED_TEST())){ ERR("tls: ssl bug #1491 workaround: not enough memory for safe" - " operation: shm=%lu threshold2=%d\n", shm_available_safe(), cfg_get(tls, tls_cfg, low_mem_threshold2)); + " operation: shm=%lu threshold2=%d\n", shm_available_safe(), + cfg_get(tls, tls_cfg, low_mem_threshold2)); return -1; } return 0; @@ -527,7 +530,8 @@ static int tls_shutdown(struct tcp_connection *c) return 0; if (unlikely(LOW_MEM_CONNECTED_TEST())){ ERR("tls: ssl bug #1491 workaround: not enough memory for safe" - " operation: shm=%lu threshold2=%d\n", shm_available_safe(), cfg_get(tls, tls_cfg, low_mem_threshold2)); + " operation: shm=%lu threshold2=%d\n", shm_available_safe(), + cfg_get(tls, tls_cfg, low_mem_threshold2)); goto err; }

8 years, 2 months

git:master:9dd2760f: tls: enhance the logging of ssl bug #1491 workaround

by Phil Lavin

Module: kamailio Branch: master Commit: 9dd2760fd337b39b72eb38189c093f5a156292f2 URL: https://github.com/kamailio/kamailio/commit/9dd2760fd337b39b72eb38189c093f5… Author: Phil Lavin <phil.lavin(a)synety.com> Committer: Phil Lavin <phil.lavin(a)synety.com> Date: 2016-02-24T12:06:41Z tls: enhance the logging of ssl bug #1491 workaround - log shm_available_safe() instead of shm_available() as this is what is actually compared in the check - also log the relevant threshold as it is not always obvious if the default value is being used --- Modified: modules/tls/tls_server.c --- Diff: https://github.com/kamailio/kamailio/commit/9dd2760fd337b39b72eb38189c093f5… Patch: https://github.com/kamailio/kamailio/commit/9dd2760fd337b39b72eb38189c093f5… --- diff --git a/modules/tls/tls_server.c b/modules/tls/tls_server.c index e5f838d..3627f07 100644 --- a/modules/tls/tls_server.c +++ b/modules/tls/tls_server.c @@ -186,7 +186,7 @@ static int tls_complete_init(struct tcp_connection* c) if (LOW_MEM_NEW_CONNECTION_TEST()){ ERR("tls: ssl bug #1491 workaround: not enough memory for safe" - " operation: %lu\n", shm_available()); + " operation: shm=%lu threshold1=%d\n", shm_available_safe(), cfg_get(tls, tls_cfg, low_mem_threshold1)); goto error2; } /* Get current TLS configuration and increase reference @@ -294,7 +294,7 @@ static int tls_fix_connection_unsafe(struct tcp_connection* c) } }else if (unlikely(LOW_MEM_CONNECTED_TEST())){ ERR("tls: ssl bug #1491 workaround: not enough memory for safe" - " operation: %lu\n", shm_available()); + " operation: shm=%lu threshold2=%d\n", shm_available_safe(), cfg_get(tls, tls_cfg, low_mem_threshold2)); return -1; } return 0; @@ -324,7 +324,7 @@ static int tls_fix_connection(struct tcp_connection* c) } if (unlikely(LOW_MEM_CONNECTED_TEST())){ ERR("tls: ssl bug #1491 workaround: not enough memory for safe" - " operation: %lu\n", shm_available()); + " operation: shm=%lu threshold2=%d\n", shm_available_safe(), cfg_get(tls, tls_cfg, low_mem_threshold2)); return -1; } return 0; @@ -527,7 +527,7 @@ static int tls_shutdown(struct tcp_connection *c) return 0; if (unlikely(LOW_MEM_CONNECTED_TEST())){ ERR("tls: ssl bug #1491 workaround: not enough memory for safe" - " operation: %lu\n", shm_available()); + " operation: shm=%lu threshold2=%d\n", shm_available_safe(), cfg_get(tls, tls_cfg, low_mem_threshold2)); goto err; }

8 years, 2 months

[kamailio] tls: enhance the logging of ssl bug #1491 workaround (#519)

by Phil Lavin

- log shm_available_safe() instead of shm_available() as this is what is actually compared in the check - also log the relevant threshold as it is not always obvious if the default value is being used You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/519 -- Commit Summary -- * tls: enhance the logging of ssl bug #1491 workaround * tls: fix line breaks -- File Changes -- M modules/tls/tls_server.c (12) -- Patch Links -- https://github.com/kamailio/kamailio/pull/519.patch https://github.com/kamailio/kamailio/pull/519.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/519

8 years, 2 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2016