sr-dev February 2016

sr-dev@lists.kamailio.org

28 participants
303 discussions

git:master:dcfd5012: tls: debug messages for mutex ops with lock function
by Daniel-Constantin Mierla 11 Feb '16

11 Feb '16

Module: kamailio Branch: master Commit: dcfd5012c0fe10c2697ceeaf5b09d24e1ae8719e URL: https://github.com/kamailio/kamailio/commit/dcfd5012c0fe10c2697ceeaf5b09d24… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-02-11T22:16:09+01:00 tls: debug messages for mutex ops with lock function --- Modified: modules/tls/tls_locking.c --- Diff: https://github.com/kamailio/kamailio/commit/dcfd5012c0fe10c2697ceeaf5b09d24… Patch: https://github.com/kamailio/kamailio/commit/dcfd5012c0fe10c2697ceeaf5b09d24… --- diff --git a/modules/tls/tls_locking.c b/modules/tls/tls_locking.c index 46a8387..434f490 100644 --- a/modules/tls/tls_locking.c +++ b/modules/tls/tls_locking.c @@ -1,7 +1,7 @@ /* * TLS module * - * Copyright (C) 2007 iptelorg GmbH + * Copyright (C) 2007 iptelorg GmbH * * Permission to use, copy, modify, and distribute this software for any * purpose with or without fee is hereby granted, provided that the above @@ -42,7 +42,7 @@ struct CRYPTO_dynlock_value{ static struct CRYPTO_dynlock_value* dyn_create_f(const char* file, int line) { struct CRYPTO_dynlock_value* l; - + l=shm_malloc(sizeof(struct CRYPTO_dynlock_value)); if (l==0){ LOG(L_CRIT, "ERROR: tls: dyn_create_f locking callback out of shm." @@ -104,11 +104,12 @@ static void locking_f(int mode, int n, const char* file, int line) abort(); /* quick crash :-) */ } if (mode & CRYPTO_LOCK){ + LM_DBG("lock get (%d): %d (%s:%d)\n", mode, n, file, line); lock_set_get(static_locks, n); }else{ lock_set_release(static_locks, n); + LM_DBG("lock release (%d): %d (%s:%d)\n", mode, n, file, line); } - } @@ -160,7 +161,7 @@ int tls_init_locks() CRYPTO_set_dynlock_create_callback(dyn_create_f); CRYPTO_set_dynlock_lock_callback(dyn_lock_f); CRYPTO_set_dynlock_destroy_callback(dyn_destroy_f); - + /* starting with v1.0.0 openssl does not use anymore getpid(), but address * of errno which can point to same virtual address in a multi-process * application @@ -172,8 +173,7 @@ int tls_init_locks() * (only atomic_inc), fallback to the default use-locks mode * CRYPTO_set_add_lock_callback(atomic_add_f); */ - - + return 0; error: tls_destroy_locks();

1 0

Vulnerability reporting
by Stelios Tsampas 11 Feb '16

11 Feb '16

Hello all, I would like to report a vulnerability, more specifically a remote heap buffer overflow. Should I report it in this mailing list or somewhere else like the issue tracker in github? Thank you, Stelios Tsampas IT Security Researcher CENSUS S.A.

2 1

git:master:fe7f4117: modules/ims_registrar_pcscf: fix rank for forked process to get DB initialisation (pua) (reverted from commit 02059e32fde2008ed906fa8ff35d79762ac97412)
by jaybeepee 11 Feb '16

11 Feb '16

Module: kamailio Branch: master Commit: fe7f4117536260d0613bc918110f1d0093ad50b9 URL: https://github.com/kamailio/kamailio/commit/fe7f4117536260d0613bc918110f1d0… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-11T10:40:04+02:00 modules/ims_registrar_pcscf: fix rank for forked process to get DB initialisation (pua) (reverted from commit 02059e32fde2008ed906fa8ff35d79762ac97412) --- Modified: modules/ims_registrar_pcscf/reg_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/fe7f4117536260d0613bc918110f1d0… Patch: https://github.com/kamailio/kamailio/commit/fe7f4117536260d0613bc918110f1d0… --- diff --git a/modules/ims_registrar_pcscf/reg_mod.c b/modules/ims_registrar_pcscf/reg_mod.c index 22eecb3..90c3471 100644 --- a/modules/ims_registrar_pcscf/reg_mod.c +++ b/modules/ims_registrar_pcscf/reg_mod.c @@ -315,10 +315,11 @@ static void mod_destroy(void) static int child_init(int rank) { + LM_DBG("Initialization of module in child [%d] \n", rank); if ((subscribe_to_reginfo == 1) && (rank == PROC_MAIN)) { LM_DBG("Creating RegInfo Event Processor process\n"); - int pid = fork_process(1, "RegInfo Event Processor", 1); + int pid = fork_process(PROC_SIPINIT, "RegInfo Event Processor", 1); if (pid < 0) return -1; //error if (pid == 0) {

1 0

git:master:02059e32: modules/ims_registrar_pcscf: fix rank for forked process to get DB initialisation (pua)
by jaybeepee 11 Feb '16

11 Feb '16

Module: kamailio Branch: master Commit: 02059e32fde2008ed906fa8ff35d79762ac97412 URL: https://github.com/kamailio/kamailio/commit/02059e32fde2008ed906fa8ff35d797… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-11T10:36:26+02:00 modules/ims_registrar_pcscf: fix rank for forked process to get DB initialisation (pua) --- Modified: modules/ims_registrar_pcscf/reg_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/02059e32fde2008ed906fa8ff35d797… Patch: https://github.com/kamailio/kamailio/commit/02059e32fde2008ed906fa8ff35d797… --- diff --git a/modules/ims_registrar_pcscf/reg_mod.c b/modules/ims_registrar_pcscf/reg_mod.c index 90c3471..22eecb3 100644 --- a/modules/ims_registrar_pcscf/reg_mod.c +++ b/modules/ims_registrar_pcscf/reg_mod.c @@ -315,11 +315,10 @@ static void mod_destroy(void) static int child_init(int rank) { - LM_DBG("Initialization of module in child [%d] \n", rank); if ((subscribe_to_reginfo == 1) && (rank == PROC_MAIN)) { LM_DBG("Creating RegInfo Event Processor process\n"); - int pid = fork_process(PROC_SIPINIT, "RegInfo Event Processor", 1); + int pid = fork_process(1, "RegInfo Event Processor", 1); if (pid < 0) return -1; //error if (pid == 0) {

1 0

git:master:4f162f84: modules/ims_charging: clean from uri to remove parameters before using as PAI
by jaybeepee 11 Feb '16

11 Feb '16

Module: kamailio Branch: master Commit: 4f162f84f9a4c0c0b843ba73d9f60cc204d012e5 URL: https://github.com/kamailio/kamailio/commit/4f162f84f9a4c0c0b843ba73d9f60cc… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-11T10:35:27+02:00 modules/ims_charging: clean from uri to remove parameters before using as PAI --- Modified: modules/ims_charging/ims_ro.c --- Diff: https://github.com/kamailio/kamailio/commit/4f162f84f9a4c0c0b843ba73d9f60cc… Patch: https://github.com/kamailio/kamailio/commit/4f162f84f9a4c0c0b843ba73d9f60cc… --- diff --git a/modules/ims_charging/ims_ro.c b/modules/ims_charging/ims_ro.c index 0c26ad8..08565bc 100644 --- a/modules/ims_charging/ims_ro.c +++ b/modules/ims_charging/ims_ro.c @@ -1023,6 +1023,7 @@ int Ro_Send_CCR(struct sip_msg *msg, struct dlg_cell *dlg, int dir, int reservat struct session_setup_data *ssd; int ret = 0; struct hdr_field *h = 0; + char *p; int cc_event_number = 0; //According to IOT tests this should start at 0 int cc_event_type = RO_CC_START; @@ -1052,9 +1053,13 @@ int Ro_Send_CCR(struct sip_msg *msg, struct dlg_cell *dlg, int dir, int reservat if ((asserted_identity = cscf_get_asserted_identity(msg, 0)).len == 0) { LM_DBG("No P-Asserted-Identity hdr found. Using From hdr for asserted_identity"); asserted_identity = dlg->from_uri; + if (asserted_identity.len > 0 && asserted_identity.s) { + p=(char*)memchr(asserted_identity.s, ';',asserted_identity.len); + if (p) + asserted_identity.len = (p-asserted_identity.s); + } } - //getting called asserted identity if ((called_asserted_identity = cscf_get_public_identity_from_called_party_id(msg, &h)).len == 0) { LM_DBG("No P-Called-Identity hdr found. Using request URI for called_asserted_identity");

1 0

git:master:0328dda2: modules/ims_charging: changed log line from ERR to DBG
by jaybeepee 11 Feb '16

11 Feb '16

Module: kamailio Branch: master Commit: 0328dda233469873b0e4632f9cd78a20a7dc06c9 URL: https://github.com/kamailio/kamailio/commit/0328dda233469873b0e4632f9cd78a2… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-11T10:34:06+02:00 modules/ims_charging: changed log line from ERR to DBG --- Modified: modules/ims_charging/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/0328dda233469873b0e4632f9cd78a2… Patch: https://github.com/kamailio/kamailio/commit/0328dda233469873b0e4632f9cd78a2… --- diff --git a/modules/ims_charging/dialog.c b/modules/ims_charging/dialog.c index 3ee608b..248f4eb 100644 --- a/modules/ims_charging/dialog.c +++ b/modules/ims_charging/dialog.c @@ -179,7 +179,7 @@ void dlg_terminated(struct dlg_cell *dlg, int type, unsigned int termcode, char* LM_DBG("processing dlg_terminated in Ro and session [%.*s] has active = %d", ro_session->ro_session_id.len, ro_session->ro_session_id.s, ro_session->active); if ((!ro_session->active && (ro_session->start_time != 0)) || (ro_session->ccr_sent == 1)) { unref_ro_session_unsafe(ro_session,1,ro_session_entry); - LM_ERR("CCR already sent or Ro Session is not active, but may have been answered [%d]\n", (int)ro_session->start_time); + LM_DBG("CCR already sent or Ro Session is not active, but may have been answered [%d]\n", (int)ro_session->start_time); ro_session_unlock(ro_session_table, ro_session_entry); return; }

1 0

using ndb_mongodb and command mongodb_cmd insert/increment question
by Boudewyn Ligthart 10 Feb '16

10 Feb '16

Hi, Any pointers on how I would go about inserting /incrementing a document, using a json encoded string using mongodb_cmd Say: Database: kamailio Collection: test Documentid: _id Valuename : beans Value: 1 And increment beans by 2 Thanks, Boudy

1 0

Kamailio SST and Dialog module workings
by Jason Penton 10 Feb '16

10 Feb '16

Hi Kamailio users and Devs. I am interested to know if any of you are using SST module with DIALOG module and sharing the timeout avp between the two - expecting the call to be torn down if no in-dialog requests are processed. If you are using it, is it working as you expect? To me it seems that the timers in the dialog module will never be updated by any in-dialog requests. I just wanted to check before I start looking at fixing... perhaps I am missing something. Cheers Jason

2 2

Release management - /utils
by Olle E. Johansson 10 Feb '16

10 Feb '16

Hi! Some of the database definition files are in /utils and some in /utils/kamctl - shall we move them into one place and if so, which directory is the correct one? These are used by kamdbctl. /O

2 3

git:master:45b0f699: examples: updated ims configs to use ims_dialog module
by Daniel-Constantin Mierla 09 Feb '16

09 Feb '16

Module: kamailio Branch: master Commit: 45b0f6992f1a37107be1d3cfdbdb10b60ac6d1c5 URL: https://github.com/kamailio/kamailio/commit/45b0f6992f1a37107be1d3cfdbdb10b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-02-09T13:26:15+01:00 examples: updated ims configs to use ims_dialog module --- Modified: examples/pcscf/kamailio.cfg Modified: examples/scscf/kamailio.cfg --- Diff: https://github.com/kamailio/kamailio/commit/45b0f6992f1a37107be1d3cfdbdb10b… Patch: https://github.com/kamailio/kamailio/commit/45b0f6992f1a37107be1d3cfdbdb10b… --- diff --git a/examples/pcscf/kamailio.cfg b/examples/pcscf/kamailio.cfg index c2d5f55..53ba1d7 100644 --- a/examples/pcscf/kamailio.cfg +++ b/examples/pcscf/kamailio.cfg @@ -161,7 +161,7 @@ loadmodule "tmx" loadmodule "pv" loadmodule "sl" loadmodule "rr" -loadmodule "dialog_ng" +loadmodule "ims_dialog" loadmodule "ims_usrloc_pcscf" loadmodule "textops" loadmodule "textopsx" @@ -308,11 +308,11 @@ modparam("cdp","config_file","/etc/kamailio/pcscf.xml") modparam("ims_qos", "rx_dest_realm", "NETWORKNAME") #!endif -# -- dialog_ng params -- -modparam("dialog_ng", "dlg_flag", FLT_DIALOG) -modparam("dialog_ng", "timeout_avp", "$avp(DLG_TIMEOUT_AVP)") -modparam("dialog_ng", "detect_spirals", 0) -modparam("dialog_ng", "profiles_no_value", "orig ; term") +# -- ims_dialog params -- +modparam("ims_dialog", "dlg_flag", FLT_DIALOG) +modparam("ims_dialog", "timeout_avp", "$avp(DLG_TIMEOUT_AVP)") +modparam("ims_dialog", "detect_spirals", 0) +modparam("ims_dialog", "profiles_no_value", "orig ; term") #!ifdef WITH_TLS # ----- tls params ----- diff --git a/examples/scscf/kamailio.cfg b/examples/scscf/kamailio.cfg index b8f7a1e..44d392a 100644 --- a/examples/scscf/kamailio.cfg +++ b/examples/scscf/kamailio.cfg @@ -102,7 +102,7 @@ loadmodule "tm.so" loadmodule "pv.so" loadmodule "sl.so" loadmodule "rr.so" -loadmodule "dialog_ng.so" +loadmodule "ims_dialog.so" loadmodule "textops.so" loadmodule "maxfwd.so" loadmodule "xlog.so" @@ -227,11 +227,11 @@ modparam("ims_registrar_scscf", "subscription_max_expires", 605800) # -- CDP params -- modparam("cdp","config_file","/etc/kamailio/scscf.xml") -# -- dialog_ng params -- -modparam("dialog_ng", "dlg_flag", FLT_DIALOG) -modparam("dialog_ng", "timeout_avp", "$avp(DLG_TIMEOUT_AVP)") -modparam("dialog_ng", "detect_spirals", 1) -modparam("dialog_ng", "profiles_no_value", "orig ; term") +# -- ims_dialog params -- +modparam("ims_dialog", "dlg_flag", FLT_DIALOG) +modparam("ims_dialog", "timeout_avp", "$avp(DLG_TIMEOUT_AVP)") +modparam("ims_dialog", "detect_spirals", 1) +modparam("ims_dialog", "profiles_no_value", "orig ; term") #!ifdef WITH_XMLRPC # ----- xmlrpc params -----

1 0

← Newer
1
...
13
14
15
16
17
18
19
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2016