sr-dev February 2016

sr-dev@lists.kamailio.org

28 participants
302 discussions

git:master:f0d0075c: NEWS update with link to 4.4.x
by Olle E. Johansson 13 Feb '16

13 Feb '16

Module: kamailio Branch: master Commit: f0d0075ce8ab15c04eecb3cfc0ce89408a481ce5 URL: https://github.com/kamailio/kamailio/commit/f0d0075ce8ab15c04eecb3cfc0ce894… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2016-02-13T19:02:40+01:00 NEWS update with link to 4.4.x --- Modified: NEWS --- Diff: https://github.com/kamailio/kamailio/commit/f0d0075ce8ab15c04eecb3cfc0ce894… Patch: https://github.com/kamailio/kamailio/commit/f0d0075ce8ab15c04eecb3cfc0ce894… --- diff --git a/NEWS b/NEWS index eb66eca..92a5b82 100644 --- a/NEWS +++ b/NEWS @@ -7,6 +7,7 @@ notes for previous versions are posted below. For releases after 3.1, please visit: +http://www.kamailio.org/wiki/features/new-in-4.4.x http://www.kamailio.org/wiki/features/new-in-4.3.x http://www.kamailio.org/wiki/features/new-in-4.2.x http://www.kamailio.org/wiki/features/new-in-4.1.x

1 0

git:master:00226fa9: ISSUES add link to Github
by Olle E. Johansson 13 Feb '16

13 Feb '16

Module: kamailio Branch: master Commit: 00226fa9cef56e3447068b891b2cb14260ff5423 URL: https://github.com/kamailio/kamailio/commit/00226fa9cef56e3447068b891b2cb14… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2016-02-13T19:01:46+01:00 ISSUES add link to Github --- Modified: ISSUES --- Diff: https://github.com/kamailio/kamailio/commit/00226fa9cef56e3447068b891b2cb14… Patch: https://github.com/kamailio/kamailio/commit/00226fa9cef56e3447068b891b2cb14… --- diff --git a/ISSUES b/ISSUES index f82cfad..e1c1a7c 100644 --- a/ISSUES +++ b/ISSUES @@ -1,4 +1,9 @@ -# +This file is here for old time's sake. +Current set of issues is to be found at our +Github Project page: +https://github.com/kamailio/kamailio/issues +-------------------------------------------------------------- + This is a collection of issues which have shown up since the version 0.8.8 was released. The issues are

1 0

[kamailio] registrar: Custom socket string for location table (related to pr #470) (#471)
by Ian Yu-Hsun Lin 13 Feb '16

13 Feb '16

# Environment Kamailio-433 installed behind nat (Amazon EC2 or Google Compute Engine) using config ```cfg listen=PRIVATE_IP:PORT advertise PUBLIC_IP:PORT ``` # What I wanted to do In table `location`, the column `socket` will be stored in the form of "PROTO:**PRIVATE_IP**:PORT" while for some reasons I would like it to be stored as "PROTO:**PUBLIC_IP**:PORT" Through the `registrar` document there is the [xavp_cfg](http://wwwkamailioorg/docs/modules/43x/modules/registrarhtml#registrarpxavp_cfg) parameter that can be used in conjunction with the attribute "socket" to specify the socket string From my understanding this might be the solution to my requirement # Problem The column `location``socket` wasn't changed when setting the custom socket string via `xavp_cfg` After looking into the source code, firstly, a potential bug (correct me if I'm wrong) that it would reset the `sock_flag` to -1 (no flags) even if `reg_xavp_cfg` and `sock_flag` is set A pull request #470 has been opened for this Secondly, if we pass the above problem, in `savec` it did grab the socket string from xavp_cfg and in function `grep_sock_info()` the socket string was checked with all the address we listen on, including the advertised public address via `socket_info->useinfo` But the returned socket structure still contains the private address info # Conclusion so far So, I wasn't sure if using the parameter `xavp_cfg` for setting socket string and stores it in location table make sense or not If yes, can you please giving me some hints about the potential way to extend this? Cheers, Ian --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/471

2 4

git:master:097637b2: INSTALL Remove flavours and ser/serctl
by Olle E. Johansson 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: 097637b2be779f9bfc0a6fa18dca3c271e35d8b1 URL: https://github.com/kamailio/kamailio/commit/097637b2be779f9bfc0a6fa18dca3c2… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2016-02-12T21:53:30+01:00 INSTALL Remove flavours and ser/serctl --- Modified: INSTALL --- Diff: https://github.com/kamailio/kamailio/commit/097637b2be779f9bfc0a6fa18dca3c2… Patch: https://github.com/kamailio/kamailio/commit/097637b2be779f9bfc0a6fa18dca3c2…

1 0

git:master:56623341: readme minor updates
by Olle E. Johansson 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: 56623341c765c298cae8c3353d2ebacd81f00070 URL: https://github.com/kamailio/kamailio/commit/56623341c765c298cae8c3353d2ebac… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2016-02-12T21:36:39+01:00 readme minor updates --- Modified: README.md --- Diff: https://github.com/kamailio/kamailio/commit/56623341c765c298cae8c3353d2ebac… Patch: https://github.com/kamailio/kamailio/commit/56623341c765c298cae8c3353d2ebac…

1 0

PUA issue when UA is not using UDP
by Phil Lavin 12 Feb '16

12 Feb '16

A number of additional ports have been opened on Kamailio - the relevant one here is TCP 443. An INVITE comes in from a UA whose from URI is suffixed with :443. PUA generates a PUBLISH out of this. Log is at https://gist.githubusercontent.com/phil-lavin/c381d556c22fd29b4fde/raw/77c5…. The relevant bit to the issue is the last line. PUA is trying to send the PUBLISH to the address and port taken from the from URI... however it sends it over UDP. Because Kamailio is not bound to UDP 443, the PUBLISH is not received. A hacky "fix" is to make Kamailio bind to UDP 443 as well as TCP 443. I will dig into this deeper on Monday in an attempt to find a better fix. Suggestions around what is the best solution would be appreciated. I'm thinking that sending this over TCP is not desirable in most instances - unless perhaps Kamailio is only bound to TCP ports? Cheers

1 0

git:master:d7e42cee: modules/ims_registrar_scscf: fixed segfault on multiple impu when building notify
by jaybeepee 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: d7e42ceef76e66b06d97159e71043fd552a29e8c URL: https://github.com/kamailio/kamailio/commit/d7e42ceef76e66b06d97159e71043fd… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-12T20:48:14+02:00 modules/ims_registrar_scscf: fixed segfault on multiple impu when building notify - also reported and fixed by Dragos Oancea --- Modified: modules/ims_registrar_scscf/registrar_notify.c --- Diff: https://github.com/kamailio/kamailio/commit/d7e42ceef76e66b06d97159e71043fd… Patch: https://github.com/kamailio/kamailio/commit/d7e42ceef76e66b06d97159e71043fd… --- diff --git a/modules/ims_registrar_scscf/registrar_notify.c b/modules/ims_registrar_scscf/registrar_notify.c index df1f0b1..70eb978 100644 --- a/modules/ims_registrar_scscf/registrar_notify.c +++ b/modules/ims_registrar_scscf/registrar_notify.c @@ -2006,9 +2006,9 @@ reg_notification * new_notification(str subscription_state, char *p; len = sizeof (reg_notification) + r->call_id.len + r->from_tag.len + r->to_tag.len + r->watcher_uri.len + r->watcher_contact.len + - r->record_route.len + r->sockinfo_str.len + r->presentity_uri.len + subscription_state.len + content_type.len + (num_impus*sizeof(str)); // + buf.len; + r->record_route.len + r->sockinfo_str.len + r->presentity_uri.len + subscription_state.len + content_type.len + (num_impus)*sizeof(str); // + buf.len; for (i=0; i<num_impus; i++) { - len += impus[i]->len; + len += (*impus)[i].len; } LM_DBG("Creating new notification"); @@ -2084,13 +2084,13 @@ reg_notification * new_notification(str subscription_state, p += content_type.len; LM_DBG("Notification content type: [%.*s]", n->content_type.len, n->content_type.s); - n->impus = p; + n->impus = (str*)p; p += sizeof(str)*num_impus; for (i=0; i<num_impus; i++) { n->impus[i].s = p; - memcpy(p, impus[i]->s, impus[i]->len); - n->impus[i].len = impus[i]->len; - p += impus[i]->len; + memcpy(p, (*impus)[i].s, (*impus)[i].len); + n->impus[i].len = (*impus)[i].len; + p += (*impus)[i].len; } n->num_impus = num_impus;

1 0

git:master:63b4561d: modules/ims_dialog: remove double unref on dialog
by jaybeepee 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: 63b4561d8d764700e0e380448d366b7f31bd2a02 URL: https://github.com/kamailio/kamailio/commit/63b4561d8d764700e0e380448d366b7… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-12T20:40:54+02:00 modules/ims_dialog: remove double unref on dialog --- Modified: modules/ims_dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/63b4561d8d764700e0e380448d366b7… Patch: https://github.com/kamailio/kamailio/commit/63b4561d8d764700e0e380448d366b7… --- diff --git a/modules/ims_dialog/dlg_handlers.c b/modules/ims_dialog/dlg_handlers.c index ba38de8..1bdb3d0 100644 --- a/modules/ims_dialog/dlg_handlers.c +++ b/modules/ims_dialog/dlg_handlers.c @@ -1417,7 +1417,6 @@ void dlg_onreply(struct cell* t, int type, struct tmcb_params *param) { counter_inc(dialog_ng_cnts_h.active); - if (unref) unref_dlg(dlg, unref); goto done; }

1 0

git:master:6620a447: modules/ims_usrloc_scscf: added support for UE types required by registrar
by jaybeepee 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: 6620a44738c68d035991df51cb915142a5d965a6 URL: https://github.com/kamailio/kamailio/commit/6620a44738c68d035991df51cb91514… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-12T20:28:49+02:00 modules/ims_usrloc_scscf: added support for UE types required by registrar --- Modified: modules/ims_usrloc_scscf/ucontact.c Modified: modules/ims_usrloc_scscf/usrloc.h --- Diff: https://github.com/kamailio/kamailio/commit/6620a44738c68d035991df51cb91514… Patch: https://github.com/kamailio/kamailio/commit/6620a44738c68d035991df51cb91514… --- diff --git a/modules/ims_usrloc_scscf/ucontact.c b/modules/ims_usrloc_scscf/ucontact.c index de0477b..971cf88 100644 --- a/modules/ims_usrloc_scscf/ucontact.c +++ b/modules/ims_usrloc_scscf/ucontact.c @@ -114,6 +114,10 @@ ucontact_t* new_ucontact(str* _dom, str* _aor, str* _contact, ucontact_info_t* _ /*Copy parameter list into shm**/ param = _ci->params; while(param) { + LM_DBG("Checking param [%.*s]\n", param->name.len, param->name.s); + if (param->name.len == 16 && (memcmp(param->name.s, "+g.3gpp.icsi-ref", 16)==0)) { + c->is_3gpp = 1; + } /*Copy first param in curr*/ curr = shm_malloc(sizeof (param_t)); curr->len = param->len; diff --git a/modules/ims_usrloc_scscf/usrloc.h b/modules/ims_usrloc_scscf/usrloc.h index 2b5bf87..2f7c0b9 100644 --- a/modules/ims_usrloc_scscf/usrloc.h +++ b/modules/ims_usrloc_scscf/usrloc.h @@ -151,6 +151,8 @@ typedef enum contact_state { /*! \brief Valid contact is a contact that either didn't expire yet or is permanent */ #define VALID_CONTACT(c, t) (((c->expires>t) || (c->expires==0)) && c->state!=CONTACT_DELETED && c->state!=CONTACT_DELETE_PENDING && c->state!=CONTACT_EXPIRE_PENDING_NOTIFY) +#define VALID_UE_TYPE(c, t) ((t==0) || (t==1 && c->is_3gpp) || (t==2 && !c->is_3gpp)) + struct hslot; /*!< Hash table slot */ struct socket_info; @@ -298,6 +300,7 @@ typedef struct ucontact { struct contact_hslot* slot; /*!< Collision slot in the hash table array we belong to */ unsigned int sl; /*!< Hash slot number we belong to */ int ref_count; + int is_3gpp; contact_state_t state; str domain; /*!< Pointer to domain name (NULL terminated) */ str aor; /*!< Pointer to the AOR string in record structure*/

1 0

git:master:1f8c8ef2: Revert "modules/ims_registrar_scscf: new function to pass extra argument to lookup (ue_type)"
by jaybeepee 12 Feb '16

12 Feb '16

Module: kamailio Branch: master Commit: 1f8c8ef2a68a380724b12d035b1d73705546dc8f URL: https://github.com/kamailio/kamailio/commit/1f8c8ef2a68a380724b12d035b1d737… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-02-12T20:13:59+02:00 Revert "modules/ims_registrar_scscf: new function to pass extra argument to lookup (ue_type)" This reverts commit 574b8d6c2d0897ba69c5eec14775350508ad0778. --- Modified: modules/ims_registrar_scscf/registrar_notify.h --- Diff: https://github.com/kamailio/kamailio/commit/1f8c8ef2a68a380724b12d035b1d737… Patch: https://github.com/kamailio/kamailio/commit/1f8c8ef2a68a380724b12d035b1d737… --- diff --git a/modules/ims_registrar_scscf/registrar_notify.h b/modules/ims_registrar_scscf/registrar_notify.h index 1d83286..f3d5ac1 100644 --- a/modules/ims_registrar_scscf/registrar_notify.h +++ b/modules/ims_registrar_scscf/registrar_notify.h @@ -72,14 +72,12 @@ typedef struct _reg_notification { int num_impus; unsigned int local_cseq; - unsigned int reginfo_s_version; str call_id; str from_tag; str to_tag; str record_route; str sockinfo_str; - struct _reg_notification *next; /**< next notification in the list */ struct _reg_notification *prev; /**< previous notification in the list */ } reg_notification; @@ -134,7 +132,7 @@ str generate_reginfo_full(udomain_t* _t, str* impu_list, int new_subscription); str get_reginfo_partial(impurecord_t *r, ucontact_t *c, int event_type); -void create_notifications(udomain_t* _t, impurecord_t* r_passed, str *presentity_uri, str *watcher_contact, str* impus, int num_impus, int event_type); +void create_notifications(udomain_t* _t, impurecord_t* r_passed, str *presentity_uri, str *watcher_contact, str** impus, int num_impus, int event_type); void notification_event_process();

1 0

← Newer
1
...
10
11
12
13
14
15
16
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2016