sr-dev December 2015

sr-dev@lists.kamailio.org

30 participants
230 discussions

git:master:d24863d0: presence: init variable to prevent invalid cleanup on error getting presence document

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d24863d071417effe5df863736ef037ec8e0b414 URL: https://github.com/kamailio/kamailio/commit/d24863d071417effe5df863736ef037… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-12-14T16:43:05+01:00 presence: init variable to prevent invalid cleanup on error getting presence document - reported by GH#441 --- Modified: modules/presence/publish.c --- Diff: https://github.com/kamailio/kamailio/commit/d24863d071417effe5df863736ef037… Patch: https://github.com/kamailio/kamailio/commit/d24863d071417effe5df863736ef037… --- diff --git a/modules/presence/publish.c b/modules/presence/publish.c index 5a48f77..73a64c6 100644 --- a/modules/presence/publish.c +++ b/modules/presence/publish.c @@ -509,7 +509,7 @@ int handle_publish(struct sip_msg* msg, char* sender_uri, char* str2) int update_hard_presentity(str *pres_uri, pres_ev_t *event, str *file_uri, str *filename) { int ret = -1, new_t, pidf_result; - str *pidf_doc; + str *pidf_doc = 0; char *sphere = NULL; presentity_t *pres = NULL; struct sip_uri parsed_uri;

9 years

[kamailio] crash on using http_query (#432)

by jayesh1017

tried doing a post on a https URL and kamailio crashes as soon as it receives a 200 response. Kamailio continues processing the response is error but on a successful response it crashes. Here's the backtrace from the core: 0x00007f62f2bf8e38 in ?? () #1 0x00007f62ea22251b in http_query (_m=0x7f62f2c3a038, _url=0x7f62f2bf3548 "\330\064\277\362b\177", _dst=0x7f62f2bf9250 "\030\215\277\362b\177", _post=0x7f62f2bf35c8 "\200r\277\362b\177", _hdr=0x7f62f2bf91d0 "h\221\277\362b\177") at functions.c:226 #2 0x00007f62ea229e0b in w_http_query_post_hdr (_m=0x7f62f2c3a038, _url=0x7f62f2bf3548 "\330\064\277\362b\177", _post=0x7f62f2bf35c8 "\200r\277\362b\177", _hdr=0x7f62f2bf91d0 "h\221\277\362b\177", _result=0x7f62f2bf9250 "\030\215\277\362b\177") at utils.c:483 #3 0x000000000041f6b5 in do_action (h=0x7ffeb128c8c0, a=0x7f62f2bf8a58, msg=0x7f62f2c3a038) at action.c:1079 #4 0x000000000042c2ea in run_actions (h=0x7ffeb128c8c0, a=0x7f62f2bf6fc0, msg=0x7f62f2c3a038) at action.c:1549 #5 0x000000000041f3ce in do_action (h=0x7ffeb128c8c0, a=0x7f62f2bfb9b0, msg=0x7f62f2c3a038) at action.c:1045 #6 0x000000000042c2ea in run_actions (h=0x7ffeb128c8c0, a=0x7f62f2bb9388, msg=0x7f62f2c3a038) at action.c:1549 #7 0x000000000041bc28 in do_action (h=0x7ffeb128c8c0, a=0x7f62f2b8f248, msg=0x7f62f2c3a038) at action.c:678 #8 0x000000000042c2ea in run_actions (h=0x7ffeb128c8c0, a=0x7f62f2b8e268, msg=0x7f62f2c3a038) at action.c:1549 #9 0x000000000041f3ce in do_action (h=0x7ffeb128c8c0, a=0x7f62f2b91040, msg=0x7f62f2c3a038) at action.c:1045 #10 0x000000000042c2ea in run_actions (h=0x7ffeb128c8c0, a=0x7f62f2b8b7a8, msg=0x7f62f2c3a038) at action.c:1549 #11 0x000000000041bc28 in do_action (h=0x7ffeb128c8c0, a=0x7f62f2b3a2c0, msg=0x7f62f2c3a038) at action.c:678 #12 0x000000000042c2ea in run_actions (h=0x7ffeb128c8c0, a=0x7f62f2b3a2c0, msg=0x7f62f2c3a038) at action.c:1549 #13 0x000000000041f3ce in do_action (h=0x7ffeb128c8c0, a=0x7f62f2b47f00, msg=0x7f62f2c3a038) at action.c:1045 #14 0x000000000042c2ea in run_actions (h=0x7ffeb128c8c0, a=0x7f62f2b37e80, msg=0x7f62f2c3a038) at action.c:1549 #15 0x000000000041bc28 in do_action (h=0x7ffeb128c8c0, a=0x7f62f2b1c9c8, msg=0x7f62f2c3a038) at action.c:678 #16 0x000000000042c2ea in run_actions (h=0x7ffeb128c8c0, a=0x7f62f2b1c9c8, msg=0x7f62f2c3a038) at action.c:1549 #17 0x000000000041f3ce in do_action (h=0x7ffeb128c8c0, a=0x7f62f2b1cc28, msg=0x7f62f2c3a038) at action.c:1045 #18 0x000000000042c2ea in run_actions (h=0x7ffeb128c8c0, a=0x7f62f2b170a0, msg=0x7f62f2c3a038) at action.c:1549 #19 0x000000000042ca93 in run_top_route (a=0x7f62f2b170a0, msg=0x7f62f2c3a038, c=0x0) at action.c:1635 #20 0x000000000051c115 in receive_msg ( buf=0xab7520 <buf> "INVITE sip:bdbbf600000001b5b919d0 at devsip.abcd.com:8321 SIP/2.0\r\nRecord-Route: <sip:203.153.53.145:8300;r2=on;lr=on>\r\nRecord-Route: <sip:203.153.53.145:8321;transport=tcp;r2=on;lr=on>\r\nVia: SIP/2.0/UDP"..., len=1901, rcv_info=0x7ffeb128cc10) at receive.c:196 #21 0x000000000062d427 in udp_rcv_loop () at udp_server.c:495 #22 0x00000000004b28c1 in main_loop () at main.c:1593 #23 0x00000000004b9aa5 in main (argc=5, argv=0x7ffeb128d118) at main.c:2597 --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/432

9 years

git:master:09be0ae1: Merge pull request #442 from smititelu/KAMAILIO-30

by Stefan Mititelu

Module: kamailio Branch: master Commit: 09be0ae191404409322bb5d8ab9df0a03c1a4845 URL: https://github.com/kamailio/kamailio/commit/09be0ae191404409322bb5d8ab9df0a… Author: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Date: 2015-12-14T17:00:46+02:00 Merge pull request #442 from smititelu/KAMAILIO-30 Better counting of received_replies counter --- Modified: modules/tm/t_reply.c Modified: modules/tm/t_stats.c Modified: modules/tm/t_stats.h Modified: modules/tmx/doc/tmx_admin.xml Modified: modules/tmx/tmx_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/09be0ae191404409322bb5d8ab9df0a… Patch: https://github.com/kamailio/kamailio/commit/09be0ae191404409322bb5d8ab9df0a…

9 years

git:master:572fa1b4: tmx: Update doku

by Stefan Mititelu

Module: kamailio Branch: master Commit: 572fa1b4497571ec68453c97b3080740364d3335 URL: https://github.com/kamailio/kamailio/commit/572fa1b4497571ec68453c97b308074… Author: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Date: 2015-12-14T15:02:53+02:00 tmx: Update doku Update doku related to the counters changes. --- Modified: modules/tmx/doc/tmx_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/572fa1b4497571ec68453c97b308074… Patch: https://github.com/kamailio/kamailio/commit/572fa1b4497571ec68453c97b308074… --- diff --git a/modules/tmx/doc/tmx_admin.xml b/modules/tmx/doc/tmx_admin.xml index 65de597..705113f 100644 --- a/modules/tmx/doc/tmx_admin.xml +++ b/modules/tmx/doc/tmx_admin.xml @@ -626,72 +626,105 @@ event_route [tm:branch-failure:contact] { Exported statistics are listed in the next sections. All statistics except <quote>inuse_transactions</quote> can be reset. </para> - <section> - <title>received_replies</title> - <para> - Total number of total replies received by TM module. - </para> - </section> - <section> - <title>relayed_replies</title> - <para> - Total number of replies received and relayed by TM module. - </para> - </section> - <section> - <title>local_replies</title> - <para> - Total number of replies local generated by TM module. - </para> - </section> + <section> <title>UAS_transactions</title> <para> Total number of transactions created by received requests. </para> </section> + <section> <title>UAC_transactions</title> <para> Total number of transactions created by local generated requests. </para> </section> + <section> <title>2xx_transactions</title> <para> Total number of transactions completed with 2xx replies. </para> </section> + <section> <title>3xx_transactions</title> <para> Total number of transactions completed with 3xx replies. </para> </section> + <section> <title>4xx_transactions</title> <para> Total number of transactions completed with 4xx replies. </para> </section> + <section> <title>5xx_transactions</title> <para> Total number of transactions completed with 5xx replies. </para> </section> + <section> <title>6xx_transactions</title> <para> Total number of transactions completed with 6xx replies. </para> </section> + <section> <title>inuse_transactions</title> <para> Number of transactions existing in memory at current time. </para> </section> + + <section> + <title>active_transactions</title> + <para> + Number of ongoing transactions at current time. + </para> + </section> + + <section> + <title>received_replies</title> + <para> + Total number of replies received by TM module. + </para> + </section> + + <section> + <title>received_replies_absorbed</title> + <para> + Total number of replies received and not relayed by TM module. + </para> + </section> + + <section> + <title>tmx:relayed_locally</title> + <para> + Total number of replies locally generated and relayed by TM module. + </para> + </section> + + <section> + <title>relayed_received </title> + <para> + Total number of replies received and relayed by TM module. + </para> + </section> + + <section> + <title>relayed_total</title> + <para> + Total number of replies relayed by TM module. + </para> + </section> + </section> </chapter>

9 years

git:master:aeb3e185: tmx: refactor counters

by Stefan Mititelu

Module: kamailio Branch: master Commit: aeb3e18527b565f22bd05f6c6989b2ae86968b71 URL: https://github.com/kamailio/kamailio/commit/aeb3e18527b565f22bd05f6c6989b2a… Author: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Date: 2015-12-14T13:54:25+02:00 tmx: refactor counters Focus on: - received_replies - received_replies_absorbed (in cfX cases) - relayed_locally - relayed_received - relayed_total --- Modified: modules/tm/t_reply.c Modified: modules/tm/t_stats.c Modified: modules/tm/t_stats.h Modified: modules/tmx/tmx_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/aeb3e18527b565f22bd05f6c6989b2a… Patch: https://github.com/kamailio/kamailio/commit/aeb3e18527b565f22bd05f6c6989b2a…

9 years

[kamailio] Better counting of received_replies counter (#442)

by Stefan Mititelu

Consider the simple basic dialog scenario: ``` Messages INVITE ----------> 1 407 <---------- 1 ACK ----------> 1 INVITE ----------> 1 100 <---------- 1 180 <---------- 1 183 <---------- 0 200 <---------- 1 ACK ----------> 1 Pause [ 7000ms] 1 BYE ----------> 1 200 <---------- 1 ``` Before this patch: ``` tmx:local_replies = 1 tmx:received_replies = 2 tmx:relayed_replies = 3 ``` After this patch: ``` tmx:received_replies = 3 tmx:received_replies_absorbed = 0 tmx:relayed_locally = 1 tmx:relayed_received = 3 tmx:relayed_total = 4 ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/442 -- Commit Summary -- * tmx: refactor counters * tmx: Update doku -- File Changes -- M modules/tm/t_reply.c (15) M modules/tm/t_stats.c (9) M modules/tm/t_stats.h (17) M modules/tmx/doc/tmx_admin.xml (69) M modules/tmx/tmx_mod.c (38) -- Patch Links -- https://github.com/kamailio/kamailio/pull/442.patch https://github.com/kamailio/kamailio/pull/442.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/442

9 years

git:master:4d89a505: tm: avoiding conditional directives that split up parts of statements

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 4d89a50544324fdac0f08497dc142c171bfcd97d URL: https://github.com/kamailio/kamailio/commit/4d89a50544324fdac0f08497dc142c1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-12-14T15:15:52+01:00 tm: avoiding conditional directives that split up parts of statements - patch by Romero Malaquias, FS#434 --- Modified: modules/tm/t_fwd.c --- Diff: https://github.com/kamailio/kamailio/commit/4d89a50544324fdac0f08497dc142c1… Patch: https://github.com/kamailio/kamailio/commit/4d89a50544324fdac0f08497dc142c1… --- diff --git a/modules/tm/t_fwd.c b/modules/tm/t_fwd.c index 9cd002f..15f0969 100644 --- a/modules/tm/t_fwd.c +++ b/modules/tm/t_fwd.c @@ -146,6 +146,7 @@ static int prepare_new_uac( struct cell *t, struct sip_msg *i_req, str ua_bak; int free_ua; int backup_route_type; + int test_dst; snd_flags_t fwd_snd_flags_bak; snd_flags_t rpl_snd_flags_bak; struct socket_info *force_send_socket_bak; @@ -427,14 +428,14 @@ static int prepare_new_uac( struct cell *t, struct sip_msg *i_req, if (likely(next_hop!=0 || (flags & UAC_DNS_FAILOVER_F))){ /* next_hop present => use it for dns resolution */ #ifdef USE_DNS_FAILOVER - if (uri2dst2(&t->uac[branch].dns_h, dst, fsocket, snd_flags, - next_hop?next_hop:uri, fproto) == 0) + test_dst = (uri2dst2(&t->uac[branch].dns_h, dst, fsocket, snd_flags, + next_hop?next_hop:uri, fproto) == 0); #else /* dst filled from the uri & request (send_socket) */ - if (uri2dst2(dst, fsocket, snd_flags, - next_hop?next_hop:uri, fproto)==0) + test_dst = (uri2dst2(dst, fsocket, snd_flags, + next_hop?next_hop:uri, fproto)==0); #endif - { + if (test_dst){ ret=E_BAD_ADDRESS; goto error01; }

9 years

[kamailio] Avoiding conditional directives that split up parts of statements. (#434)

by Romero B. de S. Malaquias

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/434 -- Commit Summary -- * Avoiding conditional directives that split up parts of statements. -- File Changes -- M modules/tm/t_fwd.c (11) -- Patch Links -- https://github.com/kamailio/kamailio/pull/434.patch https://github.com/kamailio/kamailio/pull/434.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/434

9 years

[kamailio] htable: fixing htable.stats for max slot value (#436)

by Dmitri Savolainen

add missed 'd' parameter to rpc->struct_add format string before patch ``` [root@sw4 kamailio]# kamcmd htable.stats { name: some_htable slots: 4096 all: 285304 min: 43 } ``` after patch ``` [root@sw4 kamailio]# kamcmd htable.stats { name: some_htable slots: 4096 all: 285304 min: 43 max: 103 } ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/436 -- Commit Summary -- * htable: fixing htable.stats for max slot value -- File Changes -- M modules/htable/htable.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/436.patch https://github.com/kamailio/kamailio/pull/436.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/436

9 years

git:master:aa50c18b: Merge pull request #436 from snen/htable_stats_fixing

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: aa50c18b724a25f772a1fefdec3b9d260b7c6dbf URL: https://github.com/kamailio/kamailio/commit/aa50c18b724a25f772a1fefdec3b9d2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-12-14T15:11:09+01:00 Merge pull request #436 from snen/htable_stats_fixing htable: fixing htable.stats for max slot value --- Modified: modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/aa50c18b724a25f772a1fefdec3b9d2… Patch: https://github.com/kamailio/kamailio/commit/aa50c18b724a25f772a1fefdec3b9d2… --- diff --git a/modules/htable/htable.c b/modules/htable/htable.c index 7f55be1..80764f3 100644 --- a/modules/htable/htable.c +++ b/modules/htable/htable.c @@ -1125,7 +1125,7 @@ static void htable_rpc_stats(rpc_t* rpc, void* c) ht_slot_unlock(ht, i); } - if(rpc->struct_add(th, "Sddd", + if(rpc->struct_add(th, "Sdddd", "name", &ht->name, /* str */ "slots", (int)ht->htsize, /* uint */ "all", (int)all, /* uint */

9 years

← Newer
1
...
14
15
16
17
18
19
20
...
23
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2015