Fixes linkage for Ubuntu Wily (15.10).
The issue manifests itself as "undefined symbol: SHA1" error at module loading.
In Ubuntu 14 LTS (Trusty), ```pkg-config --libs libssl``` returns ```-lssl -lcrypto```, but in Ubuntu 15.10 (Wily) it returns only ```-lssl```. In the end, websocket.so gets SHA1 symbol (and some more) unresolved.
For unclear reason, this change is not needed for tls.so - it gets linked to libcrypto automatically, despite it is linked only with ```-lssl``` flag. Maybe it is something symbol-specific, or something I am completely unaware of.
SSL_BUILDER stuff in Makefile seems to become even more mostruous with the proposed change. Keep in mind that there is ~5 more modules with identical construction in their Makefiles. Rejection of this patch in favor of cleaner solution is appreciated.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/439
-- Commit Summary --
* modules/websocket: ensure linkage to libcrypto
-- File Changes --
M modules/websocket/Makefile (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/439.patchhttps://github.com/kamailio/kamailio/pull/439.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/439
- Fix invalid check of uri and postdata parameters
- Fix fixup functions
- Refactor curl function to remove dependance on pv/fixup structures
- Export curl_connect through C API
- Fix buffer overflow in curl write function
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/435
-- Commit Summary --
* Fixes and improvements to curl module
-- File Changes --
M modules/curl/curl.c (172)
A modules/curl/curl_api.c (12)
A modules/curl/curl_api.h (36)
M modules/curl/functions.c (202)
M modules/curl/functions.h (10)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/435.patchhttps://github.com/kamailio/kamailio/pull/435.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/435
Module: kamailio
Branch: master
Commit: a3c212f2489e4ba01c7592f68cd35fdb8e16ce71
URL: https://github.com/kamailio/kamailio/commit/a3c212f2489e4ba01c7592f68cd35fd…
Author: Olle E. Johansson <oej(a)edvina.net>
Committer: Olle E. Johansson <oej(a)edvina.net>
Date: 2015-12-15T11:13:21+01:00
Fixing typo, adding copyright header
---
Modified: modules/curl/curl_api.h
---
Diff: https://github.com/kamailio/kamailio/commit/a3c212f2489e4ba01c7592f68cd35fd…
Patch: https://github.com/kamailio/kamailio/commit/a3c212f2489e4ba01c7592f68cd35fd…
---
diff --git a/modules/curl/curl_api.h b/modules/curl/curl_api.h
index cc61069..362b625 100644
--- a/modules/curl/curl_api.h
+++ b/modules/curl/curl_api.h
@@ -1,4 +1,31 @@
-#ifndef _CURL_CPI_H_
+/*
+ * Copyright (C) 2015 Hugh Waite
+ *
+ * This file is part of Kamailio, a free SIP server.
+ *
+ * Kamailio is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version
+ *
+ * Kamailio is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ *
+ */
+
+/*!
+ * \file
+ * \brief Kamailio curl :: Core API include file
+ * \ingroup curl
+ * Module: \ref curl
+ */
+#ifndef _CURL_API_H_
#define _CURL_API_H_
#include "../../sr_module.h"
After credit limit reached(ims_charging), tried to send BYE to both legs in kamailo (modules/dialog_ng/dlg_req_within.c).Bye sent to caller, but when sending bye to callee it is failing.(it is considering record-routes from caller invite, not in 200 OK from callee).Is there any changes necessary?
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/437