sr-dev August 2014

sr-dev@lists.kamailio.org

25 participants
196 discussions

[tracker] Task opened: force_send_socket in event route tm:local-request
by sip-router 21 Aug '14

21 Aug '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Kristian Høgh (kfhdk) Attached to Project - sip-router Summary - force_send_socket in event route tm:local-request Task Type - Improvement Category - Core Status - Unconfirmed Assigned To - Operating System - All Severity - Low Priority - Normal Reported Version - 4.0 Due in Version - Undecided Due Date - Undecided Details - Would it be possible to use force_send_socket in event route tm:local-request? In our setup we use a public IP for "normal" traffic and pua (for dialoginfo) uses outbound_proxy on other/private interface. Or could it be possible to set: * mhomed per module? * Auto "mhomed=1" on pua, when outbound_proxy is set, and kamailio listens on multiple interfaces? * Add "outbound_socket" module parameter on pua * A "much better solution"(tm) than the above Regards, Kristian Høgh Uni-tel On 21/08/14 12:00, Kristian F. Høgh wrote: > Hi, > > Our kamailio 4.0.6 proxy uses pua/pua_dialoginfo and an external presence server. > The PUBLISH requests generated by pua* appear in tm:local-request event route. > > Before sending, we call set_advertised_address and force_send_socket. > Still the requests have the IP address from the first "listen=" as source and Via address. > The requests are send out using the correct interface and no errors are logged. > > When forwarding SUBSCRIBE requests received from clients, force_send_socket before t_relay_to_udp do work as expected. > > mhomed=1 solves the issue, but I prefer force_send_socket. > > Regards, > Kristian Høgh > Uni-tel Hello, I think the ougoing request is already created in that event route, the set advertise address being used too late from that perspective -- however, there is no hook before to set it. Open an enhancement issue on the tracker not to forget about it and I will check to see if there is a possibility to add this feature. Cheers, Daniel More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=462 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: core: call onsend_route for replies
by Lucian Balaceanu 21 Aug '14

21 Aug '14

Module: sip-router Branch: master Commit: cd335addc40f358b6b80bfa5b9df8b468319838a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cd335ad… Author: lucian balanceanu <lucian.balanceanu(a)1and1.ro> Committer: lucian balanceanu <lucian.balanceanu(a)1and1.ro> Date: Thu Aug 21 10:02:49 2014 +0300 core: call onsend_route for replies - this feature is aimed at tracing replies with sip_trace; e.g.: onsend_route { sip_trace("sip:10.84.1.49:5060"); } would now trace the requests passing Kamailio, as well as the replies; This patch has been proposed earlier: http://lists.sip-router.org/pipermail/sr-users/2012-May/073250.html --- forward.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/forward.c b/forward.c index e4af439..849325f 100644 --- a/forward.c +++ b/forward.c @@ -856,6 +856,17 @@ static int do_forward_reply(struct sip_msg* msg, int mode) STATS_RPL_FWD_DROP(); goto error; } + /* call onsend_route */ + if(dst.send_sock == NULL) { + dst.send_sock=get_send_socket(msg, &dst.to, dst.proto); + if (dst.send_sock==0){ + LOG(L_ERR, "forward_reply: ERROR: cannot forward reply\n"); + goto done; + } + } + run_onsend(msg, &dst, new_buf, new_len); + + done: #ifdef STATS STATS_TX_RESPONSE( (msg->first_line.u.reply.statuscode/100) ); #endif

1 0

sipcapture: Retry writing to homer database in case the first attempt fails
by Lucian Balaceanu 20 Aug '14

20 Aug '14

Hi, We would like to propose a patch for the sipcapture module where we retry a write to the homer database in case the first attempt fails. This proves useful under heavy loads. We add the insert_retries parameter to limit the maximum number of write retries and also the insert_retry_timeout as a time limit for the retry. Thank you, Lucian Balaceanu

3 3

git:master: sipcapture: retry insert in DB on initial failure
by Lucian Balaceanu 20 Aug '14

20 Aug '14

Module: sip-router Branch: master Commit: e88b500f8fb6077ac17e5413ffe8770d72e5c6ac URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e88b500… Author: lucian balanceanu <lucian.balanceanu(a)1and1.ro> Committer: lucian balanceanu <lucian.balanceanu(a)1and1.ro> Date: Wed Aug 20 18:08:03 2014 +0300 sipcapture: retry insert in DB on initial failure - added insert_retries and insert_retry_timeout parameters, which control how many times and for how long Kamailio should try to rewrite to the Homer database in case the first attempt fails; trying to rewrite proves useful especially in heavy load scenarios. --- modules/sipcapture/README | 173 ++++++++++++++++++--------- modules/sipcapture/doc/sipcapture_admin.xml | 42 +++++++ modules/sipcapture/sipcapture.c | 64 +++++++--- 3 files changed, 204 insertions(+), 75 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=e88…

1 0

next release?
by Juha Heinanen 20 Aug '14

20 Aug '14

is there any planned date for release or freeze of next version (4.2?) of kamailio? -- juha

3 3

git:4.1: debugger: fix reset_msgid
by Victor Seva 20 Aug '14

20 Aug '14

Module: sip-router Branch: 4.1 Commit: 2fd085d21fb1a026d31d98541a9e33c568245771 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2fd085d… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Tue Aug 19 17:21:57 2014 +0200 debugger: fix reset_msgid Don't change the msg->id when that message has been processed already (cherry picked from commit 6b2f7d0b9d405d8ffd2310f788254453d6748f0b) --- modules/debugger/debugger_api.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/modules/debugger/debugger_api.c b/modules/debugger/debugger_api.c index e6e5f54..39e599b 100644 --- a/modules/debugger/debugger_api.c +++ b/modules/debugger/debugger_api.c @@ -268,18 +268,18 @@ int dbg_msgid_filter(struct sip_msg *msg, unsigned int flags, void *bar) } msgid_base = _dbg_pid_list[indx].msgid_base; lock_release(_dbg_pid_list[indx].lock); - msgid_new = msg->id - msgid_base; - LM_DBG("msg->id:%d msgid_base:%d -> %d\n", msg->id, msgid_base, msgid_new); - if(msgid_new>0) + if(msg->id > msgid_base) { + msgid_new = msg->id - msgid_base; + LM_DBG("msg->id:%d msgid_base:%d -> %d\n", + msg->id, msgid_base, msgid_new); msg->id = msgid_new; - return 1; } else { - LM_WARN("msgid_new<=0??\n"); - return -1; + LM_DBG("msg->id:%d already processed\n", msg->id); } + return 1; } /**

1 0

git:master: debugger: fix reset_msgid
by Victor Seva 20 Aug '14

20 Aug '14

Module: sip-router Branch: master Commit: 6b2f7d0b9d405d8ffd2310f788254453d6748f0b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6b2f7d0… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Tue Aug 19 17:21:57 2014 +0200 debugger: fix reset_msgid Don't change the msg->id when that message has been processed already --- modules/debugger/debugger_api.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/modules/debugger/debugger_api.c b/modules/debugger/debugger_api.c index 6f4cbb8..05f904e 100644 --- a/modules/debugger/debugger_api.c +++ b/modules/debugger/debugger_api.c @@ -273,18 +273,18 @@ int dbg_msgid_filter(struct sip_msg *msg, unsigned int flags, void *bar) } msgid_base = _dbg_pid_list[indx].msgid_base; lock_release(_dbg_pid_list[indx].lock); - msgid_new = msg->id - msgid_base; - LM_DBG("msg->id:%d msgid_base:%d -> %d\n", msg->id, msgid_base, msgid_new); - if(msgid_new>0) + if(msg->id > msgid_base) { + msgid_new = msg->id - msgid_base; + LM_DBG("msg->id:%d msgid_base:%d -> %d\n", + msg->id, msgid_base, msgid_new); msg->id = msgid_new; - return 1; } else { - LM_WARN("msgid_new<=0??\n"); - return -1; + LM_DBG("msg->id:%d already processed\n", msg->id); } + return 1; } char* get_current_route_type_name()

1 0

git:master: tmx: be sure From header is parsed before accessing the tag
by Daniel-Constantin Mierla 19 Aug '14

19 Aug '14

Module: sip-router Branch: master Commit: 92ff234d8b39c422aca683d4fbb0cfacc24a77b4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=92ff234… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Aug 19 11:10:14 2014 +0200 tmx: be sure From header is parsed before accessing the tag - reported by Juha Heinanen --- modules/tmx/tmx_pretran.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/modules/tmx/tmx_pretran.c b/modules/tmx/tmx_pretran.c index 3483c32..653f64c 100644 --- a/modules/tmx/tmx_pretran.c +++ b/modules/tmx/tmx_pretran.c @@ -213,6 +213,10 @@ int tmx_check_pretran(sip_msg_t *msg) LM_ERR("failed to get Via header\n"); return -1; } + if (parse_from_header(msg)<0 || get_from(msg)->tag_value.len==0) { + LM_ERR("failed to get From header\n"); + return -1; + } vbr = msg->via1->branch;

2 5

git:master: tmx: mark pretran struct as linked when adding to a non-empty slot
by Daniel-Constantin Mierla 19 Aug '14

19 Aug '14

Module: sip-router Branch: master Commit: cb04eea7b4e2a382a0315529d38d2f4ec5a60d93 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cb04eea… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Aug 19 18:19:46 2014 +0200 tmx: mark pretran struct as linked when adding to a non-empty slot - otherwise is not going to be unlinked properly, with high potential of ending in an infinite loop - reported by Juha Heinanen --- modules/tmx/tmx_pretran.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/modules/tmx/tmx_pretran.c b/modules/tmx/tmx_pretran.c index 653f64c..a9c6f2a 100644 --- a/modules/tmx/tmx_pretran.c +++ b/modules/tmx/tmx_pretran.c @@ -121,6 +121,7 @@ void tmx_pretran_link_safe(int slotid) _tmx_proc_ptran->next = _tmx_ptran_table[slotid].plist; _tmx_ptran_table[slotid].plist->prev = _tmx_proc_ptran; _tmx_ptran_table[slotid].plist = _tmx_proc_ptran; + _tmx_proc_ptran->linked = 1; return; } @@ -250,9 +251,7 @@ int tmx_check_pretran(sip_msg_t *msg) } if(dsize<256) dsize = 256; - lock_get(&_tmx_ptran_table[slotid].lock); - tmx_pretran_unlink_safe(slotid); - lock_release(&_tmx_ptran_table[slotid].lock); + tmx_pretran_unlink(); if(dsize > _tmx_proc_ptran->dbuf.len) { if(_tmx_proc_ptran->dbuf.s) shm_free(_tmx_proc_ptran->dbuf.s);

1 0

[tracker] Task opened: textopsx : hf_value and hf_value2 can not parse authorize header
by sip-router 19 Aug '14

19 Aug '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Kamrul Khan (dodullive.com) Attached to Project - sip-router Summary - textopsx : hf_value and hf_value2 can not parse authorize header Task Type - Bug Report Category - Module Status - Unconfirmed Assigned To - Operating System - Linux Severity - Low Priority - Normal Reported Version - 4.1 Due in Version - Undecided Due Date - Undecided Details - I tried using hf_value and hf_value2 for getting username, uri and response from my authorize header. But, each time it keeps returning Digest as result. For @hf_value2.Authorization.username returns Digest. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=461 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
20
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2014