sr-dev August 2014

sr-dev@lists.kamailio.org

25 participants
195 discussions

[tracker] Task closed: Do not fork command line option

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#458 - Do not fork command line option User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=458 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 3 months

[tracker] Comment added: Do not fork command line option

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#458 - Do not fork command line option User who did this - Daniel-Constantin Mierla (miconda) ---------- Help content was fixed to reflect current behaviour and relation to command line parameters: <code> -D - do not fork (almost) anyway (run in foreground, doesn't fork into daemon mode); -DD - do not daemonize creator (main process is not daemonized); -DDD - daemonize (default) </code> ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=458#comment1602 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 3 months

[tracker] Task closed: Memory leak in tm module?

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#464 - Memory leak in tm module? User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Fixed some time ago -- reopen if you think is another issue than one mentioned with the fix in the comment. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=464 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 3 months

[tracker] Comment added: Memory leak in tm module?

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#464 - Memory leak in tm module? User who did this - Daniel-Constantin Mierla (miconda) ---------- This looks like fixed by commit d921b452687a31ab49b7c5c4420c0c6134916140 You have to upgrade to latest 4.1.x -- it is included there. There is no change to config file or database from 4.1.1 to newer 4.1.x, simply deploy the newer version and restart kamailio. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=464#comment1601 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 3 months

git:master: core: update content for -D option in man page

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: ee9ea2f543975769ca544dcf3b75b97698e3b53e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ee9ea2f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Aug 25 16:56:16 2014 +0200 core: update content for -D option in man page --- sip-router.8 | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/sip-router.8 b/sip-router.8 index bc50354..3bc247d 100644 --- a/sip-router.8 +++ b/sip-router.8 @@ -75,7 +75,16 @@ Turns on debugging, multiple increase the debug level. .TP .BI \-D -Runs sip-router in the foreground (it doesn't fork into daemon mode). +Control how daemonize is done: +.br +.B -D +- do not fork (almost) anyway (run in foreground, doesn't fork into daemon mode); +.br +.B -DD +- do not daemonize creator (main process is not daemonized); +.br +.B -DDD +- daemonize (default) .TP .BI \-E Sends all the log messages to stderr.

10 years, 3 months

git:master: core: main - proper info for -D command line option

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 2b33768745130b91e984b679f9eed01a6267d8cc URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2b33768… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Aug 25 16:55:27 2014 +0200 core: main - proper info for -D command line option --- main.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/main.c b/main.c index 5f54821..bed6ccc 100644 --- a/main.c +++ b/main.c @@ -228,8 +228,10 @@ Options:\n\ (to use both use `-rR`)\n\ -K Turn on \"via:\" host checking when forwarding replies\n\ -d Debugging mode (multiple -d increase the level)\n\ - -D no 1..do not fork (almost) anyway, 2..do not daemonize creator\n\ - 3..daemonize (default)\n\ + -D Control how daemonize is done:\n\ + -D..do not fork (almost) anyway;\n\ + -DD..do not daemonize creator;\n\ + -DDD..daemonize (default)\n\ -E Log to stderr\n\ -e Log messages printed in terminal colors (requires -E)\n" #ifdef USE_TCP

10 years, 3 months

[tracker] Comment added: force_send_socket in event route tm:local-request (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#462 - force_send_socket in event route tm:local-request User who did this - Kristian Høgh (kfhdk) ---------- The attached patch works for me. In tm:local-request I call set_advertised_address() and force_send_socket(). I only change the IP address, and haven't testet change in proto, port... ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=462#comment1600 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 3 months

[tracker] Task opened: Memory leak in tm module?

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Morten Tryfoss (mtryfoss) Attached to Project - sip-router Summary - Memory leak in tm module? Task Type - Bug Report Category - tm Status - Unconfirmed Assigned To - Operating System - Linux Severity - Medium Priority - Normal Reported Version - 4.1 Due in Version - Undecided Due Date - Undecided Details - We have got a production system with a slow but steady increase of shared memory use when routing calls. The kamailio version is 4.1.1. I'm able to reproduce this in a lab. The call scenario is like this: Call from asterisk using udp to kamailio, which looks up the registered user (tested both udp and tls) and forwards using t_relay(). The call is then either answered or canceled. When I stop kamailio I get two of those lines for each call that has been routed: Aug 25 15:23:55 sip1stage /usr/sbin/kamailio[14285]: qm_status: 8372. N address=0x7fc21369f348 frag=0x7fc21369f318 size=56 used=1 Aug 25 15:23:55 sip1stage /usr/sbin/kamailio[14285]: qm_status: alloc'd from tm: t_fwd.c: prepare_new_uac(574) Aug 25 15:23:55 sip1stage /usr/sbin/kamailio[14285]: qm_status: start check=f0f0f0f0, end check= c0c0c0c0, abcdefed Aug 25 15:23:55 sip1stage /usr/sbin/kamailio[14285]: qm_status: 8373. N address=0x7fc21369f3e0 frag=0x7fc21369f3b0 size=24 used=1 Aug 25 15:23:55 sip1stage /usr/sbin/kamailio[14285]: qm_status: alloc'd from tm: t_fwd.c: prepare_new_uac(589) Aug 25 15:23:55 sip1stage /usr/sbin/kamailio[14285]: qm_status: start check=f0f0f0f0, end check= c0c0c0c0, abcdefed When the call is initiated, two of these lines appear in the log: Aug 25 15:23:40 sip1stage /usr/sbin/kamailio[14286]: <core> [mem/q_malloc.c:369]: qm_malloc(): qm_malloc(0x7fc2132db000, 21) called from tm: t_fwd.c: prepare_new_uac(574) Aug 25 15:23:40 sip1stage /usr/sbin/kamailio[14286]: <core> [mem/q_malloc.c:415]: qm_malloc(): qm_malloc(0x7fc2132db000, 24) returns address 0x7fc21369f348 frag. 0x7fc21369f318 (size=56) on 1 -th hit Aug 25 15:23:40 sip1stage /usr/sbin/kamailio[14286]: <core> [mem/q_malloc.c:369]: qm_malloc(): qm_malloc(0x7fc2132db000, 20) called from tm: t_fwd.c: prepare_new_uac(589) Aug 25 15:23:40 sip1stage /usr/sbin/kamailio[14286]: <core> [mem/q_malloc.c:415]: qm_malloc(): qm_malloc(0x7fc2132db000, 24) returns address 0x7fc21369f3e0 frag. 0x7fc21369f3b0 (size=24) on 1 -th hit More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=464 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 3 months

Reply to INVITE fron provider with old Parmeters

by Yuriy Gorlichenko

Hello. At first- I think header of my message doesn't explain my porblem but I can not say about it with different terms) So. I have construction Asterisk --> Kamailio --> Providers My provisers registered with UAC modure and stored at UACREG table. Problem scenario is: I ring from asterisk to provider Asterisk --> Kamailio --> Providers Call from asterisk come to kamailio with furi(Asterisk_clinet_local_number@asterisk) turi(external_number@kamailio) Then, to forward INVITE to provider that Needed I use some manipulations to choose provider (it does not matter, it is only sql_queryes to some tables), and then modify invite with this code: #$var(prov) - my.provider.ip #$var(trunk) - name_of_trunk $rd=$var(prov); $rp="5060"; $fU=$var(trunk); $fd=$var(prov); $td=$var(prov); remove_hf("Contact"); append_hf("Contact:<$var(trunk)@my.kamailio.domain:5068>\n","Contact"); So -after this manipulation I have write packet, that goues to my provider. Then Provier sends me 407 answer and packet goes to failure_route if (t_check_status("401|407")){ xlog("L_INFO", "Reply from provider on failure: $rs"); if (uac_auth()){ #my query to get avp for uac #modparam("uac","auth_realm_avp","$avp(s:realm)") #modparam("uac","auth_username_avp","avp(s:uname)") #modparam("uac","auth_password_avp","$avp(s:passwd))") sql_pvquery("ca","select auth_username, auth_password, realm from uacreg where auth_username='$fU'","$var(uname), $var(passwd), $var(realm)"); xlog("L_INFO", "username=$var(uname), password=$var(passwd), realm=$var(realm) for {$fU}"); pv_printf("$avp(s:uname)","$var(uname)"); pv_printf("$avp(s:passwd)","$var(passwd)"); pv_printf("$avp(s:realm)","$var(realm)"); xlog("L_INFO", "UAC_AUTH(): $rs"); append_branch(); t_relay(); } } if (t_is_canceled()) { exit; } So After changes Before Provider answer 407 my $fU = name_of_trunk, but at failure route my fU is Asterisk_clinet_local_number and it so strange because I see this packet at TCPDUMP and it have trunkname at fU Because of It I can not take from table needed vars for auth and avp`s Have 0. So packet for Auth (407) goes to Asterisk (with trunkname!!!! at fU), but t must stops at kamailio and must be ralayed to provider. So this my problem- I can not understand: Why fU at reply 407 have old parameters?

10 years, 3 months

git:master: modules/ims_registrar_pcscf: Replaced deprecated STR_PARAM with PARAM_STR

by Richard Good

Module: sip-router Branch: master Commit: 7450805ac0c8dbe620f146ddf14eba7bee69171e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7450805… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Mon Aug 25 15:03:11 2014 +0200 modules/ims_registrar_pcscf: Replaced deprecated STR_PARAM with PARAM_STR --- modules/ims_registrar_pcscf/reg_mod.c | 9 +++++---- modules/ims_registrar_pcscf/subscribe.c | 20 +++++++++----------- modules/ims_registrar_pcscf/ul_callback.c | 9 ++++----- 3 files changed, 18 insertions(+), 20 deletions(-) diff --git a/modules/ims_registrar_pcscf/reg_mod.c b/modules/ims_registrar_pcscf/reg_mod.c index 06febf9..1b9103e 100644 --- a/modules/ims_registrar_pcscf/reg_mod.c +++ b/modules/ims_registrar_pcscf/reg_mod.c @@ -81,8 +81,9 @@ int ignore_contact_rxport_check = 0; /**!< ignore po * this is useful for example if you register with UDP but possibly send invite over TCP (message too big)*/ time_t time_now; -char * pcscf_uri = "sip:pcscf.ims.smilecoms.com:4060"; -char * force_icscf_uri = ""; + +str pcscf_uri = str_init("sip:pcscf.ims.smilecoms.com:4060"); +str force_icscf_uri = str_init(""); unsigned int pending_reg_expires = 30; /**!< parameter for expiry time of a pending registration before receiving confirmation from SCSCF */ @@ -150,7 +151,7 @@ static cmd_export_t cmds[] = { * Exported parameters */ static param_export_t params[] = { - {"pcscf_uri", STR_PARAM, &pcscf_uri }, + {"pcscf_uri", PARAM_STR, &pcscf_uri }, {"pending_reg_expires", INT_PARAM, &pending_reg_expires }, {"received_avp", STR_PARAM, &rcv_avp_param }, {"is_registered_fallback2ip", INT_PARAM, &is_registered_fallback2ip }, @@ -158,7 +159,7 @@ static param_export_t params[] = { {"subscribe_to_reginfo", INT_PARAM, &subscribe_to_reginfo }, {"subscription_expires", INT_PARAM, &subscription_expires }, {"ignore_contact_rxport_check", INT_PARAM, &ignore_contact_rxport_check }, - {"force_icscf_uri", STR_PARAM, &force_icscf_uri }, + {"force_icscf_uri", PARAM_STR, &force_icscf_uri }, // {"store_profile_dereg", INT_PARAM, &store_data_on_dereg}, {0, 0, 0} }; diff --git a/modules/ims_registrar_pcscf/subscribe.c b/modules/ims_registrar_pcscf/subscribe.c index cc2065d..9c859df 100644 --- a/modules/ims_registrar_pcscf/subscribe.c +++ b/modules/ims_registrar_pcscf/subscribe.c @@ -35,8 +35,8 @@ extern pua_api_t pua; -extern char* pcscf_uri; -extern char * force_icscf_uri; +extern str pcscf_uri; +extern str force_icscf_uri; #define P_ASSERTED_IDENTITY_HDR_PREFIX "P-Asserted-Identity: <" @@ -45,11 +45,9 @@ int reginfo_subscribe_real(struct sip_msg* msg, pv_elem_t* uri, str* service_rou char uri_buf[512]; int uri_buf_len = 512; subs_info_t subs; - str server_address = {pcscf_uri, strlen(pcscf_uri)}; - str outbound_proxy = {force_icscf_uri, strlen (force_icscf_uri)}; str p_asserted_identity_header; - int len = strlen(P_ASSERTED_IDENTITY_HDR_PREFIX) + server_address.len + 1 + CRLF_LEN; + int len = strlen(P_ASSERTED_IDENTITY_HDR_PREFIX) + pcscf_uri.len + 1 + CRLF_LEN; p_asserted_identity_header.s = (char *)pkg_malloc( len ); if ( p_asserted_identity_header.s == NULL ) { LM_ERR( "insert_asserted_identity: pkg_malloc %d bytes failed", len ); @@ -58,8 +56,8 @@ int reginfo_subscribe_real(struct sip_msg* msg, pv_elem_t* uri, str* service_rou memcpy(p_asserted_identity_header.s, P_ASSERTED_IDENTITY_HDR_PREFIX, strlen(P_ASSERTED_IDENTITY_HDR_PREFIX)); p_asserted_identity_header.len = strlen(P_ASSERTED_IDENTITY_HDR_PREFIX); - memcpy(p_asserted_identity_header.s + p_asserted_identity_header.len, server_address.s, server_address.len); - p_asserted_identity_header.len += server_address.len; + memcpy(p_asserted_identity_header.s + p_asserted_identity_header.len, pcscf_uri.s, pcscf_uri.len); + p_asserted_identity_header.len += pcscf_uri.len; *(p_asserted_identity_header.s + p_asserted_identity_header.len) = '>'; p_asserted_identity_header.len ++; memcpy( p_asserted_identity_header.s + p_asserted_identity_header.len, CRLF, CRLF_LEN ); @@ -83,16 +81,16 @@ int reginfo_subscribe_real(struct sip_msg* msg, pv_elem_t* uri, str* service_rou subs.remote_target = &uri_str; subs.pres_uri= &uri_str; - subs.watcher_uri= &server_address; + subs.watcher_uri= &pcscf_uri; subs.expires = expires; subs.source_flag= REGINFO_SUBSCRIBE; subs.event= REGINFO_EVENT; - subs.contact= &server_address; + subs.contact= &pcscf_uri; subs.extra_headers = &p_asserted_identity_header; - if(outbound_proxy.s && outbound_proxy.len) { - subs.outbound_proxy= &outbound_proxy; + if(force_icscf_uri.s && force_icscf_uri.len) { + subs.outbound_proxy= &force_icscf_uri; } subs.flag|= UPDATE_TYPE; diff --git a/modules/ims_registrar_pcscf/ul_callback.c b/modules/ims_registrar_pcscf/ul_callback.c index 1a78931..119f3c9 100644 --- a/modules/ims_registrar_pcscf/ul_callback.c +++ b/modules/ims_registrar_pcscf/ul_callback.c @@ -74,7 +74,7 @@ Call-ID: 9ad9f89f-164d-bb86-1072-52e7e9eb5025. </reginfo> */ extern pua_api_t pua; -extern char* pcscf_uri; +extern str pcscf_uri; extern int publish_reginfo; /* methods for building reg publish */ @@ -189,13 +189,12 @@ int send_partial_publish(ppublic_t *impu, struct pcontact *c, int type) str content_type; int id_buf_len; char id_buf[512]; - str server_address = {pcscf_uri, strlen(pcscf_uri)}; str p_asserted_identity_header; content_type.s = "application/reginfo+xml"; content_type.len = 23; - int len = strlen(P_ASSERTED_IDENTITY_HDR_PREFIX) + server_address.len + 1 + CRLF_LEN; + int len = strlen(P_ASSERTED_IDENTITY_HDR_PREFIX) + pcscf_uri.len + 1 + CRLF_LEN; p_asserted_identity_header.s = (char *)pkg_malloc( len ); if ( p_asserted_identity_header.s == NULL ) { LM_ERR( "insert_asserted_identity: pkg_malloc %d bytes failed", len ); @@ -204,8 +203,8 @@ int send_partial_publish(ppublic_t *impu, struct pcontact *c, int type) memcpy(p_asserted_identity_header.s, P_ASSERTED_IDENTITY_HDR_PREFIX, strlen(P_ASSERTED_IDENTITY_HDR_PREFIX)); p_asserted_identity_header.len = strlen(P_ASSERTED_IDENTITY_HDR_PREFIX); - memcpy(p_asserted_identity_header.s + p_asserted_identity_header.len, server_address.s, server_address.len); - p_asserted_identity_header.len += server_address.len; + memcpy(p_asserted_identity_header.s + p_asserted_identity_header.len, pcscf_uri.s, pcscf_uri.len); + p_asserted_identity_header.len += pcscf_uri.len; *(p_asserted_identity_header.s + p_asserted_identity_header.len) = '>'; p_asserted_identity_header.len ++; memcpy( p_asserted_identity_header.s + p_asserted_identity_header.len, CRLF, CRLF_LEN );

10 years, 3 months

← Newer
1
2
3
4
5
6
7
...
20
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2014