sr-dev May 2014

sr-dev@lists.kamailio.org

34 participants
238 discussions

git:master: dialog: if sending BYE fails at timeout, unref dialog
by Daniel-Constantin Mierla 12 May '14

12 May '14

Module: sip-router Branch: master Commit: e39a90e11bfed2b4445c37db1532488aa9e3e725 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e39a90e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon May 12 22:54:54 2014 +0200 dialog: if sending BYE fails at timeout, unref dialog - destroy dialog structures --- modules/dialog/dlg_handlers.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/modules/dialog/dlg_handlers.c b/modules/dialog/dlg_handlers.c index 44bbc12..eebe30b 100644 --- a/modules/dialog/dlg_handlers.c +++ b/modules/dialog/dlg_handlers.c @@ -1356,7 +1356,8 @@ void dlg_ontimeout(struct dlg_tl *tl) if(dlg->iflags&DLG_IFLAG_TIMEOUTBYE) { - dlg_bye_all(dlg, NULL); + if(dlg_bye_all(dlg, NULL)<0) + dlg_unref(dlg, 1); /* run event route for end of dlg */ dlg_run_event_route(dlg, NULL, dlg->state, DLG_STATE_DELETED); dlg_unref(dlg, 1);

1 0

[tracker] Comment added: kamailio sometimes crash when handling failure events
by sip-router 12 May '14

12 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#427 - kamailio sometimes crash when handling failure events User who did this - Daniel-Constantin Mierla (miconda) ---------- Are you using any event_route[dialog:...], rtimer or any other event_route[...] in config file? ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=427#comment1441 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: kamailio sometimes crash when handling failure events (Attachment added)
by sip-router 12 May '14

12 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#427 - kamailio sometimes crash when handling failure events User who did this - Pawel Sternal (Sternik) ---------- pcap for above scenario ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=427#comment1440 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: pkg/kamailio/deb: append pkg-config as Build-Depends
by Victor Seva 12 May '14

12 May '14

Module: sip-router Branch: master Commit: 6c02bdb04d6e214728c13c6222e347783b66337b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6c02bdb… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Mon May 12 23:06:09 2014 +0200 pkg/kamailio/deb: append pkg-config as Build-Depends --- pkg/kamailio/deb/debian/control | 1 + pkg/kamailio/deb/jessie/control | 1 + pkg/kamailio/deb/precise/control | 1 + pkg/kamailio/deb/squeeze/control | 1 + pkg/kamailio/deb/wheezy/control | 1 + 5 files changed, 5 insertions(+), 0 deletions(-) diff --git a/pkg/kamailio/deb/debian/control b/pkg/kamailio/deb/debian/control index 820213b..ef8cefb 100644 --- a/pkg/kamailio/deb/debian/control +++ b/pkg/kamailio/deb/debian/control @@ -40,6 +40,7 @@ Build-Depends: bison, libxml2-dev, libxmlrpc-c3-dev, openssl, + pkg-config, python, python-dev, unixodbc-dev, diff --git a/pkg/kamailio/deb/jessie/control b/pkg/kamailio/deb/jessie/control index 476122e..e08ff34 100644 --- a/pkg/kamailio/deb/jessie/control +++ b/pkg/kamailio/deb/jessie/control @@ -39,6 +39,7 @@ Build-Depends: bison, libval-dev, libxml2-dev, openssl, + pkg-config, python, python-dev, unixodbc-dev, diff --git a/pkg/kamailio/deb/precise/control b/pkg/kamailio/deb/precise/control index efdca5f..a5f56c4 100644 --- a/pkg/kamailio/deb/precise/control +++ b/pkg/kamailio/deb/precise/control @@ -38,6 +38,7 @@ Build-Depends: bison, libunistring-dev, libxml2-dev, openssl, + pkg-config, python, python-dev, unixodbc-dev, diff --git a/pkg/kamailio/deb/squeeze/control b/pkg/kamailio/deb/squeeze/control index 4fb751d..43a4ca9 100644 --- a/pkg/kamailio/deb/squeeze/control +++ b/pkg/kamailio/deb/squeeze/control @@ -33,6 +33,7 @@ Build-Depends: bison, libxml2-dev, libxmlrpc-c3-dev, openssl, + pkg-config, python, python-dev, unixodbc-dev, diff --git a/pkg/kamailio/deb/wheezy/control b/pkg/kamailio/deb/wheezy/control index 266e619..a866c5c 100644 --- a/pkg/kamailio/deb/wheezy/control +++ b/pkg/kamailio/deb/wheezy/control @@ -37,6 +37,7 @@ Build-Depends: bison, libunistring-dev, libxml2-dev, openssl, + pkg-config, python, python-dev, unixodbc-dev,

1 0

[tracker] Comment added: kamailio sometimes crash when handling failure events (Attachment added)
by sip-router 12 May '14

12 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#427 - kamailio sometimes crash when handling failure events User who did this - Pawel Sternal (Sternik) ---------- Another corefile dump from yesterday - i didn't notice that kamailio on another node was restarted. In this scenario call was cancelled by caller. ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=427#comment1439 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: kamailio sometimes crash when handling failure events
by sip-router 12 May '14

12 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#427 - kamailio sometimes crash when handling failure events User who did this - Daniel-Constantin Mierla (miconda) ---------- Do you store the sip traffic? If yes, can you attach the sip packets for one of these cases? ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=427#comment1438 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: kamailio sometimes crash when handling failure events
by sip-router 12 May '14

12 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#427 - kamailio sometimes crash when handling failure events User who did this - Pawel Sternal (Sternik) ---------- Unfortunately when kamailio crashes, corefile dump was overwritten. I think there's been another restart at the same time. In syslog I notice that is the same situation after processing fail event: INVITE MB: SIP/2.0 487 Request Terminated ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=427#comment1437 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: kamailio sometimes crash when handling failure events
by sip-router 12 May '14

12 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#427 - kamailio sometimes crash when handling failure events User who did this - Daniel-Constantin Mierla (miconda) ---------- The last backtrace is from main process that tried to do cleanup at shutdonw, not being the real cause for the crash. Was there another corefile dumped at the same time? I am looking at the other ones meanwhile. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=427#comment1436 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:4.0: db_mysql: remove line accessing freed result
by Daniel-Constantin Mierla 12 May '14

12 May '14

Module: sip-router Branch: 4.0 Commit: 7165aa39a7894ba45bbe650f2a1658d3db044319 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7165aa3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Apr 21 17:35:39 2014 +0200 db_mysql: remove line accessing freed result (cherry picked from commit e114105450d8a5152448afd28de16e290297e38d) (cherry picked from commit 045b6ead1eace226ec316e3ae776f7bc35e54341) --- modules/db_mysql/km_dbase.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/modules/db_mysql/km_dbase.c b/modules/db_mysql/km_dbase.c index 151a24a..a43cac8 100644 --- a/modules/db_mysql/km_dbase.c +++ b/modules/db_mysql/km_dbase.c @@ -202,7 +202,6 @@ static int db_mysql_store_result(const db1_con_t* _h, db1_res_t** _r) mysql_free_result(res); } #endif - RES_RESULT(*_r) = 0; return -4; }

1 0

git:4.0: db_mysql: properly free db result structure if db_mysql_convert_result() fails
by Daniel-Constantin Mierla 12 May '14

12 May '14

Module: sip-router Branch: 4.0 Commit: bcd94bcfc4ba56e20620cff16b4ce9b155a344f6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bcd94bc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Apr 16 19:43:45 2014 +0200 db_mysql: properly free db result structure if db_mysql_convert_result() fails - reported by Torrey Searle, FS#420 (cherry picked from commit 37983c9f57536c57c5d34ce2d8a1c8f411e61e39) (cherry picked from commit 402e2122d1aa353ee8c10321aa1eb9315a81cd81) --- modules/db_mysql/km_dbase.c | 8 ++++---- modules/db_mysql/km_res.c | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/modules/db_mysql/km_dbase.c b/modules/db_mysql/km_dbase.c index a43cac8..18e3966 100644 --- a/modules/db_mysql/km_dbase.c +++ b/modules/db_mysql/km_dbase.c @@ -190,12 +190,12 @@ static int db_mysql_store_result(const db1_con_t* _h, db1_res_t** _r) if (db_mysql_convert_result(_h, *_r) < 0) { LM_ERR("error while converting result\n"); LM_DBG("freeing result set at %p\n", _r); - pkg_free(*_r); - *_r = 0; /* all mem on Kamailio API side is already freed by * db_mysql_convert_result in case of error, but we also need - * to free the mem from the mysql lib side */ - mysql_free_result(RES_RESULT(*_r)); + * to free the mem from the mysql lib side, internal pkg for it + * and *_r */ + db_mysql_free_result(_h, *_r); + *_r = 0; #if (MYSQL_VERSION_ID >= 40100) while( mysql_more_results(CON_CONNECTION(_h)) && mysql_next_result(CON_CONNECTION(_h)) > 0 ) { MYSQL_RES *res = mysql_store_result( CON_CONNECTION(_h) ); diff --git a/modules/db_mysql/km_res.c b/modules/db_mysql/km_res.c index 965e6dc..3f1ca26 100644 --- a/modules/db_mysql/km_res.c +++ b/modules/db_mysql/km_res.c @@ -69,6 +69,7 @@ int db_mysql_get_columns(const db1_con_t* _h, db1_res_t* _r) } if (db_allocate_columns(_r, RES_COL_N(_r)) != 0) { + RES_COL_N(_r) = 0; LM_ERR("could not allocate columns\n"); return -3; } @@ -173,6 +174,7 @@ static inline int db_mysql_convert_rows(const db1_con_t* _h, db1_res_t* _r) if (db_allocate_rows(_r) < 0) { LM_ERR("could not allocate rows"); + RES_ROW_N(_r) = 0; return -2; }

1 0

← Newer
1
...
16
17
18
19
20
21
22
23
24
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2014