sr-dev May 2014

sr-dev@lists.kamailio.org

34 participants
238 discussions

[tracker] Comment added: kamailio sometimes crash when handling failure events

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#427 - kamailio sometimes crash when handling failure events User who did this - Daniel-Constantin Mierla (miconda) ---------- Can you get again 'p *dlg' in frame 0 for the last core above? ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=427#comment1447 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 7 months

git:master: kamcmd: proper size for memset, based on malloc

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 7134959725011baa504a027c4561e0054dd907ae URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7134959… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 14 23:37:54 2014 +0200 kamcmd: proper size for memset, based on malloc --- utils/sercmd/sercmd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/utils/sercmd/sercmd.c b/utils/sercmd/sercmd.c index 00f10e7..fb9c0a3 100644 --- a/utils/sercmd/sercmd.c +++ b/utils/sercmd/sercmd.c @@ -1499,7 +1499,7 @@ static int get_mi_list(int s) /* alloc the mi_cmds array */ mi_cmds=malloc(mi_which_results*sizeof(*mi_cmds)); if (mi_cmds==0) goto error_mem; - memset(mi_cmds, 0, mi_which_results* sizeof(mi_cmds)); + memset(mi_cmds, 0, mi_which_results* sizeof(*mi_cmds)); /* get the mi names list */ for (r=0; r<mi_which_no; r++){ if (mi_which_array[r].type!=BINRPC_T_STR)

10 years, 7 months

git:master: parser/sdp: assign stream var only if session is not null

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 1cefc0c5f83eb4b7b6ffefc6ab383d7aae6de07f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1cefc0c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 14 23:28:24 2014 +0200 parser/sdp: assign stream var only if session is not null --- parser/sdp/sdp.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/parser/sdp/sdp.c b/parser/sdp/sdp.c index fde60d3..1e53940 100644 --- a/parser/sdp/sdp.c +++ b/parser/sdp/sdp.c @@ -871,12 +871,13 @@ void print_sdp_stream(sdp_stream_cell_t *stream, int log_level) void print_sdp_session(sdp_session_cell_t *session, int log_level) { - sdp_stream_cell_t *stream = session->streams; + sdp_stream_cell_t *stream; if (session==NULL) { LM_ERR("NULL session\n"); return; } + stream = session->streams; LOG(log_level, "..session[%d]:%p=>%p '%.*s' '%.*s' '%.*s' '%.*s:%.*s' (%d)=>%p\n", session->session_num, session, session->next,

10 years, 7 months

git:master: rls: free item in case of duplicate when trying to add to str list

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 71332ed9ce59de50de04c940fd600b50b1f1dc80 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=71332ed… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 14 23:19:05 2014 +0200 rls: free item in case of duplicate when trying to add to str list --- modules/rls/list.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/modules/rls/list.h b/modules/rls/list.h index c9904aa..f65c408 100644 --- a/modules/rls/list.h +++ b/modules/rls/list.h @@ -42,6 +42,7 @@ static inline list_entry_t *list_insert(str *strng, list_entry_t *list, int *dup { if (duplicate != NULL) *duplicate = 1; + pkg_free(p); return list; } if (cmp > 0) @@ -59,6 +60,7 @@ static inline list_entry_t *list_insert(str *strng, list_entry_t *list, int *dup { if (duplicate != NULL) *duplicate = 1; + pkg_free(p); return list; }

10 years, 7 months

git:master: rls: proper header define guard and check of null returned value

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 4f2da3e025fa281f88e80bb841a51d6546219ae8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4f2da3e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 14 23:12:33 2014 +0200 rls: proper header define guard and check of null returned value --- modules/rls/notify.c | 2 +- modules/rls/utils.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/rls/notify.c b/modules/rls/notify.c index 782a041..88ad158 100644 --- a/modules/rls/notify.c +++ b/modules/rls/notify.c @@ -1366,7 +1366,7 @@ int rls_get_resource_list(str *rl_uri, str *username, str *domain, { /* No path specified - use all resource-lists. */ *rl_node = XMLDocGetNodeByName(*xmldoc,"resource-lists", NULL); - if(rl_node==NULL) + if(*rl_node==NULL) { LM_ERR("no resource-lists node in XML document\n"); goto error; diff --git a/modules/rls/utils.h b/modules/rls/utils.h index 4b245e7..7918a9d 100644 --- a/modules/rls/utils.h +++ b/modules/rls/utils.h @@ -21,7 +21,7 @@ * */ -#ifndef RLS_URILS_H +#ifndef RLS_UTILS_H #define RLS_UTILS_H #include "../../ut.h"

10 years, 7 months

git:master: db_flatstore: free result before returning null on no more pkg

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 74743d6ef3bf74c1226ba5a1b6bebfbe19b06b93 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=74743d6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 14 23:03:19 2014 +0200 db_flatstore: free result before returning null on no more pkg - partial allocation when doing an incomplete new connection --- modules/db_flatstore/km_flat_con.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/db_flatstore/km_flat_con.c b/modules/db_flatstore/km_flat_con.c index c4f38bb..5a6ae40 100644 --- a/modules/db_flatstore/km_flat_con.c +++ b/modules/db_flatstore/km_flat_con.c @@ -115,6 +115,7 @@ struct flat_con* flat_new_connection(struct flat_id* id) fn = get_name(id); if (fn==0){ LM_ERR("get_name() failed\n"); + pkg_free(res); return 0; }

10 years, 7 months

git:master: ipops: free dns pv structure on invalid pv name

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: e53c715c74fb5b58f4f68b81acb60de66b19b8cc URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e53c715… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 14 23:08:06 2014 +0200 ipops: free dns pv structure on invalid pv name --- modules/ipops/ipops_pv.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/ipops/ipops_pv.c b/modules/ipops/ipops_pv.c index d6edadd..f4f3e1c 100644 --- a/modules/ipops/ipops_pv.c +++ b/modules/ipops/ipops_pv.c @@ -262,6 +262,7 @@ int pv_parse_dns_name(pv_spec_t *sp, str *in) error: LM_ERR("error at PV dns name: %.*s\n", in->len, in->s); + if(dpv) pkg_free(dpv); return -1; }

10 years, 7 months

git:master: core: free previous allocated variable if no more pkg to build rve struct

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: ace56c6bd2221920b965185c1c9a5997cd3f2768 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ace56c6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 14 22:56:37 2014 +0200 core: free previous allocated variable if no more pkg to build rve struct - cleaner shut down if not enough memory at startup --- rvalue.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/rvalue.c b/rvalue.c index ddc97c2..8e5ba20 100644 --- a/rvalue.c +++ b/rvalue.c @@ -2554,6 +2554,7 @@ struct rval_expr* mk_rval_expr_v(enum rval_type rv_type, void* val, s=(str*)val; v.s.s=pkg_malloc(s->len+1 /*0*/); if (v.s.s==0){ + pkg_free(rve); ERR("memory allocation failure\n"); return 0; }

10 years, 7 months

git:master: pv: proper length for line transformation when handling last line of value

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: f1a09e44268c77641216a78878f2c73c6e5a4d66 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f1a09e4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 14 22:53:35 2014 +0200 pv: proper length for line transformation when handling last line of value --- modules/pv/pv_trans.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/modules/pv/pv_trans.c b/modules/pv/pv_trans.c index 868123e..0b2ccc0 100644 --- a/modules/pv/pv_trans.c +++ b/modules/pv/pv_trans.c @@ -126,13 +126,13 @@ static int urlencode_param(str *sin, str *sout) { char *at, *p; - at = sout->s; - p = sin->s; - if (sin==NULL || sout==NULL || sin->s==NULL || sout->s==NULL || sin->len<0 || sout->len < 3*sin->len+1) return -1; + at = sout->s; + p = sin->s; + while (p < sin->s+sin->len) { if (isalnum(*p) || *p == '-' || *p == '_' || *p == '.' || *p == '~') *at++ = *p; @@ -1655,7 +1655,7 @@ int tr_eval_line(struct sip_msg *msg, tr_param_t *tp, int subtype, if(p==NULL) { /* last line */ - mv.len = (val->rs.s + val->rs.len) - p; + mv.len = (val->rs.s + val->rs.len) - mv.s; } else { mv.len = p - mv.s; } @@ -1737,7 +1737,7 @@ int tr_eval_line(struct sip_msg *msg, tr_param_t *tp, int subtype, if(p==NULL) { /* last line */ - mv.len = (val->rs.s + val->rs.len) - p; + mv.len = (val->rs.s + val->rs.len) - mv.s; } else { mv.len = p - mv.s; }

10 years, 7 months

git:master: dispatcher: expand attrs while running rpc command dispatcher. list

by Ovidiu Sas

Module: sip-router Branch: master Commit: 661bcef49ba3be944ba215b8a379256e3fe94a60 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=661bcef… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Wed May 14 17:00:30 2014 -0400 dispatcher: expand attrs while running rpc command dispatcher.list --- modules/dispatcher/dispatcher.c | 35 ++++++++++++++++++++++++++++------- 1 files changed, 28 insertions(+), 7 deletions(-) diff --git a/modules/dispatcher/dispatcher.c b/modules/dispatcher/dispatcher.c index c7dca2e..b07cc24 100644 --- a/modules/dispatcher/dispatcher.c +++ b/modules/dispatcher/dispatcher.c @@ -974,6 +974,7 @@ static void dispatcher_rpc_list(rpc_t* rpc, void* ctx) void* rh; void* sh; void* vh; + void* wh; int j; char c[3]; str data = {"", 0}; @@ -1005,7 +1006,6 @@ static void dispatcher_rpc_list(rpc_t* rpc, void* ctx) return; } - for(list = ds_list; list!= NULL; list= list->next) { if (rpc->struct_add(ih, "{", "SET", &sh) < 0) @@ -1045,15 +1045,36 @@ static void dispatcher_rpc_list(rpc_t* rpc, void* ctx) else c[1] = 'X'; - if(rpc->struct_add(vh, "SsdS", + if (list->dlist[j].attrs.body.s) + { + if(rpc->struct_add(vh, "Ssd{", "URI", &list->dlist[j].uri, "FLAGS", c, "PRIORITY", list->dlist[j].priority, - "ATTRS", (list->dlist[j].attrs.body.s)? - &(list->dlist[j].attrs.body):&data)<0) - { - rpc->fault(ctx, 500, "Internal error creating dest struct"); - return; + "ATTRS", &wh)<0) + { + rpc->fault(ctx, 500, "Internal error creating dest struct"); + return; + } + if(rpc->struct_add(wh, "SSdd", + "BODY", &(list->dlist[j].attrs.body), + "DUID", (list->dlist[j].attrs.duid.s)? + &(list->dlist[j].attrs.duid):&data, + "MAXLOAD", list->dlist[j].attrs.maxload, + "WEIGHT", list->dlist[j].attrs.weight)<0) + { + rpc->fault(ctx, 500, "Internal error creating attrs struct"); + return; + } + } else { + if(rpc->struct_add(vh, "Ssd", + "URI", &list->dlist[j].uri, + "FLAGS", c, + "PRIORITY", list->dlist[j].priority)<0) + { + rpc->fault(ctx, 500, "Internal error creating dest struct"); + return; + } } } }

10 years, 7 months

← Newer
1
...
14
15
16
17
18
19
20
...
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2014