sr-dev September 2013

sr-dev@lists.kamailio.org

33 participants
296 discussions

git:master: parser: added macros to check if it is a SIP or HTTP reply

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 33557b2de1631601be9b03447e3167d06e8ce1cb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=33557b2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Sep 23 18:40:48 2013 +0200 parser: added macros to check if it is a SIP or HTTP reply --- parser/msg_parser.h | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/parser/msg_parser.h b/parser/msg_parser.h index d6df9b3..475716b 100644 --- a/parser/msg_parser.h +++ b/parser/msg_parser.h @@ -156,6 +156,16 @@ if ( (*tmp==(firstchar) || *tmp==((firstchar) | 32)) && \ !strncasecmp((req)->first_line.u.request.version.s, \ SIP_VERSION, SIP_VERSION_LEN)) +#define IS_HTTP_REPLY(rpl) \ + ((rpl)->first_line.u.reply.version.len >= HTTP_VERSION_LEN && \ + !strncasecmp((rpl)->first_line.u.reply.version.s, \ + HTTP_VERSION, HTTP_VERSION_LEN)) + +#define IS_SIP_REPLY(rpl) \ + ((rpl)->first_line.u.reply.version.len >= SIP_VERSION_LEN && \ + !strncasecmp((rpl)->first_line.u.reply.version.s, \ + SIP_VERSION, SIP_VERSION_LEN)) + /*! \brief * Return a URI to which the message should be really sent (not what should * be in the Request URI. The following fields are tried in this order:

11 years, 2 months

[tracker] Comment added: Invalide tel INVITE crashes 4.0.3

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#348 - Invalide tel INVITE crashes 4.0.3 User who did this - Daniel-Constantin Mierla (miconda) ---------- It seems syslog.txt is from another crash, where the process was doing some db related operations. Am I wrong? In case you do lookup(location) in a failure route, can you try with latest version of git branch 4.0? Few days ago I fixed an issues that could result in a crash. If not, can you enable one core dump per process and get all the details (log, ngrep, backtrace) for the same crash to be able to compare them? In case the core dump per process is not enabled, the core dump can be overwritten by another process than the one that actually crashed first. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=348#comment1099 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 2 months

[tracker] Task opened: Invalide tel INVITE crashes 4.0.3 (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Daniel Tryba (dtryba) Attached to Project - sip-router Summary - Invalide tel INVITE crashes 4.0.3 Task Type - Bug Report Category - Core Status - Unconfirmed Assigned To - Operating System - All Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - Somehow a couple of Avaya IPOffices manage to generate a strange INVITE when dialling 00 resulting in a crash of kamailio 4.0.3 (http://deb.kamailio.org/kamailio wheezy): # kamailio -V version: kamailio 4.0.3 (x86_64/linux) flags: STATS: Off, USE_IPV6, USE_TCP, USE_TLS, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 4MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 17:01:35 Aug 19 2013 with gcc 4.7.2 This is reproducable. Short syslog output: kamailio[14257]: ERROR: <script>: SIPOUT: tel:+sip.pocos.nl kamailio[14257]: ERROR: <core> [resolve.c:1728]: sip_hostport2su(): ERROR: sip_hostport2su: could not resolve hostname: "" kamailio[14257]: ERROR: tm [ut.h:337]: uri2dst2(): failed to resolve "" kamailio[14257]: ERROR: tm [t_fwd.c:1534]: t_forward_nonack(): ERROR: t_forward_nonack: failure to add branches kamailio[14257]: ERROR: sl [sl_funcs.c:371]: sl_reply_error(): ERROR: sl_reply_error used: Unresolvable destination (478/SL) kamailio[14257]: ERROR: <script>: ===== noanswer of dialog [3094:6591] kamailio[14257]: WARNING: tm [t_lookup.c:1564]: t_unref(): WARNING: script writer didn't release transaction 4926763.717035] kamailio[14257]: segfault at 1b ip 00007f7388ccf107 sp 00007fff43cdd5e0 error 6 in tm.so[7f7388c8e000+86000] kamailio[14280]: : <core> [pass_fd.c:293]: receive_fd(): ERROR: receive_fd: EOF on 16 kamailio[14253]: ALERT: <core> [main.c:788]: handle_sigs(): child process 14257 exited by a signal 11 kamailio[14253]: ALERT: <core> [main.c:791]: handle_sigs(): core was not generated kamailio[14253]: INFO: <core> [main.c:803]: handle_sigs(): INFO: terminating due to SIGCHLD kamailio[14279]: INFO: <core> [main.c:854]: sig_usr(): INFO: signal 15 received kamailio[14278]: INFO: <core> [main.c:854]: sig_usr(): INFO: signal 15 received kamailio[14277]: INFO: <core> [main.c:854]: sig_usr(): INFO: signal 15 received kamailio[14276]: INFO: <core> [main.c:854]: sig_usr(): INFO: signal 15 received kamailio[14273]: INFO: <core> [main.c:854]: sig_usr(): INFO: signal 15 received kamailio[14270]: INFO: <core> [main.c:854]: sig_usr(): INFO: signal 15 received kamailio[14269]: INFO: <core> [main.c:854]: sig_usr(): INFO: signal 15 received kamailio[14265]: INFO: <core> [main.c:854]: sig_usr(): INFO: signal 15 received kamailio[14264]: INFO: <core> [main.c:854]: sig_usr(): INFO: signal 15 received kamailio[14262]: INFO: <core> [main.c:854]: sig_usr(): INFO: signal 15 received One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=348 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 2 months

[tracker] Comment added: avpops: avp_check() use xavp semantic on first parameter

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#347 - avpops: avp_check() use xavp semantic on first parameter User who did this - Daniel-Constantin Mierla (miconda) ---------- Ah, I misunderstood, you referred to key as in $xavp(key1=>key2)? Maybe you should add this to docs to make it clear. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=347#comment1098 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 2 months

[tracker] Comment added: avpops: avp_check() use xavp semantic on first parameter

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#347 - avpops: avp_check() use xavp semantic on first parameter User who did this - Daniel-Constantin Mierla (miconda) ---------- Can be applied. But I would change in docs that * cannot be used in first key with * cannot be used in the first parameter. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=347#comment1097 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 2 months

Re: [sr-dev] Decoding HTTP URLs in event_route[xhttp:request]

by Peter Dunkley

Hello, Does anyone have any ideas about this? If not it's something I want to try and do before the freeze (any suggestions as to how would be appreciated) as it will be a nice finishing touch to the WebSocket/outbound/stun/auth_ephemeral stuff I've worked on over the last couple of releases. Thanks, Peter On 19 September 2013 21:36, Peter Dunkley <peter.dunkley(a)crocodilertc.net>wrote: > Hello, > > I was wondering if there was an easy way to decode HTTP URLs in > event_route[xhttp:request]? > > For example, it would be good to be able to breakdown a URL like: > /sip?apiKey=abcdefg&username=1234567890:alice@example.com > into "path/on/server" ("/sip" in this case) and a set of parameters. For > the parameters something like the {param.value,name} transformation for SIP > header parameters would be ideal (which works perfectly for picking values > out of HTTP Cookie: headers). > > I noticed that there is already an {s.urldecode.param} transformation in > the PV module but I couldn't find any documentation for it in the wiki and > looking at the code it doesn't appear to do this anyway. > > Regards, > > Peter > > > -- > Peter Dunkley > Technical Director > Crocodile RCS Ltd > -- Peter Dunkley Technical Director Crocodile RCS Ltd

11 years, 3 months

[tracker] Comment added: avpops: avp_check() use xavp semantic on first parameter (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#347 - avpops: avp_check() use xavp semantic on first parameter User who did this - Víctor Seva (linuxmaniac) ---------- Update documentation ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=347#comment1096 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 3 months

[tracker] Task opened: avpops: avp_check() use xavp semantic on first parameter (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Víctor Seva (linuxmaniac) Attached to Project - sip-router Summary - avpops: avp_check() use xavp semantic on first parameter Task Type - Bug Report Category - Module Status - New Assigned To - Víctor Seva Operating System - All Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - With this patch now you can use: avp_check("$xavp(test[1]=>op[*])","re/$xavp(test[1]=>re[*])/g") No [*] on first key for now. One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=347 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 3 months

git:master: gzcompress: new module to compress/ decompress SIP message body using zlib

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: bd716593efb83d4124c0c0cb824bf158d547ca0d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bd71659… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Sep 21 00:10:43 2013 +0200 gzcompress: new module to compress/decompress SIP message body using zlib --- modules/gzcompress/Makefile | 25 ++ modules/gzcompress/README | 162 +++++++++++ modules/gzcompress/doc/Makefile | 4 + modules/gzcompress/doc/gzcompress.xml | 37 +++ modules/gzcompress/doc/gzcompress_admin.xml | 165 +++++++++++ modules/gzcompress/gzcompress_mod.c | 408 +++++++++++++++++++++++++++ 6 files changed, 801 insertions(+), 0 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=bd7…

11 years, 3 months

git:master: dmq: code cleanup, remove redundant includes

by Charles Chance

Module: sip-router Branch: master Commit: dcfa15de586e28a025e34590e800571b0e3abddf URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=dcfa15d… Author: Charles Chance <charles.chance(a)sipcentric.com> Committer: Charles Chance <charles.chance(a)sipcentric.com> Date: Fri Sep 20 21:07:30 2013 +0100 dmq: code cleanup, remove redundant includes --- modules/dmq/bind_dmq.h | 15 +++++++++++++++ modules/dmq/dmq.c | 12 +++--------- modules/dmq/dmq.h | 18 ------------------ modules/dmq/dmq_funcs.c | 4 ++++ modules/dmq/message.c | 6 +++--- modules/dmq/message.h | 2 +- 6 files changed, 26 insertions(+), 31 deletions(-) diff --git a/modules/dmq/bind_dmq.h b/modules/dmq/bind_dmq.h index d0330d4..c480646 100644 --- a/modules/dmq/bind_dmq.h +++ b/modules/dmq/bind_dmq.h @@ -45,5 +45,20 @@ typedef int (*bind_dmq_f)(dmq_api_t* api); int bind_dmq(dmq_api_t* api); +static inline int dmq_load_api(dmq_api_t* api) { + bind_dmq_f binddmq; + binddmq = (bind_dmq_f)find_export("bind_dmq", 0, 0); + if ( binddmq == 0) { + LM_ERR("cannot find bind_dmq\n"); + return -1; + } + if (binddmq(api) < 0) + { + LM_ERR("cannot bind dmq api\n"); + return -1; + } + return 0; +} + #endif diff --git a/modules/dmq/dmq.c b/modules/dmq/dmq.c index f4eea3a..1640a7c 100644 --- a/modules/dmq/dmq.c +++ b/modules/dmq/dmq.c @@ -32,27 +32,21 @@ #include <fcntl.h> #include <time.h> -#include "../../sr_module.h" -#include "../../dprint.h" -#include "../../error.h" #include "../../ut.h" #include "../../mem/mem.h" #include "../../mem/shm_mem.h" #include "../../usr_avp.h" -#include "../../modules/tm/tm_load.h" -#include "../../parser/parse_uri.h" -#include "../../modules/sl/sl.h" #include "../../pt.h" #include "../../lib/kmi/mi.h" #include "../../hashes.h" +#include "../../mod_fix.h" + #include "dmq.h" #include "dmq_funcs.h" -#include "peer.h" #include "bind_dmq.h" -#include "worker.h" +#include "message.h" #include "notification_peer.h" #include "dmqnode.h" -#include "../../mod_fix.h" static int mod_init(void); static int child_init(int); diff --git a/modules/dmq/dmq.h b/modules/dmq/dmq.h index 02c1fcc..c5dfcbf 100644 --- a/modules/dmq/dmq.h +++ b/modules/dmq/dmq.h @@ -32,7 +32,6 @@ #include "../../modules/tm/tm_load.h" #include "../../parser/parse_uri.h" #include "../../modules/sl/sl.h" -#include "bind_dmq.h" #include "peer.h" #include "worker.h" @@ -57,22 +56,5 @@ extern str dmq_400_rpl; extern str dmq_500_rpl; extern str dmq_404_rpl; -static inline int dmq_load_api(dmq_api_t* api) { - bind_dmq_f binddmq; - binddmq = (bind_dmq_f)find_export("bind_dmq", 0, 0); - if ( binddmq == 0) { - LM_ERR("cannot find bind_dmq\n"); - return -1; - } - if (binddmq(api) < 0) - { - LM_ERR("cannot bind dmq api\n"); - return -1; - } - return 0; -} - -int dmq_handle_message(struct sip_msg* msg, char* str1 ,char* str2); - #endif diff --git a/modules/dmq/dmq_funcs.c b/modules/dmq/dmq_funcs.c index 33c4ab1..69130cb 100644 --- a/modules/dmq/dmq_funcs.c +++ b/modules/dmq/dmq_funcs.c @@ -31,6 +31,10 @@ dmq_peer_t* register_dmq_peer(dmq_peer_t* peer) { dmq_peer_t* new_peer; + if (!peer_list) { + LM_ERR("peer list not initialized\n"); + return NULL; + } lock_get(&peer_list->lock); if(search_peer_list(peer_list, peer)) { LM_ERR("peer already exists: %.*s %.*s\n", peer->peer_id.len, peer->peer_id.s, diff --git a/modules/dmq/message.c b/modules/dmq/message.c index a6ce2d4..05b77f1 100644 --- a/modules/dmq/message.c +++ b/modules/dmq/message.c @@ -1,6 +1,3 @@ -#include "../../parser/parse_to.h" -#include "../../parser/parse_uri.h" -#include "../../sip_msg_clone.h" /* * $Id$ * @@ -27,6 +24,9 @@ */ +#include "../../parser/parse_to.h" +#include "../../parser/parse_uri.h" +#include "../../sip_msg_clone.h" #include "../../parser/parse_content.h" #include "../../parser/parse_from.h" #include "../../ut.h" diff --git a/modules/dmq/message.h b/modules/dmq/message.h index 6763960..4e9dc3a 100644 --- a/modules/dmq/message.h +++ b/modules/dmq/message.h @@ -26,6 +26,6 @@ #ifndef _MESSAGE_H_ #define _MESSAGE_H_ -int dmq_handle_message(struct sip_msg*, char*, char*); +int dmq_handle_message(struct sip_msg*, char* str1, char* str2); #endif

11 years, 3 months

← Newer
1
...
6
7
8
9
10
11
12
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2013