sr-dev September 2013

sr-dev@lists.kamailio.org

33 participants
296 discussions

git:master: acc: cast to double for safer conversion in time_mode==2
by Daniel-Constantin Mierla 03 Sep '13

03 Sep '13

Module: sip-router Branch: master Commit: ede2d6747aabf32538797dfedf13682c5c242831 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ede2d67… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 3 13:35:08 2013 +0200 acc: cast to double for safer conversion in time_mode==2 --- modules/acc/acc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/acc/acc.c b/modules/acc/acc.c index 7f08f17..272a70f 100644 --- a/modules/acc/acc.c +++ b/modules/acc/acc.c @@ -413,7 +413,7 @@ int acc_db_request( struct sip_msg *rq) if(acc_time_mode==1) { VAL_INT(db_vals+(m++)) = (int)acc_env.tv.tv_usec; } else if(acc_time_mode==2) { - VAL_DOUBLE(db_vals+(m++)) = ((acc_env.tv.tv_sec * 1000) + VAL_DOUBLE(db_vals+(m++)) = ((double)(acc_env.tv.tv_sec * 1000) + (acc_env.tv.tv_usec / 1000)) / 1000; }

1 0

sending notify over tls
by Luis Azedo 02 Sep '13

02 Sep '13

Hi, i have mwi running on a server and everything works as expected but notifications over TLS are not sent. i tried this with several ip phones (hard and soft) i can register over tls, make calls, etc the initial SUBSCRIBE sent by client works as expected and answer is sent and received. when the NOTIFY is initiated by the server here is what i get. i setup some extra debug settings any thoughts ? thank you Aug 31 23:46:42 sipproxy-01 kamailio[3041]: INFO: presence [notify.c:1681]: notify(): updating subscription to database Aug 31 23:46:42 sipproxy-01 kamailio[3041]: INFO: presence [notify.c:117]: printf_subs(): pres_uri: sip:995582130@teste.sip.90e9.com Aug 31 23:46:42 sipproxy-01 kamailio[3041]: INFO: presence [notify.c:121]: printf_subs(): callid/from_tag/to_tag: 73da11de-3566eef2(a)192.168.16.15/b302146219721c3/804318313668236640636a8c49438852-3fce Aug 31 23:46:42 sipproxy-01 kamailio[3041]: INFO: presence [notify.c:122]: printf_subs(): local_cseq/remote_cseq: 7/1005 Aug 31 23:46:42 sipproxy-01 kamailio[3041]: INFO: presence [notify.c:123]: printf_subs(): local_contact/contact: sip:192.168.16.145:5061 ;transport=tls/sip:995582130@192.168.16.15:5074;transport=tls Aug 31 23:46:42 sipproxy-01 kamailio[3041]: INFO: presence [notify.c:124]: printf_subs(): record_route: Aug 31 23:46:42 sipproxy-01 kamailio[3041]: INFO: presence [notify.c:125]: printf_subs(): sockinfo_str: tls:192.168.16.145:5061 Aug 31 23:46:42 sipproxy-01 kamailio[3041]: INFO: presence [notify.c:127]: printf_subs(): event: message-summary Aug 31 23:46:42 sipproxy-01 kamailio[3041]: INFO: presence [notify.c:1591]: send_notify_request(): expires 172 status 1 Aug 31 23:46:42 sipproxy-01 kamailio[3041]: INFO: presence [notify.c:1603]: send_notify_request(): STEP 1 Aug 31 23:46:42 sipproxy-01 kamailio[3041]: INFO: presence [notify.c:1606]: send_notify_request(): STEP 2 *Aug 31 23:46:42 sipproxy-01 kamailio[3041]: : <core> [pass_fd.c:157]: send_all(): ERROR: send_all: send on 17 failed: Bad file descriptor* *Aug 31 23:46:42 sipproxy-01 kamailio[3041]: ERROR: <core> [tcp_main.c:2353]: tcpconn_send_put(): BUG: tcp_send: failed to get fd(write):Bad file descriptor (9)* *Aug 31 23:46:42 sipproxy-01 kamailio[3041]: ERROR: tm [../../forward.h:237]: msg_send(): msg_send: ERROR: tcp_send failed* *Aug 31 23:46:42 sipproxy-01 kamailio[3041]: ERROR: tm [uac.c:506]: send_prepared_request_impl(): t_uac: Attempt to send to precreated request failed* *Aug 31 23:46:42 sipproxy-01 kamailio[3041]: INFO: presence [notify.c:1608]: send_notify_request(): STEP 3* *Aug 31 23:46:42 sipproxy-01 kamailio[3041]: INFO: presence [notify.c:1621]: send_notify_request(): NOTIFY sip:995582130@teste.sip.90e9.com via sip:995582130@192.168.16.15:5074;transport=tls on behalf of sip:995582130@teste.sip.90e9.com for event message-summary* *Aug 31 23:46:42 sipproxy-01 kamailio[3041]: INFO: presence [notify.c:3107]: pres_notify_watchers(): step 13* -- Luis Azedo

1 0

git:master: kamctl: added commands to set extra columns in subscriber table
by Daniel-Constantin Mierla 02 Sep '13

02 Sep '13

Module: sip-router Branch: master Commit: 1cec15e057bdec4455e70af951def19e36a78e8e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1cec15e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Sep 2 14:09:18 2013 +0200 kamctl: added commands to set extra columns in subscriber table - useful to deal with columns added for load_credentials of auth_db module - 'sets' - sets a column with string value - 'setn' - sets a column with numeric value --- utils/kamctl/kamctl | 53 ++++++++++++++++++++++++++++++++++++++++++++++ utils/kamctl/kamctl.base | 2 + 2 files changed, 55 insertions(+), 0 deletions(-) diff --git a/utils/kamctl/kamctl b/utils/kamctl/kamctl index e25c6f2..6e922c6 100755 --- a/utils/kamctl/kamctl +++ b/utils/kamctl/kamctl @@ -2254,6 +2254,51 @@ and $REALM_COLUMN='$OSERDOMAIN';" # and also all his contacts $0 ul rm $1 > /dev/null 2>&1 ;; + sets) + if [ $# -ne 4 ] ; then + usage_subscriber + exit 1 + fi + shift + + is_user $1 + if [ $? -ne 0 ] ; then + merr "non-existent user '$1'" + exit 1 + fi + + QUERY="update $SUB_TABLE set $2='$3' \ +WHERE $SUBSCRIBER_COLUMN='$OSERUSER' and $REALM_COLUMN='$OSERDOMAIN';" + $DBCMD "$QUERY" + if [ $? -ne 0 ] ; then + merr "attribute change failed" + else + minfo "attribute change succeeded" + fi + ;; + setn) + if [ $# -ne 4 ] ; then + usage_subscriber + exit 1 + fi + shift + + is_user $1 + if [ $? -ne 0 ] ; then + merr "non-existent user '$1'" + exit 1 + fi + + QUERY="update $SUB_TABLE set $2=$3 \ +WHERE $SUBSCRIBER_COLUMN='$OSERUSER' and $REALM_COLUMN='$OSERDOMAIN';" + $DBCMD "$QUERY" + if [ $? -ne 0 ] ; then + merr "attribute change failed" + else + minfo "attribute change succeeded" + fi + ;; + esac } @@ -2587,6 +2632,14 @@ case $1 in subscriber "$@" ;; + sets) + subscriber "$@" + ;; + + setn) + subscriber "$@" + ;; + alias|ul|usrloc) usrloc "$@" ;; diff --git a/utils/kamctl/kamctl.base b/utils/kamctl/kamctl.base index 034ac51..94db676 100644 --- a/utils/kamctl/kamctl.base +++ b/utils/kamctl/kamctl.base @@ -425,6 +425,8 @@ cat <<EOF show <username> .................... show subscriber attributes (*) passwd <username> <passwd> ......... change user's password (*) rm <username> ...................... delete a user (*) + sets <username> <attr> <val> ....... set string attribute (column value) + setn <username> <attr> <val> ....... set numeric attribute (column value) EOF } USAGE_FUNCTIONS="$USAGE_FUNCTIONS usage_subscriber"

1 0

json and jsonrpc-c modules
by Matthew Williams 02 Sep '13

02 Sep '13

Hi, The Flowroute development team is pleased to announce a complete overhaul of the json and jsonrpc-c modules, originally authored two years ago. Credit should first and foremost go to Joe Hillenbrand who did most of the new development. Jordan Levy (our CTO) and I were also involved in the updates and QA to a lesser extent. The updated modules are available in the mgw/json branch. In addition to the Kamailio modules, we have developed a Twisted Python library to complement the jsonrpc-c module: https://github.com/flowroute/txjason We would be interested in any critiques of the API, documentation, and code. Please let us know if you use these modules and especially if you find any bugs. We hope to merge this into master once we have had it in production for awhile and (ideally) have received some feedback from other users. Feel free to contact either Joe (joe(a)flowroute.com) or me directly with any questions or comments. -- Matthew Williams Flowroute LLC http://www.flowroute.com/

2 1

catching up after summer
by Daniel-Constantin Mierla 02 Sep '13

02 Sep '13

Hello, not that summer holidays (pretty much) ended, I'm making a call to catch up with what was left unattended and somehow got lost on the lists, trackers or repositories. Therefore: - if someone asked questions without answer on mailing list, send now a reminder - if you sent emails to private address (direct message only to personal emails, not as a request from a mailing list conversation), again, they are very very unlikely to be answered there, resend the message to mailing list - if you opened a tracker issue and have more details, add them as soon as possible As for development, I have seen a bunch of commits on personal branches, if they are not requiring special review, merge them to the master branch so the code can be easier tested. Soon we will have to freeze for next major release and it is better to have the code as early as possible in the main branch. Have a great autumn, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio Advanced Trainings - Berlin, Oct 21-24; Miami, Nov 11-13, 2013 - more details about Kamailio trainings at http://www.asipto.com -

1 0

git:master: Fixed potential bug in exceptional condition when max-time updated is called
by Carlos Ruiz Diaz 01 Sep '13

01 Sep '13

Module: sip-router Branch: master Commit: 7e44ff0be6cbb48c9360bee8601ec3dbff050c02 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7e44ff0… Author: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Committer: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Date: Sun Sep 1 19:56:57 2013 -0400 Fixed potential bug in exceptional condition when max-time updated is called --- modules/cnxcc/cnxcc_mod.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/cnxcc/cnxcc_mod.c b/modules/cnxcc/cnxcc_mod.c index 9a85eda..808df1f 100644 --- a/modules/cnxcc/cnxcc_mod.c +++ b/modules/cnxcc/cnxcc_mod.c @@ -1817,7 +1817,7 @@ static int update_max_time(struct sip_msg* msg, char* str_pv_client, char* str_p if (e == NULL) { - LM_ERR("Client [%.*s] was not found\n", e->key.len, e->key.s); + LM_ERR("Client [%.*s] was not found\n", client_id_val.rs.len, client_id_val.rs.s); return -1; }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2013