sr-dev September 2013

sr-dev@lists.kamailio.org

33 participants
296 discussions

by Olle E. Johansson

int connect_server(struct jsonrpc_server *server) { struct sockaddr_in server_addr; struct hostent *hp; server_addr.sin_family = AF_INET; server_addr.sin_port = htons(server->port); Hard coded IPv4 in a product that has supported IPv6 since over 10 years? Tss tss. Also, the timouts are hardcoded. Maybe we should try to use CURL, like the utils module do and standardise the way Kamailio connect to HTTP servers. Having one http client may be beneficial, an http_client module. The idea with suspend and restart transactions in another route block that json_rpc uses seems like a good idea also for the HTTP client functions in utils. Just some thoughts after looking into the code, a Sunday evening brainstorm :-) /O

10 years, 8 months

[tracker] Comment added: Kamailio: problem route

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#336 - Kamailio: problem route User who did this - Olle Johansson (oej) ---------- Please use the sr-users mailing list for support. This is a bug tracker where you report things when you think or know that the source code have problems or if you have additional source code you want incorporated. I am sure you will get a lot of answers on the mailing list. Important is to learn the difference between Kamailio an a media server like Asterisk or FreeSwitch. Kamailio can not handle media or play prompts, but can forward the call to a media server that plays the prompt you want. See you on the mailing list! Welcome to Kamailio! ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=336#comment1067 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 8 months

[tracker] Task closed: Kamailio: problem route

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#336 - Kamailio: problem route User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Deferred More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=336 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 8 months

[tracker] Comment added: Kamailio: problem route

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#336 - Kamailio: problem route User who did this - Daniel-Constantin Mierla (miconda) ---------- The tracker is for bugs in kamailio c code or requests for new features. For configuration file questions and troubleshooting, use the mailing list sr-users(a)lists.sip-router.org (http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users). For this particular case, look in syslog (/var/log/syslog or /var/log/messages) to see if there is any error message from kamailio. If not, start kamailio with debug=3 in config file, it will be lot more log messages. If you can't figure out what is wrong, then follow up on mailing list. I will close this item on tracker. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=336#comment1066 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 8 months

[tracker] Task opened: Kamailio: problem route

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - camilo (Skamilo0) Attached to Project - sip-router Summary - Kamailio: problem route Task Type - Feature Request Category - Modules kamailio Status - Unconfirmed Assigned To - Operating System - FreeBSD Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - Hello! i am new in It, i speak spanish y very bad english, my problem is: i want route to announcement when is busy or request timeout(486|408): ... ... if(t_check_status("486|408")){ route(TEST); exit; } route[TEST] { setflag(1); append_hf("P-App-Name: announcement\r\n"); rewritehostport("sip.inf.uct.cl:5080"); route("RELAY"); exit; } route[RELAY] { if(is_method("ACK")) { exec_msg("/bin/echo \" $$SIP_HF_FROM $$SIP_HF_TO $$SIP_RURI \" >> /home/kaminfo/llamadas.log"); ... ... this just to prove that routing works. call with linphone and gives an error that says "I'm terribly sorry, server error occurred (6/SL). Are you missing something in code? Please help, is my final Thank you. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=336 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 8 months

git:tmp/ims_charging: Bug-Fixes:

by Carsten Bock

Module: sip-router Branch: tmp/ims_charging Commit: 37e63951b2b05875f07a1d30b8352e3f10a99072 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=37e6395… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Wed Sep 4 18:20:20 2013 +0200 Bug-Fixes: - Use P-Asserted-Identity instead of From-Header as User in CCR - Store RURI in the ro_session structure (it may have been changed by an Application-Server) Fixed by: Carlos Ruiz Díaz (carlos(a)ng-voice.com) --- modules/ims_charging/ims_ro.c | 16 ++++++++++++++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/modules/ims_charging/ims_ro.c b/modules/ims_charging/ims_ro.c index a4f9376..42d1bf6 100644 --- a/modules/ims_charging/ims_ro.c +++ b/modules/ims_charging/ims_ro.c @@ -803,7 +803,8 @@ error_no_cca: * @returns #CSCF_RETURN_TRUE if OK, #CSCF_RETURN_ERROR on error */ int Ro_Send_CCR(struct sip_msg *msg, str* direction, str* charge_type, str* unit_type, int reservation_units) { - str session_id = { 0, 0 }; + str session_id = { 0, 0 }, + asserted_id = { 0, 0 }; AAASession* cc_acc_session = NULL; Ro_CCR_t * ro_ccr_data = 0; AAAMessage * ccr = 0; @@ -815,6 +816,11 @@ int Ro_Send_CCR(struct sip_msg *msg, str* direction, str* charge_type, str* unit int cc_event_number = 0; //According to IOT tests this should start at 0 int cc_event_type = RO_CC_START; + if (msg->first_line.type != SIP_REQUEST) { + LM_ERR("Ro_CCR() called from SIP reply."); + return -1; + } + //make sure we can get the dialog! if not, we can't continue struct dlg_cell* dlg = dlgb.get_dlg(msg); if (!dlg) { @@ -822,11 +828,17 @@ int Ro_Send_CCR(struct sip_msg *msg, str* direction, str* charge_type, str* unit return -1; } + if ((asserted_id = cscf_get_asserted_identity(msg)).len == 0) { + LM_DBG("No P-Asserted-Identity hdr found. Using From hdr"); + + asserted_id = dlg->from_uri; + } + dir = get_direction_as_int(direction); //create a session object without auth and diameter session id - we will add this later. new_session = build_new_ro_session(dir, 0, 0, &session_id, &dlg->callid, - &dlg->from_uri, &dlg->req_uri, dlg->h_entry, dlg->h_id, + &asserted_id, &msg->first_line.u.request.uri, dlg->h_entry, dlg->h_id, reservation_units, 0); if (!new_session) { LM_ERR("Couldn't create new Ro Session - this is BAD!\n");

10 years, 8 months

git:tmp/ims_charging: Another Fix for the ims_charging Module:

by Carsten Bock

Module: sip-router Branch: tmp/ims_charging Commit: 774752e4d12bd03f01362af55a5e422eade690b2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=774752e… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Thu Sep 5 19:10:15 2013 +0200 Another Fix for the ims_charging Module: - Use P-Asserted-Identity instead of From-Header fixed by Carlos Ruiz Díaz (carlos(a)ng-voice.com) --- modules/ims_charging/ims_ro.c | 36 ++++++++++++++++++++++-------------- 1 files changed, 22 insertions(+), 14 deletions(-) diff --git a/modules/ims_charging/ims_ro.c b/modules/ims_charging/ims_ro.c index 42d1bf6..e05f06f 100644 --- a/modules/ims_charging/ims_ro.c +++ b/modules/ims_charging/ims_ro.c @@ -329,7 +329,7 @@ int get_sip_header_info(struct sip_msg * req, int32_t * acc_record_type, str * sip_method, str * event, uint32_t * expires, - str * callid, str * from_uri, str * to_uri) { + str * callid, str * asserted_id_uri, str * to_uri) { sip_method->s = req->first_line.u.request.method.s; sip_method->len = req->first_line.u.request.method.len; @@ -345,16 +345,21 @@ int get_sip_header_info(struct sip_msg * req, *expires = cscf_get_expires_hdr(req, 0); *callid = cscf_get_call_id(req, NULL); - if (!cscf_get_from_uri(req, from_uri)) - goto error; + if ((*asserted_id_uri = cscf_get_asserted_identity(req)).len == 0) { + LM_DBG("No P-Asserted-Identity hdr found. Using From hdr"); - if (!cscf_get_to_uri(req, to_uri)) - goto error; + if (!cscf_get_from_uri(req, asserted_id_uri)) { + LM_ERR("Error assigning P-Asserted-Identity using From hdr"); + goto error; + } + } + + *to_uri = req->first_line.u.request.uri; LM_DBG("retrieved sip info : sip_method %.*s acc_record_type %i, event %.*s expires %u " "call_id %.*s from_uri %.*s to_uri %.*s\n", sip_method->len, sip_method->s, *acc_record_type, event->len, event->s, *expires, - callid->len, callid->s, from_uri->len, from_uri->s, to_uri->len, to_uri->s); + callid->len, callid->s, asserted_id_uri->len, asserted_id_uri->s, to_uri->len, to_uri->s); return 1; error: @@ -804,7 +809,7 @@ error_no_cca: */ int Ro_Send_CCR(struct sip_msg *msg, str* direction, str* charge_type, str* unit_type, int reservation_units) { str session_id = { 0, 0 }, - asserted_id = { 0, 0 }; + asserted_id_uri = { 0, 0 }; AAASession* cc_acc_session = NULL; Ro_CCR_t * ro_ccr_data = 0; AAAMessage * ccr = 0; @@ -816,6 +821,8 @@ int Ro_Send_CCR(struct sip_msg *msg, str* direction, str* charge_type, str* unit int cc_event_number = 0; //According to IOT tests this should start at 0 int cc_event_type = RO_CC_START; + LM_ALERT("here 1"); + if (msg->first_line.type != SIP_REQUEST) { LM_ERR("Ro_CCR() called from SIP reply."); return -1; @@ -828,23 +835,23 @@ int Ro_Send_CCR(struct sip_msg *msg, str* direction, str* charge_type, str* unit return -1; } - if ((asserted_id = cscf_get_asserted_identity(msg)).len == 0) { + if ((asserted_id_uri = cscf_get_asserted_identity(msg)).len == 0) { LM_DBG("No P-Asserted-Identity hdr found. Using From hdr"); - asserted_id = dlg->from_uri; + asserted_id_uri = dlg->from_uri; } dir = get_direction_as_int(direction); //create a session object without auth and diameter session id - we will add this later. new_session = build_new_ro_session(dir, 0, 0, &session_id, &dlg->callid, - &asserted_id, &msg->first_line.u.request.uri, dlg->h_entry, dlg->h_id, + &asserted_id_uri, &msg->first_line.u.request.uri, dlg->h_entry, dlg->h_id, reservation_units, 0); if (!new_session) { LM_ERR("Couldn't create new Ro Session - this is BAD!\n"); return -1; } - + LM_ALERT("here 3"); if (!sip_create_ro_ccr_data(msg, dir, &ro_ccr_data, &cc_acc_session)) goto error; @@ -890,12 +897,13 @@ int Ro_Send_CCR(struct sip_msg *msg, str* direction, str* charge_type, str* unit } //get sip from URI for request - str from_sip_uri; + /*str from_sip_uri; if (!cscf_get_from_uri(msg, &from_sip_uri)) {//TODO fix return 0; - } - if (!Ro_add_subscription_id(ccr, AVP_EPC_Subscription_Id_Type_End_User_SIP_URI, &from_sip_uri)) { + } */ + + if (!Ro_add_subscription_id(ccr, AVP_EPC_Subscription_Id_Type_End_User_SIP_URI, &asserted_id_uri)) { LM_ERR("Problem adding Subscription ID data\n"); goto error; }

10 years, 8 months

[tracker] Task closed: ims_registrar_scscf: unexpected 200 OK response after calling assign_server_unreg()

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#309 - ims_registrar_scscf: unexpected 200 OK response after calling assign_server_unreg() User who did this - Camille Oudot (coudot) Reason for closing: Fixed More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=309 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 8 months

[tracker] Task changed: ims_registrar_scscf: unexpected 200 OK response after calling assign_server_unreg()

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#309 - ims_registrar_scscf: unexpected 200 OK response after calling assign_server_unreg() User who did this: Camille Oudot (coudot) Percent Complete: 0% -> 100% More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=309 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 8 months

[tracker] Task closed: enable milliseconds precision for accounting

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#163 - enable milliseconds precision for accounting User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented Additional comments about closing: Implemented in master branch, given when time_mode=2 for acc module. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=163 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 8 months

← Newer
1
...
22
23
24
25
26
27
28
29
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2013