sr-dev September 2013

sr-dev@lists.kamailio.org

33 participants
296 discussions

git:master: modules/sdpops: Check for valid sdp body in sdp_remove_line_by_prefix

by Hugh Waite

Module: sip-router Branch: master Commit: 771e9093e343951e12f4875692e9ecc567a277a1 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=771e909… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Committer: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Sep 18 21:34:16 2013 +0100 modules/sdpops: Check for valid sdp body in sdp_remove_line_by_prefix - Fixes crash when used on requests with no body --- modules/sdpops/sdpops_mod.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/modules/sdpops/sdpops_mod.c b/modules/sdpops/sdpops_mod.c index e11764c..a506fc6 100644 --- a/modules/sdpops/sdpops_mod.c +++ b/modules/sdpops/sdpops_mod.c @@ -373,6 +373,11 @@ int sdp_remove_line_by_prefix(sip_msg_t* msg, str* prefix) return -1; } + if(msg->body == NULL) { + LM_DBG("No sdp body\n"); + return -1; + } + body.s = ((sdp_info_t*)msg->body)->raw_sdp.s; body.len = ((sdp_info_t*)msg->body)->raw_sdp.len;

11 years, 1 month

git:4.0: modules/sdpops: Check for valid sdp body in sdp_remove_line_by_prefix

by Hugh Waite

Module: sip-router Branch: 4.0 Commit: 3ca71bbf4f61c83d8e82c988d0789d147f81f30b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3ca71bb… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Committer: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Sep 18 21:34:16 2013 +0100 modules/sdpops: Check for valid sdp body in sdp_remove_line_by_prefix - Fixes crash when used on requests with no body --- modules/sdpops/sdpops_mod.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/modules/sdpops/sdpops_mod.c b/modules/sdpops/sdpops_mod.c index 2d2e668..72ad265 100644 --- a/modules/sdpops/sdpops_mod.c +++ b/modules/sdpops/sdpops_mod.c @@ -362,6 +362,11 @@ int sdp_remove_line_by_prefix(sip_msg_t* msg, str* prefix) return -1; } + if(msg->body == NULL) { + LM_DBG("No sdp body\n"); + return -1; + } + body.s = ((sdp_info_t*)msg->body)->raw_sdp.s; body.len = ((sdp_info_t*)msg->body)->raw_sdp.len;

11 years, 1 month

git:4.0: modules/app_lua: Fix off-by-one error in modf

by Hugh Waite

Module: sip-router Branch: 4.0 Commit: 84b21f2e9f602032d5950069cbd1dbf3ac416fcb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=84b21f2… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Committer: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Sep 18 21:58:12 2013 +0100 modules/app_lua: Fix off-by-one error in modf - Fixes calling sr.modf with additional parameters --- modules/app_lua/app_lua_sr.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/app_lua/app_lua_sr.c b/modules/app_lua/app_lua_sr.c index 21a9c18..c01db86 100644 --- a/modules/app_lua/app_lua_sr.c +++ b/modules/app_lua/app_lua_sr.c @@ -239,7 +239,7 @@ static int lua_sr_modf (lua_State *L) goto error; } } else { - for(i=1; i<=argc; i++) + for(i=1; i<argc; i++) { if(expf->fixup(&(act->val[i+1].u.data), i)<0) { @@ -255,7 +255,7 @@ static int lua_sr_modf (lua_State *L) /* free fixups */ if (expf->fixup) { - for(i=1; i<=argc; i++) + for(i=1; i<argc; i++) { if ((act->val[i+1].type == MODFIXUP_ST) && (act->val[i+1].u.data)) {

11 years, 1 month

git:master: README: updated version number

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: b9c6e70871085e63add429984eac8ee7afc9e49e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b9c6e70… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 00:09:55 2013 +0200 README: updated version number - bits of formatting for ToC --- README | 23 +++++++++++++---------- 1 files changed, 13 insertions(+), 10 deletions(-) diff --git a/README b/README index e0eae66..cf5fff4 100644 --- a/README +++ b/README @@ -1,18 +1,21 @@ -$Id$ - Welcome to Kamailio v4.0! +Kamailio v4.1 +============= - http://www.kamailio.org/ - ========================== +http://www.kamailio.org + +Table of contents + I. About Kamailio + II. Feature List + III. Getting started + IV. About the project + V. Obtaining Help + VI. More Information -I. About Kamailio -II. Feature List -III. Getting started -IV. About the project -V. Obtaining Help -VI. More Information +I. About Kamailio +================= Kamailio is an industrial-strength, free server for realtime communication, based on the Session Initiation Protocol (SIP RFC3261).

11 years, 1 month

[tracker] Task changed: Notify has incorrect information when q=0.5 in the Contact header

by sip-router

11 years, 1 month

[tracker] User took ownership: Notify has incorrect information when q=0.5 in the Contact header

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Daniel-Constantin Mierla has taken ownership of the following task: FS#342 - Notify has incorrect information when q=0.5 in the Contact header More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=342 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 1 month

[tracker] Task changed: Notify has incorrect information when q=0.5 in the Contact header

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#342 - Notify has incorrect information when q=0.5 in the Contact header User who did this: Daniel-Constantin Mierla (miconda) Task details edited: ------- When the ims_registar_scscf module sends a Notify after a deregistration and the contact has q= parameter, the XML contains state terminated for the AOR, and for the contact the state is active. <code> <?xml version="1.0"?> <reginfo xmlns="urn:ietf:params:xml:ns:reginfo" version="1" state="partial"> <registration aor="sip:+351915639755@nl.intinfra.com" id="0x2aeaf52ebb80" state="terminated"> <contact id="0x2aeaf52ebdd0" state="active" event="registered" expires="3558" q="0.500"> <uri>sip:+351915639755@192.168.230.47:5060;ep=192.168.137.206:49856;transport=udp</uri> </contact> </registration> </reginfo> </code> When q= parameter is not added in the contact field, the XML in the notify contains the following information after deregistration, AOR is terminated and also contact id in the state terminated. <code> <?xml version="1.0"?> <reginfo xmlns="urn:ietf:params:xml:ns:reginfo" version="1" state="partial"> <registration aor="sip:+31652526347@nl.intinfra.com" id="0x2b3396aecd60" state="terminated"> <contact id="0x2b3396af1e60" state="terminated" event="unregistered" expires="0"> <uri>sip:+31652526347@10.38.102.75:49844;transport=tcp</uri> </contact> </registration> </reginfo> </code> The contact in the XML of the notify seems to be incorrectly constructed when q=.. used in the contact header. Attached a patch which creates the correct contact info when the subscriber deregisters ------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=342 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 1 month

[tracker] Task changed: Dialog module: dlg_terminate_dlg and register_dlgcb function

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#256 - [sr-dev] Dialog module: dlg_terminate_dlg and register_dlgcb function User who did this: Daniel-Constantin Mierla (miconda) Severity: High -> Low Priority: Normal -> Low More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=256 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 1 month

[tracker] Comment added: presence_dialoginfo -> force_single doesn't sent most relevant xml

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#341 - presence_dialoginfo -> force_single doesn't sent most relevant xml User who did this - Daniel-Constantin Mierla (miconda) ---------- Use tabs for code indentation to make the patch easy to read. The one attached above uses a mixture of whitespaces and tabs. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=341#comment1085 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 1 month

[tracker] Comment added: presence_dialoginfo -> force_single doesn't sent most relevant xml

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#341 - presence_dialoginfo -> force_single doesn't sent most relevant xml User who did this - Daniel-Constantin Mierla (miconda) ---------- The patch doesn't look good. You should put curly braces for the two IF statements: if(force_single_dialog) and if (p_root->children) Right now, when doing the indentation of the code, the first FOR: for(i=0;i<j; i++) { includes also the second one, which is in an ELSE branch: else { /* loop over all bodies and create the aggregated body */ for(i=0; i<j; i++) Which looks wrong. Also, makes no sense to add the prototype in .h file, since the new function you added in used in one .c file. Add it at the beginning of the .c file. Right now makes an unnecessary include in the .h file for a header file from libxml2. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=341#comment1084 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 1 month

← Newer
1
...
12
13
14
15
16
17
18
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2013