sr-dev February 2013

sr-dev@lists.kamailio.org

45 participants
200 discussions

Outbound support in registrar - SIPit 30
by Olle E. Johansson 21 Feb '13

21 Feb '13

http://www.kamailio.org/wiki/devel/completing_outbound?&#work_required_to_c… I am running in outbound_mode 2 in the registrar, since I have a mixed set of clients. Clients that DO support outbound doesn't get a Require: header back in the response. "If outbound registration succeeded, as indicated by the presence of the outbound option-tag in the Require header field of a successful registration response, the UA begins sending keep-alives as described in Section 4.4." RFC 5626. This client changed the source code faster than I could, but I still consider it a bug in our registrar mode 2. /O

2 2

[tracker] Comment added: Max-forwards header missing
by sip-router 21 Feb '13

21 Feb '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#271 - Max-forwards header missing User who did this - Morten Tryfoss (mtryfoss) ---------- Hi, Maybe you should add the same if before increasing len? Like this.. if(headers==NULL || headers->len<15 || strnstr(headers->s, "Max-Forwards:", headers->len)==NULL) *len += MAXFWD_HEADER_LEN; /* Max-forwards */ ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=271#comment773 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: default config for speeddial misspelled
by sip-router 21 Feb '13

21 Feb '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#268 - default config for speeddial misspelled User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=268 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: kamailio.cfg: fixed typos to speeddial
by Daniel-Constantin Mierla 21 Feb '13

21 Feb '13

Module: sip-router Branch: master Commit: 0fd954bc6a8f94ac5e8087f6b8abdba372505c6e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0fd954b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Feb 21 11:34:25 2013 +0100 kamailio.cfg: fixed typos to speeddial - patch by Thilo Bangert, FS#268 --- etc/kamailio-oob.cfg | 4 ++-- etc/kamailio.cfg | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/etc/kamailio-oob.cfg b/etc/kamailio-oob.cfg index e1d7ff1..ab39168 100644 --- a/etc/kamailio-oob.cfg +++ b/etc/kamailio-oob.cfg @@ -405,7 +405,7 @@ modparam("alias_db", "use_domain", MULTIDOMAIN) #!endif -# ----- speedial params ----- +# ----- speeddial params ----- #!ifdef WITH_SPEEDDIAL modparam("speeddial", "db_url", DBURL) modparam("speeddial", "use_domain", MULTIDOMAIN) @@ -673,7 +673,7 @@ route[REGISTRAR] { # USER location service route[LOCATION] { -#!ifdef WITH_SPEEDIAL +#!ifdef WITH_SPEEDDIAL # search for short dialing - 2-digit extension if($rU=~"^[0-9][0-9]$") if(sd_lookup("speed_dial")) diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index 0c90f5d..0645c83 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -378,7 +378,7 @@ modparam("alias_db", "use_domain", MULTIDOMAIN) #!endif -# ----- speedial params ----- +# ----- speeddial params ----- #!ifdef WITH_SPEEDDIAL modparam("speeddial", "db_url", DBURL) modparam("speeddial", "use_domain", MULTIDOMAIN) @@ -636,7 +636,7 @@ route[REGISTRAR] { # USER location service route[LOCATION] { -#!ifdef WITH_SPEEDIAL +#!ifdef WITH_SPEEDDIAL # search for short dialing - 2-digit extension if($rU=~"^[0-9][0-9]$") if(sd_lookup("speed_dial"))

1 0

[tracker] Task closed: Max-forwards header missing
by sip-router 21 Feb '13

21 Feb '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#271 - Max-forwards header missing User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented Additional comments about closing: Commit 77f99fc7c0252c5fa71ad5939f048742592f1d43 More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=271 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Max-forwards header missing
by sip-router 21 Feb '13

21 Feb '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#271 - Max-forwards header missing User who did this - Daniel-Constantin Mierla (miconda) ---------- I changed the patch to add the max-fwd header only when not provided via "headers" param. Some modules such as presence add this header, so it could have ended in two such headers. It is committed on master branch, test if works fine and reopen in case it fails. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=271#comment772 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] User took ownership: Max-forwards header missing
by sip-router 21 Feb '13

21 Feb '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Daniel-Constantin Mierla has taken ownership of the following task: FS#271 - Max-forwards header missing More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=271 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: tm: add Max-Forwards header to local requests if not given as parameter
by Daniel-Constantin Mierla 21 Feb '13

21 Feb '13

Module: sip-router Branch: master Commit: 77f99fc7c0252c5fa71ad5939f048742592f1d43 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=77f99fc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Feb 21 11:25:39 2013 +0100 tm: add Max-Forwards header to local requests if not given as parameter - add the header to local generated CANCEL and ACK - based on a patch by Morten Tryfoss --- modules/tm/t_msgbuilder.c | 8 +++++++- modules/tm/t_msgbuilder.h | 3 +++ 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/modules/tm/t_msgbuilder.c b/modules/tm/t_msgbuilder.c index 340f99a..ffdcb7b 100644 --- a/modules/tm/t_msgbuilder.c +++ b/modules/tm/t_msgbuilder.c @@ -152,7 +152,7 @@ char *build_local(struct cell *Trans,unsigned int branch, *len+= via_len; /*headers*/ *len+=Trans->from.len+Trans->callid.len+to->len+ - +Trans->cseq_n.len+1+method_len+CRLF_LEN; + +Trans->cseq_n.len+1+method_len+CRLF_LEN+MAXFWD_HEADER_LEN; /* copy'n'paste Route headers */ @@ -226,6 +226,7 @@ char *build_local(struct cell *Trans,unsigned int branch, append_str( p, Trans->cseq_n.s, Trans->cseq_n.len ); append_str( p, " ", 1 ); append_str( p, method, method_len ); + append_str( p, MAXFWD_HEADER, MAXFWD_HEADER_LEN ); append_str( p, CRLF, CRLF_LEN ); if (!is_local(Trans)) { @@ -1516,6 +1517,7 @@ char* build_uac_req(str* method, str* headers, str* body, dlg_t* dialog, int bra *len += CALLID_LEN + dialog->id.call_id.len + CRLF_LEN; /* Call-ID */ *len += CSEQ_LEN + cseq.len + 1 + method->len + CRLF_LEN; /* CSeq */ *len += calculate_routeset_length(dialog); /* Route set */ + *len += MAXFWD_HEADER_LEN; /* Max-forwards */ *len += CONTENT_LENGTH_LEN + content_length.len + CRLF_LEN; /* Content- Length */ *len += (server_signature ? (user_agent_hdr.len + CRLF_LEN) : 0); /* Signature */ @@ -1539,6 +1541,10 @@ char* build_uac_req(str* method, str* headers, str* body, dlg_t* dialog, int bra w = print_callid(w, dialog, t); /* Call-ID */ w = print_routeset(w, dialog); /* Route set */ + if(headers==NULL || headers->len<15 + || strnstr(headers->s, "Max-Forwards:", headers->len)==NULL) + memapp(w, MAXFWD_HEADER, MAXFWD_HEADER_LEN); /* Max-forwards */ + /* Content-Length */ memapp(w, CONTENT_LENGTH, CONTENT_LENGTH_LEN); memapp(w, content_length.s, content_length.len); diff --git a/modules/tm/t_msgbuilder.h b/modules/tm/t_msgbuilder.h index f090528..7694fda 100644 --- a/modules/tm/t_msgbuilder.h +++ b/modules/tm/t_msgbuilder.h @@ -52,6 +52,9 @@ #define FROMTAG_LEN (sizeof(FROMTAG)-1) #define TOTAG ";tag=" #define TOTAG_LEN (sizeof(TOTAG)-1) +#define MAXFWD_VALUE "70" +#define MAXFWD_HEADER "Max-Forwards: " MAXFWD_VALUE CRLF +#define MAXFWD_HEADER_LEN (sizeof(MAXFWD_HEADER) - 1) char *build_local(struct cell *Trans, unsigned int branch,

1 0

[PATCH] Do not make DNS queries for IP address literals
by Simon Perreault 21 Feb '13

21 Feb '13

Hello, The current DNS code checks, when making an A query, whether the name is in fact an IPv4 address literal. Same for AAAA query with IPv6 address literal. This is good. However, nothing prevents A queries for IPv6 address literals or AAAA queries for IPv4 address literals. This is wrong. Here's the bug in action (anonymized to protect the innocent): > 1.2.3.4 -> 5.6.7.8 SIP 830 Request: ACK sip:foobar@9.10.11.12:5060;transport=udp > 5.6.7.8 -> 1.2.3.4 DNS 72 Standard query AAAA 9.10.11.12 Attached is a simple patch to fix the bug (of which there are three distinct instances). Comments? Simon

2 1

git:master: core: dns - prevent queries for IPv4/6 address literals
by Daniel-Constantin Mierla 21 Feb '13

21 Feb '13

Module: sip-router Branch: master Commit: 9e6f0268097d81c0e06c7fe33599d0763ed38179 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9e6f026… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Feb 21 10:40:07 2013 +0100 core: dns - prevent queries for IPv4/6 address literals - prevent A queries for IPv6 address literals or AAAA queries for IPv4 address literals - patch by Simon Perreault --- dns_cache.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/dns_cache.c b/dns_cache.c index 1f4ae82..b56e94d 100644 --- a/dns_cache.c +++ b/dns_cache.c @@ -1891,6 +1891,8 @@ inline static struct dns_hash_entry* dns_cache_do_request(str* name, int type) #endif /* USE_DNS_CACHE_STATS */ if (type==T_A){ + if (str2ip6(name)!=0) + goto end; if ((ip=str2ip(name))!=0){ e=dns_cache_mk_ip_entry(name, ip); if (likely(e)) @@ -1900,6 +1902,8 @@ inline static struct dns_hash_entry* dns_cache_do_request(str* name, int type) } #ifdef USE_IPV6 else if (type==T_AAAA){ + if (str2ip(name)!=0) + goto end; if ((ip=str2ip6(name))!=0){ e=dns_cache_mk_ip_entry(name, ip); if (likely(e)) @@ -2465,6 +2469,8 @@ inline static struct hostent* dns_a_get_he(str* name) struct hostent* he; e=0; + if (str2ip6(name)!=0) + return 0; if ((ip=str2ip(name))!=0){ return ip_addr2he(name, ip); } @@ -2489,6 +2495,8 @@ inline static struct hostent* dns_aaaa_get_he(str* name) struct hostent* he; e=0; + if (str2ip(name)!=0) + return 0; if ((ip=str2ip6(name))!=0){ return ip_addr2he(name, ip); } @@ -2963,6 +2971,8 @@ inline static int dns_a_resolve( struct dns_hash_entry** e, ret=-E_DNS_NO_IP; if (*e==0){ /* do lookup */ /* if ip don't set *e */ + if (str2ip6(name)!=0) + goto error; if ((tmp=str2ip(name))!=0){ *ip=*tmp; *rr_no=0; @@ -3012,6 +3022,8 @@ inline static int dns_aaaa_resolve( struct dns_hash_entry** e, ret=-E_DNS_NO_IP; if (*e==0){ /* do lookup */ /* if ip don't set *e */ + if (str2ip(name)!=0) + goto error; if ((tmp=str2ip6(name))!=0){ *ip=*tmp; *rr_no=0;

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
20
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2013