sr-dev December 2013

sr-dev@lists.kamailio.org

30 participants
318 discussions

git:master: Improved Free at cscf_get_service_route(), caused a reproducable crash

by Carsten Bock

Module: sip-router Branch: master Commit: caa9954d3c017ce741245d8f2b338158caf2270f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=caa9954… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Mon Dec 9 23:00:08 2013 +0100 Improved Free at cscf_get_service_route(), caused a reproducable crash --- lib/ims/ims_getters.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/ims/ims_getters.c b/lib/ims/ims_getters.c index 05450f1..8fce196 100644 --- a/lib/ims/ims_getters.c +++ b/lib/ims/ims_getters.c @@ -1361,14 +1361,16 @@ str* cscf_get_service_route(struct sip_msg *msg, int *size, int is_shm) { h = h->next; } if (is_shm) { - while (h) + h = msg->headers; + while (h) { if (h->name.len == 13 && strncasecmp(h->name.s, "Service-Route", 13) == 0) { h->parsed = 0; r = (rr_t*) h->parsed; free_rr(&r); } - h = h->next; + h = h->next; + } } return x;

11 years

[tracker] Comment added: Crash in TCP Read on Kamailio 4.0.1

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#364 - Crash in TCP Read on Kamailio 4.0.1 User who did this - Daniel-Constantin Mierla (miconda) ---------- Maybe Hugh or Peter can check it quickly, being a patch to websocket module. If nobody has time to get to it, definitely I will do it before we have next release out of branch 4.1. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=364#comment1239 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

git:3.2: rtpproxy: Regenerated Readme after last commit

by Carsten Bock

Module: sip-router Branch: 3.2 Commit: 8aa0367b807374ec691c3fc44232185ecf1bee63 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8aa0367… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Fri Dec 20 10:53:17 2013 +0100 rtpproxy: Regenerated Readme after last commit --- modules/rtpproxy/README | 114 +++++++++++++++++++++++----------------------- 1 files changed, 57 insertions(+), 57 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=8aa…

11 years

[tracker] Comment added: Crash in TCP Read on Kamailio 4.0.1

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#364 - Crash in TCP Read on Kamailio 4.0.1 User who did this - Vitaliy Aleksandrov (Vitaliy) ---------- Just want to remind that current 4.1 branch still has a bug described in the previous comment. Fixed version is working without any issues for the last 6 days. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=364#comment1238 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

git:4.0: modules/ims_registrar_pcscf: fix log

by Camille Oudot

Module: sip-router Branch: 4.0 Commit: 3c1ac9fa2664978c8cfd5b4a217df0163699c0b1 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3c1ac9f… Author: Camille Oudot <camille.oudot(a)orange.com> Committer: Camille Oudot <camille.oudot(a)orange.com> Date: Tue Nov 26 16:08:35 2013 +0100 modules/ims_registrar_pcscf: fix log --- modules/ims_registrar_pcscf/service_routes.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/ims_registrar_pcscf/service_routes.c b/modules/ims_registrar_pcscf/service_routes.c index 06dc709..a8d7d97 100644 --- a/modules/ims_registrar_pcscf/service_routes.c +++ b/modules/ims_registrar_pcscf/service_routes.c @@ -349,7 +349,7 @@ int force_service_routes(struct sip_msg* _m, udomain_t* _d) { } LM_DBG("Setting dst_uri to <%.*s> \n", c->service_routes[0].len, - c->service_routes[i].s); + c->service_routes[0].s); if (set_dst_uri(_m, &c->service_routes[0]) !=0 ) { LM_ERR("Error setting new dst uri\n");

11 years

planning release of v4.0.5

by Daniel-Constantin Mierla

Hello, I am considering to release a new version out of branch 4.0 (previous stable branch) before Christmas holidays. Depending on the available time, it could be this Friday or next week on Monday. If there are patches to be backported, do them as soon as possible. Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

11 years

git:3.2: rtpproxy: Fixed Typo: $rtpstart => $rtpstat

by Carsten Bock

Module: sip-router Branch: 3.2 Commit: 3b94dba6644feefe241d830c098a7e64f4b857d0 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3b94dba… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Fri Dec 20 10:25:18 2013 +0100 rtpproxy: Fixed Typo: $rtpstart => $rtpstat Thanks to Victor V. Kustov for pointing that out. --- modules/rtpproxy/doc/rtpproxy_admin.xml | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/rtpproxy/doc/rtpproxy_admin.xml b/modules/rtpproxy/doc/rtpproxy_admin.xml index 8c9bb4c..66ad7ad 100644 --- a/modules/rtpproxy/doc/rtpproxy_admin.xml +++ b/modules/rtpproxy/doc/rtpproxy_admin.xml @@ -645,7 +645,7 @@ start_recording(); <section> <title>Exported Pseudo Variables</title> <section> - <title><function moreinfo="none">$rtpstart</function></title> + <title><function moreinfo="none">$rtpstat</function></title> <para> Returns the RTP-Statistics from the RTP-Proxy. The RTP-Statistics from the RTP-Proxy are provided as a string and it does contain several packet-counters. The statistics

11 years

Missing readme docs for IMS modules

by Daniel-Constantin Mierla

Hello, reported on sr-users, some ims modules don't have docbook files nor README: ims_registrar_pcscf ims_usrloc_scscf Can any of the IMS folks take care of them? Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

11 years

git:master: modules:/ims_registrar_scscf: when processing subscriptions to reg events allow the ruri to be the contact of the S-CSCF and get the presentity from the to-header

by Richard Good

Module: sip-router Branch: master Commit: ef66bf4ce961a7379bb21e848f70d03defb8864c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ef66bf4… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Fri Dec 20 10:09:35 2013 +0200 modules:/ims_registrar_scscf: when processing subscriptions to reg events allow the ruri to be the contact of the S-CSCF and get the presentity from the to-header --- modules/ims_registrar_scscf/registrar_notify.c | 12 ++++-------- 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/modules/ims_registrar_scscf/registrar_notify.c b/modules/ims_registrar_scscf/registrar_notify.c index 70fcc95..06c2987 100644 --- a/modules/ims_registrar_scscf/registrar_notify.c +++ b/modules/ims_registrar_scscf/registrar_notify.c @@ -137,8 +137,8 @@ int can_subscribe_to_reg(struct sip_msg *msg, char *_t, char *str2) { goto done; } - //get the target/presentity URI from the request uri - presentity_uri = cscf_get_public_identity_from_requri(msg); + //get the target/presentity URI from To header + cscf_get_to_uri(msg, &presentity_uri); asserted_id = cscf_get_asserted_identity(msg); @@ -215,10 +215,8 @@ int can_subscribe_to_reg(struct sip_msg *msg, char *_t, char *str2) { ul.unlock_udomain((udomain_t*) _t, &presentity_uri); done: - if (presentity_uri.s) shm_free(presentity_uri.s); return ret; error: - if (presentity_uri.s) shm_free(presentity_uri.s); ret = CSCF_RETURN_ERROR; return ret; } @@ -410,8 +408,8 @@ int subscribe_to_reg(struct sip_msg *msg, char *_t, char *str2) { } } - //get the presentity uri from the request uri - presentity_uri = cscf_get_public_identity_from_requri(msg); + //get the presentity uri from To Header + cscf_get_to_uri(msg, &presentity_uri); //get the watcher uri from the to header cscf_get_from_uri(msg, &watcher_impu); @@ -551,12 +549,10 @@ int subscribe_to_reg(struct sip_msg *msg, char *_t, char *str2) { //free memory if (record_route.s) pkg_free(record_route.s); - if (presentity_uri.s) shm_free(presentity_uri.s); return ret; error: //free memory if (record_route.s) pkg_free(record_route.s); - if (presentity_uri.s) shm_free(presentity_uri.s); return ret; }

11 years

git:master: acc: use r-uri winning branch even for local generated replies

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 81b9c83b2fa3bd32d502a1ae9014cc7d6747e710 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=81b9c83… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Dec 19 21:15:12 2013 +0100 acc: use r-uri winning branch even for local generated replies - it was only for received and relayed replies - reported by Kelvin Chua --- modules/acc/acc_logic.c | 27 +++++++++++++++++++++++---- 1 files changed, 23 insertions(+), 4 deletions(-) diff --git a/modules/acc/acc_logic.c b/modules/acc/acc_logic.c index 50278fb..18437fc 100644 --- a/modules/acc/acc_logic.c +++ b/modules/acc/acc_logic.c @@ -344,11 +344,20 @@ static inline void on_missed(struct cell *t, struct sip_msg *req, { str new_uri_bk = {0, 0}; int flags_to_reset = 0; + int br = -1; - /* set as new_uri the last branch */ + /* get winning branch index, if set */ if (t->relayed_reply_branch>=0) { + br = t->relayed_reply_branch; + } else { + if(code>=300) { + br = tmb.t_get_picked_branch(); + } + } + /* set as new_uri the one from selected branch */ + if (br>=0) { new_uri_bk = req->new_uri; - req->new_uri = t->uac[t->relayed_reply_branch].uri; + req->new_uri = t->uac[br].uri; req->parsed_uri_ok = 0; } else { new_uri_bk.len = -1; @@ -416,6 +425,7 @@ static inline void acc_onreply( struct cell* t, struct sip_msg *req, struct sip_msg *reply, int code) { str new_uri_bk; + int br = -1; /* acc_onreply is bound to TMCB_REPLY which may be called from _reply, like when FR hits; we should not miss this @@ -426,10 +436,19 @@ static inline void acc_onreply( struct cell* t, struct sip_msg *req, if (!should_acc_reply(req, reply, code)) return; - /* for reply processing, set as new_uri the winning branch */ + /* get winning branch index, if set */ if (t->relayed_reply_branch>=0) { + br = t->relayed_reply_branch; + } else { + if(code>=300) { + br = tmb.t_get_picked_branch(); + } + } + + /* for reply processing, set as new_uri the one from selected branch */ + if (br>=0) { new_uri_bk = req->new_uri; - req->new_uri = t->uac[t->relayed_reply_branch].uri; + req->new_uri = t->uac[br].uri; req->parsed_uri_ok = 0; } else { new_uri_bk.len = -1;

11 years

← Newer
1
2
3
4
5
6
7
8
9
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2013