sr-dev December 2013

sr-dev@lists.kamailio.org

30 participants
319 discussions

Various fixes for Kamailio's IMS code
by Rob Day 08 Jan '14

08 Jan '14

Hi, I've been trying to set up Kamailio 4.0.5 as a P-CSCF, I-CSCF and S-CSCF today, and hit a few issues which I've fixed. http://sip-router.org/contribute/ suggests that patches should be submitted to this list, so here I am. The first issue I hit was the sem_post issue that has been reported from time to time (http://lists.kamailio.org/pipermail/sr-users/2013-January/076554.html) - it looks as though sem_post is only included in -lpthread on Ubuntu 12.04, not -lrt (https://bugs.launchpad.net/ubuntu/+source/manpages/+bug/874418), so I've updated some Makefiles to reflect that. I subsequently hit a segfault when calling pcscf_save: I've tracked this down to a while loop that was missing curly braces, and so tried to dereference a null pointer. I think there's another bug in this piece of code - because h is NULL at the end of the first while loop, we never go round the second loop, and so never call free_rr. It looks like even if we did, h->parsed has been set to 0 before we try and free it, so nothing would happen. I wasn't sure how the memory management here works, though, and so haven't tried to change this. I also found that the ims_auth module didn't handle standard SIP Digest authentication on the MAR interface, only AKA and Digest-MD5 (which seems to be specific to OpenIMSCore HSS, and not mentioned in the IMS specs). Most of the code to allow SIP Digest authentication was already there, so I just hooked the last piece in to get it to work. I'm not sure whether this counts as a new feature or a bugfix - it's not clear whether this was meant to be supported but just missing a piece, or not meant to be supported but very easy to add in. Finally, I was working from the 4.0 nightlies Debian repository, and the examples/scsf/kamailio.cfg file for 4.0.x seems to skip authentication. It looks like this section has been reworked heavily in 4.1.0, so this may be less important - but I put together a different kamailio.cfg based on a mailing list post (http://lists.sip-router.org/pipermail/sr-users/2013-March/077142.html), and it might make sense to use that as the default file for 4.0.x. The attached patches are against the 4.0 branch in Git (specifically, commit 1b98961522fd8a7eb73ecc7d1772541f8b81aabc). I'm happy to apply any feedback which more knowledgeable contributors have. Best regards, Rob

6 6

Happy New Year!
by Daniel-Constantin Mierla 02 Jan '14

02 Jan '14

Another year packed in the archive, thanks everyone for filling it with excellent achievements and, along them, keeping Kamailio project moving forward! I expect another wonderful year ahead for the project and I am looking forward to collaborating further within this brilliant community as well as meeting many of you at Kamailio World and other events worldwide. I wish everyone a prosperous and successful 2014! Happy new year! Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

2 1

git:master: modules/sipcapture: Fixed bad timestamp in the raw socket mode
by Alexandr Dubovikov 31 Dec '13

31 Dec '13

Module: sip-router Branch: master Commit: cc34c8e2c1e0eeafa0088c2d159260e4b10652c9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cc34c8e… Author: Alexandr Dubovikov <alexandr.dubovikov(a)gmail.com> Committer: Alexandr Dubovikov <alexandr.dubovikov(a)gmail.com> Date: Tue Dec 31 23:24:02 2013 +0100 modules/sipcapture: Fixed bad timestamp in the raw socket mode HEPpy New Year! --- modules/sipcapture/sipcapture.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/modules/sipcapture/sipcapture.c b/modules/sipcapture/sipcapture.c index 913c240..dc46ab8 100644 --- a/modules/sipcapture/sipcapture.c +++ b/modules/sipcapture/sipcapture.c @@ -1017,7 +1017,8 @@ static int child_init(int rank) LM_ERR("no more pkg memory left\n"); return -1; } - + + heptime->tv_sec = 0; return 0; }

1 0

git:refs/tags/4.0.5: ChangeLog: content updated for v4.0.5
by Victor Seva 29 Dec '13

29 Dec '13

Module: sip-router Branch: refs/tags/4.0.5 Commit: 7eea50f066d9202f17c5e352fbaffe719d1df267 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7eea50f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Dec 20 17:27:38 2013 +0100 ChangeLog: content updated for v4.0.5 --- ChangeLog | 282 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 282 insertions(+), 0 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=7ee…

1 0

git:refs/tags/3.3.6: ChangeLog: updated for v3.3.6
by Victor Seva 29 Dec '13

29 Dec '13

Module: sip-router Branch: refs/tags/3.3.6 Commit: 48db3424eb8b1c4870c8c990fa5e7cddef416c18 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=48db342… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Dec 19 16:56:17 2013 +0100 ChangeLog: updated for v3.3.6 --- ChangeLog | 107 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 107 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index ffe0199..ea415ca 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,110 @@ +===================== 2013-12-18 Version 3.3.6 Released ===================== + +===================== Changes Since Version 3.3.5 =========================== + +commit 2cc9e1dae56bc8c4a78e7cb01d4f5719c618c213 +Author: Daniel-Constantin Mierla <miconda(a)gmail.com> +Date: Thu Dec 19 16:45:42 2013 +0100 + + Makefile.defs: version set to 3.3.6 + +commit 4cc43066cb2b9dcfc3c0d0d5ab67b28dd2c19189 +Author: Daniel-Constantin Mierla <miconda(a)gmail.com> +Date: Thu Dec 19 16:45:09 2013 +0100 + + pkg/rpm: updated specs to version to 3.3.6 + +commit 7157d105c1efb10db7852adffbf55ec2803b3d44 +Author: Daniel-Constantin Mierla <miconda(a)gmail.com> +Date: Thu Dec 19 16:44:22 2013 +0100 + + pkg/debian: updated specs to version to 3.3.6 + +commit ee62d8542dbc6f9391e59018560e17a0459e7a64 +Author: Daniel-Constantin Mierla <miconda(a)gmail.com> +Date: Fri Sep 20 11:15:16 2013 +0200 + + registrar: if rcv_parm value is empty, don't add received to contacts in 200ok reply + + - otherwise results in malformed value + + (cherry picked from commit 2f213e313a86e16665f6d0acfec959bf23f72b7d) + (cherry picked from commit fc410ae69c6b371538f457947fd3a2946dc492cd) + +commit efd3fad94f179b27ac364c16df6cd69d27d814c3 +Author: Daniel-Constantin Mierla <miconda(a)gmail.com> +Date: Mon Dec 2 20:42:12 2013 +0100 + + mem: malloc(0) should return a valid pointer for free according to specs + + (cherry picked from commit f61ff34aac7c7bae3a96fb698a899c8a0e692a9f) + (cherry picked from commit e605174dab9b86ce06689d184b4b9d81288f1193) + +commit aa43b51c87e025d9526f31059dee55c2199e970f +Author: Daniel-Constantin Mierla <miconda(a)gmail.com> +Date: Thu Dec 19 16:24:32 2013 +0100 + + core: declared static and extern inline prototypes for gcc (clang) on mac os x + +commit 7ad6202d80d5fee7248db732a789d37e48b24d1e +Author: Daniel-Constantin Mierla <miconda(a)gmail.com> +Date: Fri Dec 6 16:33:04 2013 +0100 + + Makefile.defs: compiler optimization level made variable + + - allow using -O3 for clang, which gives error on the former default -O9 + + (cherry picked from commit 0713c0de50f8c2f4da2ee0ef33b0505c37792392) + + Conflicts: + Makefile.defs + +commit 16dcfd515424a23cd0706de64eea822c88df0c58 +Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> +Date: Mon Sep 17 17:21:02 2012 +0300 + + Makefiles.defs: clang compiles to O9 + + (cherry picked from commit 5273948a6eeb6f6fe878696dce54880cabb0ef7c) + +commit 8cd628522a4258f32923fe58595677b300292b97 +Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> +Date: Mon Sep 17 10:17:41 2012 +0300 + + Provide inline linkage for non-gcc compilers(like clang) + + Inline method in headers should be declared extern. + + (cherry picked from commit 2e5145ecdd8368c947ea93b98449ebd997824ce2) + +commit e53fdcd77f918c634119c8188f35d5fd3873b48e +Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> +Date: Fri Sep 14 13:17:24 2012 +0300 + + core: Added support for the clang compiler + + Support for clang, a C compiler from the LLVM suite has been added. + Install clang and run 'make cfg CC=clang && make' for building. GCC Inline assembly is supported. + TODO: clean warning caused by clang (-Wunused-variable, etc) + + (cherry picked from commit 452c543de61d413351a5ac0816adc137d150824b) + +commit f0203464ddc1e6f4b90d8d8d2bf0ff953760ba6c +Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> +Date: Fri Nov 1 15:33:08 2013 +0100 + + registrar: clean static values at pack_ci + + - backport from master 66185905850cd2ac9ab933776184da0f0882e5ac + +commit 5a71476e054975a659628aeec89a51a1d0a326f4 +Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> +Date: Fri Nov 29 12:03:14 2013 +0100 + + usrloc: db_update contact by instance + reg_id + + - backport from master f67171cf3be1ade0e1c9dd013d560c87b3fd4359 + ===================== 2013-08-12 Version 3.3.5 Released ===================== ===================== Changes Since Version 3.3.4 ===========================

1 0

[tracker] Comment added: Crash in kamailio core - timeout on forked destinations
by sip-router 28 Dec '13

28 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#384 - Crash in kamailio core - timeout on forked destinations User who did this - Hugh Waite (hugh.waite) ---------- Sometimes this issue does not cause a crash, but multiple 603s are sent to the caller In a different case, if the working connection responds with a 200 OK, the other branches are cancelled and the 200 is forwarded immediately. The 'cancelled' branches respond with 408 Timeout responses to the INVITE (10 seconds after the INVITE) and all the 408s are forwarded as well instead of being absorbed - this doesn't seem to cause a crash (yet). This is using the ims s-cscf example config. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=384#comment1251 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: htable: added section id for functions and parameters
by Daniel-Constantin Mierla 27 Dec '13

27 Dec '13

Module: sip-router Branch: master Commit: 0e0b8cd883718bb5d19999e800159add7714f69e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0e0b8cd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Dec 27 23:31:41 2013 +0100 htable: added section id for functions and parameters --- modules/htable/doc/htable_admin.xml | 32 ++++++++++++++++---------------- 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/modules/htable/doc/htable_admin.xml b/modules/htable/doc/htable_admin.xml index 3279738..b17902c 100644 --- a/modules/htable/doc/htable_admin.xml +++ b/modules/htable/doc/htable_admin.xml @@ -210,7 +210,7 @@ if(is_present_hf("Authorization")) </section> <section> <title>Parameters</title> - <section> + <section id="htable.p.htable"> <title><varname>htable</varname> (str)</title> <para> The definition of a hash table. The value of the parameter must have the @@ -298,7 +298,7 @@ modparam("htable", "htable", "c=>size=4;autoexpire=7200;initval=1;dmqreplicat </programlisting> </example> </section> - <section> + <section id="htable.p.db_url"> <title><varname>db_url</varname> (str)</title> <para> The URL to connect to database for loading values in hash @@ -318,7 +318,7 @@ modparam("htable", "db_url", "&defaultdb;") </programlisting> </example> </section> - <section> + <section id="htable.p.key_name_column"> <title><varname>key_name_column</varname> (str)</title> <para> The name of the column containing hash table key name. @@ -337,7 +337,7 @@ modparam("htable", "key_name_column", "kname") </programlisting> </example> </section> - <section> + <section id="htable.p.key_type_column"> <title><varname>key_type_column</varname> (str)</title> <para> The name of the column containing hash table key type. @@ -356,7 +356,7 @@ modparam("htable", "key_type_column", "ktype") </programlisting> </example> </section> - <section> + <section id="htable.p.value_type_column"> <title><varname>value_type_column</varname> (str)</title> <para> The name of the column containing hash table value type. @@ -375,7 +375,7 @@ modparam("htable", "value_type_column", "vtype") </programlisting> </example> </section> - <section> + <section id="htable.p.key_value_column"> <title><varname>key_value_column</varname> (str)</title> <para> The name of the column containing hash table key value. @@ -394,7 +394,7 @@ modparam("htable", "key_value_column", "kvalue") </programlisting> </example> </section> - <section> + <section id="htable.p.expires_column"> <title><varname>expires_column</varname> (str)</title> <para> The name of the column containing expires type. @@ -413,7 +413,7 @@ modparam("htable", "expires", "expiry") </programlisting> </example> </section> - <section> + <section id="htable.p.array_size_suffix"> <title><varname>array_size_suffix</varname> (str)</title> <para> The suffix to be added to store the number of items in an @@ -433,7 +433,7 @@ modparam("htable", "array_size_suffix", "-count") </programlisting> </example> </section> - <section> + <section id="htable.p.fetch_rows"> <title><varname>fetch_rows</varname> (integer)</title> <para> How many rows to fetch at once from database. @@ -452,7 +452,7 @@ modparam("htable", "fetch_rows", 1000) </programlisting> </example> </section> - <section> + <section id="htable.p.timer_interval"> <title><varname>timer_interval</varname> (integer)</title> <para> Interval in seconds to check for expired htable values. @@ -471,7 +471,7 @@ modparam("htable", "timer_interval", 10) </programlisting> </example> </section> - <section> + <section id="htable.p.timer_mode"> <title><varname>timer_mode</varname> (integer)</title> <para> If set to 1, will start a new timer process. If set to 0 @@ -492,7 +492,7 @@ modparam("htable", "timer_mode", 1) </programlisting> </example> </section> - <section> + <section id="htable.p.db_expires"> <title><varname>db_expires</varname> (integer)</title> <para> If set to 1, will load/save the expires values of the items in @@ -513,7 +513,7 @@ modparam("htable", "db_expires", 1) </programlisting> </example> </section> - <section> + <section id="htable.p.enable_dmq"> <title><varname>enable_dmq</varname> (integer)</title> <para> If set to 1, will enable DMQ replication of actions performed upon @@ -543,7 +543,7 @@ modparam("htable", "enable_dmq", 1) </section> <section> <title>Functions</title> - <section> + <section id="htable.f.sht_print"> <title> <function moreinfo="none">sht_print()</function> </title> @@ -564,7 +564,7 @@ sht_print(); </programlisting> </example> </section> - <section> + <section id="htable.f.sht_rm_name_re"> <title> <function moreinfo="none">sht_rm_name_re(htable=>regexp)</function> </title> @@ -585,7 +585,7 @@ sht_rm_name_re("ha=>.*"); </programlisting> </example> </section> - <section> + <section id="htable.f.sht_rm_value_re"> <title> <function moreinfo="none">sht_rm_value_re(htable=>regexp)</function> </title>

1 0

git:3.3: modules_k/pua: added some missing lock releases (backport)
by Juha Heinanen 27 Dec '13

27 Dec '13

Module: sip-router Branch: 3.3 Commit: 1d5618ad356c16973b699ecea223424bcca9c513 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1d5618a… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Fri Dec 27 12:11:30 2013 +0200 modules_k/pua: added some missing lock releases (backport) --- modules_k/pua/send_subscribe.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/modules_k/pua/send_subscribe.c b/modules_k/pua/send_subscribe.c index c1476cd..14435a4 100644 --- a/modules_k/pua/send_subscribe.c +++ b/modules_k/pua/send_subscribe.c @@ -1012,8 +1012,12 @@ int send_subscribe(subs_info_t* subs) insert: if (subs->expires == 0) + { /* Don't create a new dialog when expires == 0 */ - goto done; + if (dbmode != PUA_DB_ONLY) + lock_release(&HashT->p_records[hash_code].lock); + goto done; + } if(subs->flag & UPDATE_TYPE) { @@ -1026,6 +1030,8 @@ insert: { LM_ERR("while building callback" " param\n"); + if (dbmode != PUA_DB_ONLY) + lock_release(&HashT->p_records[hash_code].lock); goto error; } hentity->flag= flag; @@ -1050,6 +1056,8 @@ insert: uac_r.dialog = 0; } shm_free(hentity); + if (dbmode != PUA_DB_ONLY) + lock_release(&HashT->p_records[hash_code].lock); /* Although this is an error must not return -1 as the calling function must continue processing. */ @@ -1071,6 +1079,8 @@ insert: if(presentity== NULL) { LM_ERR("no more share memory\n"); + if (dbmode != PUA_DB_ONLY) + lock_release(&HashT->p_records[hash_code].lock); goto error; } memset(presentity, 0, size);

1 0

git:4.0: modules/pua: added some missing lock releases
by Juha Heinanen 27 Dec '13

27 Dec '13

Module: sip-router Branch: 4.0 Commit: 1b98961522fd8a7eb73ecc7d1772541f8b81aabc URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1b98961… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Thu Dec 26 17:51:04 2013 +0200 modules/pua: added some missing lock releases (cherry picked from commit 4eb338611e716e7a32f252acbae52bace6047a0a) --- modules/pua/send_subscribe.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/modules/pua/send_subscribe.c b/modules/pua/send_subscribe.c index 006bae4..d568ff2 100644 --- a/modules/pua/send_subscribe.c +++ b/modules/pua/send_subscribe.c @@ -1030,8 +1030,12 @@ int send_subscribe(subs_info_t* subs) insert: if (subs->expires == 0) + { /* Don't create a new dialog when expires == 0 */ - goto done; + if (dbmode != PUA_DB_ONLY) + lock_release(&HashT->p_records[hash_code].lock); + goto done; + } if(subs->flag & UPDATE_TYPE) { @@ -1044,6 +1048,8 @@ insert: { LM_ERR("while building callback" " param\n"); + if (dbmode != PUA_DB_ONLY) + lock_release(&HashT->p_records[hash_code].lock); goto error; } hentity->flag= flag; @@ -1068,6 +1074,8 @@ insert: uac_r.dialog = 0; } shm_free(hentity); + if (dbmode != PUA_DB_ONLY) + lock_release(&HashT->p_records[hash_code].lock); /* Although this is an error must not return -1 as the calling function must continue processing. */ @@ -1089,6 +1097,8 @@ insert: if(presentity== NULL) { LM_ERR("no more share memory\n"); + if (dbmode != PUA_DB_ONLY) + lock_release(&HashT->p_records[hash_code].lock); goto error; } memset(presentity, 0, size);

1 0

git:4.1: modules/pua: added some missing lock releases
by Juha Heinanen 27 Dec '13

27 Dec '13

Module: sip-router Branch: 4.1 Commit: a4060da5e1fe1e64c224ff32d669a699a0d5cd1d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a4060da… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Thu Dec 26 17:51:04 2013 +0200 modules/pua: added some missing lock releases (cherry picked from commit 4eb338611e716e7a32f252acbae52bace6047a0a) --- modules/pua/send_subscribe.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/modules/pua/send_subscribe.c b/modules/pua/send_subscribe.c index 006bae4..d568ff2 100644 --- a/modules/pua/send_subscribe.c +++ b/modules/pua/send_subscribe.c @@ -1030,8 +1030,12 @@ int send_subscribe(subs_info_t* subs) insert: if (subs->expires == 0) + { /* Don't create a new dialog when expires == 0 */ - goto done; + if (dbmode != PUA_DB_ONLY) + lock_release(&HashT->p_records[hash_code].lock); + goto done; + } if(subs->flag & UPDATE_TYPE) { @@ -1044,6 +1048,8 @@ insert: { LM_ERR("while building callback" " param\n"); + if (dbmode != PUA_DB_ONLY) + lock_release(&HashT->p_records[hash_code].lock); goto error; } hentity->flag= flag; @@ -1068,6 +1074,8 @@ insert: uac_r.dialog = 0; } shm_free(hentity); + if (dbmode != PUA_DB_ONLY) + lock_release(&HashT->p_records[hash_code].lock); /* Although this is an error must not return -1 as the calling function must continue processing. */ @@ -1089,6 +1097,8 @@ insert: if(presentity== NULL) { LM_ERR("no more share memory\n"); + if (dbmode != PUA_DB_ONLY) + lock_release(&HashT->p_records[hash_code].lock); goto error; } memset(presentity, 0, size);

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2013