sr-dev December 2012

sr-dev@lists.kamailio.org

34 participants
438 discussions

Possible MSRP enhancement
by Peter Dunkley 05 Dec '12

05 Dec '12

Hi Daniel, I know you were thinking of looking at the MSRP module before the next release, and during discussions here at Crocodile we realised that there was another enhancement that would be useful. An MSRP relay has the option of splitting large MSRP messages (including those that are already chunked) into smaller chunks. The reason is that there is no maximum size for an MSRP chunk, so it is entirely possible for a client to attempt to send a large file in a single, very-large, MSRP message. In this cases it becomes important to pull the message from the receive buffer in small pieces (instead of waiting for a complete message to arrive and over-flowing the receive buffer) and relaying it in smaller chunks. Also, the flow control for MSRP is based around TCP windowing, so if you want to limit the rate that someone is sending you MSRP messages (for example during the transfer of a large file) you do so by pulling from the TCP buffer at a lower rate. One way of avoiding overloading an MSRP relay is to have fairly small TCP receive buffers thereby limiting the rate at which clients and relays can send data. However, if the TCP buffers are small the chances of a client sending a message or chunk that is too large (and needs to be chunked by the relay) increases further. Of course, to do this the MSRP module will need to be able to remember the (From|To)-Path, transaction ID, and so on from the start of the MSRP message so that it can use these (along with calculated Byte-Range) in each additional chunk. I was thinking a new parameter indicating the maximum MSRP send chunk size is required. If an MSRP message in the receive buffer reaches that number then it has to be pulled from the buffer in parts and relayed as multiple chunks. This maximum send chunk size should be set to be much smaller than the TCP receive buffer size. Regards, Peter -- Peter Dunkley Technical Director Crocodile RCS Ltd

2 2

xhttp_pi module installation
by Daniel-Constantin Mierla 04 Dec '12

04 Dec '12

Hello, I see that xhttp_pi module depends on libxml2, but it is compiled and installed by default. It should be added in the excluded modules list. Regarding packaging, perhaps its place is in xml-modules package. Also, it installs a dedicated config file from the core Makefile. It is no longer the proper way to do it. Each module can install additional config file once they are installed. See the Makefile of the tls module, which installs tls.cfg only when the module is installed as well. It should be done for xhttp_pi module in the same way. Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

2 1

git:master: Makefile: adding xhttp_pi to the list of excluded modules ( depends on libxml2)
by Ovidiu Sas 04 Dec '12

04 Dec '12

Module: sip-router Branch: master Commit: 205e8545dca12bebf742b23eba592d2713623a66 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=205e854… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Tue Dec 4 17:03:15 2012 -0500 Makefile: adding xhttp_pi to the list of excluded modules (depends on libxml2) --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index ee58a21..4d22414 100644 --- a/Makefile +++ b/Makefile @@ -330,7 +330,7 @@ else # depends on libpython-dev exclude_modules+= app_python # depends on libxml2 - exclude_modules+= xmlops + exclude_modules+= xmlops xhttp_pi # depends on jsoc-c exclude_modules+= json jsonrpc-c # depends on libhiredis

1 0

git:master: xhttp_pi: fix installation of the pi_framework.xml file
by Ovidiu Sas 04 Dec '12

04 Dec '12

Module: sip-router Branch: master Commit: 7a63bbed0ccc1a2a85b26d127e775f832efaa2a7 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7a63bbe… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Tue Dec 4 16:18:12 2012 -0500 xhttp_pi: fix installation of the pi_framework.xml file --- Makefile | 8 -------- modules/xhttp_pi/Makefile | 12 ++++++++++++ 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/Makefile b/Makefile index 08c3245..ee58a21 100644 --- a/Makefile +++ b/Makefile @@ -1000,14 +1000,6 @@ install-cfg: $(cfg_prefix)/$(cfg_dir) fi ; \ fi ; \ done; true - # provisionning xml framework - $(INSTALL_TOUCH) $(cfg_prefix)/$(cfg_dir)/pi_framework.xml.sample - $(INSTALL_CFG) examples/pi_framework.xml \ - $(cfg_prefix)/$(cfg_dir)/pi_framework.xml.sample - if [ ! -f $(cfg_prefix)/$(cfg_dir)/pi_framework.xml ]; then \ - mv -f $(cfg_prefix)/$(cfg_dir)/pi_framework.xml.sample \ - $(cfg_prefix)/$(cfg_dir)/pi_framework.xml; \ - fi # radius dictionary $(INSTALL_TOUCH) $(cfg_prefix)/$(cfg_dir)/dictionary.$(CFG_NAME) $(INSTALL_CFG) etc/dictionary.$(CFG_NAME) $(cfg_prefix)/$(cfg_dir) diff --git a/modules/xhttp_pi/Makefile b/modules/xhttp_pi/Makefile index d98c979..8982013 100644 --- a/modules/xhttp_pi/Makefile +++ b/modules/xhttp_pi/Makefile @@ -27,3 +27,15 @@ DEFS+=-DKAMAILIO_MOD_INTERFACE SERLIBPATH=../../lib SER_LIBS+=$(SERLIBPATH)/srdb1/srdb1 include ../../Makefile.modules + +install-cfg: + # provisionning xml framework + @$(call try_err, $(INSTALL_TOUCH) $(cfg_prefix)/$(cfg_dir)/pi_framework.xml.sample) + @$(call try_err, $(INSTALL_CFG) ../../examples/pi_framework.xml \ + $(cfg_prefix)/$(cfg_dir)/pi_framework.xml.sample) + @if [ -z "${skip_cfg_install}" -a \ + ! -f $(cfg_prefix)/$(cfg_dir)/pi_framework.xml ]; then \ + mv -f $(cfg_prefix)/$(cfg_dir)/pi_framework.xml.sample \ + $(cfg_prefix)/$(cfg_dir)/pi_framework.xml; \ + fi +

1 0

git:master: sca: fix DB updates
by Andrew Mortensen 04 Dec '12

04 Dec '12

Module: sip-router Branch: master Commit: 5871982d3c76a4b42cd05e4b8dfb0e6128acb799 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5871982… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Committer: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Tue Dec 4 17:04:11 2012 -0500 sca: fix DB updates - if a subscription were updated before being inserted into the DB, the next DB sync call would incorrectly try to UPDATE instead of INSERT. - no effect on SCA functionality, but subscriptions are no longer lost across restarts. --- modules/sca/sca_subscribe.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/sca/sca_subscribe.c b/modules/sca/sca_subscribe.c index 16368e3..54331ef 100644 --- a/modules/sca/sca_subscribe.c +++ b/modules/sca/sca_subscribe.c @@ -826,8 +826,10 @@ sca_subscription_update_unsafe( sca_mod *scam, sca_subscription *saved_sub, saved_sub->dialog.notify_cseq += 1; saved_sub->expires = time( NULL ) + update_sub->expires; - /* flag subscription for write back to DB */ - saved_sub->db_cmd_flag = SCA_DB_FLAG_UPDATE; + /* flag subscription for DB update only if we've already inserted */ + if ( saved_sub->db_cmd_flag == SCA_DB_FLAG_NONE ) { + saved_sub->db_cmd_flag = SCA_DB_FLAG_UPDATE; + } if ( update_sub->index != SCA_CALL_INFO_APPEARANCE_INDEX_ANY ) { saved_sub->index = update_sub->index;

1 0

git:master: sca: sca_subscription_print now logs at debug level
by Andrew Mortensen 04 Dec '12

04 Dec '12

Module: sip-router Branch: master Commit: a289c6167f39f14af85d78392a8bef91da81d858 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a289c61… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Committer: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Tue Dec 4 16:47:39 2012 -0500 sca: sca_subscription_print now logs at debug level - previously logged at info level for every incoming SUBSCRIBE. --- modules/sca/sca_subscribe.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/sca/sca_subscribe.c b/modules/sca/sca_subscribe.c index 5da8acd..16368e3 100644 --- a/modules/sca/sca_subscribe.c +++ b/modules/sca/sca_subscribe.c @@ -676,7 +676,7 @@ sca_subscription_print( void *value ) { sca_subscription *sub = (sca_subscription *)value; - LM_INFO( "%.*s %s (%d) %.*s, expires: %ld, index: %d, " + LM_DBG( "%.*s %s (%d) %.*s, expires: %ld, index: %d, " "dialog %.*s;%.*s;%.*s, record_route: %.*s, " "notify_cseq: %d, subscribe_cseq: %d", STR_FMT( &sub->target_aor ),

1 0

git:master: Makefile: default FLAVOUR set to kamailio
by Daniel-Constantin Mierla 04 Dec '12

04 Dec '12

Module: sip-router Branch: master Commit: 4af2262b88918c316ee3bb9b45a716504f2f8db4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4af2262… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Dec 4 10:28:03 2012 +0100 Makefile: default FLAVOUR set to kamailio - switching to the flavour with packages and docs --- Makefile.defs | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index c4aab26..bc21034 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -123,7 +123,7 @@ endif # verbose set_if_empty=$(if $($(1)),,$(eval override $(1)=$(2))) # flavour: sip-router, ser or kamailio -$(call set_if_empty,FLAVOUR,sip-router) +$(call set_if_empty,FLAVOUR,kamailio) #prefix for various configs and scripts #config name/name-prefix for distributed configs @@ -135,24 +135,24 @@ SRC_NAME=sip-router ifeq ($(FLAVOUR),sip-router) # main binary name -MAIN_NAME=ser +MAIN_NAME?=ser else ifeq ($(FLAVOUR),ser) # main binary name -MAIN_NAME=ser +MAIN_NAME?=ser else ifeq ($(FLAVOUR),kamailio) # main binary name -MAIN_NAME=kamailio +MAIN_NAME?=kamailio # use kamailio config -CFG_NAME=kamailio +CFG_NAME?=kamailio # kamailio statistics on KMSTATS ?= 1 # fast malloc statistics on FMSTATS ?= 1 # application server support on WITHAS ?= 1 -else # default: +else # unknown: # main binary name -MAIN_NAME=sip-router +MAIN_NAME?=kamailio endif # what to install

2 2

git:master: tls: fix cross-compilation
by Ovidiu Sas 04 Dec '12

04 Dec '12

Module: sip-router Branch: master Commit: 389bbe3410018e6d58befb486f0db2ec4ff7ece6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=389bbe3… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Tue Dec 4 15:58:03 2012 -0500 tls: fix cross-compilation --- modules/tls/Makefile | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/modules/tls/Makefile b/modules/tls/Makefile index 8d11f4d..679b37c 100644 --- a/modules/tls/Makefile +++ b/modules/tls/Makefile @@ -10,9 +10,15 @@ auto_gen= NAME=tls.so CFLASFOUND = 0 + +ifeq ($(CROSS_COMPILE),) BUILDER = $(shell which pkg-config) +endif + ifneq ($(BUILDER),) + ifeq ($(CROSS_COMPILE),) SSLLIBS = $(shell pkg-config --silence-errors --libs libssl) + endif ifneq ($(SSLLIBS),) DEFS+= $(shell pkg-config --silence-errors --cflags libssl) LIBS+= $(shell pkg-config --silence-errors --libs libssl)

1 0

git:master: Makefile: fixed the option of setting some variables from command line
by Daniel-Constantin Mierla 04 Dec '12

04 Dec '12

Module: sip-router Branch: master Commit: e5dbe686bcbf15ac59ebbcb84f3bb9b17568c030 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e5dbe68… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Dec 4 21:59:16 2012 +0100 Makefile: fixed the option of setting some variables from command line - resulted in mixing names for config files - issue added in previous commit - reported by Ovidiu Sas --- Makefile.defs | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index f74b0a1..77cd7a2 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -127,7 +127,7 @@ $(call set_if_empty,FLAVOUR,kamailio) #prefix for various configs and scripts #config name/name-prefix for distributed configs -CFG_NAME=sip-router +CFG_NAME?=sip-router #config name/name-prefix for distributed scripts SCR_NAME=sip-router #name in source tree @@ -135,15 +135,15 @@ SRC_NAME=sip-router ifeq ($(FLAVOUR),sip-router) # main binary name -MAIN_NAME?=ser +MAIN_NAME=ser else ifeq ($(FLAVOUR),ser) # main binary name -MAIN_NAME?=ser +MAIN_NAME=ser else ifeq ($(FLAVOUR),kamailio) # main binary name -MAIN_NAME?=kamailio +MAIN_NAME=kamailio # use kamailio config -CFG_NAME?=kamailio +CFG_NAME=kamailio # kamailio statistics on KMSTATS ?= 1 # fast malloc statistics on @@ -152,7 +152,7 @@ FMSTATS ?= 1 WITHAS ?= 1 else # unknown: # main binary name -MAIN_NAME?=kamailio +MAIN_NAME=kamailio endif # what to install

1 0

app_python: expanding log facilities
by Konstantin M. 04 Dec '12

04 Dec '12

Hi Dev, Modified app_python: 1) Added FLAVOUR support 2) Added python objects: Module Properties: Log Levels: L_ALERT L_BUG L_CRIT2 L_CRIT L_ERR L_WARN L_NOTICE L_INFO L_DBG Log Facilities: DEFAULT_FACILITY Module Methods: LM_GEN1(self, int log_level, str msg) LM_GEN2(self, int log_facility, int log_level, str msg) LM_ALERT(self, str msg) LM_CRIT(self, str msg) LM_ERR(self, str msg) LM_WARN(self, str msg) LM_NOTICE(self, str msg) LM_INFO(self, str msg) LM_DBG(self, str msg)

3 8

← Newer
1
...
35
36
37
38
39
40
41
...
44
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2012