sr-dev December 2012

sr-dev@lists.kamailio.org

34 participants
438 discussions

git:master: qos: remove unused variable
by Ovidiu Sas 05 Dec '12

05 Dec '12

Module: sip-router Branch: master Commit: 96c39e3c31f416bbe42b434a8bbf3ece88a8ab52 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=96c39e3… Author: Ovidiu Sas <osas@dbn> Committer: Ovidiu Sas <osas@dbn> Date: Wed Dec 5 13:12:02 2012 -0500 qos: remove unused variable --- modules_k/qos/qos_ctx_helpers.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/modules_k/qos/qos_ctx_helpers.c b/modules_k/qos/qos_ctx_helpers.c index 6c85c9b..16d5cbb 100644 --- a/modules_k/qos/qos_ctx_helpers.c +++ b/modules_k/qos/qos_ctx_helpers.c @@ -504,7 +504,7 @@ error: */ void remove_sdp(qos_ctx_t *qos_ctx, unsigned int dir, struct sip_msg *_m, unsigned int role, unsigned int other_role) { - str *cseq_number, *cseq_method; + str *cseq_number; int cseq_method_id; qos_sdp_t *qos_sdp; @@ -514,7 +514,6 @@ void remove_sdp(qos_ctx_t *qos_ctx, unsigned int dir, struct sip_msg *_m, unsign } cseq_number = &((get_cseq(_m))->number); - cseq_method = &((get_cseq(_m))->method); cseq_method_id = (get_cseq(_m))->method_id; if (_m->first_line.type == SIP_REPLY) {

1 0

cfg compiler warnings
by Ovidiu Sas 05 Dec '12

05 Dec '12

CC (gcc) [kamailio] cfg/cfg_ctx.o cfg/cfg_ctx.c: In function âcfg_set_nowâ: cfg/cfg_ctx.c:490:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:494:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:564:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:564:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:565:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:584:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c: In function âcfg_commitâ: cfg/cfg_ctx.c:1125:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1133:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1185:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1185:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1190:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1225:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1226:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1226:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1228:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c: In function âcfg_add_group_instâ: cfg/cfg_ctx.c:1582:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1583:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1585:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1594:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c: In function âcfg_del_group_instâ: cfg/cfg_ctx.c:1678:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1679:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1681:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1692:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1710:6: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1712:6: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_ctx.c:1718:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] CC (gcc) [kamailio] cfg/cfg_struct.o cfg/cfg_struct.c: In function âapply_add_var_listâ: cfg/cfg_struct.c:1091:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] cfg/cfg_struct.c:1092:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] $ gcc --version gcc (Debian 4.7.2-4) 4.7.2

1 0

dns_cache compiler warnings
by Ovidiu Sas 05 Dec '12

05 Dec '12

CC (gcc) [kamailio] dns_cache.o dns_cache.c: In function âdns_srv_get_nxt_rrâ: dns_cache.c:2296:5: warning: âr_sums[1].r_sumâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[1].rrâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[2].r_sumâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[2].rrâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[3].r_sumâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[3].rrâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[4].r_sumâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[4].rrâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[5].r_sumâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[5].rrâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[6].r_sumâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[6].rrâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[7].r_sumâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[7].rrâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[8].r_sumâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[8].rrâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[9].r_sumâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[9].rrâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[10].r_sumâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[10].rrâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[11].r_sumâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[11].rrâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[12].r_sumâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[12].rrâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[13].r_sumâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[13].rrâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[14].r_sumâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[14].rrâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[15].r_sumâ may be used uninitialized in this function [-Wuninitialized] dns_cache.c:2296:5: warning: âr_sums[15].rrâ may be used uninitialized in this function [-Wuninitialized] $ gcc --version gcc (Debian 4.7.2-4) 4.7.2

1 0

modules_s/eval - survey of usage
by Daniel-Constantin Mierla 05 Dec '12

05 Dec '12

Hello, is anyone using the modules_s/eval module? In the context of merging modules_s/* to modules/*, this one lacks the docbook xml files for readme. It has a text readme file, from where I understand it does script operations using a stack and polish notation expressions. Probably it was developed before the expressions support in config file language, at this moment all its operations can be done directly by the interpreter. I am considering moving the module to obsolete/ folder. If anyone is using it and wants to keep it in modules/*, then he/she has to convert the readme text into docbook format (which is not complex at all, just takes a bit of time, probably like 60 min or even less). If there is no answer in one week about usage, will be sent to obsolete/, from where it can be rescued in case of need (just to be clear for everybody that code is not lost). Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

1 0

git:master: modules/msrp: Updated MSRP example
by Peter Dunkley 05 Dec '12

05 Dec '12

Module: sip-router Branch: master Commit: 8b731296ce80a8fcee582066ce3aad4a2bf95ed3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8b73129… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Fri Nov 9 20:54:14 2012 +0000 modules/msrp: Updated MSRP example --- modules/msrp/README | 5 ++++- modules/msrp/doc/msrp_admin.xml | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/modules/msrp/README b/modules/msrp/README index 5ab57f6..7df482d 100644 --- a/modules/msrp/README +++ b/modules/msrp/README @@ -499,7 +499,10 @@ event_route[msrp:frame-in] { if($sht(msrp=>$var(sessid)::srcaddr) == $null) { # one more hop, but we don't have address in htable - msrp_reply("481", "Session-does-not-exist"); + if ($msrp(method)!="REPORT") + { + msrp_reply("481", "Session-does-not-exist"); + } exit; } else if($msrp(method)!="REPORT") diff --git a/modules/msrp/doc/msrp_admin.xml b/modules/msrp/doc/msrp_admin.xml index 76813d2..5a785bd 100644 --- a/modules/msrp/doc/msrp_admin.xml +++ b/modules/msrp/doc/msrp_admin.xml @@ -544,7 +544,10 @@ event_route[msrp:frame-in] { if($sht(msrp=>$var(sessid)::srcaddr) == $null) { # one more hop, but we don't have address in htable - msrp_reply("481", "Session-does-not-exist"); + if ($msrp(method)!="REPORT") + { + msrp_reply("481", "Session-does-not-exist"); + } exit; } else if($msrp(method)!="REPORT")

1 0

git:master: Merge branch 'master' of ssh://git.sip-router.org/sip-router
by Peter Dunkley 05 Dec '12

05 Dec '12

Module: sip-router Branch: master Commit: 263aae0a48f3a92a0e8c0ce43a7d6f610ea8a239 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=263aae0… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Wed Dec 5 15:13:48 2012 +0000 Merge branch 'master' of ssh://git.sip-router.org/sip-router * 'master' of ssh://git.sip-router.org/sip-router: (268 commits) xcap_client: fix cross-compilation utils: fix libcurl dependency core: print debug message instead of info message when trying to resolve something that is not domain name. Makefile: adding xhttp_pi to the list of excluded modules (depends on libxml2) xhttp_pi: fix installation of the pi_framework.xml file sca: fix DB updates sca: sca_subscription_print now logs at debug level tls: fix cross-compilation Makefile: fixed the option of setting some variables from command line Makefile.defs: version set to 3.4.0-dev7 Makefile: default FLAVOUR set to kamailio sca: more cleanup of SCA example kamailio.cfg sca: include sample kamailio.cfg in docs, update function examples sca: move working example SCA kamailio.cfg to doc subdirectory app_python: better printing stacktrace app_lua: fix cross-compilation app_python: expand log facilities sca: remove public IP from example cfg sca: add working example kamailio.cfg carrierroute: fix cross-compilation ... ---

1 0

git:master: xcap_client: fix cross-compilation
by Ovidiu Sas 05 Dec '12

05 Dec '12

Module: sip-router Branch: master Commit: e819eaa0b0be61b3a818422c0ced244b5250295c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e819eaa… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Wed Dec 5 09:23:45 2012 -0500 xcap_client: fix cross-compilation --- modules_k/xcap_client/Makefile | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/modules_k/xcap_client/Makefile b/modules_k/xcap_client/Makefile index 1a8e6b7..938d45d 100644 --- a/modules_k/xcap_client/Makefile +++ b/modules_k/xcap_client/Makefile @@ -8,20 +8,17 @@ include ../../Makefile.defs auto_gen= NAME=xcap_client.so -LIBS= +ifeq ($(CROSS_COMPILE),) CURLCFG=$(shell which curl-config) +endif ifneq ($(CURLCFG),) - DEFS += $(shell $(CURLCFG) --cflags) LIBS += $(shell $(CURLCFG) --libs) - else - DEFS+=-I$(LOCALBASE)/include LIBS+=-L$(SYSBASE)/lib -L$(LOCALBASE)/lib -lcurl - endif DEFS+=-DKAMAILIO_MOD_INTERFACE

1 0

git:master: utils: fix libcurl dependency
by Ovidiu Sas 05 Dec '12

05 Dec '12

Module: sip-router Branch: master Commit: a1e462c1695013d3c74e1c1ec443df7697bb6607 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a1e462c… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Wed Dec 5 09:16:15 2012 -0500 utils: fix libcurl dependency --- modules/utils/Makefile | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/modules/utils/Makefile b/modules/utils/Makefile index 727fa8c..ff34623 100644 --- a/modules/utils/Makefile +++ b/modules/utils/Makefile @@ -11,6 +11,7 @@ LIBS= ifeq ($(CROSS_COMPILE),) XML2CFG=$(shell which xml2-config) +CURL2CFG=$(shell which curl-config) endif ifneq ($(XML2CFG),) @@ -19,7 +20,15 @@ ifneq ($(XML2CFG),) else DEFS+=-I$(LOCALBASE)/include/libxml2 \ -I$(LOCALBASE)/include - LIBS+=-L$(LOCALBASE)/lib -lcurl -lxml2 + LIBS+=-L$(LOCALBASE)/lib -lxml2 +endif + +ifneq ($(CURL2CFG),) + DEFS += $(shell $(CURL2CFG) --cflags ) + LIBS += $(shell $(CURL2CFG) --libs) +else + DEFS+=-I$(LOCALBASE)/include + LIBS+=-L$(LOCALBASE)/lib -lcurl endif DEFS+=-DKAMAILIO_MOD_INTERFACE

1 0

git:misi/dns_srv: core: dns resolver patch bugfix
by Mihaly Meszaros 05 Dec '12

05 Dec '12

Module: sip-router Branch: misi/dns_srv Commit: 8dcd97b906663fd17378f2d796728a9057519047 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8dcd97b… Author: Mihály Mészáros <misi(a)niif.hu> Committer: Mihály Mészáros <misi(a)niif.hu> Date: Wed Dec 5 12:55:24 2012 +0100 core: dns resolver patch bugfix - a small bug fixed. Many thanks to Daniel (miconda(a)gmail.com) for reporting it. --- resolve.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/resolve.c b/resolve.c index 9b094ec..eddb073 100644 --- a/resolve.c +++ b/resolve.c @@ -1650,7 +1650,7 @@ struct hostent* naptr_sip_resolvehost(str* name, unsigned short* port, #endif } /* fallback to srv lookup */ - no_naptr_srv_sip_resolvehost(name,port,proto); + he=no_naptr_srv_sip_resolvehost(name,port,proto); end: if (naptr_head) free_rdata_list(naptr_head);

1 0

git:master: core: print debug message instead of info message when trying to resolve
by admin＠sip-router.org 05 Dec '12

05 Dec '12

Module: sip-router Branch: master Commit: 87456bae50b55501c25f33a6728f4469639e0599 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=87456ba… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Wed Dec 5 10:26:29 2012 +0200 core: print debug message instead of info message when trying to resolve something that is not domain name. --- resolve.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/resolve.c b/resolve.c index faabb96..73715e3 100644 --- a/resolve.c +++ b/resolve.c @@ -725,8 +725,8 @@ struct rdata* get_record(char* name, int type, int flags) if (((c >= 'a') && (c <= 'z')) || ((c >= 'A') && (c <= 'Z')) || ((c >= '0') && (c <= '9')) || (name[i] == '.') || (name[i] == '-') || (name[i] == '_')) - continue; - LM_INFO("invalid domain name '%s'\n", name); + continue; + LM_DBG("'%s' is not domain name\n", name); return 0; }

1 0

← Newer
1
...
34
35
36
37
38
39
40
...
44
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2012