sr-dev September 2011

sr-dev@lists.kamailio.org

40 participants
298 discussions

git:master: xmlrpc: removed redeclaration of v/snprintf()

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: cbc9536d27b23115a0731a6f93bd8ef1b673be1c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cbc9536… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Sep 28 22:48:23 2011 +0200 xmlrpc: removed redeclaration of v/snprintf() - otherwise throws error on mac os x when redeclaring functions from stdio.h --- modules/xmlrpc/xmlrpc.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/modules/xmlrpc/xmlrpc.c b/modules/xmlrpc/xmlrpc.c index 7528ea3..8824a30 100644 --- a/modules/xmlrpc/xmlrpc.c +++ b/modules/xmlrpc/xmlrpc.c @@ -147,9 +147,6 @@ MODULE_VERSION -int snprintf(char *str, size_t size, const char *format, ...); -int vsnprintf(char *str, size_t size, const char *format, va_list ap); - static int process_xmlrpc(sip_msg_t* msg); static int dispatch_rpc(sip_msg_t* msg, char* s1, char* s2); static int xmlrpc_reply(sip_msg_t* msg, char* code, char* reason);

12 years, 6 months

documentation update for 3.2.0 and wiki system

by Daniel-Constantin Mierla

Hello, in preparation for release 3.2.0, I was checking our wiki (on kamailio.org), which is quite rich in information, but some tutorials are for older versions. Maybe it is also a good time to do some restructuring along with the update of the useful tutorials to be valid for 3.2.0. For restructuring, the main goal is to provide some ways to let people find the documentation they need (and it is available there) easier. Some ideas, introducing categorization/tags for specific topics (e.g., radius, ldap, presence, asterisk, ...), introducing some index pages to link tutorials per version, etc. More suggestions are welcome here, let us know what will make your life easier in browsing the docs. On another hand, currently wiki is based on dokuwiki, which from my point of view did good job so far, but maybe we are missing another excellent wiki system that we should use, because provides more tools for this kind of purpose. One thing I was missing, was export to pdf, which I may be possible right now with dokuwiki plugins -- or even better, we can get something to export to docbook xml format with dokuwiki or other wiki system. In the same kind of subject, what about using git to store (or at least have a replica of) the wiki pages? IIRC, I saw somewhere that even for dokuwiki is possible to configure to use a git repository to store the wiki content instead of local CVS. This will allow people to mirror very easy the content. I could spot from time to time web spiders downloading the wiki. Comments or other suggestions to make the access to documentation easier? Thanks, Daniel -- Daniel-Constantin Mierla -- http://www.asipto.com Kamailio Advanced Training, Oct 10-13, Berlin: http://asipto.com/u/kat http://linkedin.com/in/miconda -- http://twitter.com/miconda

12 years, 6 months

git:3.1: dialog(k): Do not consider late requests for dialogs in "deleted"

by Timo Reimann

Module: sip-router Branch: 3.1 Commit: 77101ce36e90c6ec37128c007fc92444812b5301 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=77101ce… Author: Timo Reimann <timo.reimann(a)1und1.de> Committer: Timo Reimann <timo.reimann(a)1und1.de> Date: Wed Sep 28 20:04:36 2011 +0200 dialog(k): Do not consider late requests for dialogs in "deleted" state as bogus messages. (cherry picked from commit 908f674978349fbabb2d79d6e45381a77a716ffc) --- modules_k/dialog/dlg_hash.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/modules_k/dialog/dlg_hash.c b/modules_k/dialog/dlg_hash.c index c0dedb3..03754c0 100644 --- a/modules_k/dialog/dlg_hash.c +++ b/modules_k/dialog/dlg_hash.c @@ -724,6 +724,7 @@ void next_state_dlg(struct dlg_cell *dlg, int event, switch (dlg->state) { case DLG_STATE_EARLY: case DLG_STATE_CONFIRMED_NA: + case DLG_STATE_DELETED: break; default: log_next_state_dlg(event, dlg); @@ -734,6 +735,7 @@ void next_state_dlg(struct dlg_cell *dlg, int event, case DLG_STATE_EARLY: case DLG_STATE_CONFIRMED_NA: case DLG_STATE_CONFIRMED: + case DLG_STATE_DELETED: break; default: log_next_state_dlg(event, dlg);

12 years, 6 months

git:master: dialog(k): Do not consider late requests for dialogs in " deleted"

by Timo Reimann

Module: sip-router Branch: master Commit: 908f674978349fbabb2d79d6e45381a77a716ffc URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=908f674… Author: Timo Reimann <timo.reimann(a)1und1.de> Committer: Timo Reimann <timo.reimann(a)1und1.de> Date: Wed Sep 28 20:04:36 2011 +0200 dialog(k): Do not consider late requests for dialogs in "deleted" state as bogus messages. --- modules_k/dialog/dlg_hash.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/modules_k/dialog/dlg_hash.c b/modules_k/dialog/dlg_hash.c index ddfd714..5795dbd 100644 --- a/modules_k/dialog/dlg_hash.c +++ b/modules_k/dialog/dlg_hash.c @@ -737,6 +737,7 @@ void next_state_dlg(struct dlg_cell *dlg, int event, switch (dlg->state) { case DLG_STATE_EARLY: case DLG_STATE_CONFIRMED_NA: + case DLG_STATE_DELETED: break; default: log_next_state_dlg(event, dlg); @@ -747,6 +748,7 @@ void next_state_dlg(struct dlg_cell *dlg, int event, case DLG_STATE_EARLY: case DLG_STATE_CONFIRMED_NA: case DLG_STATE_CONFIRMED: + case DLG_STATE_DELETED: break; default: log_next_state_dlg(event, dlg);

12 years, 6 months

[tracker] Task closed: wrong integer parameters parsing in ndb_redis

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#162 - wrong integer parameters parsing in ndb_redis User who did this - Jon Bonilla (manwe) Reason for closing: Implemented Additional comments about closing: Thanks Andrew. Implemented in git 3786d09052e4852ba50bec78aaf00485de5a12e6 More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=162 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 6 months

git:master: Fix previous commit e5a5344290a351344c2451017d1d5677fe649cb8

by Jon Bonilla

Module: sip-router Branch: master Commit: 3786d09052e4852ba50bec78aaf00485de5a12e6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3786d09… Author: Jon Bonilla <manwe(a)aholab.ehu.es> Committer: Jon Bonilla <manwe(a)aholab.ehu.es> Date: Wed Sep 28 17:19:14 2011 +0200 Fix previous commit e5a5344290a351344c2451017d1d5677fe649cb8 Thanks to Andrew Pogrebennyk --- modules/ndb_redis/redis_client.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/ndb_redis/redis_client.c b/modules/ndb_redis/redis_client.c index e8d74f6..9f4ffc4 100644 --- a/modules/ndb_redis/redis_client.c +++ b/modules/ndb_redis/redis_client.c @@ -71,10 +71,10 @@ int redisc_init(void) addr = pit->body.s; addr[pit->body.len] = '\0'; } else if(pit->name.len==4 && strncmp(pit->name.s, "port", 4)==0) { - if(!str2int(&pit->body, &port) < 0) + if(str2int(&pit->body, &port) < 0) port = 6379; } else if(pit->name.len==2 && strncmp(pit->name.s, "db", 2)==0) { - if(!str2int(&pit->body, &db) < 0) + if(str2int(&pit->body, &db) < 0) db = 0; } }

12 years, 6 months

git:master: ndb_redis: fix parsing of integer arguments from server connect string

by Jon Bonilla

Module: sip-router Branch: master Commit: e5a5344290a351344c2451017d1d5677fe649cb8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e5a5344… Author: Jon Bonilla <manwe(a)aholab.ehu.es> Committer: Jon Bonilla <manwe(a)aholab.ehu.es> Date: Wed Sep 28 17:16:34 2011 +0200 ndb_redis: fix parsing of integer arguments from server connect string Reported and patch contributed by Andrew Pogrebennyk --- modules/ndb_redis/redis_client.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/ndb_redis/redis_client.c b/modules/ndb_redis/redis_client.c index 6a91019..e8d74f6 100644 --- a/modules/ndb_redis/redis_client.c +++ b/modules/ndb_redis/redis_client.c @@ -71,10 +71,10 @@ int redisc_init(void) addr = pit->body.s; addr[pit->body.len] = '\0'; } else if(pit->name.len==4 && strncmp(pit->name.s, "port", 4)==0) { - if(!str2int(&pit->body, &port)) + if(!str2int(&pit->body, &port) < 0) port = 6379; } else if(pit->name.len==2 && strncmp(pit->name.s, "db", 2)==0) { - if(!str2int(&pit->body, &db)) + if(!str2int(&pit->body, &db) < 0) db = 0; } }

12 years, 6 months

[tracker] User took ownership: wrong integer parameters parsing in ndb_redis

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Jon Bonilla has taken ownership of the following task: FS#162 - wrong integer parameters parsing in ndb_redis More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=162 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 6 months

git:master: core: parser/sdp - optimized a= lines parsing

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 550a879a50258557084da59787f13f3f6eb285f1 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=550a879… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Sep 28 16:02:02 2011 +0200 core: parser/sdp - optimized a= lines parsing - search for next a= line from the last parsed position in previous a= line --- parser/sdp/sdp.c | 8 +++++--- parser/sdp/sdp_helpr_funcs.c | 12 ++++++++++++ parser/sdp/sdp_helpr_funcs.h | 2 ++ 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/parser/sdp/sdp.c b/parser/sdp/sdp.c index 687d466..6d53ab9 100644 --- a/parser/sdp/sdp.c +++ b/parser/sdp/sdp.c @@ -553,11 +553,13 @@ static int parse_sdp_session(str *sdp_body, int session_num, str *cnt_disp, sdp_ a1p = stream->max_size.s + stream->max_size.len; } else if (extract_path(&tmpstr1, &stream->path) == 0) { a1p = stream->path.s + stream->path.len; - /*} else { */ - /* LM_DBG("else: `%.*s'\n", tmpstr1.len, tmpstr1.s); */ + } else { + /* unknown a= line, ignore -- jump over it */ + LM_DBG("ignoring unknown type in a= line: `%.*s'\n", tmpstr1.len, tmpstr1.s); + a1p += 2; } - a2p = find_next_sdp_line(a2p, m2p, 'a', m2p); + a2p = find_first_sdp_line(a1p, m2p, 'a', m2p); } /* Let's detect if the media is on hold by checking * the good old "0.0.0.0" connection address */ diff --git a/parser/sdp/sdp_helpr_funcs.c b/parser/sdp/sdp_helpr_funcs.c index 6dde0d4..466dc8c 100644 --- a/parser/sdp/sdp_helpr_funcs.c +++ b/parser/sdp/sdp_helpr_funcs.c @@ -606,6 +606,18 @@ char * find_next_sdp_line(char* p, char* plimit, char linechar, char* defptr) } +/* Find first SDP line starting with linechar. Return defptr if not found */ +char * find_first_sdp_line(char* pstart, char* plimit, char linechar, + char* defptr) +{ + char *t; + if (pstart >= plimit || plimit - pstart < 3) + return defptr; + t = find_sdp_line(pstart, plimit, linechar); + return t ? t : defptr; +} + + /* returns pointer to next header line, and fill hdr_f ; * if at end of header returns pointer to the last crlf (always buf)*/ char* get_sdp_hdr_field(char* buf, char* end, struct hdr_field* hdr) diff --git a/parser/sdp/sdp_helpr_funcs.h b/parser/sdp/sdp_helpr_funcs.h index c815845..0ec10e2 100644 --- a/parser/sdp/sdp_helpr_funcs.h +++ b/parser/sdp/sdp_helpr_funcs.h @@ -68,4 +68,6 @@ char* get_sdp_hdr_field(char* , char* , struct hdr_field* ); char *find_sdp_line_delimiter(char *p, char *plimit, str delimiter); char *find_next_sdp_line_delimiter(char *p, char *plimit, str delimiter, char *defptr); +char * find_first_sdp_line(char* pstart, char* plimit, char linechar, + char* defptr); #endif

12 years, 6 months

git:master: core: parser/sdp - fixed parsing attributes lines

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: e332ea9eaac3035c3ccd1605ef0b623a2b63a733 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e332ea9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Sep 28 15:48:02 2011 +0200 core: parser/sdp - fixed parsing attributes lines - some lines were mistakenly jumped over --- parser/sdp/sdp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/parser/sdp/sdp.c b/parser/sdp/sdp.c index 2f8831d..687d466 100644 --- a/parser/sdp/sdp.c +++ b/parser/sdp/sdp.c @@ -557,7 +557,7 @@ static int parse_sdp_session(str *sdp_body, int session_num, str *cnt_disp, sdp_ /* LM_DBG("else: `%.*s'\n", tmpstr1.len, tmpstr1.s); */ } - a2p = find_next_sdp_line(a1p, m2p, 'a', m2p); + a2p = find_next_sdp_line(a2p, m2p, 'a', m2p); } /* Let's detect if the media is on hold by checking * the good old "0.0.0.0" connection address */

12 years, 6 months

← Newer
1
2
3
4
5
6
7
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2011