November 2011 - sr-dev - kamailio.org

git:master: snmpstats: control exporting registrar records
by Daniel-Constantin Mierla 29 Nov '11

29 Nov '11

Module: sip-router Branch: master Commit: 0696af54dac4ecc53bb0a9dc4e56da11bc3f2b30 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0696af5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Oct 16 11:33:16 2011 +0200 snmpstats: control exporting registrar records - exporting of large location database may result in out of shared memory, as well as when the records are not pulled - might be the case of out of memory messages reported by Klaus Darilion - new parameter export_registrar was added to enable/disable location records export (off by default) - fixed missing exporting the counter with all processed dialogs (discussion from March 2011 with Stefan Tiedje) --- modules_k/snmpstats/README | 31 ++++++++++++++++----- modules_k/snmpstats/doc/snmpstats_admin.xml | 25 +++++++++++++++++ modules_k/snmpstats/mibs/OPENSER-MIB | 13 ++++++++- modules_k/snmpstats/snmpObjects.c | 28 +++++++++++++++++++ modules_k/snmpstats/snmpObjects.h | 1 + modules_k/snmpstats/snmpstats.c | 40 +++++++++++++++++---------- 6 files changed, 115 insertions(+), 23 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=069…

2 6

git:3.1: snmpstats: control exporting registrar records
by Daniel-Constantin Mierla 29 Nov '11

29 Nov '11

Module: sip-router Branch: 3.1 Commit: 4669e348b2ab8fc251afed538971efb55cdc77fd URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4669e34… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Oct 16 11:33:16 2011 +0200 snmpstats: control exporting registrar records - exporting of large location database may result in out of shared memory, as well as when the records are not pulled - might be the case of out of memory messages reported by Klaus Darilion - new parameter export_registrar was added to enable/disable location records export (off by default) - fixed missing exporting the counter with all processed dialogs (discussion from March 2011 with Stefan Tiedje) --- modules_k/snmpstats/README | 746 +++++++++++++++------------ modules_k/snmpstats/doc/snmpstats_admin.xml | 25 + modules_k/snmpstats/mibs/OPENSER-MIB | 13 +- modules_k/snmpstats/snmpObjects.c | 28 + modules_k/snmpstats/snmpObjects.h | 1 + modules_k/snmpstats/snmpstats.c | 40 +- 6 files changed, 496 insertions(+), 357 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=466…

1 0

[tracker] Comment added: Sanity module fails to reject broken From/ To headers
by sip-router 29 Nov '11

29 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#177 - Sanity module fails to reject broken From/ To headers User who did this - Daniel-Constantin Mierla (miconda) ---------- I committed a patch to allow sanity checks for SIP replies. Checking for duplicated parameters is still to do. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=177#comment424 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] User took ownership: Sanity module fails to reject broken From/ To headers
by sip-router 29 Nov '11

29 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Daniel-Constantin Mierla has taken ownership of the following task: FS#177 - Sanity module fails to reject broken From/ To headers More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=177 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: sanity: allow doing the checks in reply routes
by Daniel-Constantin Mierla 29 Nov '11

29 Nov '11

Module: sip-router Branch: master Commit: 54c99da0de46c59cd85363dca1eed324dbb6b495 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=54c99da… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Nov 29 11:36:36 2011 +0100 sanity: allow doing the checks in reply routes - use wrapper function for sending replies, to skip doing it for SIP replies - reported by Bayan Towfiq, FS#177 --- modules/sanity/mod_sanity.c | 6 ++-- modules/sanity/sanity.c | 72 +++++++++++++++++++++++++++--------------- 2 files changed, 49 insertions(+), 29 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=54c…

1 0

[tracker] Task closed: DOUBLE FREE / CRASH in parse_to.c
by sip-router 29 Nov '11

29 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#180 - DOUBLE FREE / CRASH in parse_to.c User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Backported to 3.1/3.2 More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=180 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: server crash while running "tm.t_uac_wait" via sercmd
by sip-router 29 Nov '11

29 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#176 - server crash while running "tm.t_uac_wait" via sercmd User who did this - Daniel-Constantin Mierla (miconda) ---------- Any update on this? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=176#comment423 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: PV $ds in xlog in branch_route
by sip-router 29 Nov '11

29 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#182 - PV $ds in xlog in branch_route User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Backported to 3.1/3.2 More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=182 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: Kamailio / Crash / Textops (302 Redirect)
by sip-router 29 Nov '11

29 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#181 - Kamailio / Crash / Textops (302 Redirect) User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Backported to 3.2/3.1. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=181 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:3.1: parser: don't free on error To param linked in to_body struct
by Daniel-Constantin Mierla 29 Nov '11

29 Nov '11

Module: sip-router Branch: 3.1 Commit: 92833c4f641710a604b519722d6f37035845a3d5 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=92833c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Nov 24 17:22:26 2011 +0100 parser: don't free on error To param linked in to_body struct - if a To header parameter was already linked in to_body struct, don't free if there is a parsing error for it later, it will be freed by free_to_params() - reported by Bayan Towfiq in FS#180 (cherry picked from commit 6299704ebb280214f35fc86968d86be972219e51) (cherry picked from commit a56b17e065d175f213688cacd3db3aa88fe48e2a) --- parser/parse_to.c | 36 +++++++++++++++++------------------- 1 files changed, 17 insertions(+), 19 deletions(-) diff --git a/parser/parse_to.c b/parser/parse_to.c index bcd0bd0..cb2ea75 100644 --- a/parser/parse_to.c +++ b/parser/parse_to.c @@ -53,7 +53,7 @@ enum { -#define add_param( _param , _body ) \ +#define add_param( _param , _body , _newparam ) \ do{\ DBG("DEBUG: add_param: %.*s=%.*s\n",param->name.len,ZSW(param->name.s),\ param->value.len,ZSW(param->value.s));\ @@ -62,6 +62,7 @@ enum { (_body)->last_param =(_param);\ if ((_param)->type==TAG_PARAM)\ memcpy(&((_body)->tag_value),&((_param)->value),sizeof(str));\ + _newparam = 0;\ }while(0); @@ -73,11 +74,13 @@ static /*inline*/ char* parse_to_param(char *buffer, char *end, int *returned_status) { struct to_param *param; + struct to_param *newparam; int status; int saved_status; char *tmp; param=0; + newparam=0; status=E_PARA_VALUE; saved_status=E_PARA_VALUE; for( tmp=buffer; tmp<end; tmp++) @@ -99,7 +102,7 @@ static /*inline*/ char* parse_to_param(char *buffer, char *end, case PARA_VALUE_TOKEN: param->value.len = tmp-param->value.s; status = E_PARA_VALUE; - add_param( param , to_b ); + add_param(param, to_b, newparam); break; case F_CRLF: case F_LF: @@ -132,7 +135,7 @@ static /*inline*/ char* parse_to_param(char *buffer, char *end, param->value.len = tmp-param->value.s; saved_status = E_PARA_VALUE; status = F_LF; - add_param( param , to_b ); + add_param(param, to_b, newparam); break; case F_CR: status=F_CRLF; @@ -171,7 +174,7 @@ static /*inline*/ char* parse_to_param(char *buffer, char *end, param->value.len = tmp-param->value.s; saved_status = E_PARA_VALUE; status = F_CR; - add_param( param , to_b ); + add_param(param, to_b, newparam); break; case F_CRLF: case F_CR: @@ -202,7 +205,7 @@ static /*inline*/ char* parse_to_param(char *buffer, char *end, case PARA_VALUE_TOKEN: status = E_PARA_VALUE; param->value.len = tmp-param->value.s; - add_param( param , to_b ); + add_param(param , to_b, newparam); case E_PARA_VALUE: saved_status = status; goto endofheader; @@ -242,7 +245,7 @@ static /*inline*/ char* parse_to_param(char *buffer, char *end, break; case PARA_VALUE_QUOTED: param->value.len=tmp-param->value.s; - add_param( param , to_b ); + add_param(param, to_b, newparam); status = E_PARA_VALUE; break; case F_CRLF: @@ -277,7 +280,7 @@ static /*inline*/ char* parse_to_param(char *buffer, char *end, case PARA_VALUE_TOKEN: param->value.len=tmp-param->value.s; semicolon_add_param: - add_param(param,to_b); + add_param(param, to_b, newparam); case E_PARA_VALUE: param = (struct to_param*) pkg_malloc(sizeof(struct to_param)); @@ -289,6 +292,8 @@ semicolon_add_param: memset(param,0,sizeof(struct to_param)); param->type=GENERAL_PARAM; status = S_PARA_NAME; + /* link to free mem if not added in to_body list */ + newparam = param; break; case F_CRLF: case F_LF: @@ -483,19 +488,19 @@ endofheader: /* parameter without '=', e.g. foo */ param->value.s=0; param->value.len=0; - add_param(param, to_b); + add_param(param, to_b, newparam); saved_status=E_PARA_VALUE; break; case S_PARA_VALUE: /* parameter with null value, e.g. foo= */ param->value.s=tmp; param->value.len=0; - add_param(param, to_b); + add_param(param, to_b, newparam); saved_status=E_PARA_VALUE; break; case PARA_VALUE_TOKEN: param->value.len=tmp-param->value.s; - add_param(param, to_b); + add_param(param, to_b, newparam); saved_status=E_PARA_VALUE; break; case E_PARA_VALUE: @@ -510,7 +515,7 @@ endofheader: return tmp; error: - if (param) pkg_free(param); + if (newparam) pkg_free(newparam); to_b->error=PARSE_ERROR; *returned_status = status; return tmp; @@ -527,15 +532,8 @@ char* parse_to(char* buffer, char *end, struct to_body *to_b) saved_status=START_TO; /* fixes gcc 4.x warning */ status=START_TO; + memset(to_b, 0, sizeof(struct to_body)); to_b->error=PARSE_OK; - to_b->uri.len = 0; - to_b->uri.s= 0; - to_b->display.len = 0; - to_b->display.s = 0; - to_b->tag_value.len = 0; - to_b->tag_value.s = 0; - to_b->param_lst = 0; - to_b->last_param = 0; foo=0; for( tmp=buffer; tmp<end; tmp++)

1 0