November 2011 - sr-dev - kamailio.org

[tracker] Comment added: tls module error on initialization when used together with the dialog module
by sip-router 30 Nov '11

30 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#183 - tls module error on initialization when used together with the dialog module User who did this - Daniel-Constantin Mierla (miconda) ---------- I will try to get a solution for it. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=183#comment431 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] User took ownership: tls module error on initialization when used together with the dialog module
by sip-router 30 Nov '11

30 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Daniel-Constantin Mierla has taken ownership of the following task: FS#183 - tls module error on initialization when used together with the dialog module More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=183 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: Double Free -- Crash/Coredump and possible security vulnerability
by sip-router 30 Nov '11

30 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#173 - Double Free -- Crash/Coredump and possible security vulnerability User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=173 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Double Free -- Crash/Coredump and possible security vulnerability
by sip-router 30 Nov '11

30 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#173 - Double Free -- Crash/Coredump and possible security vulnerability User who did this - Daniel-Constantin Mierla (miconda) ---------- Merged branch branch tmp/dlgnewref to master and backported to 3.2 ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=173#comment430 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:3.2: dialog(k): disable unused functionunref_new_dialog()
by Daniel-Constantin Mierla 30 Nov '11

30 Nov '11

Module: sip-router Branch: 3.2 Commit: 3bc0cc561630cb24332bd2e1ae2c84d8dba2826c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3bc0cc5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Nov 30 18:57:21 2011 +0100 dialog(k): disable unused functionunref_new_dialog() - get rid of compliler warning (cherry picked from commit 880b447b43bb75328a3cd2f245d969272812ae42) --- modules_k/dialog/dlg_handlers.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/modules_k/dialog/dlg_handlers.c b/modules_k/dialog/dlg_handlers.c index ac4dacd..9c4686a 100644 --- a/modules_k/dialog/dlg_handlers.c +++ b/modules_k/dialog/dlg_handlers.c @@ -705,6 +705,7 @@ void dlg_onreq(struct cell* t, int type, struct tmcb_params *param) * \see dlg_onreq * \param dialog unreferenced dialog */ +#if 0 static void unref_new_dialog(void *iuid) { struct tmcb_params p; @@ -713,6 +714,7 @@ static void unref_new_dialog(void *iuid) p.param = (void*)&iuid; dlg_onreply(0, TMCB_DESTROY, &p); } +#endif /*!

1 0

git:3.2: dialog(k): safety check for lookup in dialog table at shutdown
by Daniel-Constantin Mierla 30 Nov '11

30 Nov '11

Module: sip-router Branch: 3.2 Commit: 926caef8f2b37dc83aab12aa5b8f717a9eeff328 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=926caef… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Nov 26 00:32:23 2011 +0100 dialog(k): safety check for lookup in dialog table at shutdown (cherry picked from commit 017ea5779710223df8f5a28829f77eff8395affc) (cherry picked from commit b018f09abbecc6b057c6f9446406c6f20f43a235) --- modules_k/dialog/dlg_hash.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/modules_k/dialog/dlg_hash.c b/modules_k/dialog/dlg_hash.c index 296efdd..2dbf9a0 100644 --- a/modules_k/dialog/dlg_hash.c +++ b/modules_k/dialog/dlg_hash.c @@ -444,6 +444,9 @@ dlg_cell_t *dlg_lookup( unsigned int h_entry, unsigned int h_id) dlg_cell_t *dlg; dlg_entry_t *d_entry; + if(d_table==NULL) + return 0; + if (h_entry>=d_table->size) goto not_found;

1 0

git:3.2: dialog(k): refactored dlg ref counting
by Daniel-Constantin Mierla 30 Nov '11

30 Nov '11

Module: sip-router Branch: 3.2 Commit: e8dd7fee405a375e0ad501018b05700401e8d26a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e8dd7fe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Nov 21 23:52:43 2011 +0100 dialog(k): refactored dlg ref counting - dlg pointer is no longer stored in tm callbacks parameter and ref counting for these kind of needs was removed - the internal id (hash entry, dlg id) is given now to tm callbacks. The callbacks will do dlg lookup to get the structure - there are longer-time persistent ref counting for: * storing dlg structure in dialog hash table * keeping dlg in timer list * waiting for the reply of BYE to destroy dialog structure - all the other ref countings are for short time, only for the period of doing specific processing - the new ref counting is safer in relation with tm callbacks and avoids tight dependecy which may have been easily broken by future tm changes (cherry picked from commit 9ba4ee25e32368a9c17c3f86784a52a97b748b93) (cherry picked from commit 5bdee1ffe820d3e9e75898bb252d1660b4bbad60) --- modules_k/dialog/dialog.c | 102 +++++++---- modules_k/dialog/dlg_db_handler.c | 8 +- modules_k/dialog/dlg_handlers.c | 387 +++++++++++++++++++------------------ modules_k/dialog/dlg_handlers.h | 23 ++- modules_k/dialog/dlg_hash.c | 60 +++++-- modules_k/dialog/dlg_hash.h | 73 +++++--- modules_k/dialog/dlg_profile.c | 145 ++++++--------- modules_k/dialog/dlg_profile.h | 44 ++--- modules_k/dialog/dlg_req_within.c | 12 +- modules_k/dialog/dlg_timer.h | 8 +- modules_k/dialog/dlg_var.c | 338 ++++++++++++++++++++++---------- modules_k/dialog/dlg_var.h | 34 ++-- 12 files changed, 716 insertions(+), 518 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=e8d…

1 0

git:master: pua: regenerated the readme file
by Daniel-Constantin Mierla 30 Nov '11

30 Nov '11

Module: sip-router Branch: master Commit: 521857609419050ee98a0220fb23cd5eed797dad URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5218576… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Nov 30 19:00:30 2011 +0100 pua: regenerated the readme file --- modules_k/pua/README | 221 ++++++++++++++++++++++++++------------------------ 1 files changed, 116 insertions(+), 105 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=521…

1 0

git:master: dialog(k): safety check for lookup in dialog table at shutdown
by Daniel-Constantin Mierla 30 Nov '11

30 Nov '11

Module: sip-router Branch: master Commit: b018f09abbecc6b057c6f9446406c6f20f43a235 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b018f09… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Nov 26 00:32:23 2011 +0100 dialog(k): safety check for lookup in dialog table at shutdown (cherry picked from commit 017ea5779710223df8f5a28829f77eff8395affc) --- modules_k/dialog/dlg_hash.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/modules_k/dialog/dlg_hash.c b/modules_k/dialog/dlg_hash.c index 296efdd..2dbf9a0 100644 --- a/modules_k/dialog/dlg_hash.c +++ b/modules_k/dialog/dlg_hash.c @@ -444,6 +444,9 @@ dlg_cell_t *dlg_lookup( unsigned int h_entry, unsigned int h_id) dlg_cell_t *dlg; dlg_entry_t *d_entry; + if(d_table==NULL) + return 0; + if (h_entry>=d_table->size) goto not_found;

1 0

git:master: dialog(k): disable unused functionunref_new_dialog()
by Daniel-Constantin Mierla 30 Nov '11

30 Nov '11

Module: sip-router Branch: master Commit: 880b447b43bb75328a3cd2f245d969272812ae42 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=880b447… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Nov 30 18:57:21 2011 +0100 dialog(k): disable unused functionunref_new_dialog() - get rid of compliler warning --- modules_k/dialog/dlg_handlers.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/modules_k/dialog/dlg_handlers.c b/modules_k/dialog/dlg_handlers.c index ac4dacd..9c4686a 100644 --- a/modules_k/dialog/dlg_handlers.c +++ b/modules_k/dialog/dlg_handlers.c @@ -705,6 +705,7 @@ void dlg_onreq(struct cell* t, int type, struct tmcb_params *param) * \see dlg_onreq * \param dialog unreferenced dialog */ +#if 0 static void unref_new_dialog(void *iuid) { struct tmcb_params p; @@ -713,6 +714,7 @@ static void unref_new_dialog(void *iuid) p.param = (void*)&iuid; dlg_onreply(0, TMCB_DESTROY, &p); } +#endif /*!

1 0