sr-dev July 2010

sr-dev@lists.kamailio.org

29 participants
223 discussions

[tracker] Comment added: patch to add method masking to xlog function

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#81 - patch to add method masking to xlog function User who did this - Daniel-Constantin Mierla (miconda) ---------- Juha, as you can use different log levels as parameters you can use different variables and have couple of assignments (e.g., $var(dbg), $var(info), ...). That xlog parameter supports static value or variable for so long time, so there is nothing extra that is done. You can implement your extra functions if these suggestions does not fit you, but the basic functions must stay available to the config, without adding particular needs of filtering - there can be wrappers, same was done for xlogl(). ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=81#comment105 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years, 9 months

[tracker] Comment added: patch to add method masking to xlog function

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#81 - patch to add method masking to xlog function User who did this - Juha Heinanen (jh) ---------- the proposed solution does not work, because different log messages related to the same request may (and in practice are) printed at different log levels. it it thus not possible to set $var(log) to some given level at top of the main route block. the above test and setting of $var(log) would thus need to be done before each xlog call in the script. in addition, always using a var as the first param of xlog call would be much slower than the simple c if statement inside xlog function. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=81#comment104 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years, 9 months

questions regarding tm callbacks in sr

by Timo Reimann

Hello, after never really having to use sip-router's tm callbacks but Kamailio's only, I did some tests today and found a few issues I'd like to discuss followingly: 1) In Kamailio, certain callbacks (namely TMCB_RESPONSE_PRE_OUT, TMCB_RESPONSE_OUT, and TMCB_REQUEST_BUILT) provided the entire processed message (i.e., after headers were modified) in tmcb_params->extra1 as *str. AFAICS, sr's equivalent to that parameter is send_buf in the tmcb_params structure. However, the only sr callbacks that do provide the processed messages are TMCB_REQUEST_SENT and TMCB_RESPONSE_SENT which, had no perfect correspondency in Kamailio (*_OUT callbacks would not be called for retransmissions). Technically, this makes complete sense because the two *_SENT callbacks and the send_buf variable are available only when WITH_ONSEND is defined. Also, I noticed that these callbacks are handled through run_onsend_callbacks[2]() instead of run_trans_callbacks(). Only the former fill send_buf and hence pass processed messages as part of the callback. Why do these TMCB_ONSEND callbacks need such special care? Would it be feasible to pass processed messages for other callbacks somehow too? Ideally, I'd like to see that happen for every callback where a processed message is supposed to be available, i.e., all *_OUT and *_READY callbacks. 2) Is there a special reason why TMCB_REQUEST_OUT is missing? Kamailio used to have it although it's name TMCB_REQUEST_BUILT was a little misleading. 3) Similarly, how hard would it be to implement TMCB_REQUEST_READY? Kamailio lacked that but I'd truly love to see it exist in sr. Sorry for the abundance of questions and lack of solutions -- when I had just started to get a rough idea of how Kamailio's tm module works internally, here comes sr and forces me to start over again. :) TIA and cheers, --Timo

13 years, 9 months

[ openser-Patches-3035778 ] Fix registrar when fetching binding for unregistered user

by SourceForge.net

Patches item #3035778, was opened at 2010-07-28 09:04 Message generated for change (Comment added) made by ibc_sf You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035778&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x >Status: Closed >Resolution: Invalid Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Fix registrar when fetching binding for unregistered user Initial Comment: When an UA fetches the bindings for a user and the user isn't registered, properly return an empty contact. ---------------------------------------------------------------------- >Comment By: Iñaki Baz Castillo (ibc_sf) Date: 2010-07-28 12:29 Message: A "Contact" header with no value is *not* valid according to SIP BNF grammar so in case a UA fetches its bindging and there are not bindings then the registrar should reply a 200 without "Contact" header. Taking this into account I suspect that this patch is wrong. As a side note, there is a bug/issue open for RFC 3261 related to this topic as the RFC 3261 seems to state that the registrar should reply a 200 with a Contact header containing all the bindings. But it's clear (also in the RFC bug report) that the BNF grammar cannot be violated so there should be NO Contact header if there are no bindings. I close this bug as it not valid. However as Daniel said please use http://sip-router.org/tracker/ for future reports :) ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-07-28 09:07 Message: Can you use the tracker at sip-router.org? http://sip-router.org/tracker/ SF tracker should not be used anymore for new items. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035778&group_…

13 years, 9 months

[ openser-Patches-3035778 ] Fix registrar when fetching binding for unregistered user

by SourceForge.net

Patches item #3035778, was opened at 2010-07-28 10:04 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035778&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Fix registrar when fetching binding for unregistered user Initial Comment: When an UA fetches the bindings for a user and the user isn't registered, properly return an empty contact. ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-07-28 10:07 Message: Can you use the tracker at sip-router.org? http://sip-router.org/tracker/ SF tracker should not be used anymore for new items. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035778&group_…

13 years, 9 months

[ openser-Patches-3035808 ] Add rfc1918 test for source ip to nat_uac_test

by SourceForge.net

Patches item #3035808, was opened at 2010-07-28 10:13 Message generated for change (Tracker Item Submitted) made by axlh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035808&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Add rfc1918 test for source ip to nat_uac_test Initial Comment: Expand nathelper function nat_uac_test with function to test for rfc1918 address in source ip of SIP message. Move some code to helper functions to prevent duplication of code. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035808&group_…

13 years, 9 months

[ openser-Patches-3035804 ] Multiple return values for force_rtp_proxy

by SourceForge.net

Patches item #3035804, was opened at 2010-07-28 10:03 Message generated for change (Tracker Item Submitted) made by axlh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035804&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Multiple return values for force_rtp_proxy Initial Comment: Add a separate return value (-2) when an rtp proxy has already mangled the packet. makes it possible to determine in the script if an rtpproxy is in the audio path. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035804&group_…

13 years, 9 months

[ openser-Patches-3035802 ] Add locking to pua for serializing PUBLISHes

by SourceForge.net

Patches item #3035802, was opened at 2010-07-28 09:58 Message generated for change (Tracker Item Submitted) made by axlh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035802&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Add locking to pua for serializing PUBLISHes Initial Comment: pua must not send multiple PUBLISH with the same id before receiving a reply as the ETag must be updated on subsequent publishes. Patch by Anca Vamanu. Stolen from opensips r5924. Original commit message: introduced a locking mechanism to prevent sending a new Publish before the reply for a previous one is received (thanks to Piotr Sobolewski <sobolewski at gmail dot com> for help with debugging) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035802&group_…

13 years, 9 months

[ openser-Patches-3035794 ] Add option to keep subscriptions on timed out NOTIFY

by SourceForge.net

Patches item #3035794, was opened at 2010-07-28 09:33 Message generated for change (Tracker Item Submitted) made by axlh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035794&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Add option to keep subscriptions on timed out NOTIFY Initial Comment: This parameter is a flag that should be set if subscriptions should be removed from the active_watchers when a NOTIFY times out. RFC3265 section 3.2.2 defines this behaviour as a SHOULD, so by default it is on. Disabling this will keep subscriptions active on unreliable networks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035794&group_…

13 years, 9 months

[ openser-Patches-3035783 ] Add route headers to CANCEL

by SourceForge.net

Patches item #3035783, was opened at 2010-07-28 09:14 Message generated for change (Tracker Item Submitted) made by axlh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035783&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Add route headers to CANCEL Initial Comment: When an INVITE is sent which had route headers, the CANCEL must have them too. This happens when the registrar sends an INVITE to a contact that registered with a Path header. The Path becomes a Route header. Currently, if that transaction is canceled, the CANCEL doesn't have this Route header. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035783&group_…

13 years, 9 months

← Newer
1
2
3
4
5
6
7
8
...
23
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2010