sr-dev July 2010

sr-dev@lists.kamailio.org

29 participants
223 discussions

git:master: permissions(k): reverted incomplete fix for mi cmd
by Daniel-Constantin Mierla 01 Jul '10

01 Jul '10

Module: sip-router Branch: master Commit: 5dcc8789096e9c7148aa9ba1242f84e3412b050d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5dcc878… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 12:10:34 2010 +0200 permissions(k): reverted incomplete fix for mi cmd - the mi command execution via rpc is fixed by initialization of mi commands done now by mi_rpc module --- modules_k/permissions/address.c | 23 +++++------------------ 1 files changed, 5 insertions(+), 18 deletions(-) diff --git a/modules_k/permissions/address.c b/modules_k/permissions/address.c index 0dd7b10..469e21a 100644 --- a/modules_k/permissions/address.c +++ b/modules_k/permissions/address.c @@ -79,17 +79,6 @@ int reload_address_table(void) cols[2] = &mask_col; cols[3] = &port_col; cols[4] = &tag_col; - - if (db_handle) { - LM_ERR("db_handle already exists\n"); - return -1; - } - - db_handle = perm_dbf.init(&db_url); - if (!db_handle) { - LM_ERR("unable to connect database\n"); - return -1; - } if (perm_dbf.use_table(db_handle, &address_table) < 0) { LM_ERR("failed to use table\n"); @@ -177,9 +166,6 @@ int reload_address_table(void) perm_dbf.free_result(db_handle, res); - perm_dbf.close(db_handle); - db_handle = 0; - *addr_hash_table = new_hash_table; *subnet_table = new_subnet_table; @@ -222,13 +208,9 @@ int init_addresses(void) if(db_check_table_version(&perm_dbf, db_handle, &address_table, TABLE_VERSION) < 0) { LM_ERR("error during table version check.\n"); perm_dbf.close(db_handle); - db_handle = 0; return -1; } - perm_dbf.close(db_handle); - db_handle = 0; - addr_hash_table_1 = new_addr_hash_table(); if (!addr_hash_table_1) return -1; @@ -263,6 +245,9 @@ int init_addresses(void) goto error; } + perm_dbf.close(db_handle); + db_handle = 0; + return 0; error: @@ -290,6 +275,8 @@ error: shm_free(subnet_table); subnet_table = 0; } + perm_dbf.close(db_handle); + db_handle = 0; return -1; }

1 0

[tracker] Comment added: function for evaluating string value
by sip-router 01 Jul '10

01 Jul '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#78 - function for evaluating string value User who did this - Juha Heinanen (jh) ---------- defines do not work here, since the idea is to be able to dynamically at runtime to change string values of cfg variables that may contain pseudo variables and transformations. such strings may, for example, appear as parameters of http_queries, what comes to implementation, this kind of stuff is normal in interpreted languages, for example #!/usr/bin/php <? $format = "Printing number %d\n"; printf($format, 1234); ?> correctly produces jh@rautu:~$ /tmp/test.php Printing number 1234 what comes to my the specific trial implementation, it first calls spve fixup on the string value that may contain pseudo variables and then tries to get final string value based on the fixup result. what exactly is wrong with this? why all calls succeed, but final string value is not correct? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=78#comment92 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

msilo generated messages should not include Contact header
by Juha Heinanen 01 Jul '10

01 Jul '10

i noticed that msilo generated messages include a Contact header such as: Contact: <sip:jh@test.fi>;msilo=yes according to rfc3428.txt this is wrong: MESSAGE requests do not initiate dialogs. User Agents MUST NOT insert Contact header fields into MESSAGE requests. if no one objects, i'll fix msilo module accordingly, i.e., remove contact header from msilo generated messages. -- juha

3 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2010