sr-dev July 2010

sr-dev@lists.kamailio.org

29 participants
223 discussions

[tracker] Comment added: Major regression in db_postgres with FS#77 patch

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#80 - Major regression in db_postgres with FS#77 patch User who did this - Henning Westerholt (henningw) ---------- Ok, this sounds indeed as a unexpected consequence of the patch. I'll tomorrow try to reproduce locally and also take a look how the mysql engine behaves here. With regards to the if($avp(..)) checks, this also not work reliable in some other corner cases on mysql, if i remember correctly. More reliable is to check for the return type of avp_db_query. But the problem with append_hf() is unrelated to this. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=80#comment95 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years, 10 months

[tracker] User took ownership: Major regression in db_postgres with FS#77 patch

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Henning Westerholt has taken ownership of the following task: FS#80 - Major regression in db_postgres with FS#77 patch More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=80 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years, 10 months

method mask for xlog

by Juha Heinanen

i'm thinking to add method mask to xlog module. when xlog() is called, nothing happens if method of request or reply is included in the mask. the mask could be set at run rime via an rpc command and would default to 0. using the mask, it would be easy, for example, to prevent logging of OPTIONS requests without a need to add if statements to the script. any comments? -- juha

13 years, 10 months

[tracker] Task opened: Major regression in db_postgres with FS#77 patch

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Bayan (bayan) Attached to Project - sip-router Summary - Major regression in db_postgres with FS#77 patch Task Type - Bug Report Category - Module Status - Unconfirmed Assigned To - Operating System - All Severity - High Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - The patch for FS#77 that was applied to 1.5 3.0 and master caused a major regression for other modules using db_postgres. Currently, all queries returning a Text type result have an extra 0x00 at the end. For example, in avpops, when avp_db_query() is called and a text field is returned to be stored in an avp, an extra null (0x00) is saved at the end of the field in the avp. This means that even results that should be null are giving the avp a value which breaks conditional statements. This 0x00 also transfers to the SIP message if the result used in append_hf() which corrupts the SIP message. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=80 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years, 10 months

[tracker] Comment added: presence_xml with db_postgres

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#77 - presence_xml with db_postgres User who did this - Bayan (bayan) ---------- This patch has messed up other modules that depend on db_postgres and caused lots of problems forcing us to revert to older versions. With this patch, when avp_db_query() is called and a text field is returned, an extra null (0x00) is saved at the end of the field in the avp. This means that even null results fill up the avp and give a value. I'm not sure how to reopen the ticket. Can you please resolve this? Bayan ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=77#comment94 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years, 10 months

New commits on branch kamailio_3.0

by Daniel-Constantin Mierla

URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c72473f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 16 17:22:05 2010 +0200 dispatcher: doc updated to reflect PV parameter options - ds_select_dst() can take PVs as parameters (cherry picked from commit f3d351355852c7df6582bcd7939ee3855168a60a) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e4b3a3d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 16 17:19:48 2010 +0200 tm: use warn to print message if load_tm is not found - in case of sl trying to import tm api for stateful reply, is not an error if tm is not found - modules importing tm api print error message if the function returns error code and they need the tm (cherry picked from commit 5a25609343f5697e6ebcf8f49e589b992a8af72e) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d9a4c3b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 15 13:48:21 2010 +0200 core: print line for include_file errors - easier to localize the error, reported by Raul Alexis Betancor Santana (cherry picked from commit 2b680bde0605cbc1cb4840105fafc83a2a235ec5) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a0c6d4b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 8 12:34:40 2010 +0200 tmx: use TM api function to get tm table - fix missing symbol for mode=debug, reported by Santiago Gimeno (cherry picked from commit fb39052ff574c133c74f1f0a1c8d5f43b5bc93be) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f6ddf0a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 8 12:32:45 2010 +0200 tm: export function to get access to tm table - to fix missing symbol in tmx for mode=debug, reported by Santiago Gimeno (cherry picked from commit 181f81b2458ee04241b36c65ac1d95f38003250d) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=87f7392… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Jul 5 10:36:58 2010 +0200 core: typos in comments (cherry picked from commit 39ac6a5c0a7833ad0c29ae7711f37b92c5c81e95) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cbac69c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 2 18:21:10 2010 +0200 tm: TMCB_RESPONSE_READY executes by its own - removed the define of it to TMCB_RESPONSE_OUT - now this callback is executed before writing reply to network (cherry picked from commit f1c35c13252d3160334e9b3f56094404f06009ba) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f9f7bef… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 21:03:36 2010 +0200 msilo(k): updated readme file - documented the new parameter add_contact - readme file regenerated (cherry picked from commit 9d8c55287ea9ac93440d762c511afe531c629552) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cb4d998… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 20:56:23 2010 +0200 msilo(k): parameter to control contact header - add_contact parameter controls whether contact header is added to msilo generated messages - default is off (no contact added, as per RFC3428), reported by Juha Heinanen (cherry picked from commit 8ffb09ce908088af89e70a5acd87a318baf5a029) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=56d19db… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 19:19:17 2010 +0200 pdb: avoid child re-init - for mi cmd when used over xmlrpc module (cherry picked from commit bc34a82fbf5bd903cc50cb34c73afb7b685603a7) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b4b903e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 19:08:04 2010 +0200 presence_xml: avoid re-init of db handler - safety check for usage of xmlrpc module for mi cmds (cherry picked from commit 098deec785ab7c4e927104e83fc84b6c1b347719) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ad6ae8c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 19:07:18 2010 +0200 presence: avoid re-init of db handler - safety check for usage of xmlrpc for mi cmds (cherry picked from commit 8a1d985743fe6ec544a215b8ddb6e54adbb024d9) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2b47fd2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 19:00:51 2010 +0200 kex: check if uptime value was initialized (cherry picked from commit 7537d27782b185a20d32b08f7bcb30557bb3b7ff) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a01e7ed… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 18:57:09 2010 +0200 userblacklist: avoid double child initialization - safety check for cases when xmlrpc module is used to run mi commands (cherry picked from commit 3f2ca85f4254746240177830e85a87b81d8cfd85) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=705a61b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 18:43:54 2010 +0200 usrloc(k): avoid re-initialization of db handler - can happen if mi commands are used over rpc interface via xmlrpc module (cherry picked from commit 8948fe654b83217979b2d2154934a973aefa9ae3) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7e2eaeb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 18:35:27 2010 +0200 domain(k): safety check for db handler initialization - avoid double initialization of db handler when using xmlrpc module for mi commands (cherry picked from commit c65fc04ff83c6304d5889f3426b3b96b5ac7ee69) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8a9b915… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 18:31:14 2010 +0200 drouting: check if db connection is initialized - applied for the case of mi reload command (cherry picked from commit 76266ca085d05be949ddc34df513de6810c5d65f) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=36b8d1a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 18:22:15 2010 +0200 htable: close db connection in case of mi cmd errors - in some error cases while processing mi reload command, db connection was left open (cherry picked from commit e723b2b24a87599d538b652ee60c862f769f8036) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4a83157… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 18:15:33 2010 +0200 pdt(k): safety check for db handler initialization - there can be two attepts to initialize if xmlrpc module is loaded (cherry picked from commit 2e8d469de4253444d61cb186395d40c0fd492fe6) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=59d209f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 18:13:54 2010 +0200 mi_rpc: initialize mi cmds for sip workers - xmlrpc module re-uses sip workers to process xmlrpc request which can execute mi commands, therefore is need to initialize mi cmds as for a mi process - initialization is done only when xmlrpc module is loaded (cherry picked from commit b2b2a82d497ee37428abab933f4862255bc5c4a1) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a6abcee… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 17:40:20 2010 +0200 permissions(k): safety check for db_handle - avoid double initialization of trusted ops db handler (cherry picked from commit df2d92a1f0698e0d108ec080de5fc3673d332209) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a92bb2e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 12:10:34 2010 +0200 permissions(k): reverted incomplete fix for mi cmd - the mi command execution via rpc is fixed by initialization of mi commands done now by mi_rpc module URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6028bb2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 12:08:42 2010 +0200 mi_rpc: call MI init child functions - MI init child functions called for RPC processes - fix for several MI commands that can be executed now via RPC and they needed to do specific initialization for each process - reported by Juha Heinanen (cherry picked from commit af18dae034cf8836f1627929f189983ca6010428) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1364efd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 12:04:52 2010 +0200 kmi: allow multiple initializations of mi child - safety check to detect if mi child was initialized - protect against multiple initializations that can occure due to usage from MI or RPC processes (cherry picked from commit 4047fc33053898d17498104b849dae9e45bee1e6) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=99a0c0e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Jun 29 19:48:59 2010 +0200 core: safety check for free contact - patch by Sebastian Z., checking if the content is null before freeing it (cherry picked from commit 7aed7d72c98a8228e9687773c3bab20d8934251a) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=134edd5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Jun 1 23:02:14 2010 +0200 presence_xml: fixed log message

13 years, 10 months

git:master: core: pkg size can be set via compile option

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: bdc85a8cdf3e4ec8ae543691ed77e6ab0e458240 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bdc85a8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 16 19:10:54 2010 +0200 core: pkg size can be set via compile option - new makefile option PKG_MEM_SIZE that can be used to specify the size in MB for PKG memory, e.g., make PKG_MEM_SIZE=8 cfg - easier way to set the pkg size without messing with c code and defines in config.h - pkg size is printed by -V command line option --- Makefile.defs | 3 +++ config.h | 5 ++++- main.c | 4 ++-- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index e34f305..f6bf2c4 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -666,6 +666,9 @@ ifeq ($(MEMDBG), 1) else C_DEFS+= -DF_MALLOC endif +ifneq ($(PKG_MEM_SIZE),) + C_DEFS+= -DPKG_MEM_SIZE=$(PKG_MEM_SIZE) +endif ifeq ($(CORE_TLS), 1) C_DEFS+= -DUSE_TLS -DCORE_TLS endif diff --git a/config.h b/config.h index 83ba64c..1c5108d 100644 --- a/config.h +++ b/config.h @@ -140,7 +140,10 @@ #define SRV_MAX_PREFIX_LEN SRV_TLS_PREFIX_LEN -#define PKG_MEM_POOL_SIZE 4*1024*1024 /*!< used only if PKG_MALLOC is defined*/ +#ifndef PKG_MEM_SIZE +#define PKG_MEM_SIZE 4 +#endif +#define PKG_MEM_POOL_SIZE PKG_MEM_SIZE*1024*1024 /*!< used only if PKG_MALLOC is defined*/ #define SHM_MEM_SIZE 32 /*!< used if SH_MEM is defined*/ diff --git a/main.c b/main.c index 8f71731..ea90c43 100644 --- a/main.c +++ b/main.c @@ -265,9 +265,9 @@ void print_ct_constants() #endif */ printf("MAX_RECV_BUFFER_SIZE %d, MAX_LISTEN %d," - " MAX_URI_SIZE %d, BUF_SIZE %d\n", + " MAX_URI_SIZE %d, BUF_SIZE %d, PKG_SIZE %uMB\n", MAX_RECV_BUFFER_SIZE, MAX_LISTEN, MAX_URI_SIZE, - BUF_SIZE ); + BUF_SIZE, PKG_MEM_SIZE); #ifdef USE_TCP printf("poll method support: %s.\n", poll_support); #endif

13 years, 10 months

git:andrei/tcp_tls_changes: tls: no tls_bio debugging by default

by Andrei Pelinescu-Onciul

Module: sip-router Branch: andrei/tcp_tls_changes Commit: d38a78bfa702927cb298d0c3c033f563c6183879 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d38a78b… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Jul 16 18:50:04 2010 +0200 tls: no tls_bio debugging by default Don't log BIO level debug messages, unless compiled with -DTLS_BIO_DEBUG. --- modules/tls/tls_bio.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/tls/tls_bio.c b/modules/tls/tls_bio.c index df0a7af..c9b4af0 100644 --- a/modules/tls/tls_bio.c +++ b/modules/tls/tls_bio.c @@ -38,8 +38,8 @@ #define BIO_TYPE_TLS_MBUF (BIO_TYPE_SOURCE_SINK | 0xf2) /* debugging */ -#ifndef NO_TLS_BIO_DEBUG -#define TLS_BIO_DEBUG +#ifdef NO_TLS_BIO_DEBUG +#undef TLS_BIO_DEBUG #endif #ifdef TLS_BIO_DEBUG #ifdef __SUNPRO_C

13 years, 10 months

git:master: dispatcher: doc updated to reflect PV parameter options

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: f3d351355852c7df6582bcd7939ee3855168a60a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f3d3513… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 16 17:22:05 2010 +0200 dispatcher: doc updated to reflect PV parameter options - ds_select_dst() can take PVs as parameters --- modules_k/dispatcher/README | 456 +++++++++++++++---------- modules_k/dispatcher/doc/dispatcher_admin.xml | 13 +- 2 files changed, 291 insertions(+), 178 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=f3d…

13 years, 10 months

git:master: tm: use warn to print message if load_tm is not found

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 5a25609343f5697e6ebcf8f49e589b992a8af72e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5a25609… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 16 17:19:48 2010 +0200 tm: use warn to print message if load_tm is not found - in case of sl trying to import tm api for stateful reply, is not an error if tm is not found - modules importing tm api print error message if the function returns error code and they need the tm --- modules/tm/tm_load.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/tm/tm_load.h b/modules/tm/tm_load.h index 11cf4e1..14b2256 100644 --- a/modules/tm/tm_load.h +++ b/modules/tm/tm_load.h @@ -143,7 +143,7 @@ static inline int load_tm_api(struct tm_binds* tmb) load_tm = (load_tm_f)find_export("load_tm", NO_SCRIPT, 0); if (load_tm == NULL) { - LOG(L_ERR, "Cannot import load_tm function from tm module\n"); + LOG(L_WARN, "Cannot import load_tm function from tm module\n"); return -1; }

13 years, 10 months

← Newer
1
...
10
11
12
13
14
15
16
...
23
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2010