sr-dev April 2010

sr-dev@lists.kamailio.org

27 participants
495 discussions

SF.net SVN: openser:[6000] branches/1.5/modules/permissions/address.c
by Juha Heinanen 08 Apr '10

08 Apr '10

Revision: 6000 http://openser.svn.sourceforge.net/openser/?rev=6000&view=rev Author: juhe Date: 2010-04-08 16:52:46 +0000 (Thu, 08 Apr 2010) Log Message: ----------- * Fixed incorrect error message. Modified Paths: -------------- branches/1.5/modules/permissions/address.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

1 0

[tracker] Comment added: kamailio 3.0.x: segfault in carrierroute
by sip-router 08 Apr '10

08 Apr '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#60 - kamailio 3.0.x: segfault in carrierroute User who did this - Ovidiu Sas (osas) ---------- With the new core (in kamailio 3.0) the AVPs are handled a little bit different then kamailio 1.x. I remember some discussions about how to handle string versus integer AVPs, but I don't remember all the details. I prefer to use int AVPs (my understanding - in kamailio 1.5 - was that int AVPs were faster then str AVPs). Maybe Daniel or Andrei can shed more light on this issue. Thanks, Ovidiu ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=60#comment73 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

3 2

[tracker] Comment added: kamailio 3.0.x: segfault in carrierroute
by sip-router 08 Apr '10

08 Apr '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#60 - kamailio 3.0.x: segfault in carrierroute User who did this - Ovidiu Sas (osas) ---------- Hello Marius, I performed some tests and the server is not crashing anymore. Here's the output of the logs: INFO: <script>: [1] cr_route("3", "1"); ERROR: carrierroute [cr_func.c:112]: could not find id '707' ERROR: carrierroute [cr_func.c:558]: invalid carrier id -1 The verbosity of error logs are not good enough to debug the problem and a little bit misleading: - the avp i:707 exists and it is having a valid value - the carrier id that we were looking for is '3', not '-1' On the other hand, I wonder if these error logs are really necessary. Most of the time, I iterate through carriers until I run out of them. In order to figure out if the routing is successful, I test the return of 'cr_route': if ( cr_route(...) ) and in case of an error I print out an error log: xlog("L_WARN", "WARNING: [$mi] Unable to route '$rU' via carrier '$avp(i:707)' and domain '$var(domain)'\n"); with the following output: WARNING: <script>: WARNING: [1] Unable to route '123' via carrier '3' and domain '1' I would see that trying to route via a non existing carrier is a script issue and the maintainer of the script should deal with it (by checking the return of 'cr_route') and the logs should be clean (the routing works as expected and if there are no routes, then no routing is performed which is properly reflected by the return code of cr_route). Regards, Ovidiu Sas ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=60#comment74 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: kamailio 3.0.x: segfault in carrierroute
by sip-router 08 Apr '10

08 Apr '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#60 - kamailio 3.0.x: segfault in carrierroute User who did this - marius zbihlei (marius.zbihlei) ---------- Hello Ovidiu, I have done a couple of tests and I get the following results: 1. The crash happens only in kamailio-3.0 branch (not it ser or kamailio 1.5) 2. The crash happens only when I use an string value for the avp As it seems the handling of the name of the avp in case of an error is wrong, because the code always behaves like the avp name is AVP_VAL_STR which is not the case in smth like $avp(i:707) I have commited a patch on the kamailio_3.0 branch that fixes the bug by checking the type of avp name. (http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5604e51…) As I side note I still can't figure it out why in ser or kamailio 1.5 it doesn't crash. If anyone can shed more light on the subject, I would be very thankful. Marius ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=60#comment72 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:kamailio_3.0: modules/carrierroute In case of incorrect avp value ( unknown carrier id), print the name of the avp accordinly to its type
by Marius Zbihlei 08 Apr '10

08 Apr '10

Module: sip-router Branch: kamailio_3.0 Commit: 5604e51eb8fd6502495a37c26f9c549bcd63ca8a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5604e51… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Thu Apr 8 16:54:53 2010 +0300 modules/carrierroute In case of incorrect avp value (unknown carrier id), print the name of the avp accordinly to its type --- modules/carrierroute/cr_func.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/modules/carrierroute/cr_func.c b/modules/carrierroute/cr_func.c index 425bb0c..8effe12 100644 --- a/modules/carrierroute/cr_func.c +++ b/modules/carrierroute/cr_func.c @@ -90,8 +90,12 @@ static inline int cr_gp2id(struct sip_msg *_msg, gparam_t *gp, struct name_map_t avp = search_first_avp(gp->v.pve->spec.pvp.pvn.u.isname.type, gp->v.pve->spec.pvp.pvn.u.isname.name, &avp_val, 0); if (!avp) { - LM_ERR("cannot find AVP '%.*s'\n", gp->v.pve->spec.pvp.pvn.u.isname.name.s.len, + if(gp->v.pve->spec.pvp.pvn.u.isname.type & AVP_NAME_STR) + LM_ERR("cannot find AVP '%.*s'\n", gp->v.pve->spec.pvp.pvn.u.isname.name.s.len, gp->v.pve->spec.pvp.pvn.u.isname.name.s.s); + else if(gp->v.pve->spec.pvp.pvn.u.isname.type & AVP_NAME_RE) + LM_ERR("cannot find AVP regex\n"); + else LM_ERR("cannot find AVP '%d'\n", gp->v.pve->spec.pvp.pvn.u.isname.name.n); return -1; } if ((avp->flags&AVP_VAL_STR)==0) { @@ -99,9 +103,13 @@ static inline int cr_gp2id(struct sip_msg *_msg, gparam_t *gp, struct name_map_t } else { id = map_name2id(map, size, &avp_val.s); if (id < 0) { - LM_ERR("could not find id '%.*s' from AVP\n", + if(gp->v.pve->spec.pvp.pvn.u.isname.type & AVP_NAME_STR) + LM_ERR("could not find id '%.*s' from AVP\n", gp->v.pve->spec.pvp.pvn.u.isname.name.s.len, gp->v.pve->spec.pvp.pvn.u.isname.name.s.s); + else if(gp->v.pve->spec.pvp.pvn.u.isname.type & AVP_NAME_RE) + LM_ERR("could not find id regex\n"); + else LM_ERR("could not find id '%d'\n", gp->v.pve->spec.pvp.pvn.u.isname.name.n); return -1; } return id;

1 0

irc devel meeting
by Daniel-Constantin Mierla 08 Apr '10

08 Apr '10

Hello, I know some of devels are still in Easter vacation, but I hope we can get together soon on irc to sketch the plan for 3.1 release. I propose next week, Wednesday, April 14, 15:00UTC, on #sip-router channel hosted by irc.freenode.net If you are a developer and want to participate, please announce. If it is not possible to attend for major contributors, we can look for another date (eventually start a pool to see the day were most of us are available). Cheers, Daniel -- Daniel-Constantin Mierla * http://www.asipto.com/ * http://twitter.com/miconda * http://www.linkedin.com/in/danielconstantinmierla

5 5

[tracker] User took ownership: kamailio 3.0.x: segfault in carrierroute
by sip-router 08 Apr '10

08 Apr '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. marius zbihlei has taken ownership of the following task: FS#60 - kamailio 3.0.x: segfault in carrierroute More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=60 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

merging users mailing lists
by Daniel-Constantin Mierla 08 Apr '10

08 Apr '10

Hello, I propose to merge the users mailing lists, most of the traffic these days is about 3.0 and even there are 2 stables branches now, they are sync'ed, so same code more or less. For 3.1 will be one stable branch, falvor selection will be only a matter of make command. Lately common useful topics are discussed on those different mailing lists, notifications and knowledge base building require cross-posting, lot of overhead imo. Any other opinion? Like with devel mailing lists, existing email addresses for users ML can still be used, just that end on same ML. Natural choice will be to have users@kamailio and serusers@iptel to be directed to sr-users(a)lists.sip-router.org Cheers, Daniel -- Daniel-Constantin Mierla * http://www.asipto.com/

6 8

git:master: pdbt(sr): some spelling fixes, found by Jakob Hirsch
by Henning Westerholt 08 Apr '10

08 Apr '10

Module: sip-router Branch: master Commit: 465a781e73128e66e9328fa27f1c1a1971b260dc URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=465a781… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Thu Apr 8 10:37:22 2010 +0200 pdbt(sr): some spelling fixes, found by Jakob Hirsch --- utils/pdbt/docs/network_protocol.txt | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/pdbt/docs/network_protocol.txt b/utils/pdbt/docs/network_protocol.txt index 2daff3b..b93eaf9 100644 --- a/utils/pdbt/docs/network_protocol.txt +++ b/utils/pdbt/docs/network_protocol.txt @@ -1,11 +1,11 @@ * Network protocol of pdb server and sip-router module * The pdb server daemon listen only for UDP messages. The requests contains in -the UDP payload the number starting with a internation prefix, e.g. '49' for +the UDP payload the number starting with a international prefix, e.g. '49' for germany. It must contain only numbers like this: '49721913742734'. The answer packet contains then the number string from the respective request, -null-terminated and followed from two bytes which represents the result. This +null-terminated and followed by two bytes which represents the result. This two bytes are interpreted as 16 bit signed integer value, the UDP payload is in network byte order (most significant byte first).

1 0

[tracker] Task opened: more user friendly module function fixup system
by sip-router 08 Apr '10

08 Apr '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Juha Heinanen (jh) Attached to Project - sip-router Summary - more user friendly module function fixup system Task Type - Improvement Category - Core Status - Assigned Assigned To - Andrei Pelinescu-Onciul Operating System - All Severity - Medium Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - now when module functions can have any number of arguments, a scalable and more user friendly fixup system needs to be developed. basic requirement is that if a module function only accepts well known arguments, such as int, str, pvar, or spve, all that module writer would need to do is to list the type of each argument. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=61 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2010