sr-dev December 2010

sr-dev@lists.kamailio.org

16 participants
114 discussions

[tracker] Comment added: Error db_berkeley

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#106 - Error db_berkeley User who did this - stas (_stas) ---------- Thanks for your answer. I have rectified this error change of the declaration of structure "struct module_exports exports" in a file dbd_mod.c. I have changed "db_bdb" on "db_berkeley". All works. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=106#comment144 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years

[tracker] Comment added: $snd(name) pvar contains local instead of remote socket info

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#103 - $snd(name) pvar contains local instead of remote socket info User who did this - Daniel-Constantin Mierla (miconda) ---------- I just did a commit and broke $snd(id) in $sndto(id) and $sndfrom(id) to get access to the details of remote address and local socket used for sending. $snd(id) is aliased to $sndto(id). It is committed on master branch, if you can test and report if all is ok, then I will backport to get it fixed as well in 3.x branches. Thanks! ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=103#comment143 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years

git:master: pv: $snd(id) broken in $sndto(id) and $sndfrom(id)

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: f6e2325aa6770840c25dbb64afd405f73077fc79 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f6e2325… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Dec 6 00:05:46 2010 +0100 pv: $snd(id) broken in $sndto(id) and $sndfrom(id) - $snd(id) is aliased to $sndto(id) - $sndto(id) points to next hop address - $sndfrom(id) points to local socket to be used for sending --- modules_k/pv/pv.c | 8 ++++++-- modules_k/pv/pv_branch.c | 40 +++++++++++++++++++++++++++++++++++++++- modules_k/pv/pv_branch.h | 4 +++- 3 files changed, 48 insertions(+), 4 deletions(-) diff --git a/modules_k/pv/pv.c b/modules_k/pv/pv.c index efeb7ee..3e21fc9 100644 --- a/modules_k/pv/pv.c +++ b/modules_k/pv/pv.c @@ -70,8 +70,12 @@ static pv_export_t mod_pvs[] = { { {"sel", sizeof("sel")-1}, /* select */ PVT_OTHER, pv_get_select, 0, pv_parse_select_name, 0, 0, 0 }, - {{"snd", (sizeof("snd")-1)}, PVT_OTHER, pv_get_snd, 0, - pv_parse_snd_name, 0, 0, 0}, + { {"snd", (sizeof("snd")-1)}, PVT_OTHER, pv_get_sndto, 0, + pv_parse_snd_name, 0, 0, 0 }, + { {"sndto", (sizeof("sndto")-1)}, PVT_OTHER, pv_get_sndto, 0, + pv_parse_snd_name, 0, 0, 0 }, + { {"sndfrom", (sizeof("sndfrom")-1)}, PVT_OTHER, pv_get_sndfrom, 0, + pv_parse_snd_name, 0, 0, 0 }, #ifdef WITH_XAVP { {"xavp", sizeof("xavp")-1}, /* xavp */ PVT_OTHER, pv_get_xavp, pv_set_xavp, diff --git a/modules_k/pv/pv_branch.c b/modules_k/pv/pv_branch.c index 0831bd5..a9dd1bc 100644 --- a/modules_k/pv/pv_branch.c +++ b/modules_k/pv/pv_branch.c @@ -328,7 +328,7 @@ error: return -1; } -int pv_get_snd(struct sip_msg *msg, pv_param_t *param, +int pv_get_sndfrom(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { struct onsend_info* snd_inf; @@ -365,6 +365,44 @@ int pv_get_snd(struct sip_msg *msg, pv_param_t *param, return 0; } +int pv_get_sndto(struct sip_msg *msg, pv_param_t *param, + pv_value_t *res) +{ + struct onsend_info* snd_inf; + str s; + + snd_inf=get_onsend_info(); + if (! likely(snd_inf && snd_inf->send_sock)) + return pv_get_null(msg, param, res); + + switch(param->pvn.u.isname.name.n) + { + case 1: /* af */ + return pv_get_uintval(msg, param, res, + (int)snd_inf->send_sock->address.af); + case 2: /* port */ + return pv_get_uintval(msg, param, res, + (int)su_getport(snd_inf->to)); + case 3: /* proto */ + return pv_get_uintval(msg, param, res, + (int)snd_inf->send_sock->proto); + case 4: /* buf */ + s.s = snd_inf->buf; + s.len = snd_inf->len; + return pv_get_strval(msg, param, res, &s); + case 5: /* len */ + return pv_get_uintval(msg, param, res, + (int)snd_inf->len); + default: + /* 0 - ip */ + s.s = su2a(snd_inf->to, sizeof(*snd_inf->to)); + s.len = strlen(s.s); + return pv_get_strval(msg, param, res, &s); + } + + return 0; +} + int pv_parse_snd_name(pv_spec_p sp, str *in) { if(sp==NULL || in==NULL || in->len<=0) diff --git a/modules_k/pv/pv_branch.h b/modules_k/pv/pv_branch.h index d8e3fbc..b10d877 100644 --- a/modules_k/pv/pv_branch.h +++ b/modules_k/pv/pv_branch.h @@ -31,7 +31,9 @@ int pv_set_branchx(struct sip_msg* msg, pv_param_t *param, int op, pv_value_t *val); int pv_parse_branchx_name(pv_spec_p sp, str *in); -int pv_get_snd(struct sip_msg *msg, pv_param_t *param, +int pv_get_sndto(struct sip_msg *msg, pv_param_t *param, + pv_value_t *res); +int pv_get_sndfrom(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); int pv_parse_snd_name(pv_spec_p sp, str *in);

14 years

[tracker] User took ownership: $snd(name) pvar contains local instead of remote socket info

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Daniel-Constantin Mierla has taken ownership of the following task: FS#103 - $snd(name) pvar contains local instead of remote socket info More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=103 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years

[tracker] Task closed: [regression] proxy_authorize function is missing return values

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#101 - [regression] proxy_authorize function is missing return values User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented Additional comments about closing: Thanks! Patch broken in pieces to be able to cherry-pick easier in stable branches. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=101 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years

git:master: auth: README regenerated

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: fef7983c13a3bc1e9c501f80b3f4c618ad80373f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fef7983… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Dec 5 23:28:31 2010 +0100 auth: README regenerated --- modules/auth/README | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/modules/auth/README b/modules/auth/README index 025a044..0c34aa8 100644 --- a/modules/auth/README +++ b/modules/auth/README @@ -585,6 +585,11 @@ if (!proxy_authenticate("$fd", "subscriber)) { sent out; * -2 (invalid password) - wrong password; * -3 (invalid user) - authentication user does not exist. + * -4 (nonce expired) - the nonce has expired + * -5 (no credentials) - request does not contain an Authorization + header with the correct realm. + * -6 (nonce reused) - the nonce has already been used to authenticate + a previous request Meaning of the parameters is as follows: * realm - Realm is a opaque string that the user agent should present

14 years

git:master: auth: more return codes for auth API

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 5ec0e4222a31610ec0c4184dfdbe6d10dd00e0b5 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5ec0e42… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Dec 5 23:23:41 2010 +0100 auth: more return codes for auth API - report more granular failure causes - part of patch by Alex Hermann, FS#101 --- modules/auth/api.c | 9 +++++++-- modules/auth/api.h | 9 ++++++++- modules/auth/auth_mod.c | 12 ++++++++++++ modules/auth/doc/functions.xml | 11 +++++++++++ modules/auth/nonce.c | 3 ++- 5 files changed, 40 insertions(+), 4 deletions(-) diff --git a/modules/auth/api.c b/modules/auth/api.c index f73b75d..b7ce413 100644 --- a/modules/auth/api.c +++ b/modules/auth/api.c @@ -83,7 +83,7 @@ auth_result_t pre_auth(struct sip_msg* msg, str* realm, hdr_types_t hftype, } else if (ret > 0) { DBG("auth:pre_auth: Credentials with realm '%.*s' not found\n", realm->len, ZSW(realm->s)); - return NOT_AUTHENTICATED; + return NO_CREDENTIALS; } /* Pointer to the parsed credentials */ @@ -132,7 +132,12 @@ static int auth_check_hdr_md5(struct sip_msg* msg, auth_body_t* auth, if (ret==3 || ret==4){ /* failed auth_extra_checks or stale */ auth->stale=1; /* we mark the nonce as stale - (hack that makes our life much easier) */ + (hack that makes our life much easier) */ + *auth_res = STALE_NONCE; + return 0; + } else if (ret==6) { + *auth_res = NONCE_REUSED; + return 0; } else { DBG("auth:pre_auth: Invalid nonce value received\n"); *auth_res = NOT_AUTHENTICATED; diff --git a/modules/auth/api.h b/modules/auth/api.h index 35807cd..976a547 100644 --- a/modules/auth/api.h +++ b/modules/auth/api.h @@ -44,6 +44,9 @@ * return codes to config by auth functions */ typedef enum auth_cfg_result { + AUTH_NONCE_REUSED = -6, /*!< Returned if nonce is used more than once */ + AUTH_NO_CREDENTIALS = -5, /*!< Credentials missing */ + AUTH_STALE_NONCE = -4, /*!< Stale nonce */ AUTH_USER_UNKNOWN = -3, /*!< User not found */ AUTH_INVALID_PASSWORD = -2, /*!< Invalid password */ AUTH_ERROR = -1, /*!< Error occurred */ @@ -56,7 +59,10 @@ typedef enum auth_cfg_result { * return codes to auth API functions */ typedef enum auth_result { - ERROR = -2 , /* Error occurred, a reply has been sent out -> return 0 to the ser core */ + NONCE_REUSED = -5, /* Returned if nonce is used more than once */ + NO_CREDENTIALS, /* Credentials missing */ + STALE_NONCE, /* Stale nonce */ + ERROR, /* Error occurred, a reply has been sent out -> return 0 to the ser core */ NOT_AUTHENTICATED, /* Don't perform authentication, credentials missing */ DO_AUTHENTICATION, /* Perform digest authentication */ AUTHENTICATED, /* Authenticated by default, no digest authentication necessary */ @@ -68,6 +74,7 @@ typedef enum auth_result { * of sequnce numbers with mobile station. */ } auth_result_t; + typedef int (*check_auth_hdr_t)(struct sip_msg* msg, auth_body_t* auth_body, auth_result_t* auth_res); int check_auth_hdr(struct sip_msg* msg, auth_body_t* auth_body, diff --git a/modules/auth/auth_mod.c b/modules/auth/auth_mod.c index 87f4291..c44fb96 100644 --- a/modules/auth/auth_mod.c +++ b/modules/auth/auth_mod.c @@ -409,6 +409,18 @@ int pv_authenticate(struct sip_msg *msg, str *realm, str *passwd, ret = AUTH_ERROR; switch(pre_auth(msg, realm, hftype, &h, NULL)) { + case NONCE_REUSED: + LM_DBG("nonce reused"); + ret = AUTH_NONCE_REUSED; + goto end; + case STALE_NONCE: + LM_DBG("stale nonce\n"); + ret = AUTH_STALE_NONCE; + goto end; + case NO_CREDENTIALS: + LM_DBG("no credentials\n"); + ret = AUTH_NO_CREDENTIALS; + goto end; case ERROR: case BAD_CREDENTIALS: LM_DBG("error or bad credentials\n"); diff --git a/modules/auth/doc/functions.xml b/modules/auth/doc/functions.xml index 45eceb6..f452529 100644 --- a/modules/auth/doc/functions.xml +++ b/modules/auth/doc/functions.xml @@ -158,6 +158,17 @@ if (!proxy_authenticate("$fd", "subscriber)) { <emphasis>-3 (invalid user)</emphasis> - authentication user does not exist. </para></listitem> + <listitem><para> + <emphasis>-4 (nonce expired)</emphasis> - the nonce has expired + </para></listitem> + <listitem><para> + <emphasis>-5 (no credentials)</emphasis> - request does not contain + an Authorization header with the correct realm. + </para></listitem> + <listitem><para> + <emphasis>-6 (nonce reused)</emphasis> - the nonce has already been + used to authenticate a previous request + </para></listitem> </itemizedlist> <para>Meaning of the parameters is as follows:</para> <itemizedlist> diff --git a/modules/auth/nonce.c b/modules/auth/nonce.c index 72c156a..1611876 100644 --- a/modules/auth/nonce.c +++ b/modules/auth/nonce.c @@ -302,6 +302,7 @@ int calc_nonce(char* nonce, int *nonce_len, int cfg, int since, int expires, * 3 - nonce expires ok, but the auth_extra checks failed * 4 - stale * 5 - invalid nc value (not an unsigned int) + * 6 - nonce reused */ int check_nonce(auth_body_t* auth, str* secret1, str* secret2, struct sip_msg* msg) @@ -430,7 +431,7 @@ int check_nonce(auth_body_t* auth, str* secret1, str* secret2, case OTN_ID_OVERFLOW: case OTN_INV_POOL: case OTN_REPLAY: - return 4; /* stale */ + return 6; /* reused */ } } #endif

14 years

git:master: auth_db(k): more granular return codes for failure cases

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 010f9159f974d81d8bf5be2ab4d92e38325de884 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=010f915… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Dec 5 23:25:41 2010 +0100 auth_db(k): more granular return codes for failure cases - enhanced the config auth functions return codes - part of a path by Alex Hermann, FS#101 --- modules_k/auth_db/authorize.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/modules_k/auth_db/authorize.c b/modules_k/auth_db/authorize.c index 564da9c..0502760 100644 --- a/modules_k/auth_db/authorize.c +++ b/modules_k/auth_db/authorize.c @@ -220,6 +220,18 @@ static int digest_authenticate(struct sip_msg* msg, str *realm, ret = auth_api.pre_auth(msg, realm, hftype, &h, NULL); switch(ret) { + case NONCE_REUSED: + LM_DBG("nonce reused"); + ret = AUTH_NONCE_REUSED; + goto end; + case STALE_NONCE: + LM_DBG("stale nonce\n"); + ret = AUTH_STALE_NONCE; + goto end; + case NO_CREDENTIALS: + LM_DBG("no credentials\n"); + ret = AUTH_NO_CREDENTIALS; + goto end; case ERROR: case BAD_CREDENTIALS: LM_DBG("error or bad credentials\n");

14 years

[tracker] Task closed: presence_xml with db_postgres

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#77 - presence_xml with db_postgres User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: I added a fix before releasing 3.1.0, if the issue still persists, reopen. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=77 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years

[tracker] Task closed: dialplan reload, out of memory

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#86 - dialplan reload, out of memory User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Not a bug Additional comments about closing: If adjusting of fetch_rows does not help, then reopen. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=86 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years

← Newer
1
...
6
7
8
9
10
11
12
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2010