sr-dev December 2010

sr-dev@lists.kamailio.org

16 participants
114 discussions

by Jon Bonilla

Module: sip-router Branch: 3.1 Commit: 88bda825581a919778eb6f85e0a7bf6b04ede630 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=88bda82… Author: Jon Bonilla <manwe(a)aholab.ehu.es> Committer: Jon Bonilla <manwe(a)aholab.ehu.es> Date: Sat Dec 4 09:22:15 2010 +0100 pkg/debian: Fix bad changelog. * Prevents dpkg-parsechangelog not parsing the correct version and generating bad versiones packages. --- pkg/kamailio/deb/debian/changelog | 2 +- pkg/kamailio/deb/lenny/changelog | 2 +- pkg/kamailio/deb/lucid/changelog | 2 +- pkg/kamailio/deb/squeeze/changelog | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/kamailio/deb/debian/changelog b/pkg/kamailio/deb/debian/changelog index 44e7ccf..5d95b65 100644 --- a/pkg/kamailio/deb/debian/changelog +++ b/pkg/kamailio/deb/debian/changelog @@ -2,7 +2,7 @@ kamailio (3.1.1) unstable; urgency=low * update to 3.1.1 from upstream - -- Jon Bonilla <manwe(a)aholab.ehu.es> Fri, 3 Dic 2010 16:30:00 +0100 + -- Jon Bonilla <manwe(a)aholab.ehu.es> Fri, 3 Dec 2010 16:30:00 +0100 kamailio (3.1.0) unstable; urgency=low diff --git a/pkg/kamailio/deb/lenny/changelog b/pkg/kamailio/deb/lenny/changelog index 44e7ccf..5d95b65 100644 --- a/pkg/kamailio/deb/lenny/changelog +++ b/pkg/kamailio/deb/lenny/changelog @@ -2,7 +2,7 @@ kamailio (3.1.1) unstable; urgency=low * update to 3.1.1 from upstream - -- Jon Bonilla <manwe(a)aholab.ehu.es> Fri, 3 Dic 2010 16:30:00 +0100 + -- Jon Bonilla <manwe(a)aholab.ehu.es> Fri, 3 Dec 2010 16:30:00 +0100 kamailio (3.1.0) unstable; urgency=low diff --git a/pkg/kamailio/deb/lucid/changelog b/pkg/kamailio/deb/lucid/changelog index 44e7ccf..5d95b65 100644 --- a/pkg/kamailio/deb/lucid/changelog +++ b/pkg/kamailio/deb/lucid/changelog @@ -2,7 +2,7 @@ kamailio (3.1.1) unstable; urgency=low * update to 3.1.1 from upstream - -- Jon Bonilla <manwe(a)aholab.ehu.es> Fri, 3 Dic 2010 16:30:00 +0100 + -- Jon Bonilla <manwe(a)aholab.ehu.es> Fri, 3 Dec 2010 16:30:00 +0100 kamailio (3.1.0) unstable; urgency=low diff --git a/pkg/kamailio/deb/squeeze/changelog b/pkg/kamailio/deb/squeeze/changelog index 44e7ccf..5d95b65 100644 --- a/pkg/kamailio/deb/squeeze/changelog +++ b/pkg/kamailio/deb/squeeze/changelog @@ -2,7 +2,7 @@ kamailio (3.1.1) unstable; urgency=low * update to 3.1.1 from upstream - -- Jon Bonilla <manwe(a)aholab.ehu.es> Fri, 3 Dic 2010 16:30:00 +0100 + -- Jon Bonilla <manwe(a)aholab.ehu.es> Fri, 3 Dec 2010 16:30:00 +0100 kamailio (3.1.0) unstable; urgency=low

14 years

git:3.1: pkg debian

by Jon Bonilla

Module: sip-router Branch: 3.1 Commit: 22b18eefa163392ab37c6274d1631824908a4b47 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=22b18ee… Author: Jon Bonilla <manwe(a)aholab.ehu.es> Committer: Jon Bonilla <manwe(a)aholab.ehu.es> Date: Fri Dec 3 16:38:01 2010 +0100 pkg debian * Update version to 3.1.1 * Install general ChangeLog instead of Debian's one. --- pkg/kamailio/deb/debian/changelog | 6 ++++++ pkg/kamailio/deb/debian/rules | 2 +- pkg/kamailio/deb/lenny/changelog | 6 ++++++ pkg/kamailio/deb/lenny/rules | 2 +- pkg/kamailio/deb/lucid/changelog | 6 ++++++ pkg/kamailio/deb/lucid/rules | 2 +- pkg/kamailio/deb/squeeze/changelog | 6 ++++++ pkg/kamailio/deb/squeeze/rules | 2 +- 8 files changed, 28 insertions(+), 4 deletions(-) diff --git a/pkg/kamailio/deb/debian/changelog b/pkg/kamailio/deb/debian/changelog index fd4ebda..44e7ccf 100644 --- a/pkg/kamailio/deb/debian/changelog +++ b/pkg/kamailio/deb/debian/changelog @@ -1,3 +1,9 @@ +kamailio (3.1.1) unstable; urgency=low + + * update to 3.1.1 from upstream + + -- Jon Bonilla <manwe(a)aholab.ehu.es> Fri, 3 Dic 2010 16:30:00 +0100 + kamailio (3.1.0) unstable; urgency=low * update to 3.1.0 from upstream diff --git a/pkg/kamailio/deb/debian/rules b/pkg/kamailio/deb/debian/rules index 5ec2077..fbaccf6 100755 --- a/pkg/kamailio/deb/debian/rules +++ b/pkg/kamailio/deb/debian/rules @@ -187,7 +187,7 @@ binary-common: dh_installman dh_installinfo # dh_undocumented - dh_installchangelogs + dh_installchangelogs ChangeLog dh_link dh_strip dh_compress diff --git a/pkg/kamailio/deb/lenny/changelog b/pkg/kamailio/deb/lenny/changelog index fd4ebda..44e7ccf 100644 --- a/pkg/kamailio/deb/lenny/changelog +++ b/pkg/kamailio/deb/lenny/changelog @@ -1,3 +1,9 @@ +kamailio (3.1.1) unstable; urgency=low + + * update to 3.1.1 from upstream + + -- Jon Bonilla <manwe(a)aholab.ehu.es> Fri, 3 Dic 2010 16:30:00 +0100 + kamailio (3.1.0) unstable; urgency=low * update to 3.1.0 from upstream diff --git a/pkg/kamailio/deb/lenny/rules b/pkg/kamailio/deb/lenny/rules index 4ed1149..84ebd65 100755 --- a/pkg/kamailio/deb/lenny/rules +++ b/pkg/kamailio/deb/lenny/rules @@ -187,7 +187,7 @@ binary-common: dh_installman dh_installinfo # dh_undocumented - dh_installchangelogs + dh_installchangelogs ChangeLog dh_link dh_strip dh_compress diff --git a/pkg/kamailio/deb/lucid/changelog b/pkg/kamailio/deb/lucid/changelog index fd4ebda..44e7ccf 100644 --- a/pkg/kamailio/deb/lucid/changelog +++ b/pkg/kamailio/deb/lucid/changelog @@ -1,3 +1,9 @@ +kamailio (3.1.1) unstable; urgency=low + + * update to 3.1.1 from upstream + + -- Jon Bonilla <manwe(a)aholab.ehu.es> Fri, 3 Dic 2010 16:30:00 +0100 + kamailio (3.1.0) unstable; urgency=low * update to 3.1.0 from upstream diff --git a/pkg/kamailio/deb/lucid/rules b/pkg/kamailio/deb/lucid/rules index 5ec2077..fbaccf6 100755 --- a/pkg/kamailio/deb/lucid/rules +++ b/pkg/kamailio/deb/lucid/rules @@ -187,7 +187,7 @@ binary-common: dh_installman dh_installinfo # dh_undocumented - dh_installchangelogs + dh_installchangelogs ChangeLog dh_link dh_strip dh_compress diff --git a/pkg/kamailio/deb/squeeze/changelog b/pkg/kamailio/deb/squeeze/changelog index fd4ebda..44e7ccf 100644 --- a/pkg/kamailio/deb/squeeze/changelog +++ b/pkg/kamailio/deb/squeeze/changelog @@ -1,3 +1,9 @@ +kamailio (3.1.1) unstable; urgency=low + + * update to 3.1.1 from upstream + + -- Jon Bonilla <manwe(a)aholab.ehu.es> Fri, 3 Dic 2010 16:30:00 +0100 + kamailio (3.1.0) unstable; urgency=low * update to 3.1.0 from upstream diff --git a/pkg/kamailio/deb/squeeze/rules b/pkg/kamailio/deb/squeeze/rules index d54e7fb..a64793a 100755 --- a/pkg/kamailio/deb/squeeze/rules +++ b/pkg/kamailio/deb/squeeze/rules @@ -187,7 +187,7 @@ binary-common: dh_installman dh_installinfo # dh_undocumented - dh_installchangelogs + dh_installchangelogs ChangeLog dh_link dh_strip dh_compress

14 years

UAC Issue

by Bernhard Suttner

Hi, I am using UAC to register to an outbound provider. Kamailio (3.1.0) does send the following REGISTER: E..'A...@.=...P...P9......\1REGISTER sip:172.16.0.57 SIP/2.0 Via: SIP/2.0/UDP 172.16.0.130;branch=z9hG4bKa69c.50411006.0 To: sip:SIP001@172.16.0.57 From: sip:SIP001@172.16.0.57;tag=533cb9e91f4b999cf76861cbb9ed54ed-c10d CSeq: 10 REGISTER Call-ID: 7bad8cfd-13535(a)127.0.0.1 Content-Length: 0 User-Agent: kamailio (3.1.0 (i386/linux)) Contact: <sip:@172.16.0.130> Expires: 600 Authorization: Digest username="SIP001", realm="asterisk", nonce="1be9f4f2", uri="sip:172.16.0.57", response="e46d865eb495e170fdef058b857d7b76", algorithm=MD5 I am not really 100% sure, but I think the Contact address is not valid. Within the database I have only set the host part. I think the Contact should be the following then: Contact: <sip:172.16.0.130) (without the @). In addition, I think the Call-ID could be better. I know, that it is valid to set it like that, but the IP Address 127.0.0.1 could be misunderstood somewhere. Best regards, Bernhard Suttner

14 years

git:master: uac: safety checks for empty values in uacreg

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: dd663a733845510a9ee0557b8d49f058c77ef02c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=dd663a7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Dec 3 10:59:05 2010 +0100 uac: safety checks for empty values in uacreg - the values in uacreg table must not be empty - reported by Bernhard Suttner --- modules_k/uac/uac_reg.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/modules_k/uac/uac_reg.c b/modules_k/uac/uac_reg.c index d378bc7..8fb4e78 100644 --- a/modules_k/uac/uac_reg.c +++ b/modules_k/uac/uac_reg.c @@ -663,6 +663,11 @@ void uac_reg_timer(unsigned int ticks) reg.attr.s = \ (char*)(RES_ROWS(db_res)[i].values[pos].val.string_val); \ reg.attr.len = strlen(reg.attr.s); \ + if(reg.attr.len == 0) { \ + LM_ERR("empty value not allowed for column[%d]=%.*s\n", \ + pos, db_cols[pos]->len, db_cols[pos]->s); \ + goto error; \ + } \ } \ } while(0);

14 years

git:master: dispatcher(k): fixed use of use_default parameter

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 0f5e21c668e46492fb9f9ec69e5b5aafe41bd272 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0f5e21c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Dec 3 10:45:00 2010 +0100 dispatcher(k): fixed use of use_default parameter - when there was a single destination in destination set and it was in inactive state, then having parameter use_default=1 caused a divion by 0 while atteptimpting to look for active destaintaion - reported by Eric Hiller --- modules_k/dispatcher/dispatch.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/modules_k/dispatcher/dispatch.c b/modules_k/dispatcher/dispatch.c index bcd7f7c..e42f5d8 100644 --- a/modules_k/dispatcher/dispatch.c +++ b/modules_k/dispatcher/dispatch.c @@ -1717,15 +1717,20 @@ int ds_select_dst(struct sip_msg *msg, int set, int alg, int mode) while ((idx->dlist[i].flags & DS_INACTIVE_DST) || (idx->dlist[i].flags & DS_PROBING_DST)) { - if(ds_use_default!=0) + if(ds_use_default!=0 && idx->nr!=1) i = (i+1)%(idx->nr-1); else i = (i+1)%idx->nr; if(i==hash) { + /* back to start -- looks like no active dst */ if(ds_use_default!=0) { i = idx->nr-1; + if((idx->dlist[i].flags & DS_INACTIVE_DST) + || (idx->dlist[i].flags & DS_PROBING_DST)) + return -1; + break; } else { return -1; } @@ -1751,6 +1756,7 @@ int ds_select_dst(struct sip_msg *msg, int set, int alg, int mode) if(dst_avp_name.n!=0) { + /* add default dst to last position in AVP list */ if(ds_use_default!=0 && hash!=idx->nr-1) { avp_val.s = idx->dlist[idx->nr-1].uri;

14 years

UAC Module Bug and Feature-Request

by Bernhard Suttner

Hi, first of all - thanks to all these great modules, the kamailio core, the very well documented features. This project is really very well maintained. I am using the UAC module (V 3.1.0) to make an outbound registration. During testing I used the wrong "realm" for the registration. The result within the log was thousands line of: ... 41(13280) ERROR: uac [uac_reg.c:505]: realms are different - ignire?!?! 44(13286) ERROR: uac [uac_reg.c:505]: realms are different - ignire?!?! 46(13290) ERROR: uac [uac_reg.c:505]: realms are different - ignire?!?! 42(13282) ERROR: uac [uac_reg.c:505]: realms are different - ignire?!?! 44(13286) ERROR: uac [uac_reg.c:505]: realms are different - ignire?!?! 43(13284) ERROR: uac [uac_reg.c:505]: realms are different - ignire?!?! 47(13292) ERROR: uac [uac_reg.c:505]: realms are different - ignire?!?! 45(13288) ERROR: uac [uac_reg.c:505]: realms are different - ignire?!?! ... And a REGISTER flood from Kamailio to the registration endpoint. After that, I recognized that I have to restart kamailio to fix the realm. It would be cool to have a "kamctl" function to reload this module. Best regards and have a nice weekend. Bernhard Suttner

14 years

Kamailio v3.1.1 Released

by Daniel-Constantin Mierla

Hello, Kamailio SIP Server v3.1.1 is released. This is a maintenance release of latest stable branch, 3.1, that includes fixes since release of v3.1.0. There is no change to database or configuration file required to upgrade to 3.1.1 from 3.1.0 version. If you run v3.1.0 from tarball or packages, it is strongly recommended to upgrade to v3.1.1. For more details about version 3.1.1, visit: http://www.kamailio.org/w/2010/12/kamailio-v3-1-1-released/ Cheers, Daniel -- Daniel-Constantin Mierla Kamailio (OpenSER) Advanced Training Jan 24-26, 2011, Irvine, CA, USA http://www.asipto.com

14 years

git:3.1: ChangeLog: commit log updated for v3.1.0

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.1 Commit: c274ce53a62a8d5f3ab911761ac8a5f7e3361592 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c274ce5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Dec 2 22:18:36 2010 +0100 ChangeLog: commit log updated for v3.1.0 --- ChangeLog | 560 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 560 insertions(+), 0 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=c27…

14 years

git:3.1: Makefile: version set to 3.1.1

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.1 Commit: 44a154b4c5db9f0f49461ea3bf8ae8768dfcf440 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=44a154b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Dec 2 22:16:59 2010 +0100 Makefile: version set to 3.1.1 --- Makefile.defs | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index e07654e..1ceb63b 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -159,7 +159,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) #version number VERSION = 3 PATCHLEVEL = 1 -SUBLEVEL = 0 +SUBLEVEL = 1 EXTRAVERSION = # memory debugger switcher

14 years

git:master: modules_k/textops: new function is_audio_on_hold()

by Ovidiu Sas

Module: sip-router Branch: master Commit: bd18d55dc1a5225a58483132b578723a155958e9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bd18d55… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Thu Dec 2 14:56:11 2010 -0500 modules_k/textops: new function is_audio_on_hold() - returns true if at least one 'audio' stream is on hold - only 'audio' streams are checked --- modules_k/textops/textops.c | 35 ++++++++++++++++++++++++++++++++++- 1 files changed, 34 insertions(+), 1 deletions(-) diff --git a/modules_k/textops/textops.c b/modules_k/textops/textops.c index cb3907d..5b0e3b5 100644 --- a/modules_k/textops/textops.c +++ b/modules_k/textops/textops.c @@ -64,6 +64,7 @@ #include "../../parser/parse_methods.h" #include "../../parser/parse_content.h" #include "../../parser/parse_param.h" +#include "../../parser/sdp/sdp.h" #include "../../lib/kcore/parse_privacy.h" #include "../../msg_translator.h" #include "../../ut.h" @@ -93,6 +94,9 @@ MODULE_VERSION #define TIME_FORMAT "Date: %a, %d %b %Y %H:%M:%S GMT" #define MAX_TIME 64 +#define AUDIO_STR "audio" +#define AUDIO_STR_LEN 5 + static int search_body_f(struct sip_msg*, char*, char*); static int replace_f(struct sip_msg*, char*, char*); @@ -124,7 +128,7 @@ static int cmp_istr_f(struct sip_msg *msg, char *str1, char *str2 ); static int starts_with_f(struct sip_msg *msg, char *str1, char *str2 ); static int remove_hf_re_f(struct sip_msg* msg, char* key, char* foo); static int is_present_hf_re_f(struct sip_msg* msg, char* key, char* foo); - +static int is_audio_on_hold_f(struct sip_msg *msg, char *str1, char *str2 ); static int fixup_substre(void**, int); static int hname_fixup(void** param, int param_no); static int free_hname_fixup(void** param, int param_no); @@ -246,6 +250,9 @@ static cmd_export_t cmds[]={ {"starts_with", (cmd_function)starts_with_f, 2, fixup_spve_spve, 0, REQUEST_ROUTE|ONREPLY_ROUTE|FAILURE_ROUTE|BRANCH_ROUTE|LOCAL_ROUTE}, + {"is_audio_on_hold", (cmd_function)is_audio_on_hold_f, 0, + 0, 0, + REQUEST_ROUTE|ONREPLY_ROUTE|FAILURE_ROUTE|BRANCH_ROUTE|LOCAL_ROUTE}, {0,0,0,0,0,0} }; @@ -1874,6 +1881,32 @@ static int starts_with_f(struct sip_msg *msg, char *str1, char *str2 ) return -2; } +static int is_audio_on_hold_f(struct sip_msg *msg, char *str1, char *str2 ) +{ + int sdp_session_num = 0, sdp_stream_num; + sdp_session_cell_t* sdp_session; + sdp_stream_cell_t* sdp_stream; + + if (0 == parse_sdp(msg)) { + for(;;) { + sdp_session = get_sdp_session(msg, sdp_session_num); + if(!sdp_session) break; + sdp_stream_num = 0; + for(;;) { + sdp_stream = get_sdp_stream(msg, sdp_session_num, sdp_stream_num); + if(!sdp_stream) break; + if(sdp_stream->media.len==AUDIO_STR_LEN && + strncmp(sdp_stream->media.s,AUDIO_STR,AUDIO_STR_LEN)==0 && + sdp_stream->is_on_hold) + return 1; + sdp_stream_num++; + } + sdp_session_num++; + } + } + return -1; +} + int fixup_regexpNL_none(void** param, int param_no) { regex_t* re;

14 years

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2010