sr-dev November 2010

sr-dev@lists.kamailio.org

17 participants
108 discussions

[tracker] Task opened: Segfault in allow_trusted2 (Attachment added)
by sip-router 25 Nov '10

25 Nov '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Alex Hermann (axlh) Attached to Project - sip-router Summary - Segfault in allow_trusted2 Task Type - Bug Report Category - Modules kamailio Status - Assigned Assigned To - Daniel-Constantin Mierla Operating System - All Severity - Medium Priority - Normal Reported Version - 3.1 Due in Version - Undecided Due Date - Undecided Details - if (allow_trusted("$si", "$proto")) Will cause a segfault. $proto is returned from the following code fragment in pv_core.c: int pv_get_proto(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { str s; if(msg==NULL) return -1; switch(msg->rcv.proto) { case PROTO_UDP: s.s = "udp"; s.len = 3; break; The "udp" string is allocated by the compiler in the TEXT segment, which by its nature is not writable. The tolower() which allow_trusted2() tries to do later is rewarded with a segfault. Attached patch fixes the segfault. One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=102 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Assignee added: Segfault in allow_trusted2
by sip-router 25 Nov '10

25 Nov '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#102 - Segfault in allow_trusted2 User who did this - Alex Hermann (axlh) http://sip-router.org/tracker/index.php?do=details&task_id=102 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task opened: [regression] proxy_authorize function is missing return values (Attachment added)
by sip-router 25 Nov '10

25 Nov '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Alex Hermann (axlh) Attached to Project - sip-router Summary - [regression] proxy_authorize function is missing return values Task Type - Bug Report Category - Modules kamailio Status - Assigned Assigned To - Daniel-Constantin Mierla Operating System - All Severity - Low Priority - Normal Reported Version - 3.1 Due in Version - Undecided Due Date - Undecided Details - In kamailio 1.5 the various _authorize functions return a lot more info on failed authorization attempts. In 3.1 this functionalitity is missing. Attached patch is a first attempt to restore this functionality. One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=101 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Assignee added: [regression] proxy_authorize function is missing return values
by sip-router 25 Nov '10

25 Nov '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#101 - [regression] proxy_authorize function is missing return values User who did this - Alex Hermann (axlh) http://sip-router.org/tracker/index.php?do=details&task_id=101 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:3.1: dialog: added missing parameter in example
by Daniel-Constantin Mierla 24 Nov '10

24 Nov '10

Module: sip-router Branch: 3.1 Commit: 0ff1a6dc15d2ccc7fc5ad99a65a496aebda8283b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0ff1a6d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Oct 29 21:41:17 2010 +0200 dialog: added missing parameter in example (cherry picked from commit 1705424e70650ae0d173227221b04d1160c3e2c4) --- modules_k/dialog/README | 8 ++++---- modules_k/dialog/doc/dialog_admin.xml | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/modules_k/dialog/README b/modules_k/dialog/README index 0cb0730..233e136 100644 --- a/modules_k/dialog/README +++ b/modules_k/dialog/README @@ -961,11 +961,11 @@ if (is_in_profile("caller","XX")) { Example 1.41. get_profile_size usage ... -get_profile_size("inbound_call","$avp(size)"); -xlog("currently there are $avp(size) inbound calls\n"); +if(get_profile_size("inbound_call","$avp(size)")) + xlog("currently there are $avp(size) inbound calls\n"); ... -get_profile_size("caller","$fu"); -xlog("currently, the user %fu has $avp(size) active outgoing calls\n"); +if(get_profile_size("caller","$fu","$avp(size)")) + xlog("currently, the user $fu has $avp(size) active outgoing calls\n"); ... 6.5. dlg_isflagset(flag) diff --git a/modules_k/dialog/doc/dialog_admin.xml b/modules_k/dialog/doc/dialog_admin.xml index d6ecfe2..aaed79e 100644 --- a/modules_k/dialog/doc/dialog_admin.xml +++ b/modules_k/dialog/doc/dialog_admin.xml @@ -1117,11 +1117,11 @@ if (is_in_profile("caller","XX")) { <title><function>get_profile_size</function> usage</title> <programlisting format="linespecific"> ... -get_profile_size("inbound_call","$avp(size)"); -xlog("currently there are $avp(size) inbound calls\n"); +if(get_profile_size("inbound_call","$avp(size)")) + xlog("currently there are $avp(size) inbound calls\n"); ... -get_profile_size("caller","$fu"); -xlog("currently, the user %fu has $avp(size) active outgoing calls\n"); +if(get_profile_size("caller","$fu","$avp(size)")) + xlog("currently, the user $fu has $avp(size) active outgoing calls\n"); ... </programlisting> </example>

1 0

git:3.1: dialog(k): set null value parameter for get_dlg_profile() with 2 params
by Daniel-Constantin Mierla 24 Nov '10

24 Nov '10

Module: sip-router Branch: 3.1 Commit: 96def8782f8869cb0dce1c14daa66aee09eb468a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=96def87… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Oct 29 20:51:16 2010 +0200 dialog(k): set null value parameter for get_dlg_profile() with 2 params - because of using same internal function for cfg get_dlg_profile(...), when only 2 params were provided, the third was unpredicted and not null most probably, potentially resulting in a crash - reported by Eugene Oden (cherry picked from commit 028e3cc1a34f1e682d604a7c0e3fb1a7da03a211) --- modules_k/dialog/dialog.c | 26 ++++++++++++++++++++------ 1 files changed, 20 insertions(+), 6 deletions(-) diff --git a/modules_k/dialog/dialog.c b/modules_k/dialog/dialog.c index 7a731ed..8a0963c 100644 --- a/modules_k/dialog/dialog.c +++ b/modules_k/dialog/dialog.c @@ -127,7 +127,8 @@ static int fixup_get_profile3(void** param, int param_no); static int w_set_dlg_profile(struct sip_msg*, char*, char*); static int w_unset_dlg_profile(struct sip_msg*, char*, char*); static int w_is_in_profile(struct sip_msg*, char*, char*); -static int w_get_profile_size(struct sip_msg*, char*, char*, char*); +static int w_get_profile_size2(struct sip_msg*, char*, char*); +static int w_get_profile_size3(struct sip_msg*, char*, char*, char*); static int w_dlg_isflagset(struct sip_msg *msg, char *flag, str *s2); static int w_dlg_resetflag(struct sip_msg *msg, char *flag, str *s2); static int w_dlg_setflag(struct sip_msg *msg, char *flag, char *s2); @@ -156,9 +157,9 @@ static cmd_export_t cmds[]={ 0, REQUEST_ROUTE| FAILURE_ROUTE | ONREPLY_ROUTE | BRANCH_ROUTE }, {"is_in_profile", (cmd_function)w_is_in_profile, 2,fixup_profile, 0, REQUEST_ROUTE| FAILURE_ROUTE | ONREPLY_ROUTE | BRANCH_ROUTE }, - {"get_profile_size",(cmd_function)w_get_profile_size, 2,fixup_get_profile2, + {"get_profile_size",(cmd_function)w_get_profile_size2, 2,fixup_get_profile2, 0, REQUEST_ROUTE| FAILURE_ROUTE | ONREPLY_ROUTE | BRANCH_ROUTE }, - {"get_profile_size",(cmd_function)w_get_profile_size, 3,fixup_get_profile3, + {"get_profile_size",(cmd_function)w_get_profile_size3, 3,fixup_get_profile3, 0, REQUEST_ROUTE| FAILURE_ROUTE | ONREPLY_ROUTE | BRANCH_ROUTE }, {"dlg_setflag", (cmd_function)w_dlg_setflag, 1,fixup_igp_null, 0, REQUEST_ROUTE| FAILURE_ROUTE | ONREPLY_ROUTE | BRANCH_ROUTE }, @@ -732,8 +733,11 @@ static int w_is_in_profile(struct sip_msg *msg, char *profile, char *value) } -static int w_get_profile_size(struct sip_msg *msg, char *profile, - char *value, char *result) +/** + * get dynamic name profile size + */ +static int w_get_profile_size3(struct sip_msg *msg, char *profile, + char *value, char *result) { pv_elem_t *pve; str val_s; @@ -755,7 +759,7 @@ static int w_get_profile_size(struct sip_msg *msg, char *profile, LM_WARN("cannot get string for value\n"); return -1; } - size = get_profile_size( (struct dlg_profile_table*)profile ,&val_s ); + size = get_profile_size( (struct dlg_profile_table*)profile, &val_s ); } else { size = get_profile_size( (struct dlg_profile_table*)profile, NULL ); } @@ -773,6 +777,16 @@ static int w_get_profile_size(struct sip_msg *msg, char *profile, return 1; } + +/** + * get static name profile size + */ +static int w_get_profile_size2(struct sip_msg *msg, char *profile, char *result) +{ + return w_get_profile_size3(msg, profile, result, NULL); +} + + static int w_dlg_setflag(struct sip_msg *msg, char *flag, char *s2) { dlg_ctx_t *dctx;

1 0

git:3.1: db_mysql: Fixes crash in libmysqlclient after connection reset.
by Daniel-Constantin Mierla 24 Nov '10

24 Nov '10

Module: sip-router Branch: 3.1 Commit: e9709a3c6b2c99e9cc3fd528704aea24e0534a55 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e9709a3… Author: Jan Janak <jan(a)ryngle.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Nov 17 18:26:32 2010 -0500 db_mysql: Fixes crash in libmysqlclient after connection reset. Sometimes SIP-Router would crash in libmysqlclient after a connection to the server has been reset. This is caused by mysql_stmt_prepare which will reset the connection data structure if a connection has been reset. Subsequent calls to other mysql functions (mysql_stmt_execute) crash unless the connection has been re-connected. This is documented as mysql bug #33384. A workaround is to reset and reconnect the connection explicitly immediately after mysql_stmt_prepare has failed with CR_SERVER_GONE_ERROR. This change implements exactly that. First of all, this patch fixes a minor bug in updating the variable that keeps track of number of connection resets for each database connection and pre-pared statement. The variable needs to be incremented each time a connection is closed. Previously it was incremented only if a connection was successfully reconnected. If the reconnect attempt failed than the variable was not incremented. The function that uploads commands to the server relies on the variable to detect connection resets and may not have worked properly under some circumstances (if a connection fails to reconnect). Function upload_cmd has been modified to close the connection explicitly if mysql_stmt_prepare fails with CR_SERVER_GONE_ERROR. This ensures that subsequent calls to mysql_stmt_exec are forced to reconnect and re-upload commands to the server. This is needed to prevent the library from crashing. exec_cmd_safe now checks if a connection has been disconnected and if so it tries to reconnect it before executing a prepared statement. This is used to recover from failing mysql_stmt_prepare. (cherry picked from commit 0e564bcd3616f9dc981bb768003545674c79c2a7) --- modules/db_mysql/my_cmd.c | 258 +++++++++++++++++++++++++-------------------- modules/db_mysql/my_con.c | 18 ++-- modules/db_mysql/my_con.h | 10 +- 3 files changed, 158 insertions(+), 128 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=e97…

1 0

git:3.1: dispatcher(k): more verbose logs for MI ds_reload
by Daniel-Constantin Mierla 24 Nov '10

24 Nov '10

Module: sip-router Branch: 3.1 Commit: 58b0bafff9354282750035ec239f16750178f200 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=58b0baf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Nov 12 12:52:27 2010 +0100 dispatcher(k): more verbose logs for MI ds_reload - if the command is disabled, print error message to syslog with some hints (cherry picked from commit 72c052a94ce3a5fd2baefc74861d797c1a404a1a) --- modules_k/dispatcher/dispatcher.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/modules_k/dispatcher/dispatcher.c b/modules_k/dispatcher/dispatcher.c index 3f8f229..59fe0bb 100644 --- a/modules_k/dispatcher/dispatcher.c +++ b/modules_k/dispatcher/dispatcher.c @@ -451,7 +451,8 @@ static int mod_init(void) return -1; register_timer(ds_ht_timer, NULL, ds_hash_check_interval); } else { - LM_ERR("call load dispatching AVP set but no size of hash table\n"); + LM_ERR("call load dispatching DSTID_AVP set but no size" + " for hash table\n"); return -1; } } @@ -716,6 +717,8 @@ static struct mi_root* ds_mi_list(struct mi_root* cmd_tree, void* param) static struct mi_root* ds_mi_reload(struct mi_root* cmd_tree, void* param) { if(dstid_avp_name.n!=0) { + LM_ERR("No reload support when call load dispatching is enabled." + " Do not set dstid_avp param if you do not use alg 10.\n"); return init_mi_tree(500, MI_ERR_DSLOAD, MI_ERR_DSLOAD_LEN); }

1 0

git:3.1: db_flatstore: exported DB API v1 bind function
by Daniel-Constantin Mierla 24 Nov '10

24 Nov '10

Module: sip-router Branch: 3.1 Commit: 86c16fd9bc30a6b1346c04b2e1bbd3983122dddb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=86c16fd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Nov 24 22:24:25 2010 +0100 db_flatstore: exported DB API v1 bind function - bind function for DB API v1 was no longer exported upon merging with implementation of DB API V2 - reported by Javier Gallart (cherry picked from commit 3e44fcbe47774d2b157e82228e6266df2a08d627) --- modules/db_flatstore/flatstore_mod.c | 1 + modules/db_flatstore/km_flatstore_mod.h | 4 ++++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/modules/db_flatstore/flatstore_mod.c b/modules/db_flatstore/flatstore_mod.c index 0f7b5b5..b008f20 100644 --- a/modules/db_flatstore/flatstore_mod.c +++ b/modules/db_flatstore/flatstore_mod.c @@ -110,6 +110,7 @@ static cmd_export_t cmds[] = { {"db_con", (cmd_function)flat_con, 0, 0, 0}, {"db_cmd", (cmd_function)flat_cmd, 0, 0, 0}, {"db_put", (cmd_function)flat_put, 0, 0, 0}, + {"db_bind_api", (cmd_function)db_flat_bind_api, 0, 0, 0}, {0, 0, 0, 0, 0} }; diff --git a/modules/db_flatstore/km_flatstore_mod.h b/modules/db_flatstore/km_flatstore_mod.h index 3ca8c50..36c103b 100644 --- a/modules/db_flatstore/km_flatstore_mod.h +++ b/modules/db_flatstore/km_flatstore_mod.h @@ -32,6 +32,8 @@ #include <time.h> +#include "../../lib/srdb1/db.h" + /* * Process number used in filenames */ @@ -63,5 +65,7 @@ void km_mod_destroy(void); int km_child_init(int rank); +int db_flat_bind_api(db_func_t *dbb); + #endif /* KM_FLATSTORE_MOD_H */

1 0

git:3.1: dispatcher(k): note about disabling MI ds_reload
by Daniel-Constantin Mierla 24 Nov '10

24 Nov '10

Module: sip-router Branch: 3.1 Commit: 7340a8d0d02e22c2541b6e1d0dc82fb194a90c87 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7340a8d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Nov 12 12:26:26 2010 +0100 dispatcher(k): note about disabling MI ds_reload - the MI command ds_reload is disabled for call load based dispatching (algorithm 10) (cherry picked from commit e1371192357f889c35003ea28d0eb2351e27f84d) --- modules_k/dispatcher/README | 5 ++++- modules_k/dispatcher/doc/dispatcher_admin.xml | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/modules_k/dispatcher/README b/modules_k/dispatcher/README index 781e499..1c747c9 100644 --- a/modules_k/dispatcher/README +++ b/modules_k/dispatcher/README @@ -857,7 +857,10 @@ onreply_route { 5.3. ds_reload - It reloads the groups and included destinations. + It reloads the groups and included destinations. The command is + disabled for call load based dispatching (algorithm 10) since removal + of destinations may leave the list of active calls with broken + references. Name: ds_reload diff --git a/modules_k/dispatcher/doc/dispatcher_admin.xml b/modules_k/dispatcher/doc/dispatcher_admin.xml index b05403a..ae857fd 100644 --- a/modules_k/dispatcher/doc/dispatcher_admin.xml +++ b/modules_k/dispatcher/doc/dispatcher_admin.xml @@ -1069,7 +1069,10 @@ onreply_route { <function moreinfo="none">ds_reload</function> </title> <para> - It reloads the groups and included destinations. + It reloads the groups and included destinations. The command is + disabled for call load based dispatching (algorithm 10) since + removal of destinations may leave the list of active + calls with broken references. </para> <para> Name: <emphasis>ds_reload</emphasis>

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
11
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2010