sr-dev November 2010

sr-dev@lists.kamailio.org

17 participants
108 discussions

git:master: dispatcher(k): more verbose logs for MI ds_reload
by Daniel-Constantin Mierla 12 Nov '10

12 Nov '10

Module: sip-router Branch: master Commit: 72c052a94ce3a5fd2baefc74861d797c1a404a1a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=72c052a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Nov 12 12:52:27 2010 +0100 dispatcher(k): more verbose logs for MI ds_reload - if the command is disabled, print error message to syslog with some hints --- modules_k/dispatcher/dispatcher.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/modules_k/dispatcher/dispatcher.c b/modules_k/dispatcher/dispatcher.c index 3f8f229..59fe0bb 100644 --- a/modules_k/dispatcher/dispatcher.c +++ b/modules_k/dispatcher/dispatcher.c @@ -451,7 +451,8 @@ static int mod_init(void) return -1; register_timer(ds_ht_timer, NULL, ds_hash_check_interval); } else { - LM_ERR("call load dispatching AVP set but no size of hash table\n"); + LM_ERR("call load dispatching DSTID_AVP set but no size" + " for hash table\n"); return -1; } } @@ -716,6 +717,8 @@ static struct mi_root* ds_mi_list(struct mi_root* cmd_tree, void* param) static struct mi_root* ds_mi_reload(struct mi_root* cmd_tree, void* param) { if(dstid_avp_name.n!=0) { + LM_ERR("No reload support when call load dispatching is enabled." + " Do not set dstid_avp param if you do not use alg 10.\n"); return init_mi_tree(500, MI_ERR_DSLOAD, MI_ERR_DSLOAD_LEN); }

1 0

git:master: sanity: note about different behavior based on autodrop
by Daniel-Constantin Mierla 12 Nov '10

12 Nov '10

Module: sip-router Branch: master Commit: 4a0b559062b70c1c089c1ea9908eaae60679ad04 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4a0b559… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Nov 12 12:22:20 2010 +0100 sanity: note about different behavior based on autodrop --- modules/sanity/README | 15 +++++++++------ modules/sanity/doc/functions.xml | 12 +++++++----- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/modules/sanity/README b/modules/sanity/README index a3e4ce1..0442064 100644 --- a/modules/sanity/README +++ b/modules/sanity/README @@ -20,7 +20,7 @@ Nils Ohlmeier 1.4. Functions - 1.4.1. sanity_check() + 1.4.1. sanity_check([msg_checks [, uri_checks]]) 1.1. Overview @@ -136,12 +136,15 @@ modparam("sanity", "autodrop", 1) Revision History Revision $Revision$ $Date$ -1.4.1. sanity_check() +1.4.1. sanity_check([msg_checks [, uri_checks]]) - This function makes a row of sanity checks on the given request. The - function returns false (-1) if one of the checks failed. If one of the - checks fails the module sends a precise error reply via sl_send_reply. - Thus there is no need to reply with a generic error message. + This function makes a row of sanity checks over the given SIP request. + The behavior of the function is also controled by 'autodrop' parameter. + If autodrop=0, the function returns false (-1) if one of the checks + failed. When autodrop=1, the function stops the execution of + configuration file. In both cases, ff one of the checks fails the + module sends a precise error reply via SL send_reply(). Thus there is + no need to reply with a generic error message. Example 5. sanity_check usage ... diff --git a/modules/sanity/doc/functions.xml b/modules/sanity/doc/functions.xml index ea9cf1d..f3cfa85 100644 --- a/modules/sanity/doc/functions.xml +++ b/modules/sanity/doc/functions.xml @@ -22,13 +22,15 @@ <section id="sanity_check"> <title> - <function>sanity_check()</function> + <function>sanity_check([msg_checks [, uri_checks]])</function> </title> <para> - This function makes a row of sanity checks on the given request. - The function returns false (-1) if one of the checks failed. If one - of the checks fails the module sends a precise error reply via - sl_send_reply. Thus there is no need to reply with a generic + This function makes a row of sanity checks over the given SIP request. The + behavior of the function is also controled by 'autodrop' parameter. + If autodrop=0, the function returns false (-1) if one of the checks failed. + When autodrop=1, the function stops the execution of configuration file. + In both cases, ff one of the checks fails the module sends a precise error + reply via SL send_reply(). Thus there is no need to reply with a generic error message. </para> <example>

1 0

git:master: modules_k/nathelper: core sdp parser integration for nat_uac_test()
by Ovidiu Sas 08 Nov '10

08 Nov '10

Module: sip-router Branch: master Commit: 06986b23ad72b648a28f614ab47d8cbc727823cf URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=06986b2… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Mon Nov 8 19:04:24 2010 -0500 modules_k/nathelper: core sdp parser integration for nat_uac_test() --- modules_k/nathelper/nathelper.c | 40 +++++++++++++++++++++++++++++--------- 1 files changed, 30 insertions(+), 10 deletions(-) diff --git a/modules_k/nathelper/nathelper.c b/modules_k/nathelper/nathelper.c index 82c6528..51c1086 100644 --- a/modules_k/nathelper/nathelper.c +++ b/modules_k/nathelper/nathelper.c @@ -1134,21 +1134,41 @@ contact_1918(struct sip_msg* msg) static int sdp_1918(struct sip_msg* msg) { - str body, ip; + str *ip; int pf; + int sdp_session_num, sdp_stream_num; + sdp_session_cell_t* sdp_session; + sdp_stream_cell_t* sdp_stream; - if (extract_body(msg, &body) == -1) { - LM_ERR("cannot extract body from msg!\n"); - return 0; - } - if (extract_mediaip(&body, &ip, &pf,"c=") == -1) { - LM_ERR("can't extract media IP from the SDP\n"); + if(0 != parse_sdp(msg)) { + LM_ERR("Unable to parse sdp\n"); return 0; } - if (pf != AF_INET || isnulladdr(&ip, pf)) - return 0; - return (is1918addr(&ip) == 1) ? 1 : 0; + sdp_session_num = 0; + for(;;) { + sdp_session = get_sdp_session(msg, sdp_session_num); + if(!sdp_session) break; + sdp_stream_num = 0; + for(;;) { + sdp_stream = get_sdp_stream(msg, sdp_session_num, sdp_stream_num); + if(!sdp_stream) break; + if (sdp_stream->ip_addr.s && sdp_stream->ip_addr.len) { + ip = &(sdp_stream->ip_addr); + pf = sdp_stream->pf; + } else { + ip = &(sdp_session->ip_addr); + pf = sdp_session->pf; + } + if (pf != AF_INET || isnulladdr(ip, pf)) + break; + if (is1918addr(ip) == 1) + return 1; + sdp_stream_num++; + } + sdp_session_num++; + } + return 0; } /*

1 0

CFP - Open Source Telephony Devroom - FOSDEM 2011
by Bryan M. Johns 08 Nov '10

08 Nov '10

Greetings, This is a call for presentations for the open source telephony devroom at FOSDEM 2011 - http://www.fosdem.org/. We will be holding a day full of presentations on development topics in the area of open source telephony on Sunday, February 6th. The schedule allows for presentations from 9:00 to 17:00. The room we have available will have a projector, wifi, and 59 seats. Please submit all proposals no later than 2010-12-10. Notification of accepted speakers will be provided by 2010-12-17. We will then work to have a schedule finalized by 2011-01-07. Talks should be submitted by fulling out the following form: http://goo.gl/9SWlz Please direct discussion about this devroom to the telephony-devroom mailing list hosted on http://lists.fosdem.org/. If you would like to contact the devroom organizer directly, please contact Russell Bryant <russell(a)digium.com>. Feel free to forward this along to any people or mailing lists that you think would be interested in this event. Thank you! Bryan M. Johns Digium, Inc. | Community Director 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA direct: +1 256-428-6007 Check us out at : www.asterisk.org or www.digium.com

2 1

CFP - Open Source Telephony Devroom - FOSDEM 2011
by Bryan M. Johns 04 Nov '10

04 Nov '10

1 0

git:master: core:forward.c Fixed small error caused by unlikely usage.
by Marius Zbihlei 04 Nov '10

04 Nov '10

Module: sip-router Branch: master Commit: 6cfee82666b78400d5ff15c49aac1441cfbbaaf6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6cfee82… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Thu Nov 4 17:14:56 2010 +0200 core:forward.c Fixed small error caused by unlikely usage. --- forward.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/forward.c b/forward.c index 3d7aed1..175f54b 100644 --- a/forward.c +++ b/forward.c @@ -175,7 +175,7 @@ retry: if( !mhomed_sock_cache_disabled ){ /* some Linux kernel versions (all?) along with other UNIXes don't re-bound the sock if already bound */ /* to un-bound a socket set sin_family to AF_UNSPEC and zero out the rest*/ - if (unlikely(connect(*temp_sock, &uncon.s, sockaddru_len(uncon))) < 0) + if (unlikely(connect(*temp_sock, &uncon.s, sockaddru_len(uncon)) < 0)) mhomed_sock_cache_disabled = 1; }

1 0

git:master: core/forward.c Fixed mhomed behavior.
by Marius Zbihlei 04 Nov '10

04 Nov '10

Module: sip-router Branch: master Commit: ef0dd4e3f0837753ac18d58606078d8595f24dc6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ef0dd4e… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Thu Nov 4 16:11:41 2010 +0200 core/forward.c Fixed mhomed behavior. As connect() dones't re-bound a UDP sock if the socket is already bound to an interface, first unbind the socket by connecting to AF_UNSPEC --- forward.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/forward.c b/forward.c index 25bc11d..3d7aed1 100644 --- a/forward.c +++ b/forward.c @@ -131,6 +131,10 @@ struct socket_info* get_out_socket(union sockaddr_union* to, int proto) union sockaddr_union from; struct socket_info* si; struct ip_addr ip; + union sockaddr_union uncon; + + memset(&uncon, 0, sizeof(union sockaddr_union)); + uncon.sin.sin_family = AF_UNSPEC; if (unlikely(proto!=PROTO_UDP)) { LOG(L_CRIT, "BUG: get_out_socket can only be called for UDP\n"); @@ -167,6 +171,14 @@ retry: return 0; } } + + if( !mhomed_sock_cache_disabled ){ + /* some Linux kernel versions (all?) along with other UNIXes don't re-bound the sock if already bound */ + /* to un-bound a socket set sin_family to AF_UNSPEC and zero out the rest*/ + if (unlikely(connect(*temp_sock, &uncon.s, sockaddru_len(uncon))) < 0) + mhomed_sock_cache_disabled = 1; + } + if (unlikely(connect(*temp_sock, &to->s, sockaddru_len(*to))==-1)) { if (unlikely(errno==EISCONN && !mhomed_sock_cache_disabled)){ /* no multiple connects support on the same socket */

1 0

SF.net SVN: openser:[6050] branches/1.5/forward.c
by Marius Zbihlei 04 Nov '10

04 Nov '10

Revision: 6050 http://openser.svn.sourceforge.net/openser/?rev=6050&view=rev Author: mariuszbihlei Date: 2010-11-04 13:07:25 +0000 (Thu, 04 Nov 2010) Log Message: ----------- core/forward.c Some Linux kernels, (tested on 2.6.26 and 2.6.32) don't re-bound a UDP sock if the socket is already bound to an interface when doing connect(). Modified Paths: -------------- branches/1.5/forward.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

1 0

SF.net SVN: openser:[6049] branches/1.5/modules/dialog/dlg_handlers.c
by Timo Reimann 02 Nov '10

02 Nov '10

Revision: 6049 http://openser.svn.sourceforge.net/openser/?rev=6049&view=rev Author: timoreimann Date: 2010-11-02 18:21:32 +0000 (Tue, 02 Nov 2010) Log Message: ----------- modules/dialog: Enhance unref_dlg_from_cb() robustness. - Check parameter for NULL pointer. - Call unreference_dlg(), thus being more wrapper-ish. - Fix indention. Backport from git commit 75fc49f74d13774f1ecc0cdd8f0adfe168915b4f. Modified Paths: -------------- branches/1.5/modules/dialog/dlg_handlers.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

1 0

git:3.1: modules_k/dialog: Enhance unref_dlg_from_cb() robustness.
by Timo Reimann 02 Nov '10

02 Nov '10

Module: sip-router Branch: 3.1 Commit: 849a667f74a1c2dd543c52e7be9b4e8a05a0bcfe URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=849a667… Author: Timo Reimann <timo.reimann(a)1und1.de> Committer: Timo Reimann <timo.reimann(a)1und1.de> Date: Tue Nov 2 19:06:12 2010 +0100 modules_k/dialog: Enhance unref_dlg_from_cb() robustness. - Check parameter for NULL pointer. - Call unreference_dlg(), thus being more wrapper-ish. - Fix indention. (cherry picked from commit 75fc49f74d13774f1ecc0cdd8f0adfe168915b4f) --- modules_k/dialog/dlg_handlers.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/modules_k/dialog/dlg_handlers.c b/modules_k/dialog/dlg_handlers.c index ebed8a9..a118a91 100644 --- a/modules_k/dialog/dlg_handlers.c +++ b/modules_k/dialog/dlg_handlers.c @@ -820,10 +820,13 @@ static void unreference_dialog(void *dialog) */ static void unref_dlg_from_cb(struct cell* t, int type, struct tmcb_params *param) { - struct dlg_cell *dlg = (struct dlg_cell *)(*param->param); + struct dlg_cell *dlg = (struct dlg_cell *)(*param->param); + + if (!dlg) + return; /* destroy dialog */ - unref_dlg(dlg, 1); + unreference_dialog(dlg); }

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2010