2 Oct
2009
2 Oct
'09
9:51 a.m.
Revision: 5928
http://openser.svn.sourceforge.net/openser/?rev=5928&view=rev
Author: juhe
Date: 2009-10-02 04:51:57 +0000 (Fri, 02 Oct 2009)
Log Message:
-----------
* Check that db connection exists before trying to make query.
* Do not close db connection if db query fails.
Modified Paths:
--------------
branches/1.5/modules/permissions/trusted.c
This was sent by the SourceForge.net collaborative development platform, the world's
largest Open Source development site.
2 Oct
2 Oct
12:21 p.m.
El Viernes, 2 de Octubre de 2009, Juha Heinanen escribió:
Revision: 5928
http://openser.svn.sourceforge.net/openser/?rev=5928&view=rev
Author: juhe
Date: 2009-10-02 04:51:57 +0000 (Fri, 02 Oct 2009)
Log Message:
-----------
* Check that db connection exists before trying to make query.
* Do not close db connection if db query fails.
Isn't this stuf handled by db_xxxxx modules?
--
Iñaki Baz Castillo <ibc(a)aliax.net>
12:25 p.m.
New subject: SF.net SVN: openser:[5928] branches/1.5/modules/permissions/trusted.c
� wrote:
El Viernes, 2 de Octubre de 2009, Juha Heinanen
escribi�:
That's what I thought, but evidently not, because results vary depending
on which module is doing the calling.
--
Alex Balashov - Principal
Evariste Systems
Web : http://www.evaristesys.com/
Tel : (+1) (678) 954-0670
Direct : (+1) (678) 954-0671
Revision: 5928
http://openser.svn.sourceforge.net/openser/?rev=5928&view=rev
Author: juhe
Date: 2009-10-02 04:51:57 +0000 (Fri, 02 Oct 2009)
Log Message:
-----------
* Check that db connection exists before trying to make query.
* Do not close db connection if db query fails.
Isn't this stuf handled by db_xxxxx modules?
12:43 p.m.
El Viernes, 2 de Octubre de 2009, Alex Balashov escribió:
� wrote:
I really fail to understand why a module using a DB backend should handle the
DB connection... ¿?
--
Iñaki Baz Castillo <ibc(a)aliax.net>
El Viernes, 2 de Octubre de 2009, Juha Heinanen
escribi�:
That's what I thought, but evidently not, because results vary depending
on which module is doing the calling. Revision: 5928
http://openser.svn.sourceforge.net/openser/?rev=5928&view=rev
Author: juhe
Date: 2009-10-02 04:51:57 +0000 (Fri, 02 Oct 2009)
Log Message:
-----------
* Check that db connection exists before trying to make query.
* Do not close db connection if db query fails.
Isn't this stuf handled by db_xxxxx modules?
12:57 p.m.
Iñaki Baz Castillo wrote:
El Viernes, 2 de Octubre de 2009, Alex Balashov
escribió:
I haven't looked at the code, but I suspect that the calling module does
not "handle" the DB connection in any direct sense, but rather
indirectly through an interface exposed to it by the DB backend module.
This problem probably cannot be entirely avoided; even if the mechanics
of database interaction are hidden in db_*, some manipulation of
abstractions - which correspond to underlying database handle and query
states, etc. - by modules that use db_* is probably required, just like
with any API. And just like any caller of an API, it is possible for
the calling module to misbehave on exceptional conditions returned by
the lower-level DB module.
I would agree, however, that db_* should probably provide enough
containment and error handling to prevent all but the most egregious
database-related fatal runtime errors.
--
Alex Balashov - Principal
Evariste Systems
Web : http://www.evaristesys.com/
Tel : (+1) (678) 954-0670
Direct : (+1) (678) 954-0671
� wrote:
I really fail to understand why a module using a DB backend should handle the
DB connection... ¿? El Viernes, 2 de Octubre de 2009, Juha Heinanen
escribi�:
That's what I thought, but evidently not, because results
vary depending
on which module is doing the calling. Revision: 5928
http://openser.svn.sourceforge.net/openser/?rev=5928&view=rev
Author: juhe
Date: 2009-10-02 04:51:57 +0000 (Fri, 02 Oct 2009)
Log Message:
-----------
* Check that db connection exists before trying to make query.
* Do not close db connection if db query fails.
Isn't this stuf handled by
db_xxxxx modules?
12:59 p.m.
New subject: SF.net SVN: openser:[5928] branches/1.5/modules/permissions/trusted.c
Alex Balashov wrote:
Iñaki Baz Castillo wrote:
Also, keep in mind that the bulk of the permissions module was written
in 2003. It is possible that it uses more extensive and low-level
database interaction approaches from a time when the functional
decomposition and modularisation of all this stuff was not where it was
today.
--
Alex Balashov - Principal
Evariste Systems
Web : http://www.evaristesys.com/
Tel : (+1) (678) 954-0670
Direct : (+1) (678) 954-0671
El Viernes, 2 de Octubre de 2009, Alex Balashov
escribió:
I haven't looked at the code, but I suspect that the calling module does
not "handle" the DB connection in any direct sense, but rather
indirectly through an interface exposed to it by the DB backend module.
This problem probably cannot be entirely avoided; even if the mechanics
of database interaction are hidden in db_*, some manipulation of
abstractions - which correspond to underlying database handle and query
states, etc. - by modules that use db_* is probably required, just like
with any API. And just like any caller of an API, it is possible for
the calling module to misbehave on exceptional conditions returned by
the lower-level DB module.
I would agree, however, that db_* should probably provide enough
containment and error handling to prevent all but the most egregious
database-related fatal runtime errors. � wrote:
I really fail to understand why a module using a DB backend should
handle the DB connection... ¿? El Viernes, 2 de Octubre de 2009, Juha Heinanen
escribi�:
> Revision: 5928
>
> http://openser.svn.sourceforge.net/openser/?rev=5928&view=rev
> Author: juhe
> Date: 2009-10-02 04:51:57 +0000 (Fri, 02 Oct 2009)
>
> Log Message:
> -----------
> * Check that db connection exists before trying to make query.
> * Do not close db connection if db query fails.
Isn't this stuf handled by db_xxxxx modules?
That's what I thought, but
evidently not, because results vary depending
on which module is doing the calling.
1:32 p.m.
El Viernes, 2 de Octubre de 2009, Alex Balashov escribió:
Iñaki Baz Castillo wrote:
Yes, I just meant basic DB stuf as:
- Connection/disconnection to DB.
- Re-connect in case of failure.
- Regenerate prepared statements (if they were used) automatically after re-
coonecting to the database (mysql prepared statements are in server side).
IMHO all this stuf should be handled by db_xxxxx module itself. I expect that
when Kamailio starts, modules using database backends use the db_xxxx API to
initiate the connection, generate prepared statements and basically that's
all. During runtime a module function should just do SQL queries, no more.
Am I wrong?
Regards.
--
Iñaki Baz Castillo <ibc(a)aliax.net>
El Viernes, 2 de Octubre de 2009, Alex Balashov
escribió:
I haven't looked at the code, but I suspect that the calling module does
not "handle" the DB connection in any direct sense, but rather
indirectly through an interface exposed to it by the DB backend module.
This problem probably cannot be entirely avoided; even if the mechanics
of database interaction are hidden in db_*, some manipulation of
abstractions - which correspond to underlying database handle and query
states, etc. - by modules that use db_* is probably required, just like
with any API. And just like any caller of an API, it is possible for
the calling module to misbehave on exceptional conditions returned by
the lower-level DB module.
I would agree, however, that db_* should probably provide enough
containment and error handling to prevent all but the most egregious
database-related fatal runtime errors. � wrote:
I really fail to understand why a module using a DB backend should handle
the DB connection... ¿? El Viernes, 2 de Octubre de 2009, Juha Heinanen
escribi�:
> Revision: 5928
>
> http://openser.svn.sourceforge.net/openser/?rev=5928&view=rev Author:
> juhe
> Date: 2009-10-02 04:51:57 +0000 (Fri, 02 Oct 2009)
>
> Log Message:
> -----------
> * Check that db connection exists before trying to make query.
> * Do not close db connection if db query fails.
Isn't this stuf handled by db_xxxxx modules?
That's what I thought, but evidently not, because results vary depending
on which module is doing the calling.
1:13 p.m.
New subject: SF.net SVN: openser:[5928] branches/1.5/modules/permissions/trusted.c
Iñaki Baz Castillo writes:
inaki,
the problem with the implementation was, that if db query failed (for
example, because db server was down), allow_trusted code closed the db
connection and then later tried to use the (non-existing) connection
again without creating a new one.
now allow_trusted code does not close the db connection no matter
what happens, but assumes that the low level stuff takes care of the
problems.
-- juha
Log Message:
-----------
* Check that db connection exists before trying to make query.
* Do not close db connection if db query fails.
Isn't this stuf handled by db_xxxxx modules?
5331
days inactive
5331
days old
7 comments
4 participants
participants (4)
-
Alex Balashov -
Iñaki Baz Castillo -
jh＠tutpro.com -
Juha Heinanen