20 Jan
2013
20 Jan
'13
9:24 a.m.
Module: sip-router
Branch: master
Commit: c059041a71a1b7175243c366316108ce370fffa7
URL:
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c059041…
Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com>
Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com>
Date: Sun Jan 20 14:18:55 2013 +0000
core: fixed bug in PV caching that broke the use of the $$ symbol
- Found and fixed by Hugh Waite @ Crocodile RCS
---
pvapi.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/pvapi.c b/pvapi.c
index aafc5b8..6245ee9 100644
--- a/pvapi.c
+++ b/pvapi.c
@@ -120,6 +120,10 @@ int pv_locate_name(str *in)
LM_ERR("missing pv marker [%.*s]\n", in->len, in->s);
return -1;
}
+ if(in->s[1]==PV_MARKER)
+ {
+ return 2;
+ }
pcount = 0;
if(in->s[1]==PV_LNBRACKET)
{
20 Jan
20 Jan
10:54 a.m.
The proper way to commit others people work is to use --author option:
--author='Hugh Waite <hugh.waite(a)crocodile-rcs.com>'
Or maybe Hugh should get git write access :)
Regards,
Ovidiu Sas
On Sun, Jan 20, 2013 at 9:24 AM, Peter Dunkley
<peter.dunkley(a)crocodile-rcs.com> wrote:
Module: sip-router
Branch: master
Commit: c059041a71a1b7175243c366316108ce370fffa7
URL:
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c059041…
Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com>
Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com>
Date: Sun Jan 20 14:18:55 2013 +0000
core: fixed bug in PV caching that broke the use of the $$ symbol
- Found and fixed by Hugh Waite @ Crocodile RCS
---
pvapi.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/pvapi.c b/pvapi.c
index aafc5b8..6245ee9 100644
--- a/pvapi.c
+++ b/pvapi.c
@@ -120,6 +120,10 @@ int pv_locate_name(str *in)
LM_ERR("missing pv marker [%.*s]\n", in->len, in->s);
return -1;
}
+ if(in->s[1]==PV_MARKER)
+ {
+ return 2;
+ }
pcount = 0;
if(in->s[1]==PV_LNBRACKET)
{
3:10 p.m.
Hugh has been offered git access before.
The reason it has always been done this way is that we maintain our own
Kamailio tree internally and with one person responsible for keeping it
synchronised it works, but with multiple people involved it could get...
complicated.
I didn't know about the --author option, so thanks for that. I've been
doing it the way I have for 18 months now.
Peter
The proper way to commit others people work is to use
--author option:
--author='Hugh Waite <hugh.waite(a)crocodile-rcs.com>'
Or maybe Hugh should get git write access :)
Regards,
Ovidiu Sas
On Sun, Jan 20, 2013 at 9:24 AM, Peter Dunkley
<peter.dunkley(a)crocodile-rcs.com> wrote:
--
Peter Dunkley
Technical Director
Crocodile RCS Ltd
Module: sip-router
Branch: master
Commit: c059041a71a1b7175243c366316108ce370fffa7
URL:
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c059041…
Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com>
Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com>
Date: Sun Jan 20 14:18:55 2013 +0000
core: fixed bug in PV caching that broke the use of the $$ symbol
- Found and fixed by Hugh Waite @ Crocodile RCS
---
pvapi.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/pvapi.c b/pvapi.c
index aafc5b8..6245ee9 100644
--- a/pvapi.c
+++ b/pvapi.c
@@ -120,6 +120,10 @@ int pv_locate_name(str *in)
LM_ERR("missing pv marker [%.*s]\n", in->len, in->s);
return -1;
}
+ if(in->s[1]==PV_MARKER)
+ {
+ return 2;
+ }
pcount = 0;
if(in->s[1]==PV_LNBRACKET)
{
_______________________________________________
sr-dev mailing list
sr-dev(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
8:52 p.m.
Then '--author' option should work just fine for your case.
Regards,
Ovidiu Sas
On Sun, Jan 20, 2013 at 3:10 PM, Peter Dunkley
<peter.dunkley(a)crocodile-rcs.com> wrote:
Hugh has been offered git access before.
The reason it has always been done this way is that we maintain our own
Kamailio tree internally and with one person responsible for keeping it
synchronised it works, but with multiple people involved it could get...
complicated.
I didn't know about the --author option, so thanks for that. I've been
doing it the way I have for 18 months now.
Peter
The proper way to commit others people work is to
use --author option:
--author='Hugh Waite <hugh.waite(a)crocodile-rcs.com>'
Or maybe Hugh should get git write access :)
Regards,
Ovidiu Sas
On Sun, Jan 20, 2013 at 9:24 AM, Peter Dunkley
<peter.dunkley(a)crocodile-rcs.com> wrote:
--
Peter Dunkley
Technical Director
Crocodile RCS Ltd Module: sip-router
Branch: master
Commit: c059041a71a1b7175243c366316108ce370fffa7
URL:
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c059041…
Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com>
Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com>
Date: Sun Jan 20 14:18:55 2013 +0000
core: fixed bug in PV caching that broke the use of the $$ symbol
- Found and fixed by Hugh Waite @ Crocodile RCS
---
pvapi.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/pvapi.c b/pvapi.c
index aafc5b8..6245ee9 100644
--- a/pvapi.c
+++ b/pvapi.c
@@ -120,6 +120,10 @@ int pv_locate_name(str *in)
LM_ERR("missing pv marker [%.*s]\n", in->len, in->s);
return -1;
}
+ if(in->s[1]==PV_MARKER)
+ {
+ return 2;
+ }
pcount = 0;
if(in->s[1]==PV_LNBRACKET)
{
_______________________________________________
sr-dev mailing list
sr-dev(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
4165
days inactive
4166
days old
3 comments
2 participants
participants (2)
-
Ovidiu Sas -
Peter Dunkley