25 Aug
2009
25 Aug
'09
7:15 p.m.
Hello,
just committed to GIT support for 'include' in config file. Hopefully
this helps in nicer structuring and maintenance of your configs.
The syntax is simple:
include path_to_file
The path_to_file can be relative or absolute. If it is not absolute
path, first attempt is to locate it relative to current directory, and
if fails, relative to directory of the file that includes it. There is
no restriction where include can be used or what can contain - any part
of config file is ok. There is a limit of maximum 10 includes in depth,
otherwise you can use as many includes as you want. Reporting of the cfg
file syntax errors prints now the file name for easier troubleshooting.
Example:
route {
...
include /sr/checks.cfg
...
}
--- /sr/checks.cfg ---
if (!mf_process_maxfwd_header("10")) {
sl_send_reply("483","Too Many Hops");
exit;
}
---
Testing and feedback is much appreciated.
Cheers,
Daniel
--
Daniel-Constantin Mierla
* http://www.asipto.com/
25 Aug
25 Aug
7:21 p.m.
New subject: [SR-Users] support for 'include' in cfg file
2009/8/25 Daniel-Constantin Mierla <miconda(a)gmail.com>om>:
Hello,
just committed to GIT support for 'include' in config file. Hopefully this
helps in nicer structuring and maintenance of your configs.
The syntax is simple:
include path_to_file
Really useful !!!
Just a question, how about the logs? The current logs display the line
error and so, what would occur if there is a syntax error in an
included file?
--
Iñaki Baz Castillo
<ibc(a)aliax.net>
7:25 p.m.
New subject: [SR-Users] support for 'include' in cfg file
On 25.08.2009 20:21 Uhr, Iñaki Baz Castillo wrote:
2009/8/25 Daniel-Constantin Mierla
<miconda(a)gmail.com>om>:
good.
Hello,
just committed to GIT support for 'include' in config file. Hopefully this
helps in nicer structuring and maintenance of your configs.
The syntax is simple:
include path_to_file
Really useful !!!
Just a question, how about the logs? The current logs
display the line
error and so, what would occur if there is a syntax error in an
included file?
yes, line is printed in kamailio 1.5.x, I am working to get line and
file printed in SR for fixup and runtime errors - right now only log of
syntax errors does this.
Cheers,
Daniel
--
Daniel-Constantin Mierla
* http://www.asipto.com/
26 Aug
26 Aug
12:51 a.m.
New subject: [SR-Users] support for 'include' in cfg file
Great!
...added to wiki ....
http://sip-router.org/wiki/cookbooks/core-cookbook/devel#include
klaus
Daniel-Constantin Mierla wrote:
Hello,
just committed to GIT support for 'include' in config file. Hopefully
this helps in nicer structuring and maintenance of your configs.
The syntax is simple:
include path_to_file
The path_to_file can be relative or absolute. If it is not absolute
path, first attempt is to locate it relative to current directory, and
if fails, relative to directory of the file that includes it. There is
no restriction where include can be used or what can contain - any part
of config file is ok. There is a limit of maximum 10 includes in depth,
otherwise you can use as many includes as you want. Reporting of the cfg
file syntax errors prints now the file name for easier troubleshooting.
Example:
route {
...
include /sr/checks.cfg
...
}
--- /sr/checks.cfg ---
if (!mf_process_maxfwd_header("10")) {
sl_send_reply("483","Too Many Hops");
exit;
}
---
Testing and feedback is much appreciated.
Cheers,
Daniel
9:47 a.m.
New subject: [SR-Users] support for 'include' in cfg file
On 26.08.2009 1:51 Uhr, Klaus Darilion wrote:
Great!
...added to wiki ....
http://sip-router.org/wiki/cookbooks/core-cookbook/devel#include
thanks, I was
wondering if this really belongs to parameters section,
since it can be used in route blocks as well. Maybe a new section is
better -- not sure how to name it now.
Cheers,
Daniel
klaus
Daniel-Constantin Mierla wrote:
--
Daniel-Constantin Mierla
* http://www.asipto.com/
Hello,
just committed to GIT support for 'include' in config file. Hopefully
this helps in nicer structuring and maintenance of your configs.
The syntax is simple:
include path_to_file
The path_to_file can be relative or absolute. If it is not absolute
path, first attempt is to locate it relative to current directory,
and if fails, relative to directory of the file that includes it.
There is no restriction where include can be used or what can contain
- any part of config file is ok. There is a limit of maximum 10
includes in depth, otherwise you can use as many includes as you
want. Reporting of the cfg file syntax errors prints now the file
name for easier troubleshooting.
Example:
route {
...
include /sr/checks.cfg
...
}
--- /sr/checks.cfg ---
if (!mf_process_maxfwd_header("10")) {
sl_send_reply("483","Too Many Hops");
exit;
}
---
Testing and feedback is much appreciated.
Cheers,
Daniel
_______________________________________________
sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
10:25 a.m.
New subject: [SR-Users] support for 'include' in cfg file
26 aug 2009 kl. 09.47 skrev Daniel-Constantin Mierla:
On 26.08.2009 1:51 Uhr, Klaus Darilion wrote:
It is important to mark such a construct as a configuration engine
option, we've learned in Asterisk where we have two of them. One is
#include that includes a file, another one is #exec that runs a script
and takes stdout and includes that. Both of them are valid in all
configuration files, parsed before the app gets the configuration data.
If you don't mark it a separate option, people will misunderstand it.
Especially in Asterisk where we have both "#include" and
"include=>"
in the dialplan, which wasn't very clever choice of names looking at
it from hindsight.
/O
Great!
...added to wiki ....
http://sip-router.org/wiki/cookbooks/core-cookbook/devel#include
thanks, I was
wondering if this really belongs to parameters
section, since it can be used in route blocks as well. Maybe a new
section is better -- not sure how to name it now.
10:32 a.m.
New subject: [SR-Users] support for 'include' in cfg file
On 26.08.2009 11:25 Uhr, Olle E. Johansson wrote:
26 aug 2009 kl. 09.47 skrev Daniel-Constantin Mierla:
was an option to get the c style, but in K/S the '#' marks beginning of
a comment, so I sticked more or less to php version. Other chars like $,
@... are used for some classes of variables... changing it is very
simple, just need something which does not add confusion.
Cheers,
Daniel
--
Daniel-Constantin Mierla
* http://www.asipto.com/
On 26.08.2009 1:51 Uhr, Klaus Darilion wrote:
It is important to mark such a construct as a configuration engine
option, we've learned in Asterisk where we have two of them. One is
#include that includes a file, another one is #exec that runs a script
and takes stdout and includes that. Both of them are valid in all
configuration files, parsed before the app gets the configuration data.
If you don't mark it a separate option, people will misunderstand it.
Especially in Asterisk where we have both "#include" and
"include=>"
in the dialplan, which wasn't very clever choice of names looking at
it from hindsight. Great!
...added to wiki ....
http://sip-router.org/wiki/cookbooks/core-cookbook/devel#include
thanks, I was
wondering if this really belongs to parameters section,
since it can be used in route blocks as well. Maybe a new section is
better -- not sure how to name it now.
10:35 a.m.
New subject: [SR-Users] support for 'include' in cfg file
2009/8/26 Daniel-Constantin Mierla <miconda(a)gmail.com>om>:
was an option to get the c style, but in K/S the
'#' marks beginning of a
comment, so I sticked more or less to php version. Other chars like $, @...
are used for some classes of variables...
changing it is very simple, just need something which
does not add confusion.
include_file PATH_TO_FILE
:)
--
Iñaki Baz Castillo
<ibc(a)aliax.net>
10:44 a.m.
New subject: [SR-Users] support for 'include' in cfg file
On Wed, Aug 26, 2009 at 9:47 AM, Daniel-Constantin
Mierla<miconda(a)gmail.com> wrote:
On 26.08.2009 1:51 Uhr, Klaus Darilion wrote:
Maybe we should have a section about general config file syntax, such
as comments, identifiers, reserved keywords, included files. This
directive would then fit in nicely.
By the way, wouldn't it make more sense to require that the filename
is enclosed between a pair of quotes? Unix filenames may contain
pretty much anything except '/' and that could result in all kinds of
strange errors when not quoted. Also it would be consistend with
loadmodule and loadpath.
Jan.
Great!
...added to wiki ....
http://sip-router.org/wiki/cookbooks/core-cookbook/devel#include
thanks, I was wondering if this really belongs to parameters section, since
it can be used in route blocks as well. Maybe a new section is better -- not
sure how to name it now.
Cheers,
Daniel
klaus
Daniel-Constantin Mierla wrote:
--
Daniel-Constantin Mierla
* http://www.asipto.com/
_______________________________________________
sr-dev mailing list
sr-dev(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Hello,
just committed to GIT support for 'include' in config file. Hopefully
this helps in nicer structuring and maintenance of your configs.
The syntax is simple:
include path_to_file
The path_to_file can be relative or absolute. If it is not absolute path,
first attempt is to locate it relative to current directory, and if fails,
relative to directory of the file that includes it. There is no restriction
where include can be used or what can contain - any part of config file is
ok. There is a limit of maximum 10 includes in depth, otherwise you can use
as many includes as you want. Reporting of the cfg file syntax errors prints
now the file name for easier troubleshooting.
Example:
route {
...
include /sr/checks.cfg
...
}
--- /sr/checks.cfg ---
if (!mf_process_maxfwd_header("10")) {
sl_send_reply("483","Too Many Hops");
exit;
}
---
Testing and feedback is much appreciated.
Cheers,
Daniel
_______________________________________________
sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
10:49 a.m.
New subject: [SR-Users] support for 'include' in cfg file
Iñaki Baz Castillo schrieb:
2009/8/26 Daniel-Constantin Mierla
<miconda(a)gmail.com>om>:
+1
was an option to get the c style, but in K/S the
'#' marks beginning of a
comment, so I sticked more or less to php version. Other chars like $, @...
are used for some classes of variables...
changing it is very simple, just need something
which does not add confusion.
include_file PATH_TO_FILE
10:55 a.m.
New subject: [SR-Users] support for 'include' in cfg file
On 26.08.2009 11:44 Uhr, Jan Janak wrote:
_______________________________________________
sr-dev mailing list
sr-dev(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
--
Daniel-Constantin Mierla
* http://www.asipto.com/
On Wed, Aug 26, 2009 at 9:47 AM, Daniel-Constantin
Mierla<miconda(a)gmail.com> wrote:
yes, enclosing in quotes would be recommended. Shall we force all the
time the double quotes?
Cheers,
Daniel
On 26.08.2009 1:51 Uhr, Klaus Darilion wrote:
Maybe we should have a section about general config file syntax, such
as comments, identifiers, reserved keywords, included files. This
directive would then fit in nicely.
By the way, wouldn't it make more sense to require that the filename
is enclosed between a pair of quotes? Unix filenames may contain
pretty much anything except '/' and that could result in all kinds of
strange errors when not quoted. Also it would be consistend with
loadmodule and loadpath.
Great!
...added to wiki ....
http://sip-router.org/wiki/cookbooks/core-cookbook/devel#include
thanks, I was wondering if this really belongs to parameters section,
since
it can be used in route blocks as well. Maybe a new section is better -- not
sure how to name it now.
klaus
Daniel-Constantin Mierla wrote:
--
Daniel-Constantin Mierla
* http://www.asipto.com/
_______________________________________________
sr-dev mailing list
sr-dev(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Hello,
just committed to GIT support for 'include' in config file. Hopefully
this helps in nicer structuring and maintenance of your configs.
The syntax is simple:
include path_to_file
The path_to_file can be relative or absolute. If it is not absolute path,
first attempt is to locate it relative to current directory, and if fails,
relative to directory of the file that includes it. There is no restriction
where include can be used or what can contain - any part of config file is
ok. There is a limit of maximum 10 includes in depth, otherwise you can use
as many includes as you want. Reporting of the cfg file syntax errors prints
now the file name for easier troubleshooting.
Example:
route {
...
include /sr/checks.cfg
...
}
--- /sr/checks.cfg ---
if (!mf_process_maxfwd_header("10")) {
sl_send_reply("483","Too Many Hops");
exit;
}
---
Testing and feedback is much appreciated.
Cheers,
Daniel
_______________________________________________
sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
10:56 a.m.
New subject: [SR-Users] support for 'include' in cfg file
26 aug 2009 kl. 10.49 skrev Klaus Darilion:
Iñaki Baz Castillo schrieb:
++1
/O
2009/8/26 Daniel-Constantin Mierla
<miconda(a)gmail.com>om>:
+1 was an option to get the c style, but in K/S the
'#' marks
beginning of a
comment, so I sticked more or less to php version. Other chars
like $, @...
are used for some classes of variables...
changing it is very simple, just need something which does not add
confusion.
include_file PATH_TO_FILE
11:03 a.m.
New subject: [SR-Users] support for 'include' in cfg file
On Wed, Aug 26, 2009 at 10:55 AM, Daniel-Constantin
Mierla<miconda(a)gmail.com> wrote:
On 26.08.2009 11:44 Uhr, Jan Janak wrote:
Yes, please. That way it would be obvious that what the include
directive expects is a string and not an expression to be evaluated.
thanks, Jan.
On Wed, Aug 26, 2009 at 9:47 AM, Daniel-Constantin
Mierla<miconda(a)gmail.com> wrote:
yes, enclosing in quotes would be recommended. Shall we force all the time
the double quotes?
On 26.08.2009 1:51 Uhr, Klaus Darilion wrote:
Maybe we should have a section about general config file syntax, such
as comments, identifiers, reserved keywords, included files. This
directive would then fit in nicely.
By the way, wouldn't it make more sense to require that the filename
is enclosed between a pair of quotes? Unix filenames may contain
pretty much anything except '/' and that could result in all kinds of
strange errors when not quoted. Also it would be consistend with
loadmodule and loadpath.
Great!
...added to wiki ....
http://sip-router.org/wiki/cookbooks/core-cookbook/devel#include
thanks, I was wondering if this really belongs to parameters section,
since
it can be used in route blocks as well. Maybe a new section is better --
not
sure how to name it now.
11:06 a.m.
New subject: [SR-Users] support for 'include' in cfg file
26 aug 2009 kl. 11.03 skrev Jan Janak:
On Wed, Aug 26, 2009 at 10:55 AM, Daniel-Constantin
Mierla<miconda(a)gmail.com> wrote:
And just to be very clear in the documentation - "Note that you can't
use any type of avp's in this statement as it is processed at startup,
not at runtime."
/O
On 26.08.2009 11:44 Uhr, Jan Janak wrote:
Yes, please. That way it would be obvious that what the include
directive expects is a string and not an expression to be evaluated.
On Wed, Aug 26, 2009 at 9:47 AM, Daniel-Constantin
Mierla<miconda(a)gmail.com> wrote:
yes, enclosing in quotes would be recommended. Shall we force all
the time
the double quotes?
On 26.08.2009 1:51 Uhr, Klaus Darilion wrote:
>
> Great!
>
> ...added to wiki ....
> http://sip-router.org/wiki/cookbooks/core-cookbook/devel#include
>
thanks, I was wondering if this really belongs to parameters
section,
since
it can be used in route blocks as well. Maybe a new section is
better --
not
sure how to name it now.
Maybe we should have a section about general config file syntax,
such
as comments, identifiers, reserved keywords, included files. This
directive would then fit in nicely.
By the way, wouldn't it make more sense to require that the filename
is enclosed between a pair of quotes? Unix filenames may contain
pretty much anything except '/' and that could result in all kinds
of
strange errors when not quoted. Also it would be consistend with
loadmodule and loadpath.
11:09 a.m.
New subject: [SR-Users] support for 'include' in cfg file
2009/8/26 Olle E. Johansson <oej(a)edvina.net>et>:
And just to be very clear in the documentation -
"Note that you can't use
any type of avp's in this statement as it is processed at startup, not at
runtime."
Sorry, is that true?
I understood that the included file text is justinserted in the main
config file being parse, no more, so the included file could also
contain AVP's and everything. Am I wrong?
--
Iñaki Baz Castillo
<ibc(a)aliax.net>
12:25 p.m.
New subject: [SR-Users] support for 'include' in cfg file
On 26.08.2009 12:03 Uhr, Jan Janak wrote:
On Wed, Aug 26, 2009 at 10:55 AM, Daniel-Constantin
Mierla<miconda(a)gmail.com> wrote:
done. Just that it cannot be a string like elsewhere in the config for
now. Expanding grammar to support hex, octet representation of chars,
whitespace, etc. is a bit more complex to implement in order to cope
with comments on the same line after the include. But I have it in mind
for future.
Cheers,
Daniel
--
Daniel-Constantin Mierla
* http://www.asipto.com/
On 26.08.2009 11:44 Uhr, Jan Janak wrote:
Yes, please. That way it would be obvious that what the include
directive expects is a string and not an expression to be evaluated.
On Wed, Aug 26, 2009 at 9:47 AM,
Daniel-Constantin
Mierla<miconda(a)gmail.com> wrote:
yes, enclosing in quotes would be recommended. Shall we force all the time
the double quotes?
On 26.08.2009 1:51 Uhr, Klaus Darilion wrote:
> Great!
>
> ...added to wiki ....
> http://sip-router.org/wiki/cookbooks/core-cookbook/devel#include
>
>
thanks, I was wondering if this really belongs to parameters section,
since
it can be used in route blocks as well. Maybe a new section is better --
not
sure how to name it now.
Maybe we should have a section about general config file syntax, such
as comments, identifiers, reserved keywords, included files. This
directive would then fit in nicely.
By the way, wouldn't it make more sense to require that the filename
is enclosed between a pair of quotes? Unix filenames may contain
pretty much anything except '/' and that could result in all kinds of
strange errors when not quoted. Also it would be consistend with
loadmodule and loadpath.
12:28 p.m.
New subject: [Kamailio-Users] [SR-Users] support for 'include' in cfg file
On 26.08.2009 12:09 Uhr, Iñaki Baz Castillo wrote:
2009/8/26 Olle E. Johansson <oej(a)edvina.net>et>:
Yes, kind of. One cfg tree is built from the content of
all files.
And just to be very clear in the documentation -
"Note that you can't use
any type of avp's in this statement as it is processed at startup, not at
runtime."
Sorry, is that true?
I understood that the included file text is justinserted in the main
config file being parse, no more, so the included file could also
contain AVP's and everything.
Yes, can contain anything that is valid in at the
position of include
directive.
Am I wrong?
Probably Olle meant that you cannot do:
$avp(x) = "my_file";
include $avp(x)
Cheers,
Daniel
--
Daniel-Constantin Mierla
* http://www.asipto.com/
12:29 p.m.
New subject: [SR-Users] support for 'include' in cfg file
To understand that people prefer "include_file" over "include"? Shall
we
wait more opinions or update now since it is early stage...
Cheers,
Daniel
On 26.08.2009 11:56 Uhr, Olle E. Johansson wrote:
26 aug 2009 kl. 10.49 skrev Klaus Darilion:
--
Daniel-Constantin Mierla
* http://www.asipto.com/
Iñaki Baz Castillo schrieb:
++1
/O
_______________________________________________
sr-dev mailing list
sr-dev(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
2009/8/26 Daniel-Constantin Mierla
<miconda(a)gmail.com>om>:
+1 was an option to get the c style, but in K/S the
'#' marks
beginning of a
comment, so I sticked more or less to php version. Other chars like
$, @...
are used for some classes of variables...
changing it is very simple, just need something which does not add
confusion.
include_file PATH_TO_FILE
1:33 p.m.
New subject: [Kamailio-Users] [SR-Users] support for 'include' in cfg file
2009/8/26 Daniel-Constantin Mierla <miconda(a)gmail.com>om>:
ahhh ok
--
Iñaki Baz Castillo
<ibc(a)aliax.net>
Am I wrong?
Probably Olle meant that you cannot do:
$avp(x) = "my_file";
include $avp(x)
1:35 p.m.
New subject: [SR-Users] support for 'include' in cfg file
2009/8/26 Daniel-Constantin Mierla <miconda(a)gmail.com>om>:
To understand that people prefer
"include_file" over "include"? Shall we
wait more opinions or update now since it is early stage...
include what?
=> include file
:)
Imagine in a future you want to extend it as Asterisk #exec. It could
be called "include_script" :)
--
Iñaki Baz Castillo
<ibc(a)aliax.net>
1:38 p.m.
New subject: [SR-Users] support for 'include' in cfg file
3 Sep
3 Sep
1:09 p.m.
New subject: [SR-Users] support for 'include' in cfg file
Hello,
note: following most of opinions expressed on devel list regarding the
directive name (to be more suggestive about what it does), "include" has
been replaced with "include_file". See:
http://sip-router.org/wiki/cookbooks/core-cookbook/devel#include_file
Cheers,
Daniel
On 25.08.2009 20:15 Uhr, Daniel-Constantin Mierla wrote:
Hello,
just committed to GIT support for 'include' in config file. Hopefully
this helps in nicer structuring and maintenance of your configs.
The syntax is simple:
include path_to_file
The path_to_file can be relative or absolute. If it is not absolute
path, first attempt is to locate it relative to current directory, and
if fails, relative to directory of the file that includes it. There is
no restriction where include can be used or what can contain - any
part of config file is ok. There is a limit of maximum 10 includes in
depth, otherwise you can use as many includes as you want. Reporting
of the cfg file syntax errors prints now the file name for easier
troubleshooting.
Example:
route {
...
include /sr/checks.cfg
...
}
--- /sr/checks.cfg ---
if (!mf_process_maxfwd_header("10")) {
sl_send_reply("483","Too Many Hops");
exit;
}
---
Testing and feedback is much appreciated.
Cheers,
Daniel
--
Daniel-Constantin Mierla
* http://www.asipto.com/
5372
days inactive
5381
days old
21 comments
6 participants
participants (6)
-
Daniel-Constantin Mierla -
Iñaki Baz Castillo -
Jan Janak -
Klaus Darilion -
Olle E. Johansson -
Watkins, Bradley