20 Jun
2009
20 Jun
'09
12:35 a.m.
Module: sip-router
Branch: rbetancor/drouting
Commit: 1c5d19277a14e71167c81665d6de8173e61a2ccb
URL:
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1c5d192…
Author: Juha Heinanen <jh(a)tutpro.com>
Committer: Juha Heinanen <jh(a)tutpro.com>
Date: Fri Jun 19 16:40:24 2009 +0300
* core
* Added fixup_igp_pvar and fixup_free_igp_pvar fixup functions.
---
mod_fix.c | 1 +
mod_fix.h | 3 +++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/mod_fix.c b/mod_fix.c
index a228e16..90a4a4d 100644
--- a/mod_fix.c
+++ b/mod_fix.c
@@ -176,6 +176,7 @@ FIXUP_F2T(pvar_str_str, 1, 3, 1, FPARAM_PVS, FPARAM_STR)
FIXUP_F2FP(igp_null, 1, 1, 1, FPARAM_INT|FPARAM_PVS, 0)
FIXUP_F2FP(igp_igp, 1, 2, 2, FPARAM_INT|FPARAM_PVS, 0)
+FIXUP_F2FP(igp_pvar, 1, 2, 1, FPARAM_INT|FPARAM_PVS, FPARAM_PVS)
FIXUP_F2FP_T(igp_pvar_pvar, 1, 3, 1, FPARAM_INT|FPARAM_PVS, FPARAM_PVS)
diff --git a/mod_fix.h b/mod_fix.h
index 257d78c..37bccb6 100644
--- a/mod_fix.h
+++ b/mod_fix.h
@@ -109,6 +109,9 @@ int fixup_igp_igp(void** param, int param_no);
int fixup_igp_null(void** param, int param_no);
int fixup_get_ivalue(struct sip_msg* msg, gparam_p gp, int *val);
+int fixup_igp_pvar(void** param, int param_no);
+int fixup_free_igp_pvar(void** param, int param_no);
+
int fixup_igp_pvar_pvar(void** param, int param_no);
int fixup_free_igp_pvar_pvar(void** param, int param_no);
20 Jun
20 Jun
12:44 a.m.
On Friday 19 June 2009 23:35:45 Raul Alexis Betancor Santana wrote:
Module: sip-router
Branch: rbetancor/drouting
Commit: 1c5d19277a14e71167c81665d6de8173e61a2ccb
URL:
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1c5d192
77a14e71167c81665d6de8173e61a2ccb
Author: Juha Heinanen <jh(a)tutpro.com>
Committer: Juha Heinanen <jh(a)tutpro.com>
Date: Fri Jun 19 16:40:24 2009 +0300
* core
* Added fixup_igp_pvar and fixup_free_igp_pvar fixup functions.
UMM ????? ... I just created a new branch for porting drouting module from
OpenSIPS ..
rabs@salma:~/Proyectos/VoIP/sip-router/modules_k$ git add drouting/
rabs@salma:~/Proyectos/VoIP/sip-router/modules_k$ git push origin
drouting:rbetancor/drouting
Total 0 (delta 0), reused 0 (delta 0)
To ssh://rbetancor@git.sip-router.org/sip-router
* [new branch] drouting -> rbetancor/drouting
Don't know from were that fixup came ...
May I have done something wrong ?
--
Raúl Alexis Betancor Santana
Dimensión Virtual
12:55 a.m.
On Jun 19, 2009 at 23:44, Ra?l Alexis Betancor Santana <rabs(a)dimension-virtual.com>
wrote:
On Friday 19 June 2009 23:35:45 Raul Alexis Betancor
Santana wrote:
No, if you create a new branch with no new commits on it, the script
that generates the mails will just send the top commit on the branch
(which in your case happened to be the fixup one).
Andrei
Module: sip-router
Branch: rbetancor/drouting
Commit: 1c5d19277a14e71167c81665d6de8173e61a2ccb
URL:
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1c5d192
77a14e71167c81665d6de8173e61a2ccb
Author: Juha Heinanen <jh(a)tutpro.com>
Committer: Juha Heinanen <jh(a)tutpro.com>
Date: Fri Jun 19 16:40:24 2009 +0300
* core
* Added fixup_igp_pvar and fixup_free_igp_pvar fixup functions.
UMM ????? ... I just created a new branch for porting drouting module from
OpenSIPS ..
rabs@salma:~/Proyectos/VoIP/sip-router/modules_k$ git add drouting/
rabs@salma:~/Proyectos/VoIP/sip-router/modules_k$ git push origin
drouting:rbetancor/drouting
Total 0 (delta 0), reused 0 (delta 0)
To ssh://rbetancor@git.sip-router.org/sip-router
* [new branch] drouting -> rbetancor/drouting
Don't know from were that fixup came ...
May I have done something wrong ?
1:37 a.m.
On Friday 19 June 2009 23:55:19 Andrei Pelinescu-Onciul wrote:
No, if you create a new branch with no new commits on
it, the script
that generates the mails will just send the top commit on the branch
(which in your case happened to be the fixup one).
Andrei
Uff .. ok, thanks for the answer ... I was wondering If I made a mistake .. :P
Just talking about drouting module, it should use srdb1/db.h because it's a
kamailio/opensips module .. but it also trye to include ../../blacklists.h,
that seems to be a kind of blacklisting functions, present on OpenSIPS, but I
do not find anything similar on Kamailio, does anyone knows if we have an
equivalent on s-r or must I also port the blacklists.c/h functions ?
Best regards
--
Raúl Alexis Betancor Santana
Dimensión Virtual
29 Jun
29 Jun
8:27 p.m.
Hello,
On 06/20/2009 01:37 AM, Raúl Alexis Betancor Santana wrote:
On Friday 19 June 2009 23:55:19 Andrei
Pelinescu-Onciul wrote:
you can leave the BL out for now. SR has a different implementation for
blacklisting.
Let me know if you need help here.
Cheers,
Daniel
No, if you create a new branch with no new
commits on it, the script
that generates the mails will just send the top commit on the branch
(which in your case happened to be the fixup one).
Andrei
Uff .. ok, thanks for the answer ... I was wondering If I made a mistake .. :P
Just talking about drouting module, it should use srdb1/db.h because it's a
kamailio/opensips module .. but it also trye to include ../../blacklists.h,
that seems to be a kind of blacklisting functions,
present on OpenSIPS, but I
do not find anything similar on Kamailio, does anyone knows if we have an
equivalent on s-r or must I also port the blacklists.c/h functions ?
Best regards
--
Daniel-Constantin Mierla
http://www.asipto.com/
11:51 p.m.
On Monday 29 June 2009 19:27:04 Daniel-Constantin Mierla wrote:
Hello,
On 06/20/2009 01:37 AM, Raúl Alexis Betancor Santana wrote:
If you could point me to the BL implementation on SR, so I could check it.
By now, I'm reviewing the drouting code, looking if it's possible to not use
the dialog module and also I have seen some structures I don't like at all.
--
Raúl Alexis Betancor Santana
Dimensión Virtual
On Friday 19 June 2009 23:55:19 Andrei
Pelinescu-Onciul wrote:
you can leave the BL out for now. SR has a different implementation for
blacklisting.
Let me know if you need help here. No, if you create a new branch with no new
commits on it, the script
that generates the mails will just send the top commit on the branch
(which in your case happened to be the fixup one).
Andrei
Uff .. ok, thanks for the answer ... I was wondering If I made a mistake
.. :P
Just talking about drouting module, it should use srdb1/db.h because it's
a kamailio/opensips module .. but it also trye to include
../../blacklists.h,
11:52 p.m.
On 06/29/2009 11:51 PM, Raúl Alexis Betancor Santana wrote:
On Monday 29 June 2009 19:27:04 Daniel-Constantin
Mierla wrote:
maybe is better to start with the version before the bl implementation.
Daniel
--
Daniel-Constantin Mierla
http://www.asipto.com/
Hello,
On 06/20/2009 01:37 AM, Raúl Alexis Betancor Santana wrote:
If you could point me to the BL implementation on SR, so I could check it.
By now, I'm reviewing the drouting code, looking if it's possible to not use
the dialog module and also I have seen some structures I don't like at all.
On Friday 19 June 2009 23:55:19 Andrei
Pelinescu-Onciul wrote:
you can leave the BL out for now. SR has a different implementation for
blacklisting.
Let me know if you need help here.
No, if you create a new branch with no new
commits on it, the script
that generates the mails will just send the top commit on the branch
(which in your case happened to be the fixup one).
Andrei
Uff .. ok, thanks for the answer ... I was wondering If I made a mistake
.. :P
Just talking about drouting module, it should use srdb1/db.h because it's
a kamailio/opensips module .. but it also trye to include
../../blacklists.h,
30 Jun
30 Jun
5:57 a.m.
Raúl Alexis Betancor Santana writes:
By now, I'm reviewing the drouting code, looking
if it's possible to not use
the dialog module and also I have seen some structures I don't like at all.
raul,
just for curiosity, what is missing in lcr module that prevents you
from using it instead of drouting module?
-- juha
8:49 a.m.
On Tuesday 30 June 2009 04:57:34 Juha Heinanen wrote:
Raúl Alexis Betancor Santana writes:
Just more routing options than lcr + carrierroute, at least easy to setup
bigger routing trees.
However, I make routing using a bit special way of working with lcr, because I
use it to select witch GW I will use to route the call, and the I made a new
routing desition with carrierroute and pass that information to the previous
selected GW (with lcr)
--
Raúl Alexis Betancor Santana
Dimensión Virtual
By now, I'm reviewing the drouting code,
looking if it's possible to not
use the dialog module and also I have seen some structures I don't like
at all.
raul,
just for curiosity, what is missing in lcr module that prevents you
from using it instead of drouting module? 
11:36 a.m.
On Dienstag, 30. Juni 2009, Raúl Alexis Betancor Santana wrote:
Just more routing options than lcr + carrierroute, at least easy to setup
bigger routing trees.
Raúl,
i don't looked that much into drouting, but what are you missing in cr with
regards to big routing trees?
By now, I'm reviewing the drouting code, looking
if it's possible to
not use the dialog module and also I have seen some structures I don't
like at all.
just for curiosity, what is missing in lcr module that prevents you
from using it instead of drouting module? However, I make routing using a bit special way of
working with lcr,
because I use it to select witch GW I will use to route the call, and the I
made a new routing desition with carrierroute and pass that information to
the previous selected GW (with lcr)
Ok, interesting. :)
Henning
6:47 p.m.
On Tuesday 30 June 2009 10:36:22 Henning Westerholt wrote:
On Dienstag, 30. Juni 2009, Raúl Alexis Betancor
Santana wrote:
Just more routing options than lcr + carrierroute, at least easy to setup
bigger routing trees.
Raúl,
i don't looked that much into drouting, but what are you missing in cr with
regards to big routing trees?
One important difference is that with cr I could only use one ordering
criteria, If I need to "reorder" the tree depending on other criteria, I
should create another tree and manage it.
With drouting you could use 3 differents ordering criteria for the same tree
and this is very important for our goals.
Also drouting uses one UNIQUE tree and not a "working and a failover" tree,
this was too messy for me the first time I tryed to use cr.
--
Raúl Alexis Betancor Santana
Dimensión Virtual
By now, I'm reviewing the drouting code, looking
if it's possible to
not use the dialog module and also I have seen some structures I
don't like at all.
just for curiosity, what is missing in lcr module that prevents you
from using it instead of drouting module?
5422
days inactive
5433
days old
10 comments
5 participants
participants (5)
-
Andrei Pelinescu-Onciul -
Daniel-Constantin Mierla -
Henning Westerholt -
jh＠tutpro.com -
Raul Alexis Betancor Santana