Hi Anca! From the README: subs_db_mode (int): 3 - DB-Only scheme. No memory cache is kept, all operations being directly performed with the database. The timer deletes all expired subscriptions from database. The mode is useful if you configure more servers sharing the same DB without any replication at SIP level. The mode may be slower due the high number of DB operation. You mention replication at SIP level - I wonder how you can replicate subscriptions on SIP level?

regards Klaus

Hi Anca! I wonder what happens if I build a server cluster (p1 and p2) with subs_db_mode=3 and publ_cache=0. Then a subscription to user1 is received from p1 and stored into the DB. Then user1 sends a publish via p2, which is stored in the DB. Who will send the NOTIFY for the subscription? p1 or p2? I guess p2 as p1 has no idea about the publish - correct?

thanks Klaus

What if publ_cache=1. What really happens on incoming PUBLISH? I have not read the code but I suspect with subs_db_mode=3 and publ_cache=0 the module does (without permissions checking): incoming PUBLISH without e-tag: INSERT INTO presentity ..... incoming PUBLISH with e-tag:

incoming SUBSCRIBE without to-tag: INSERT INTO active-watchers ... SELECT * FROM presentity WHERE .... incoming SUBSCRIBE with to-tag:

So what changes if publ_cache=1?

Is the SELECT really necessary? If only UPDATE is done, and UPDATE returns '0 rows' affected then respond with 412.

Hi, I just tried this updated presence module and ran into some problems. The scenario I use is presence and RLS. The client SUBSCRIBEs to a single resource list on the RLS and to presence.winfo on the PS. The client PUBLISHes to the PS. With the new code I get two error messages out a lot: Feb 29 11:31:18 pd-laptop-linux ./kamailio[22566]: ERROR: presence [subscribe.c:799]: wrong status Feb 29 11:32:39 pd-laptop-linux ./kamailio[22566]: ERROR: presence [subscribe.c:1314]: wrong sequence number received: 4 - stored: 10 I also get segmentation faults when I change presence state or log out. Here is a fragment of the back-trace: #0 0x00007f0447191438 in get_subs_db (pres_uri=0x7fff0ce09ea0, event=0x7f0443f15728, sender=<optimized out>, s_array=0x7fff0ce09bf0, n=0x7fff0ce09c00) at notify.c:1120 #1 0x00007f044719375f in get_subs_dialog (pres_uri=0x7fff0ce09ea0, event=0x7f0443f15728, sender=0x0) at notify.c:1238 #2 0x00007f04471994ce in query_db_notify (pres_uri=0x7fff0ce09ea0, event=0x7f0443f15728, watcher_subs=0x0) at notify.c:1353 #3 0x00007f04471b024e in update_subscription (msg=0x7f044d36ec38, subs=0x7fff0ce09ea0, to_tag_gen=<optimized out>, sent_reply=0x7fff0ce09ff0) at subscribe.c:452 #4 0x00007f04471be82a in handle_subscribe (msg=0x7f044d36ec38, str1=<optimized out>, str2=<optimized out>) at subscribe.c:805 #5 0x00000000004e50c5 in do_action (h=0x7fff0ce0c950, a=<optimized out>, msg=0x7f044d36ec38) at action.c:1116 I rolled back to the previous version of presence and it all works correctly as before. Thanks, Peter

Hi, I used the latest version (taken from git on Thursday evening - so after the last change). I was using db mode 3 (DB only) and d publ_cache set to 0. Thanks, Peter

Hi, I've been doing more investigation myself. It seems that even with old presence module I can get it to crash here if the records in the DB are "broken" enough. So I think it was just a co-incidence that I first spotted the crash with the new code. I suspect that with the two errors coming out of the new presence code (and the state things are in when they come out) it is just easier to get the DB records broken in the right way. The error messages are actually the bigger issue as they are stopping presence and RLS working together. Thanks, Peter -- Peter Dunkley Technical Director Crocodile RCS Ltd

Module: sip-router Branch: master Commit: ae86ca3611398ce365ac4a1776ff0c7e95476bbe URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ae86ca3… Author: Anca Vamanu&lt;anca.vamanu(a)1and1.ro&gt; Committer: Anca Vamanu&lt;anca.vamanu(a)1and1.ro&gt; Date: Wed Feb 15 13:39:55 2012 +0200 modules_k/presence Fixed DB Storage Modes - removed db_mode and fallback2db parameters and added two new parameters: subs_db_mode and publ_cache - fixed and extended the storage modes for subscriptions: Memory Only, Write Through, Write Back, DB Only - publ_cache parameter offers the possibility to disable publish cache - some other fixes: - delete subscription only for 481 or 408 reply for Notify - call child_init also for main process (no shutdown DB flush was being performed) --- modules_k/presence/README | 190 ++++++----- modules_k/presence/bind_presence.c | 4 +- modules_k/presence/bind_presence.h | 4 +- modules_k/presence/doc/presence_admin.xml | 127 +++++--- modules_k/presence/doc/presence_devel.xml | 2 +- modules_k/presence/event_list.c | 2 +- modules_k/presence/event_list.h | 2 +- modules_k/presence/hash.c | 25 +-- modules_k/presence/hash.h | 2 +- modules_k/presence/notify.c | 253 ++++++--------- modules_k/presence/notify.h | 2 +- modules_k/presence/presence.c | 108 +++---- modules_k/presence/presence.h | 19 +- modules_k/presence/presentity.c | 30 +-- modules_k/presence/presentity.h | 2 +- modules_k/presence/publish.c | 52 ++-- modules_k/presence/publish.h | 2 +- modules_k/presence/subscribe.c | 495 +++++++++++++++++++---------- modules_k/presence/subscribe.h | 7 +- modules_k/presence/utils_func.c | 2 +- modules_k/presence/utils_func.h | 2 +- modules_k/pua/hash.h | 1 + 22 files changed, 736 insertions(+), 597 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=ae8… _______________________________________________ sr-dev mailing list sr-dev(a)lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev