git:master: kamailio.cfg: removed append_branch() from failure_route
Module: sip-router Branch: master Commit: 9f542264b8d022959a2006af6fe73dd6b7cfbf13 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9f542264... Author: Daniel-Constantin Mierla <miconda@gmail.com> Committer: Daniel-Constantin Mierla <miconda@gmail.com> Date: Wed May 25 22:54:53 2011 +0200 kamailio.cfg: removed append_branch() from failure_route - it is no longer necessary --- etc/kamailio.cfg | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index 5e6d9f7..decfd0f 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -837,7 +837,7 @@ failure_route[FAIL_ONE] { # uncomment the following lines if you want to block client # redirect based on 3xx replies. ##if (t_check_status("3[0-9][0-9]")) { - ##t_reply("404","Not found"); + ## t_reply("404","Not found"); ## exit; ##} @@ -845,8 +845,6 @@ failure_route[FAIL_ONE] { # calls to a different new destination ##if (t_check_status("486|408")) { ## sethostport("192.168.2.100:5060"); - ## append_branch(); - ## # do not set the missed call flag again ## t_relay(); ##} }
Daniel, if I got it right, since Kamailio 3.1 such changes in failure route are automatically detected and append-branch is called automatically internally. As I couldn't find this documented: Which changes are detected? Any change to R-URI ($ru, $rU, sethostport ...)? Also changes to destination URI? Are there any other route blocks beside failure routes which trigger this behavior? Thanks Klaus Am 25.05.2011 22:55, schrieb Daniel-Constantin Mierla:
Module: sip-router Branch: master Commit: 9f542264b8d022959a2006af6fe73dd6b7cfbf13 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9f542264...
Author: Daniel-Constantin Mierla <miconda@gmail.com> Committer: Daniel-Constantin Mierla <miconda@gmail.com> Date: Wed May 25 22:54:53 2011 +0200
kamailio.cfg: removed append_branch() from failure_route
- it is no longer necessary
---
etc/kamailio.cfg | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index 5e6d9f7..decfd0f 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -837,7 +837,7 @@ failure_route[FAIL_ONE] { # uncomment the following lines if you want to block client # redirect based on 3xx replies. ##if (t_check_status("3[0-9][0-9]")) { - ##t_reply("404","Not found"); + ## t_reply("404","Not found"); ## exit; ##}
@@ -845,8 +845,6 @@ failure_route[FAIL_ONE] { # calls to a different new destination ##if (t_check_status("486|408")) { ## sethostport("192.168.2.100:5060"); - ## append_branch(); - ## # do not set the missed call flag again ## t_relay(); ##} }
_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Hello, On 6/1/11 4:23 PM, Klaus Darilion wrote:
Daniel, if I got it right, since Kamailio 3.1 such changes in failure route are automatically detected and append-branch is called automatically internally.
As I couldn't find this documented:
Which changes are detected? Any change to R-URI ($ru, $rU, sethostport ...)? Also changes to destination URI?
Are there any other route blocks beside failure routes which trigger this behavior? only the failure route had the issue in case of serial forking to create a new branch.
I expect r-uri and dst-uri, but good question, since Andrei implemented it I should look into the code. Cheers, Daniel
Thanks Klaus
Am 25.05.2011 22:55, schrieb Daniel-Constantin Mierla:
Module: sip-router Branch: master Commit: 9f542264b8d022959a2006af6fe73dd6b7cfbf13 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9f542264...
Author: Daniel-Constantin Mierla<miconda@gmail.com> Committer: Daniel-Constantin Mierla<miconda@gmail.com> Date: Wed May 25 22:54:53 2011 +0200
kamailio.cfg: removed append_branch() from failure_route
- it is no longer necessary
---
etc/kamailio.cfg | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index 5e6d9f7..decfd0f 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -837,7 +837,7 @@ failure_route[FAIL_ONE] { # uncomment the following lines if you want to block client # redirect based on 3xx replies. ##if (t_check_status("3[0-9][0-9]")) { - ##t_reply("404","Not found"); + ## t_reply("404","Not found"); ## exit; ##}
@@ -845,8 +845,6 @@ failure_route[FAIL_ONE] { # calls to a different new destination ##if (t_check_status("486|408")) { ## sethostport("192.168.2.100:5060"); - ## append_branch(); - ## # do not set the missed call flag again ## t_relay(); ##} }
_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- Daniel-Constantin Mierla http://www.asipto.com
participants (2)
-
Daniel-Constantin Mierla -
Klaus Darilion